Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2019-05-08
13:17:37 mordred adriant: looking at the code, I have a few ideas of how to solve this slighly less hacky - but they'll take a few more minutes to work on
13:18:12 gtema mordred: just a few minutes longer? that's like immediately ;-)
13:18:19 mordred gtema: hehe
13:19:26 mordred tl;dr - I think if we refactor openstack.service_description.ServiceDescription._make_proxy a little bit, we can make it easier to override parts of the story for individual services ... in their ServiceDescription subclass
13:20:13 gtema what do you mean?
13:21:07 mordred I'm not 100% sure yet :)
13:21:15 gtema :D
13:24:14 mordred johnsom: does octavia have microversions? (doesn't look like it) - also, I see a comment in the code that indicates exposing the v1 endpoint is a security risk - does that mean it's reasonable at this point to assume v2 is the only thing we'll be talking to (in the cases where version discovery doesn't work)
13:25:32 mordred gtema: I *think* what I'm thniking is that we have the ServiceDescription class do the initial stuff the same for everybody - then have a method we can override on a per-service basis (but most wouldn't) - that handles "what do I do if I found the service but service discovery didn't work"
13:26:23 mordred but what I shoudl really do is finish that patch from above and add some tests that show the correct behavior with a linkless octavia version document
13:27:13 gtema yes, right.
13:28:50 gtema mordred: as I see we do not currently have any tests for vendor profiles. I see those are really tricky, but probably need to introduce some
13:29:22 gtema especially since I am preparing this vendor_hook as part of the vendors/*.json and openstack.connect(vendor_hook='')
13:32:34 mordred gtema: yes. we should probably make some tests
13:32:58 gtema will try implement some for the vendor_hook patch
13:33:07 gtema and then extend separately
13:33:13 mordred :)
13:33:20 gtema hehe
13:48:16 johnsom mordred: v1 is only for neutron to talk to us, it was never user facing. No microcersions either.
13:49:15 mordred johnsom: ok, cool
13:54:42 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Workaround older octavia version discovery https://review.opendev.org/657799
13:55:03 mordred johnsom, adriant, gtema: ok - I was wrong - there is a one-line fix if you don't count the comment
13:55:40 gtema hehe, nice
13:57:17 gtema mordred: probably rename then network_adapter => adapter; network_endpoint => endpoint?
14:00:46 mordred gtema: I thought about that - but I was worried about shadowing other variables in that method. lemme pull it into a helper method real quick
14:00:58 gtema ok
14:05:36 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Workaround older octavia version discovery https://review.opendev.org/657799
16:23:44 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Add support for vendor hooks https://review.opendev.org/657848
21:18:17 openstackgerrit Jeremy Houser proposed openstack/python-openstackclient master: Alter test_volume.py to ensure volume deletion https://review.opendev.org/652682
21:22:46 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Fix bug in endpoint group deletion https://review.opendev.org/655889
21:59:23 adriant mordred: ty!
22:00:40 adriant I guess for that one script I'll downgrade to 0.17.2 for now, and then upgrade to the 0.28.0 release when it is out
22:00:45 adriant lemme grab that patch and test it
22:46:23 mordred adriant: yeah - let me know if it does, and we can get it in and get 0.28.0 out (which is overdue anyway)
22:52:16 adriant mordred: it works for me at least against an older Octavia
22:52:40 adriant I don't have a newer one to point to, but looking at the code changes I shouldn't change anything there either
22:52:51 adriant it* shouldn't
22:53:34 mordred adriant: cool. I'll try to get some tests written for it in the morning
23:25:16 openstackgerrit Merged openstack/python-openstackclient master: Fix --limit option in image list sub-command https://review.opendev.org/617139
23:28:01 openstackgerrit LIU Yulong proposed openstack/python-openstackclient master: Add floating IP Port Forwarding commands https://review.opendev.org/650062
#openstack-sdks - 2019-05-09
00:13:52 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Use cliff formattable columns in network commands https://review.opendev.org/657907
03:09:42 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Use cliff formattable columns in image commands https://review.opendev.org/657911
03:13:57 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Use cliff formattable columns in identity commands https://review.opendev.org/657912
11:09:34 openstackgerrit Stephen Finucane proposed openstack/cliff master: Stop wildcard importing argparse https://review.opendev.org/611889
11:09:35 openstackgerrit Stephen Finucane proposed openstack/cliff master: WIP: Add support for environment variables https://review.opendev.org/611890
11:26:29 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Use cliff formattable columns in image commands https://review.opendev.org/657911
11:26:29 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Use cliff formattable columns in identity commands https://review.opendev.org/657912
11:28:00 bjanssens Hello ppl, I'm trying to pass the OS_PROJECT_DOMAIN_NAME env to openstack.connect but it seems not to be passed through any pointers?
13:21:50 openstackgerrit Jeremy Houser proposed openstack/python-openstackclient master: Refactor test_snapshot.py and test_transfer_request.py https://review.opendev.org/655554
14:03:49 mordred bjanssens: hi! do you also have a clouds.yaml file with clouds defined?
14:04:10 mordred poo. bjanssens left before I finished typing
14:13:49 openstackgerrit Jeremy Houser proposed openstack/python-openstackclient master: Refactor test_snapshot.py and test_transfer_request.py https://review.opendev.org/655554
16:00:03 edleafe The API-SIG Office Hour is now in session!
16:00:39 gtema well, we are probably again alone
16:00:55 gtema dtantsur seem to be still sleeping after travel
16:01:37 edleafe I don't blame him!
16:01:52 edleafe I was exhausted after last week
16:02:05 gtema I would also like to sleeeeeeeeppppp. Feel myself still like zombie
16:16:05 cdent is that a PUT or a POST?
16:16:21 mordred yes
16:16:53 gtema more or less DELETE (SUSPEND)
16:18:45 edleafe It's more of an RPC call
16:42:33 mordred edleafe: are you suggesting it should follow the nova action pattern then/
16:42:35 mordred ?
16:42:52 edleafe mordred: Everything should!
16:43:06 cdent past performance blah blah
16:43:13 mordred edleafe: you're in luck - someone already implemented that - it's called gRPC
17:01:18 gtema mordred: merge day :D party!
18:28:30 openstackgerrit Merged openstack/openstacksdk master: fixing timing https://review.opendev.org/656417
18:28:35 openstackgerrit Merged openstack/openstacksdk master: Add support for all_tenants in OpenStackInventory https://review.opendev.org/656600
18:28:52 openstackgerrit Merged openstack/openstacksdk master: Add "name" filter in "list" call when retrieving a single register https://review.opendev.org/637238
18:30:02 openstackgerrit Merged openstack/openstacksdk master: Update compute.server resource https://review.opendev.org/650868
18:30:03 openstackgerrit Merged openstack/openstacksdk master: Update baremetal to use proxy logger https://review.opendev.org/652083
18:35:50 openstackgerrit Merged openstack/openstacksdk master: Workaround older octavia version discovery https://review.opendev.org/657799
18:38:16 Shrews oh, mordred, you asked me to look at something sdk related some time before the summit. what was that again? i think it was sdk related
18:39:04 Shrews oh, the image things, i think
19:12:52 openstackgerrit Brian Haley proposed openstack/python-openstackclient master: Stop leaving temp files after unit test runs https://review.opendev.org/658190
19:21:59 mordred Shrews: yeah - the image patch
19:23:18 mordred Shrews: this bad boy: https://review.opendev.org/#/c/651534/
19:23:26 mordred Shrews: you can mail thankyou beer to gtema
20:43:31 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Use cliff formattable columns in image commands https://review.opendev.org/657911
20:43:32 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Use cliff formattable columns in identity commands https://review.opendev.org/657912
21:55:49 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Blacklist Bandit 1.6.0 due to directory exclusion bug https://review.opendev.org/658220
#openstack-sdks - 2019-05-10
02:15:06 openstackgerrit Merged openstack/python-openstackclient master: Blacklist Bandit 1.6.0 due to directory exclusion bug https://review.opendev.org/658220
02:24:37 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Use cliff formattable columns in identity commands https://review.opendev.org/657912
02:24:38 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Use cliff formattable columns in image commands https://review.opendev.org/657911
02:24:38 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Use cliff formattable columns in network commands https://review.opendev.org/657907
02:52:07 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Use cliff formattable columns in network commands https://review.opendev.org/657907
02:52:07 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Use cliff formattable columns in image commands https://review.opendev.org/657911
02:52:08 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Use cliff formattable columns in identity commands https://review.opendev.org/657912
11:54:15 openstackgerrit Monty Taylor proposed openstack/cliff master: Pin cmd2 back to <0.9 on all versions https://review.opendev.org/629283
12:32:33 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Extract image download method into a mixin https://review.opendev.org/658346
12:35:51 mordred Shrews: https://review.opendev.org/#/c/651534 has 2x+2 - but I left off +A in case you wanna poke at it
12:36:58 Shrews mordred: i was going to get to that this morning, but if it already has two 2's, go ahead
13:03:01 mordred Shrews: I dunno - one of them is from me - and who knows what I've been drinking
13:12:07 openstackgerrit Merged openstack/python-openstackclient master: document the --timing option https://review.opendev.org/657640
13:38:42 openstackgerrit Jeremy Houser proposed openstack/python-openstackclient master: Refactor test_snapshot.py and test_transfer_request.py https://review.opendev.org/655554
15:28:14 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Continue refactoring of the image https://review.opendev.org/651534
15:29:00 gtema shrews, mordred, dtantsur: with the image refactor there was small conflict with yesterdays merged https://review.opendev.org/#/c/637238/
15:29:40 gtema just pushed a tiny update with changes only in cloud.test_image (few lines adding name query param)

Earlier   Later