Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2019-03-01
22:16:32 openstackgerrit Merged openstack/keystoneauth master: Drop py35 jobs https://review.openstack.org/639915
22:38:37 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Replace TaskManager with a keystoneauth concurrency https://review.openstack.org/604926
22:39:29 mordred needscoffee: ^^ updated ... we'd added in a couple of calls to task_manager.stop() since we wrote the patch that weren't covered in the rebase (cause new)
22:39:50 mordred those are just causing exceptions, because there is no object to call stop on
22:39:57 mordred so I removed them
22:40:03 mordred fingers crossed for this time
23:14:07 needscoffee mordred: ah yeah
23:14:10 needscoffee mordred: that makes sense
23:16:27 needscoffee mordred: thankfully that becomes a non-issue (no more of it) soon.
23:22:02 mordred ++
23:25:48 needscoffee i really hope it passes so we can get that in and stop playing the "this might need more love" game.
#openstack-sdks - 2019-03-02
00:04:22 openstackgerrit Merged openstack/keystoneauth master: add python 3.7 unit test job https://review.openstack.org/610685
02:06:47 openstackgerrit Morgan Fainberg proposed openstack/openstacksdk master: Replace TaskManager with a keystoneauth concurrency https://review.openstack.org/604926
02:07:07 needscoffee mordred: ^ needs lower-constraints update.
02:07:16 needscoffee mordred: but otherwise should pass this time, should be good to remove -2 on it
08:04:58 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Replace TaskManager with a keystoneauth concurrency https://review.openstack.org/604926
08:10:11 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Add DNS support https://review.openstack.org/623009
15:26:28 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Replace TaskManager with a keystoneauth concurrency https://review.openstack.org/604926
15:28:25 mordred needscoffee: ^^ nodepool imports openstack.task_manager, so that patch restores the file even though sdk doesn't use it so that we can unwind it out of nodepool
15:28:54 needscoffee Aha
15:29:09 needscoffee Good stuff
15:31:02 needscoffee So if zuul passes it, I think it is ready to land.
15:31:16 needscoffee Woo, nice to see this moving.
15:44:13 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Move pep8 requirements in to test-requirements https://review.openstack.org/640597
15:44:34 mordred needssleep: srrsly
15:52:31 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Collect request stats https://review.openstack.org/614834
15:52:50 mordred needssleep: there's the followup for the other thing we'll need to get in for feature parity
15:58:41 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Don't try to upload to images in saving or queued state https://review.openstack.org/624188
#openstack-sdks - 2019-03-03
13:27:49 mordred Shrews: ZOMG! https://review.openstack.org/#/c/604926/ is green!
13:27:50 mordred kmalloc: ^^
14:21:38 kmalloc Yeah
14:23:50 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Collect request stats https://review.openstack.org/614834
18:11:34 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Collect request stats https://review.openstack.org/614834
#openstack-sdks - 2019-03-04
06:35:31 openstackgerrit Niraj Singh proposed openstack/openstacksdk master: Add support to get progress details of notification https://review.openstack.org/640673
12:11:41 openstackgerrit Merged openstack/os-service-types master: Update home-page https://review.openstack.org/630075
14:54:54 Shrews mordred: wow. neat. +2
14:57:22 mordred Shrews: ikr?
14:58:43 Shrews mordred: does that mean we need to change nodepool to always pass the rate down?
14:59:03 mordred Shrews: yeah - I've got a nodepool patch up ...
14:59:04 Shrews and remove its own task manager, obviously
14:59:10 Shrews oh
14:59:15 mordred Shrews: https://review.openstack.org/#/c/640643/
15:07:56 Shrews mordred: imma fix up those errors real quick for ya...
15:08:16 mordred Shrews: oh - I've got em fixed locally
15:08:26 Shrews ok
15:08:33 mordred Shrews: want me to go ahead and push them up?
15:08:39 Shrews sure
15:09:01 Shrews if'ns you'ns wanna
15:10:49 Shrews mordred: you missed the 'import os' in provider.py
15:11:25 mordred poop
16:30:24 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Make tox tips job actually run sdk tests https://review.openstack.org/640804
17:09:36 mordred Shrews, dtantsur: ^^ if you get a sec - the openstacksdk jobs we run on keystoneauth changes have just been running keystoneauth tests
17:09:49 dtantsur heh
17:57:59 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: Add "name" filter in "list" call when retrieving a single register https://review.openstack.org/637238
18:31:26 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Move pep8 requirements in to test-requirements https://review.openstack.org/640597
18:53:38 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Clarify error if no version can be found https://review.openstack.org/640835
18:57:11 mordred dtantsur|afk: ^^ that's a followup based on your review
20:26:20 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Move pep8 requirements in to test-requirements https://review.openstack.org/640597
21:13:21 openstackgerrit Merged openstack/openstacksdk master: Make tox tips job actually run sdk tests https://review.openstack.org/640804
21:19:10 mordred \o/
21:19:24 mordred kmalloc: ^^ you migth find that patch that just landed amusing
21:19:52 mordred kmalloc: for some value of amusing
21:23:09 tosky mordred: talking about amusing things... do you remember our old discussion about openstacksdk and its lack of branches which makes the openstack-check-plugins jobs fail on older branches?
21:23:12 kmalloc hahaha
21:23:20 kmalloc oh man really?
21:23:35 kmalloc well then...
21:24:55 mordred tosky: uhm ... let's go with "yes" but also maybe it would be fun to rehash the problem as-if I didn't remember because I'm old and addled
21:25:08 mordred (although openstacksdk does have branches)
21:25:51 tosky uh
21:26:28 tosky let me find again which unbranches repository prevented those jobs from working
21:26:32 mordred http://git.openstack.org/cgit/openstack/openstacksdk/log/?h=stable/rocky
21:26:35 mordred probably shade?
21:26:49 mordred oh!
21:26:52 mordred no - os-service-types
21:27:01 mordred os-service-types definitely does not have branches
21:27:27 tosky openstackclient, sorry, it was openstackclient
21:27:33 mordred ah
21:27:36 mordred yes. that one
21:27:51 mordred (also os-service-types - but openstack-check-plugin makes more sense to have problems with openstackclient repo)
21:28:47 mordred dtroyer: ^^ I think tosky's issue is more of a you thing than a me thing, although I'm more than happy to be helpful if I can
21:29:06 tosky I lost the logs of the test jobs, but I can recheck them
21:29:43 dtroyer osc has branches
21:29:43 tosky those reviews: https://review.openstack.org/#/c/588515/ https://review.openstack.org/#/c/588336/
21:29:55 tosky python-openstackclient has branches; openstackclient has no branches
21:30:27 dtroyer ah, right, I always miss that. it also has no releases, or if it does it's intert. don't use it (yet)
21:31:28 tosky right, but opentackclient-check-plugins is defined inside openstackclient
21:31:55 tosky and something weird happens with the dependencies (partially from master, but then they don't mix with the dependencies from the branches)
21:31:57 tosky let me recheck the jobs
21:33:12 tosky I think it's just a matter of moving away the job from there :)
21:33:56 dtroyer yeah, moving it in the first place was premature since we're not really using the openstackclient repo now
21:33:59 dtroyer otherwise
21:45:41 tosky dtroyer: http://logs.openstack.org/36/588336/4/check/openstackclient-check-plugins/f5225ad/job-output.txt.gz#_2019-03-04_21_42_38_050007
21:46:15 tosky quoting myself from 6 months ago: "there is a conflict with a version of keystoneclient which seems to come from master (>=3.17.0)"
21:47:16 tosky and we discussed again about this here: http://eavesdrop.openstack.org/irclogs/%23openstack-sdks/%23openstack-sdks.2018-09-27.log.html#t2018-09-27T12:39:22
#openstack-sdks - 2019-03-05
04:52:33 shilpasd dtantsur|afk: hi, kindly review https://review.openstack.org/#/c/640673/
05:19:04 shilpasd Requesting core reviewer: kindly review https://review.openstack.org/#/c/640673/
07:37:34 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: Add "name" filter in "list" call when retrieving a single register https://review.openstack.org/637238
09:02:29 openstackgerrit Colleen Murphy proposed openstack/keystoneauth master: Fix rate semaphore for keystoneclient https://review.openstack.org/640957
11:47:26 shilpasd gtema: thanks for review https://review.openstack.org/#/c/640673/1, will address review comments and shortly update the latest patch
12:00:34 openstackgerrit Niraj Singh proposed openstack/openstacksdk master: Add support to get progress details of notification https://review.openstack.org/640673

Earlier   Later