| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2019-02-19 | |||
| 14:06:07 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: WIP Move image methods to sdk image proxy https://review.openstack.org/609684 | |
| 14:12:04 | gtema | mordred: just rebased your change 609684 on top of master leaving all other related changes off, since there were lots of conflicts | |
| 14:44:24 | mordred | gtema: sweet. obviously the code needs some cleanup to start using Image resource objects internally - but I think if we can get that passing tests landing it in that state should let us Resource-ify it in smaller patches | |
| 14:46:55 | gtema | great | |
| 14:47:42 | gtema | mordred: let's see what the tests show now. Do you want to continue on it, or should I take it? | |
| 14:56:30 | johnsom | dulek: fyi, Octavia tags support has merged. Still waiting on the rest of those patches however. | |
| 15:02:23 | dulek | johnsom: Oh, I see, it's even released. :) | |
| 15:19:27 | Shrews | dtantsur: +A'd https://review.openstack.org/636594 but left a nit there you might want to see | |
| 15:22:51 | openstackgerrit | Vishakha Agarwal proposed openstack/python-openstackclient master: Cleanup: Remove deprecated role list filters https://review.openstack.org/637166 | |
| 15:24:13 | dtantsur | Shrews: thanks! I'll check that and also the place I copy-pasted it from :) | |
| 15:42:16 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Add image.task resource https://review.openstack.org/637913 | |
| 16:13:54 | openstackgerrit | Merged openstack/python-openstackclient master: Fix help message of image add project https://review.openstack.org/637828 | |
| 16:21:32 | mordred | gtema: if you haven't started yet - I'm going to take a quick stab at the failures on that WIP image reorg patch | |
| 16:22:48 | mordred | Shrews, dtantsur: https://review.openstack.org/#/c/637563/ if you have a sec ... odyssey4me was having a hard time debugging a failure yesterday in nodepool, and it's a failure mode that is always confusing to users when it happens | |
| 16:23:42 | mordred | Shrews, dtantsur: it's a behavior change, but I **seriously** doubt it's a behavior change anyone is depending on because I think I might be the only person to have that whole behavior stack in my head :) | |
| 16:24:53 | mordred | gtema: ^^ you might also want to look at that one | |
| 16:25:22 | dtantsur | mordred: any unit tests to update? | |
| 16:25:46 | mordred | dtantsur: no - it worked fine (although that maybe indicates there is a missing unittest) | |
| 16:25:55 | dtantsur | exactly ;) | |
| 16:27:27 | mordred | the only use case I could see this making harder is if a user has a cloud that only has an unknown verion of a known service - but even in that case they can set an endpoint_override and a version override and it'll work | |
| 16:27:55 | mordred | dtantsur: after I poke at this image patch I'll see if I can't come up with a unittest | |
| 16:31:16 | gtema | mordred: you should definitely have a look in to the image-reorg. I have managed to resolve some of the issues, but here a knowledge of shade-creator is required to do it properly | |
| 16:37:03 | openstackgerrit | Merged openstack/openstacksdk master: baremetal: implement set_node_power_state in the proxy https://review.openstack.org/636601 | |
| 16:39:58 | openstackgerrit | Merged openstack/openstacksdk master: baremetal: support for allocation API https://review.openstack.org/636594 | |
| 16:43:14 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Add image.task resource https://review.openstack.org/637913 | |
| 17:03:07 | gtema | mordred, odyssey4me: with https://github.com/ansible/ansible/pull/37390 a change of "default" port_security_enabled from True (when not given) to False (explicitly) was introduced. Now all openstacksdk-ansible-devel-functional-devstack are failing | |
| 17:08:10 | gtema | mordred, odyssey4me: I do not really understand why so far, but comparing logs from stable-2.6 and master I see that in 2.6 when no port_security_enabled was given - a net with "True" was created, even when in the SDK we have a default of "False" | |
| 17:13:07 | gtema | mordred, odyssey4me: I got it. Ansible calls cloud.create_network and it bypasses Resource completely, so a "deployed default" plays role. I think we need to create a follow-up in Ansible to make default 'None' | |
| 17:14:14 | Shrews | mordred: 563 lgtm, but will wait for your unittest | |
| 17:14:38 | Shrews | mordred: also, sorry for delay. still quite sick :( | |
| 17:14:41 | mordred | Shrews: coolio | |
| 17:14:49 | mordred | Shrews: no worries! you should stop being sick :( | |
| 17:14:54 | Shrews | ikr? | |
| 17:35:51 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Add image.task resource https://review.openstack.org/637913 | |
| 18:49:35 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Add image attributes from v2.7 https://review.openstack.org/637538 | |
| 20:20:26 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Add image attributes from v2.7 https://review.openstack.org/637538 | |
| #openstack-sdks - 2019-02-20 | |||
| 09:33:23 | openstackgerrit | David Rabel proposed openstack/python-openstackclient master: Fix help message of image add project https://review.openstack.org/638113 | |
| 11:33:03 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: WIP Move image methods to sdk image proxy https://review.openstack.org/609684 | |
| 11:38:03 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Fix minor issues in the baremetal proxy docs https://review.openstack.org/638136 | |
| 11:38:08 | dtantsur | Shrews: ^^^ (also get better soon!) | |
| 13:25:25 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: WIP Move image methods to sdk image proxy https://review.openstack.org/609684 | |
| 13:56:16 | Shrews | dtantsur: thanks, feeling much better today | |
| 13:56:30 | dtantsur | great :) | |
| 14:01:38 | Shrews | dtantsur: i guess something in neutron is broken based on the failures in your doc change? | |
| 14:02:12 | dtantsur | dunno, haven't checked yet (crazy day) | |
| 14:02:33 | Shrews | embrace the crazy | |
| 14:03:42 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Fix minor issues in the baremetal proxy docs https://review.openstack.org/638136 | |
| 14:06:22 | frickler | slaweq: ^^ that looks like a neutron regression, have you seen that yet? http://logs.openstack.org/36/638136/1/check/openstacksdk-functional-devstack/1cdc712/controller/logs/screen-q-svc.txt.gz#_Feb_20_12_04_53_392346 | |
| 14:10:03 | slaweq | frickler: I will check | |
| 14:10:18 | frickler | https://review.openstack.org/635671 looks slightly suspicous in that context | |
| 14:14:26 | slaweq | frickler: TBH I hope it's not that one :) | |
| 14:26:29 | slaweq | frickler: https://bugs.launchpad.net/neutron/+bug/1816771 | |
| 14:26:30 | openstack | Launchpad bug 1816771 in neutron "Creation of router fails in devstack" [Undecided,New] | |
| 14:26:44 | slaweq | frickler: we now have L3 subteam meeting so I will try to raise this one there | |
| 14:28:36 | frickler | slaweq: thx | |
| 14:38:13 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: WIP Move image methods to sdk image proxy https://review.openstack.org/609684 | |
| 14:53:40 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: Add "name" filter in "list" call when retrieving a single register https://review.openstack.org/637238 | |
| 16:01:09 | ralonsoh | dtantsur, hi. About https://review.openstack.org/#/c/637238/2/requirements.txt@11. oslo.utils is already required in nova, neutron and many other projects. I usually prefer not to copy/paste code and use the libraries provided by the OpenStack ecosystem | |
| 16:01:33 | dtantsur | ralonsoh: usually copy-paste is bad, but this is quite an overkill | |
| 16:01:35 | ralonsoh | dtantsur, I'm using both in the code and the tests | |
| 16:01:53 | dtantsur | keep in mind that openstacksdk targets consumers that do not use oslo libraries | |
| 16:02:09 | dtantsur | like this https://github.com/openstack/metalsmith/blob/master/requirements.txt | |
| 16:02:09 | ralonsoh | dtantsur, ok, I'll implement both functions in sdk repo | |
| 16:05:22 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: WIP Move image methods to sdk image proxy https://review.openstack.org/609684 | |
| 16:06:07 | mordred | yeah. we don't use oslo libraries in sdk because our users are end-users and not just openstack services | |
| 16:09:57 | gtema | mordred: I'm passing image-reorg to you. 'properties' need to be fixed, but I do not know how you wanted to do this | |
| 16:10:16 | mordred | gtema: oh - hah. I've got a huge update to that patch locally | |
| 16:10:43 | gtema | mordred: ups. Fun merging | |
| 16:10:54 | mordred | although i'm also at "properties needs to be fixed" | |
| 16:11:06 | gtema | but you can then simply throw away my changes then | |
| 16:16:51 | mordred | :) | |
| 16:17:02 | mordred | gtema: just think how much fun we both got to have | |
| 16:17:13 | gtema | yeah | |
| 16:17:27 | gtema | and this all is just a beginning of aligning things | |
| 16:18:14 | gtema | mordred: https://review.openstack.org/#/c/637913/ - have you wanted it for ImageTask this way? | |
| 16:19:56 | mordred | gtema: yeah - I think that's a great idea (although I haven't read the whole patch yet) | |
| 16:20:20 | gtema | no hurry. Just a brief idea, especially with respect to wait_for_task | |
| 16:22:48 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Move image methods to sdk image proxy https://review.openstack.org/609684 | |
| 16:23:01 | mordred | gtema: ok. I think that should work now | |
| 16:23:12 | gtema | mordred: great | |
| 16:23:17 | mordred | gtema: unless it doesn't | |
| 16:23:48 | gtema | :D let's see | |
| 16:30:30 | ralonsoh | dtantsur, mordred: thanks! I'll implement those functions in the repo | |
| 17:37:56 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Add image.service_info resources https://review.openstack.org/638227 | |
| 19:17:19 | mordred | dtroyer: does this: http://logs.openstack.org/84/609684/9/check/openstacksdk-functional-devstack-tips/0c1b740/job-output.txt.gz#_2019-02-20_16_51_39_497256 mean anything to you? | |
| 19:19:33 | Shrews | mordred: slaweq opened a bug for that this morning https://bugs.launchpad.net/neutron/+bug/1816771 | |
| 19:19:34 | openstack | Launchpad bug 1816771 in neutron "Creation of router fails in devstack" [Undecided,New] | |
| 19:19:46 | mordred | Shrews: oh awesome | |
| 19:22:04 | johnsom | mordred Who should I poke to get the rest of this chain merged? We want to start using some of this in the dashboard. https://review.openstack.org/#/q/project:openstack/openstacksdk+owner:self+status:open | |
| 19:43:02 | dtroyer | mordred: no, that's new to me | |
| 19:43:21 | mordred | dtroyer: seems there is a neutron bug open - so yay | |
| 19:48:34 | mordred | johnsom: I pushed them in (responded to dtantsur|afk on the first one) - although it's possible we'll hit that neutron bug | |
| 19:49:03 | johnsom | mordred Thank you! | |
| 19:49:47 | mordred | Shrews: got a sec to look at https://review.openstack.org/#/c/634558 ? | |
| 20:28:45 | Shrews | mordred: sure | |
| 22:46:23 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Bail earlier on a version mismatch for a supported service https://review.openstack.org/637563 | |
| 22:46:36 | mordred | Shrews, dtantsur|afk : ^^ I made tests | |
| #openstack-sdks - 2019-02-21 | |||
| 00:48:02 | mordred | slaweq: let me know if I can be helpful investigating that devstack/neutron thing - it's hitting all of our patches now | |
| 00:48:11 | mordred | slaweq: I'm pretty open tomorrow and can debug or whatnot if it's helpful | |
| 08:03:17 | slaweq | mordred: frickler: I found the culprit of Your issue :) | |