| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2019-01-08 | |||
| 06:05:46 | ykarel | mordred, hi | |
| 06:05:57 | ykarel | mordred, remember thread.error: can't start new thread i mentioned sometime back | |
| 06:06:25 | ykarel | in openstacksdk python2 and i proposed https://review.openstack.org/#/c/615543 | |
| 06:07:54 | ykarel | mordred, looks like it's fixed in master, as test passing during package build https://review.rdoproject.org/r/#/c/16824/ | |
| 06:08:13 | ykarel | mordred, can u confirm the fix, and get a new release from master | |
| 08:58:58 | openstackgerrit | Johannes Kulik proposed openstack/openstacksdk master: Use pagination detection by default https://review.openstack.org/629110 | |
| 10:06:50 | openstackgerrit | Bruno HALEBLIAN proposed openstack/openstacksdk master: implement identity v3 Proxy "unassign_project_role_from_user" https://review.openstack.org/629073 | |
| 12:18:02 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Compute location properly in server https://review.openstack.org/626380 | |
| 12:18:02 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Skip block-storage tests when service is not found https://review.openstack.org/628969 | |
| 12:18:03 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Skip block storage v2 functional tests for a minute https://review.openstack.org/629162 | |
| 12:28:41 | mordred | ykarel: awesome! there have only been two patches landed in master that aren't in 0.22.0. I'm not sure which of them might have been related | |
| 12:29:31 | mordred | ykarel: but - I'll be happy to get a new sdk release cut - I'd like to land a couple of the patches in flight - perhaps a release by tomorrow? | |
| 12:30:06 | ykarel | mordred, ok for me | |
| 12:30:10 | ykarel | and Thanks | |
| 12:32:26 | mordred | jkulik: thanks for the patch - looks great, those test failures are unrelated and I've got a couple of patches up to deal with them | |
| 12:34:27 | jkulik | mordred, the other one seems more important to me: https://review.openstack.org/628977 | |
| 12:34:39 | jkulik | especially if pagination detection should become default | |
| 12:36:32 | mordred | jkulik: yes! very much so | |
| 12:50:05 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Skip v2 block-storage tests when service is not found https://review.openstack.org/628969 | |
| 12:50:19 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Skip v2 block-storage tests when service is not found https://review.openstack.org/628969 | |
| 12:51:14 | mordred | Shrews: if you have a sec when you're up, ^^ and the one before it (the one before it is a hack workaround to unblock the gate - but then I think I actually figured out the real problem in the second patch) | |
| 13:24:00 | dtantsur | mordred: so, maybe leave only the 2nd patch? :) | |
| 13:24:57 | mordred | dtantsur: yeah ... but I also might be wrong :) | |
| 13:25:14 | mordred | I thought I had it figured out yesterday too ... but oh I was so wrong | |
| 13:25:21 | dtantsur | mordred: okay, +2 on the 1st patch | |
| 13:25:28 | dtantsur | will wait for the CI on the 2nd | |
| 13:25:34 | mordred | ++ ... and thanks! | |
| 13:26:00 | mordred | this also reminds me we really need to get the v3 volume support patch updated and landed | |
| 13:26:27 | dtantsur | indeed | |
| 13:37:58 | mordred | cmurphy, lbragstad: I'm seeing some errors in the osc functional tips job that are keystone related and that I have **no clue** what's up: http://logs.openstack.org/80/626380/9/check/osc-functional-devstack-tips/dcf2d3a/testr_results.html.gz | |
| 13:38:14 | mordred | makes me think maybe there is a devstack something missing? or something something? | |
| 13:40:26 | mordred | Shrews, dtantsur: woot! https://review.openstack.org/#/c/626380/ is green which means it's worth reviewing - it's not NEARLY as much test case carnage as I thought it would be | |
| 13:44:06 | cmurphy | mordred: oops that's probably because of https://review.openstack.org/#/c/626007 | |
| 13:44:16 | cmurphy | lbragstad will know what to do | |
| 13:44:47 | mordred | cmurphy: neat! I like it when people know what to do | |
| 13:58:18 | mordred | dtantsur: replied to your comment - and thanks! | |
| 13:58:38 | dtantsur | ah, cool | |
| 14:00:32 | mordred | dtantsur: I keep looking at the code and thinking I'm going to go through and rename all of those uses of "session" which are not actually sessions | |
| 14:00:47 | mordred | dtantsur: I then keep giving up because life is too short | |
| 14:00:55 | dtantsur | heh, right | |
| 14:03:22 | mordred | ooh! the update to the volume tests hit a whole new issue. I'm guessing that one needs admin credentials | |
| 14:04:45 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Extract getting connection from proxy into method https://review.openstack.org/629193 | |
| 14:06:54 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Skip v2 block-storage tests when service is not found https://review.openstack.org/628969 | |
| 14:07:03 | mordred | look at all these exciting patches | |
| 14:07:41 | lbragstad | cmurphy mordred interesting | |
| 14:08:15 | mordred | uhoh :) | |
| 14:09:19 | lbragstad | that's failing because the user making the request in those tests isn't defined as a system administrator | |
| 14:09:35 | lbragstad | they probably only have a role assignment on the project | |
| 14:09:56 | lbragstad | and in keystone we've changed those policies to require a system admin in order to access the registered limits APIs | |
| 14:13:31 | lbragstad | cmurphy mordred https://review.openstack.org/#/c/621016/ was probably the breaking change | |
| 14:17:53 | mordred | lbragstad: ok. so we should likely update the osc tests for that to use an admin auth context rather than an end-user one | |
| 14:21:16 | mordred | lbragstad: hrm. it looks like osc is already using the devstack-admin account (it's doing domain deletion operations already and stuff) | |
| 14:23:22 | Shrews | mordred: the osc-func-tips job is pretty sad in 380 | |
| 14:23:48 | Shrews | non-voting but probably worth looking into? | |
| 14:33:46 | mordred | Shrews: yah - that's the convo with lbragstad | |
| 14:34:07 | mordred | lbragstad: perhaps the devstack-admin account in devstack isn't being granted the system admin role? | |
| 14:36:29 | Shrews | mordred: pfffft... who has time to read scrollback?? | |
| 14:37:10 | lbragstad | mordred it should have it | |
| 14:37:19 | lbragstad | keystone-manage bootstrap does that for you | |
| 14:37:30 | lbragstad | which i'm pretty sure devstack executes | |
| 14:37:47 | lbragstad | but, i think the tests need to ask for a system-scoped token instead of a project-scoped one | |
| 14:37:54 | lbragstad | and use that for those requests instead | |
| 14:39:17 | lbragstad | https://developer.openstack.org/api-ref/identity/v3/index.html?expanded=token-authentication-with-scoped-authorization-detail#id30 | |
| 14:40:19 | mordred | oh goodie | |
| 14:41:34 | mordred | lbragstad: I honestly have no idea how to get a system-scoped token with osc - or if it's even possible | |
| 14:41:47 | lbragstad | does osc use ksa? | |
| 14:42:24 | mordred | yeah - but I don't know if we've got 'scope' plumbed through in either config or cli args | |
| 14:42:39 | mordred | lbragstad: how does one get a system scoped token with ksa? | |
| 14:43:42 | lbragstad | looking for an example | |
| 14:44:57 | mordred | cool. fwiw, we're still using keystoneclient for keystone things | |
| 14:47:49 | lbragstad | mordred if you set system_scope=all with password authentication, it should work https://docs.openstack.org/keystoneauth/latest/plugin-options.html#password | |
| 14:49:05 | lbragstad | :( | |
| 14:49:20 | lbragstad | we did overhaul some docs to try and make things more clear | |
| 14:49:24 | lbragstad | https://docs.openstack.org/keystone/latest/admin/tokens-overview.html | |
| 14:51:25 | frickler | "openstack --os-system-scope system registered limit create ..." works for me with the devstack-admin user and unsetting all OS_PROJECT/TENANT env | |
| 14:52:18 | mordred | ah - --os-system-scope | |
| 14:52:20 | mordred | neat | |
| 14:53:12 | frickler | would be nice to give a warning when it still does project-scope, instead of silently ignoring the system-scope request in that case | |
| 14:54:31 | mordred | I think it would be better if --os-system-scope overrode the project settings -- unsetting env vars is a bit of a pita | |
| 14:54:45 | dtantsur | lbragstad: this actually helps. I don't think i saw it when I started rust-openstack. | |
| 14:56:08 | mordred | frickler: because the osc test cases are all run with env vars set ... | |
| 14:57:37 | frickler | mordred: yeah, having cli options override other env vars would be neat, too, but not so easy I fear | |
| 14:57:43 | lbragstad | frickler it does.. but since the registered limit and limit apis are still experimental, we didn't deprecate the policies | |
| 14:58:03 | lbragstad | https://gist.github.com/lbragstad/ad744f1a5acb4f4dc3387383514ab33f is an example of defining different scopes in clouds.yaml | |
| 14:58:27 | lbragstad | if you had different users with different roles on the system (one of them being a read-only role) | |
| 14:58:33 | frickler | mordred: maybe setting things like --os-project-name="" to set overrides to the env via cli might work in the meantime | |
| 14:59:00 | lbragstad | dtantsur if you have questions about how all that works, you should bug me :) I'm happy to help | |
| 14:59:02 | mordred | frickler: yeah, I'll try that | |
| 14:59:21 | dtantsur | lbragstad: thanks! I will when I start extending authentication support there | |
| 14:59:30 | frickler | lbragstad: I'm not talking about policies, a simple "openstack --os-system-scope system token issue" will still issue a project-scope token without warning when e.g. OS_TENANT_NAME is set | |
| 14:59:44 | lbragstad | ahh | |
| 14:59:53 | lbragstad | got it - i misread that | |
| 15:00:11 | cmurphy | lbragstad: it seems like this is pointing out an issue in our backwards compatibility? | |
| 15:00:37 | lbragstad | with the policies or with osc? | |
| 15:00:48 | cmurphy | with the policies | |
| 15:01:22 | lbragstad | they are backwards compatible when we deprecate them - due to the logic in the oslo.policy library | |
| 15:01:42 | lbragstad | the only reason we didn't with the registered limit and limit policies is because the api is experimental | |
| 15:01:53 | cmurphy | oh I see | |
| 15:02:08 | cmurphy | I assumed we went through the same process with those | |
| 15:02:30 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Set system-scope parameter for registered_limits tests https://review.openstack.org/629203 | |