Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-11-30
09:25:09 gtema dtantsur|msg: as a continue to removal of xxxDetails I have found similar issue in orchestrate
09:25:19 gtema but the difference is that it is not list, but create/update
09:25:30 dtantsur|mtg I think all Details are broken more or less
09:25:36 gtema basically StackPreview
09:26:14 gtema I feel it would be good to apply the same approach as for Details here, but this would mean extension for also other request types
09:26:30 gtema and extending basic proxy/resource/test_proxy
09:26:43 gtema this is however becoming relatively big
09:26:55 gtema I mean everywhere adding optional base_path
09:27:08 gtema wanted to ask, what is your opinion here?
09:28:04 dtantsur|mtg I need to think about it, I'm quite sleepy right now :) and I'm not familiar with orchestration enough
09:28:54 gtema it's not about orchestration itself. I am asking more about adding base_path optional parameter not only for "list", what you did for Details, but also for other request types
09:30:00 gtema use case: upon some parameter to proxy (i.e. preview) the endpoint for "create" is different
09:44:28 dtantsur|mtg gtema: this can be done in _prepare_request (used by everything except for list)
09:45:12 gtema sure, this is what I have done. But you would first need to also extend Proxy._create (and _update) and pass this optional parameter into Resource
09:45:46 gtema and this mean that test_proxy_base should be also extended with additional check of base_path for such calls
09:46:35 gtema that's what I ment "is getting big"
09:47:29 gtema and wanted to check before I land a patch not to face resistence
09:47:54 gtema s/resistence/resistance/
09:58:21 dtantsur|mtg the approach seems good to me at first glance, but I really need to see the code
09:58:37 gtema ok, than I will work further
09:58:46 gtema thanks
13:02:50 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Add possibility to override base_path for resource operations https://review.openstack.org/621153
13:04:43 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Rework orchestration to add update preview https://review.openstack.org/621154
14:11:36 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Add possibility to override base_path for resource operations https://review.openstack.org/621153
14:46:49 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Rework orchestration to add update preview https://review.openstack.org/621154
16:39:11 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Rework orchestration to add update preview https://review.openstack.org/621154
16:41:06 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Add possibility to override base_path for resource operations https://review.openstack.org/621153
16:48:43 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Rework orchestration to add update preview https://review.openstack.org/621154
16:57:41 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Rework orchestration to add update preview https://review.openstack.org/621154
18:40:11 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: WIP Fix version discovery for rackspace public cloud https://review.openstack.org/621257
18:49:27 kmalloc mordred: ^ that makes me sad.
18:49:44 Shrews kmalloc: yah, he's working on a better thilng
18:49:51 kmalloc i figured
18:49:53 kmalloc but man.
18:50:00 kmalloc gross.
18:50:54 kmalloc cmurphy: ^ cc
18:58:50 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Fix version discovery for clouds with int project_ids https://review.openstack.org/621257
19:09:35 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Fix version discovery for clouds with int project_ids https://review.openstack.org/621257
19:35:36 openstackgerrit Nathan Kinder proposed openstack/osc-lib master: Default to using public interface for all clients https://review.openstack.org/621276
20:00:23 mordred kmalloc: ^^ care to weigh in on that one?
20:01:32 kmalloc the most recent one?
20:01:50 kmalloc or the nkinder change?
20:02:11 kmalloc cause YES PUBLIC INTERFACES
20:03:05 kmalloc mordred: +1 (since i don't have +2 on that repo)
20:03:11 kmalloc but i'd +2 that if i could
20:18:38 mordred kmalloc: sweet. perhaps dhellmann or dtroyer will do the +3
20:21:24 dhellmann lgtm
21:14:40 larsks mordred: https://review.openstack.org/#/c/618519/ has two +2s and +verified, but it hasn't merged yet. Is something stuck?
21:15:04 mordred larsks: it's marked cannot merge
21:15:09 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: syntax errors and undefined exceptions in service_description.py https://review.openstack.org/618519
21:15:20 mordred larsks: I rebased it - let's see if that fixes the issue
21:16:09 larsks mordred: I must not have been looking at the right spot. Thanks!
21:16:31 mordred larsks: fingers crossed gerrit likes us this time
21:40:48 openstackgerrit Monty Taylor proposed openstack/promstat master: Add initial code https://review.openstack.org/621295
23:29:54 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Transform server with munch before normalizing https://review.openstack.org/621316
23:30:47 mordred Shrews: ^^
#openstack-sdks - 2018-12-01
06:08:39 openstackgerrit Merged openstack/openstacksdk master: syntax errors and undefined exceptions in service_description.py https://review.openstack.org/618519
07:16:25 openstackgerrit Yang JianFeng proposed openstack/openstacksdk master: Add support for octavia's resuorces quota https://review.openstack.org/590193
14:03:06 openstackgerrit Merged openstack/promstat master: Add initial code https://review.openstack.org/621295
16:25:42 openstackgerrit Merged openstack/keystoneauth master: Fix version discovery for clouds with int project_ids https://review.openstack.org/621257
16:37:11 openstackgerrit Merged openstack/openstacksdk master: Transform server with munch before normalizing https://review.openstack.org/621316
21:23:39 openstackgerrit Merged openstack/osc-lib master: Default to using public interface for all clients https://review.openstack.org/621276
22:02:44 openstackgerrit Gonéri Le Bouder proposed openstack/openstacksdk master: object_store: exposes the prefix parameter https://review.openstack.org/621381
#openstack-sdks - 2018-12-02
03:55:31 openstackgerrit Merged openstack/openstacksdk master: Fix some spelling in documentation https://review.openstack.org/618198
#openstack-sdks - 2018-12-03
09:21:31 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Add possibility to override base_path for resource operations https://review.openstack.org/621153
10:25:53 openstackgerrit Merged openstack/openstacksdk master: Add missing properties for role https://review.openstack.org/614705
13:33:18 mordred dtantsur: does https://review.openstack.org/#/c/616227/ look ok to you now?
13:33:30 dtantsur lemme see
13:35:19 dtantsur +2
13:44:24 mordred \o/
14:02:24 Shrews mordred: for that ping from late friday for 621316, seems like _normalize_server() should handle that, no?
14:03:24 Shrews seems silly to have to Munch a thing before we call a thing that returns a Munch
14:03:32 mordred Shrews: well - normalize_server handles making a new munch - but previously the rest call itself had returned a munch rather than a dict ...
14:03:48 mordred but yeah - maybe the right answer there is to just munch the flavor?
14:04:09 Shrews mordred: what you have should work, it's just confusing to me
14:04:33 Shrews and is sort of a broken interface
14:05:47 Shrews we call _normalize_server() in multiple places, but only pre-munch in the one
14:06:11 Shrews mordred: so maybe it's still broken for certain paths
14:06:32 mordred oh - yeah. good point
14:07:00 mordred lemme try something different
14:08:37 Shrews okie
14:15:17 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Move server munch transformation into normalize https://review.openstack.org/621585
14:15:21 mordred Shrews: how's that?
14:16:30 Shrews mordred: looks like that would work
14:16:54 mordred woot
14:17:08 Shrews though, without a test, how do we know? ;)
14:24:49 mordred hahaha
14:24:53 mordred Shrews: MAGIC?
14:25:51 Shrews so much magic
15:10:56 openstackgerrit Merged openstack/openstacksdk master: Slightly refactor vendor profile loading https://review.openstack.org/616227
15:13:35 openstackgerrit Merged openstack/osc-lib master: Fix formatter handling for python 3.7 https://review.openstack.org/618137
15:25:27 openstackgerrit Merged openstack/python-openstackclient master: Add Python 3.6 classifier to setup.cfg https://review.openstack.org/621096
15:36:36 tis_at_teuto_net Hi there, i had a problem to perform an create-request for openstack.block_storage.v2.type.Type. The volume-type was created, but the attribute 'os-volume-type-access:is_public' was not set. Further i was unable to query non-public voume-types, because the required flag is not set in the get-request. I've changed two classes to get things working and i wanne give back the two small changes. I saw that this is not
15:36:36 tis_at_teuto_net possible via github-pull-request. Can you tell me what is the easiest way to do this? Regards, Tino.
15:39:23 frickler tis_at_teuto_net: for starters see https://docs.openstack.org/infra/manual/developers.html , feel free to ask again here when you get stuck
15:40:59 tis_at_teuto_net Thanks.
15:59:01 openstackgerrit Tino Schmeier proposed openstack/openstacksdk master: - added query-parameters to filter for non-public volume-types. Needs ?is_public=None https://review.openstack.org/621617
16:18:47 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Support non-public volume types https://review.openstack.org/621617
16:19:28 mordred frickler: ^^ there's that patch from tis_at_teuto_net - I updated the commit message to fix the formatting, but otherwise the patch lgtm
16:24:01 mordred Shrews: feel like reviewing https://review.openstack.org/#/c/616228/ ? I even added a test!

Earlier   Later