| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-11-01 | |||
| 15:37:47 | kmalloc | Hmmmmmm | |
| 15:38:14 | kmalloc | mordred: we don't do a good job of communicating that is allowed | |
| 15:38:39 | kmalloc | mordred: you could use our API version (e.g. 3.11) | |
| 15:40:04 | kmalloc | mordred: let me check, roles might be a bit sloppy on this front though and just work. | |
| 15:42:45 | kmalloc | mordred: so, roles are sloppy and store "extra" fields in a JSON blob | |
| 15:42:55 | kmalloc | So if it isn't supported, it still works | |
| 15:43:21 | kmalloc | And stores it as description on the role. The difference is it is a full column now. | |
| 15:43:40 | kmalloc | It should be fine to just support that universally | |
| 15:43:59 | kmalloc | Other resources are not as sloppy, and may not work like that. | |
| 15:45:54 | kmalloc | https://github.com/openstack/keystone/blob/master/keystone/assignment/role_backends/sql.py#L203 | |
| 15:45:57 | kmalloc | And | |
| 15:46:25 | kmalloc | https://github.com/openstack/keystone/blob/master/keystone/assignment/schema.py#L26 | |
| 15:48:09 | kmalloc | This also highlights that we wrote a broken migration for adding that column :( | |
| 15:57:16 | mordred | kmalloc: oh yay fun | |
| 15:57:49 | kmalloc | Basically, we didn't migrate descriptions from the json blob | |
| 15:58:08 | mordred | \o/ | |
| 15:58:13 | kmalloc | So when that column is added, any descriptions should be eaten | |
| 15:58:23 | kmalloc | And disappear | |
| 15:58:32 | mordred | kmalloc: that would be a super fun migration to write | |
| 15:58:40 | kmalloc | I think.. the extras code is horrid | |
| 15:58:44 | mordred | yeah | |
| 15:58:48 | kmalloc | I want to just delete it. | |
| 15:58:58 | kmalloc | But something something API contract | |
| 15:59:28 | kmalloc | We did it before. | |
| 15:59:34 | kmalloc | It is gross to migrate. | |
| 16:00:32 | kmalloc | I should 2x check with previous openstack (devstack) but I am fairly certain... It isn't an issue (the code you linked me ) | |
| 16:00:38 | elmiko | API SIG office hours now open | |
| 16:01:46 | kmalloc | Sorry, no coffee today. I drank it all. | |
| 16:01:49 | elmiko | ooh snacks! | |
| 16:02:29 | edleafe | Sooooo... some weather we've been having, eh? | |
| 16:02:49 | elmiko | lol | |
| 16:08:54 | mordred | edleafe: it was rainy most of the day yesterday, but luckily let up right around dusk | |
| 16:09:32 | edleafe | mordred: Good for the crops! | |
| 16:10:39 | mordred | edleafe: you'd think - but we've actually gotten more than our average annual rainfall just in the last month ... so things are a bit water logged | |
| 16:11:11 | kmalloc | mordred: so, not swimming ATM, eh? ;) | |
| 16:18:00 | mordred | kmalloc: oh golly no - way too chilly for that | |
| 16:18:21 | kmalloc | Hehe. | |
| 17:08:07 | elmiko | later edleafe o/ | |
| 17:09:02 | edleafe | c ya | |
| 18:44:23 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Replace TaskManager with a keystoneauth concurrency https://review.openstack.org/604926 | |
| 18:44:23 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove mocking workaround from adapter https://review.openstack.org/614831 | |
| 18:44:24 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Shift swift segment async code out of adapter https://review.openstack.org/614832 | |
| 18:44:24 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove unused Task classes https://review.openstack.org/614833 | |
| 18:44:25 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Collect request stats with statsd https://review.openstack.org/614834 | |
| 18:46:58 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Replace TaskManager with a keystoneauth concurrency https://review.openstack.org/604926 | |
| 21:03:39 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Shift swift segment async code out of adapter https://review.openstack.org/614832 | |
| 21:03:40 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove unused Task classes https://review.openstack.org/614833 | |
| 21:03:40 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Collect request stats with statsd https://review.openstack.org/614834 | |
| 21:03:41 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Replace TaskManager with a keystoneauth concurrency https://review.openstack.org/604926 | |
| 23:11:46 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Collect request stats with statsd https://review.openstack.org/614834 | |
| 23:11:46 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Replace TaskManager with a keystoneauth concurrency https://review.openstack.org/604926 | |
| #openstack-sdks - 2018-11-02 | |||
| 06:52:47 | openstackgerrit | Vieri proposed openstack/openstackclient master: Update min tox version to 2.0 https://review.openstack.org/615036 | |
| 06:54:05 | openstackgerrit | Vieri proposed openstack/openstacksdk master: Update min tox version to 2.0 https://review.openstack.org/615037 | |
| 06:55:57 | openstackgerrit | Vieri proposed openstack/os-client-config master: Update min tox version to 2.0 https://review.openstack.org/615040 | |
| 07:10:15 | openstackgerrit | Kim Bao Long proposed openstack-infra/shade master: Update the min version of tox to 2.0 https://review.openstack.org/615056 | |
| 07:46:00 | openstackgerrit | Vieri proposed openstack-dev/os-http master: Update min tox version to 2.0 https://review.openstack.org/615079 | |
| 08:31:36 | openstackgerrit | Kim Bao Long proposed openstack-infra/shade master: Update the min version of tox to 2.0 https://review.openstack.org/615056 | |
| 11:57:16 | openstackgerrit | Vieri proposed openstack-infra/requestsexceptions master: Update min tox version to 2.0 https://review.openstack.org/615150 | |
| 12:06:22 | openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/openstacksdk master: Allow returning munch on create and get object https://review.openstack.org/597198 | |
| 12:06:38 | samueldmq | morning sdk! | |
| 13:20:44 | mordred | morning samueldmq ! | |
| 13:26:08 | Shrews | mordred: what are the "verification commands" that we need tox 2.0 for in https://review.openstack.org/615056 ? | |
| 13:26:40 | Shrews | we haven't had any issues with shade tox that i know of | |
| 13:27:49 | Shrews | upgrading local tox (in my experience) usually results in a PITA | |
| 13:28:00 | mordred | Shrews: no clue. but I figure I'm running tox 3.4.0 locally, so requiring 2 vs 1 is probably fine? | |
| 13:28:10 | mordred | Shrews: what version are you running locally? | |
| 13:29:41 | Shrews | mordred: oh wow, didn't realize tox had advanced versions so quickly | |
| 13:30:16 | Shrews | i'm on 3.1.2 on this machine, so i suppose i shouldn't worry about that requirement :) | |
| 13:35:32 | dtantsur | Shrews, mordred, EPEL has 1.4.2.. | |
| 13:36:02 | mordred | dtantsur: do folks develop on centos+epel? | |
| 13:36:47 | dtantsur | mordred: I have devstack on centos, but I install tox from pypi | |
| 13:36:53 | mordred | sorry- that may have come out snarkier than intended - it's an honest question, I'm pretty clueless about how a bunch of that stuff works | |
| 13:37:21 | dtantsur | well, I do see overall issues with developing on centos. but I know people do it (ditto for rhel) | |
| 13:37:29 | mordred | dtantsur: yah - I install tox from pypi as well (although I'm on ubuntu bionic) | |
| 13:37:31 | mordred | wild | |
| 13:37:38 | dtantsur | in any case, since we started putting basepython=python3 in tox.ini, centos users are quite screwed :D | |
| 13:37:43 | mordred | yeah | |
| 13:37:59 | mordred | fingers crossed centos8/rhel8 have a good python3 version | |
| 13:38:17 | dtantsur | check what I have to do: https://github.com/dtantsur/config/blob/master/tasks/tox.yml | |
| 13:38:35 | mordred | dtantsur: :) | |
| 13:38:49 | mordred | dtantsur: fwiw - I gave up on distro python even and started using pyenv for python | |
| 13:39:18 | dtantsur | mordred: let us make devstack give up on distro python, and I'll be a much happier man | |
| 13:39:30 | dtantsur | :) | |
| 13:39:49 | mordred | I keep mildly floating the idea that we should just use pyenv - but I don't actually want to do the work to champion that :) | |
| 13:40:28 | dtantsur | I'd be fine with venv as well.. even if it just one huge venv with all services. | |
| 13:41:01 | dtantsur | another problem with us using the distro python is that it heavily screws 'yum update' by overwriting half of system python packages | |
| 13:43:31 | mordred | yes | |
| 13:43:56 | mordred | dtantsur: have you played with pyenv? it's really cool | |
| 13:44:03 | mordred | mordred@solace:~/src/git.openstack.org/openstack/openstacksdk$ pyenv versions | |
| 13:44:04 | mordred | system | |
| 13:44:06 | mordred | * 2.7.14 (set by /home/mordred/src/github.com/pyenv/pyenv/version) | |
| 13:44:08 | mordred | * 3.5.5 (set by /home/mordred/src/github.com/pyenv/pyenv/version) | |
| 13:44:30 | dtantsur | I have, yes. I don't have a pressing need for it on my laptop since fedora has plenty of python versions out of the box :) | |
| 13:44:40 | mordred | fair :) | |
| 13:45:20 | dtantsur | for centos - yes. I need to come up with some playbooks to configure it (I have a rule of never configuring my test environments by hand, only with these playbooks I linked above) | |
| 13:45:37 | mordred | that is an excellent rule | |
| 14:08:27 | mordred | Shrews: I made a few more patches related to nodepool/task-manager - https://review.openstack.org/#/c/614834/ and its ancestors | |
| 14:08:49 | mordred | the three leading up to it are just extracting some smaller pieces from the "remove task manager" patch | |
| 14:09:01 | mordred | the one I linked to is the one with a whole new thing in it | |
| 14:23:03 | openstackgerrit | Merged openstack-infra/shade master: Update the min version of tox to 2.0 https://review.openstack.org/615056 | |