| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-10-18 | |||
| 19:02:55 | mordred | lbragstad: so you can just do "import openstack ; conn = openstack.connect(cloud='devstack')" | |
| 19:03:02 | lbragstad | huh | |
| 19:03:07 | lbragstad | badass | |
| 19:03:39 | mordred | lbragstad: then that limits api should be at conn.identity - so like "conn.identity.create_registered_limit()" | |
| 19:03:48 | lbragstad | nice | |
| 19:03:51 | mordred | in theory | |
| 19:04:10 | mordred | I just use vexxhost as my devstack - because mnaser is awesome | |
| 19:04:19 | lbragstad | :) | |
| 19:04:43 | lbragstad | very few things are better than dogfood | |
| 19:05:29 | mnaser | mordred: lbragstad <3 | |
| 19:05:54 | lbragstad | maybe brisket | |
| 19:06:15 | mordred | I recommend steaks cut from the chuck flap | |
| 19:06:17 | mordred | mmm | |
| 20:19:37 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add all_projects as a preferred alias for all_tenants https://review.openstack.org/540390 | |
| 20:19:37 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use sdk for list_servers https://review.openstack.org/530770 | |
| 20:19:38 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix get_server to work with use_direct_get https://review.openstack.org/540389 | |
| 21:59:10 | openstackgerrit | Merged openstack/openstacksdk master: Support v4-fixed-ip and v6-fixed-ip in create_server https://review.openstack.org/611652 | |
| 23:20:53 | openstackgerrit | Robin Cernin proposed openstack/python-openstackclient master: Improve document 'openstack complete' https://review.openstack.org/611469 | |
| #openstack-sdks - 2018-10-19 | |||
| 00:44:30 | openstackgerrit | Merged openstack/keystoneauth master: Update sphinx extension logging https://review.openstack.org/611135 | |
| 06:59:42 | openstackgerrit | Vishakha Agarwal proposed openstack/python-openstackclient master: Add project param in LimitList parser https://review.openstack.org/611789 | |
| 09:49:14 | openstackgerrit | Vlad Gusev proposed openstack/python-openstackclient master: Add support for get details of Quota https://review.openstack.org/515401 | |
| 10:37:04 | openstackgerrit | Vishakha Agarwal proposed openstack/python-openstackclient master: Add project param in LimitList parser https://review.openstack.org/611789 | |
| 10:44:57 | dtantsur | mordred: hey, you need to re-add your +W to https://review.openstack.org/#/c/609984/ now that the dependency has merged | |
| 10:47:43 | openstackgerrit | Vlad Gusev proposed openstack/python-openstackclient master: Add support for get details of Quota https://review.openstack.org/515401 | |
| 11:38:15 | openstackgerrit | Vlad Gusev proposed openstack/python-openstackclient master: Add support for get details of Quota https://review.openstack.org/515401 | |
| 12:24:40 | mordred | dtantsur: done | |
| 12:25:15 | dtantsur | thnx | |
| 12:46:32 | mordred | dtantsur, Shrews, dtroyer, slaweq: I pushed up a release request for sdk for an 0.18.0 - I'm thinking it's *basically* an RC, but I was thinking that it would be a good idea to start making some python-openstackclient patches to start using it more there - so we can see what shakes out of that. I also think we should figure out the baremetal resource normalization question and finish those image api | |
| 12:46:34 | mordred | patches | |
| 12:46:58 | dtantsur | yep, cool | |
| 12:47:14 | dtantsur | I think we'll need more deprecation for baremetal stuff in the shade part.. but we can left removals for 2.0 | |
| 12:47:23 | mordred | but I'm figuring we can use writing osc patches to use sdk for images instead of python-glanceclient to spur finishing the image api stuff | |
| 12:47:39 | mordred | dtantsur: ++ | |
| 12:48:46 | mordred | frickler: if you're around, would you mind +Aing https://review.openstack.org/#/c/585030/ ? | |
| 12:49:12 | dtantsur | mordred: oh, and we need to finish the story around rate limiting | |
| 12:49:14 | mordred | oh - actually - hang on, let me bump mins in that | |
| 12:49:23 | mordred | dtantsur: yes. thanks - that's the other thing we should finish | |
| 12:50:20 | mordred | we should chat with cmurphy about whether the keystoneauth retries feature justifies putting the rate limiting down in keystoneauth | |
| 12:51:58 | cmurphy | ah hmm that is a somewhat compelling case | |
| 12:52:18 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Make use of keystoneauth service-type filtering for versions https://review.openstack.org/585030 | |
| 12:53:24 | mordred | cmurphy: yah - I wrote more words on that review - but dtantsur had a patch to sdk to make use of the retriable_status_codes feature - and that made me realize that if ksa is doing retries under the covers, it makes higher-level rate limiting have a hole where it doesn't know about some of the interactions | |
| 12:53:43 | cmurphy | yeah that makes sense | |
| 12:54:22 | frickler | mordred: that patch seems to have a merge conflict now that you updated it | |
| 12:54:26 | mordred | that said - there's still a potential slight weirdness, as retries are implemented in the session, while a rate limit is really an adapter-level concept (so that it can be per-service) | |
| 12:54:28 | mordred | frickler: *awesome* | |
| 12:54:30 | mordred | lemme fix | |
| 12:55:47 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Make use of keystoneauth service-type filtering for versions https://review.openstack.org/585030 | |
| 12:55:51 | mordred | frickler: that should do it :) | |
| 12:57:52 | mordred | cmurphy: so I guess the important next step for that patch would be "write tests"? | |
| 12:58:51 | cmurphy | mordred: I'm kind of hoping there is a non-DIY way of implementing the semaphore thing | |
| 12:59:12 | cmurphy | mordred: but assuming there's not then tests would be a good next step | |
| 12:59:22 | mordred | cmurphy: I didn't find one when I was looking - although I totally agree with you | |
| 12:59:29 | mordred | I'm a bit sad there isn't one of these in the standard lib | |
| 12:59:44 | frickler | mordred: oh, that's osc, I can only +1 there anyway, but lgtm | |
| 13:00:01 | mordred | frickler: awesome, thanks! | |
| 13:00:24 | mordred | cmurphy: maybe we should upstream this one to the python stdlib once we're happy with it. I'm sure that'll only take 8 years or something | |
| 13:00:44 | cmurphy | :D | |
| 13:00:53 | dtantsur | heh | |
| 13:00:58 | dtantsur | Python 4.2 | |
| 13:01:06 | cmurphy | lol | |
| 13:12:52 | samueldmq | morning sdk | |
| 13:15:50 | mordred | morning samueldmq ! | |
| 13:25:17 | openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/openstacksdk master: DNM: Logging image code path https://review.openstack.org/611868 | |
| 13:29:33 | openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/openstacksdk master: DNM: Logging public server code path https://review.openstack.org/611869 | |
| 14:15:41 | openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add support for client-side rate limiting https://review.openstack.org/605043 | |
| 14:18:19 | mordred | dtantsur: ^^ I reworked it a bit based on your review and put the rate limit wait into the semaphore itself | |
| 14:18:33 | mordred | dtantsur: I tried to add some comments - but it's still a pretty dense class | |
| 14:18:41 | dtantsur | cool, will check | |
| 14:19:34 | mordred | kmalloc, cmurphy: ^^ also y'all. of course, it can't land without tests - so I still have to figure that out - but if you feel like attacking it logically, awesome | |
| 14:25:43 | dtantsur | mordred: I have a feeling there is a deadlock lurking there | |
| 14:25:46 | dtantsur | see inline | |
| 14:28:11 | mordred | dtantsur: ah - yeah. it should be fine as long as there are more than one thread executing at the same time - but not for the 1st thread or in a single-threaded mode ... good catch | |
| 14:30:43 | dtantsur | mordred: I'm not sure how multiple thread would help. You're calling wait() while holding a lock. For wait() to return something needs to acquire the same lock and fire the event. | |
| 14:30:55 | dtantsur | It cannot acquire the lock held during wait(). Am I missing something? | |
| 14:31:57 | mordred | dtantsur: no - you're totally right | |
| 14:32:04 | mordred | dtantsur: I need another coffee :) | |
| 14:32:33 | dtantsur | mordred: the resource starvation problem you mention in the commit message.. is it really so bad to justify writing your own semaphore class? :) | |
| 14:33:16 | mordred | dtantsur: yup :) | |
| 14:34:35 | openstackgerrit | Stephen Finucane proposed openstack/cliff master: Remove dead files https://review.openstack.org/611888 | |
| 14:34:35 | openstackgerrit | Stephen Finucane proposed openstack/cliff master: Stop wildcard importing argparse https://review.openstack.org/611889 | |
| 14:34:36 | openstackgerrit | Stephen Finucane proposed openstack/cliff master: WIP: Add support for environment variables https://review.openstack.org/611890 | |
| 14:34:37 | mordred | dtantsur: amazingly enough - all of the varied use cases this solves for are represented by actual real-world issues | |
| 14:35:11 | mordred | dtantsur: you're think that the server side would just be able to handle all of this without the client needing to care ... but oh golly | |
| 14:35:15 | dtantsur | that damn reality; I like dealing with round things in vacuum much more | |
| 14:35:18 | mordred | right? | |
| 14:35:23 | dtantsur | ofc | |
| 14:35:32 | mordred | dtantsur: remind me to tell you the story of the time we crashed the HP Public Cloud | |
| 14:35:45 | mordred | just by running nodepool against its public api | |
| 14:35:58 | dtantsur | OH I'd LOVE to hear that | |
| 14:37:02 | mordred | they had a hardware load balancer / api gateway in front of the api services - which would time out client connections for requests that took too long | |
| 14:37:23 | mordred | so, on receiving a 500 from the load balancer - we'd auto retry again | |
| 14:37:55 | mordred | problem was - the requests were taking so long because there was a missing index on a sql table, so each request was causing a long running query to get started in mysql | |
| 14:39:00 | dtantsur | LOOOL | |
| 14:39:47 | mordred | bcause it was doing a full table scan on the server table for every operation - oh, and also they hadn't been cleaning out old deleted entries from the table | |
| 14:40:19 | dtantsur | hashtag successstory | |
| 14:40:25 | mordred | so we'd to, while True: try: create_server ; break except: delete_server | |
| 14:40:42 | mordred | every create would fail, at which point we'd attempt to clean up after ourselves | |
| 14:40:53 | mordred | in a tight loop with no pausing | |
| 14:41:11 | mordred | and then everything melted to the ground :) | |
| 14:41:35 | dtantsur | well, you gave them a free DoS attack testing :D some people pay for that | |