| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-10-15 | |||
| 16:25:17 | mordred | samueldmq: how I've been thinking about it recently is to try to make the Resource layer be similar to the _normalize_* methods from shade - so that we can have objects that are returned with consistent field names no matter which api you're using | |
| 16:26:00 | samueldmq | mordred: sure for that part yes, I agree 100% | |
| 16:26:01 | mordred | and then have shade have the "10 things more people care about" methods - and the sdk/proxy layer have the more service-oriented specific methods | |
| 16:27:03 | mordred | so - like with that image patch as an example - there are methods in the proxy layer for image.v1.upload_image and image.v2.upload_image and block_storage.v2.create_image_from_volume - but in the shade layer there's still just 'create_image' that just works | |
| 16:28:50 | samueldmq | mordred: that makes total sense | |
| 16:29:38 | samueldmq | what I was saying is that we should watch for how deep we go in representing resources. we might be normalizing to attributes that require not basic usage, let's keep abstraction layer simple | |
| 16:30:22 | samueldmq | mordred: what if the user could define what their resources look like by defining their own aliases. does that make sense at all? | |
| 16:31:39 | samueldmq | my rationale is that simple may vary from user to user, | |
| 16:33:56 | samueldmq | maybe that's not the best api design. can be crazy to maintain | |
| 16:35:41 | mordred | samueldmq: hrm. it's an interesting thought ... but I think maybe what I'm thinking is somewhere in the middle | |
| 16:36:31 | mordred | like, since Resource does magic with __getattribute__ anyway - we should be able to make any attribute of the original json from the service accessible? | |
| 16:36:44 | samueldmq | what if I inherit Munch in MunchWithAliases | |
| 16:37:11 | samueldmq | hmm yes that's the same concept | |
| 16:38:13 | samueldmq | if I do print(network) it gives me {"provider_physical_network": True}, but I can access with | |
| 16:38:42 | samueldmq | network['provider_physical_network'] == network['provider:physical_network'] == network.provider_physical_network | |
| 16:53:59 | samueldmq | mordred: yes you're right, https://github.com/openstack/openstacksdk/blob/master/openstack/object_store/v1/container.py#L42 | |
| 16:54:19 | samueldmq | Resource can do that for us, with a single alias, but should be enoguh for now | |
| 17:54:41 | mordred | samueldmq: \o/ | |
| 18:05:00 | openstackgerrit | Corey Bryant proposed openstack/keystoneauth master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610685 | |
| 18:22:16 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove all the deprecated stuff https://review.openstack.org/605508 | |
| 18:22:17 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Start shifting cloud object-store methods to proxy https://review.openstack.org/608317 | |
| 18:22:17 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Make it clear that OpenStackCloud is a mixin https://review.openstack.org/608318 | |
| 18:22:18 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Revert the Proxy metaclass https://review.openstack.org/609747 | |
| 18:22:18 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rearrange shade image code https://review.openstack.org/609683 | |
| 18:22:19 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: WIP Use proxy layer in shade networks https://review.openstack.org/610624 | |
| 18:38:52 | openstackgerrit | Maxime Guyot proposed openstack/openstacksdk master: Update Auro cloud profile https://review.openstack.org/610699 | |
| 19:04:30 | openstackgerrit | Maxime Guyot proposed openstack/openstacksdk master: Update ElastX cloud profile https://review.openstack.org/610704 | |
| 19:09:54 | openstackgerrit | Maxime Guyot proposed openstack/openstacksdk master: Update ElastX cloud profile https://review.openstack.org/610704 | |
| 22:07:44 | openstackgerrit | Merged openstack/python-openstackclient master: Handle not having cinderclient.v1 available https://review.openstack.org/609473 | |
| 22:15:38 | mordred | Shrews: if you're bored, the stack ending at https://review.openstack.org/#/c/609683 is green now | |
| 22:38:05 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: DNM Testing magnum gate fix https://review.openstack.org/610744 | |
| 22:50:45 | openstackgerrit | Filippo Inzaghi proposed openstack/cliff master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610746 | |
| 22:50:57 | openstackgerrit | Filippo Inzaghi proposed openstack/openstackclient master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610748 | |
| 22:52:26 | openstackgerrit | Filippo Inzaghi proposed openstack/osc-lib master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610749 | |
| 22:52:41 | openstackgerrit | Filippo Inzaghi proposed openstack/python-openstackclient master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610751 | |
| #openstack-sdks - 2018-10-16 | |||
| 03:17:27 | openstackgerrit | Merged openstack/openstacksdk master: Turn down stevedore and urllib logging https://review.openstack.org/604515 | |
| 09:36:38 | openstackgerrit | Tobias Rydberg proposed openstack/openstacksdk master: Adding two new regions and dynamic auth_url based on region name. https://review.openstack.org/610919 | |
| 09:49:41 | openstackgerrit | Tobias Rydberg proposed openstack/openstacksdk master: Adding two new regions and dynamic auth_url based on region name. https://review.openstack.org/610921 | |
| 10:13:31 | openstackgerrit | Merged openstack/openstacksdk master: Update Auro cloud profile https://review.openstack.org/610699 | |
| 10:17:55 | openstackgerrit | Merged openstack/openstacksdk master: Update ElastX cloud profile https://review.openstack.org/610704 | |
| 11:44:23 | dtantsur | mordred: morning! when you have some time, I could use your opinion on https://review.openstack.org/603427 | |
| 11:44:43 | dtantsur | note that it does not take the TaskManager into account yet, I'd wait for its implementation to settle | |
| 12:16:25 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Convert inspect_machine to use the baremetal proxy https://review.openstack.org/610941 | |
| 12:47:53 | mordred | dtantsur: hrm. reading through 603427 - it makes me think more that maybe we really should push the fair-locking based task manager replacement down in to keystoneauth (I was waffling about it earlier)- since the retriable status code logic is down in the Session, if we want that to honor a rate limit setting, we'd need it to know about it | |
| 12:49:26 | dtantsur | mordred: well, keystoneauth could certainly benefit from (optional) rate limiting logic | |
| 12:51:24 | Luzi | I already talked about this on the ML: We want to propose Image encryption for OpenStack, which would also affect osc. And we are gathering thought on which library to use: https://etherpad.openstack.org/p/library-for-image-encryption-and-decryption | |
| 12:51:38 | Luzi | It would be nice, to have some input from your side :) | |
| 12:52:22 | mordred | dtantsur: https://review.openstack.org/#/c/605043/1 :) | |
| 12:53:36 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Move wait_for_baremetal_node_lock to the baremetal proxy https://review.openstack.org/610946 | |
| 12:53:41 | dtantsur | w00t | |
| 12:53:57 | dtantsur | meanwhile, I continue polishing the bare metal stuff in OpenStackCloud ^^^ | |
| 12:54:13 | dtantsur | mordred: do you expect another release before 1.0? I guess I'll end up with a lot of deprecations.. | |
| 12:55:18 | mordred | dtantsur: yeah - I think we need to do at least one just to see what we might have missed/broken | |
| 12:55:31 | mordred | dtantsur: the current master branch is ... large :) | |
| 12:55:40 | dtantsur | right :) | |
| 12:55:46 | mordred | eandersson: \o/ THANK YOU for fixing the magnum jobs | |
| 13:06:17 | Shrews | mordred: approved the stack | |
| 13:07:18 | mordred | Shrews: \o/ | |
| 13:08:44 | mordred | Shrews: if you're still in the mood, dtantsur has a good patch here: https://review.openstack.org/#/c/603427 | |
| 13:10:31 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add stackviz processing to functional tests https://review.openstack.org/610167 | |
| 13:10:42 | mordred | dtantsur: added comment ^ | |
| 13:10:52 | dtantsur | thnx | |
| 13:14:29 | samueldmq | morning | |
| 13:14:46 | samueldmq | is the glance task import a v2 only thing or does it exist in v1? | |
| 13:21:27 | mordred | samueldmq: only v2 | |
| 13:21:47 | mordred | samueldmq: v1 had PUT content upload- and also had import-from-url which 2 doesn't have | |
| 13:21:54 | samueldmq | mordred: thanks, that one is a very special case. I haven't seen that in the clouds I tested though | |
| 13:22:17 | samueldmq | mordred: kk but we don't do import-from-url for v1 | |
| 13:23:03 | samueldmq | we could technically try via put directly and if it fails try the task workflow when using v2 | |
| 13:23:10 | mordred | samueldmq: that's right - I never added it because it wasn't in v2 - so there was no way to add it consistently across both | |
| 13:23:24 | samueldmq | so that one didn't have to set use_task_api in the config... but as I haven't seen that anywhere... /me shrugs | |
| 13:23:38 | mordred | samueldmq: yes - I was thinking the same thing | |
| 13:23:51 | mordred | samueldmq: and have use_task_api as a config option to avoid the call to PUT | |
| 13:24:12 | mordred | samueldmq: rackspace and switch are the only clouds I'm aware of that make you use the task api | |
| 13:24:13 | samueldmq | mordred: yes, that wins if set | |
| 13:24:27 | samueldmq | mordred: switch no more. it's using the put api now | |
| 13:24:31 | mordred | samueldmq: we should test which error code we get on a task cloud when you try the put | |
| 13:24:34 | mordred | samueldmq: oh good! | |
| 13:24:58 | mordred | samueldmq: to make sure we can detect it properly | |
| 13:26:16 | samueldmq | mordred: ++ | |
| 13:38:16 | Shrews | mordred: what is your plan for using the stackviz output? what problem is it solving for us? | |
| 13:39:21 | mordred | Shrews: looking at it to see which tests take how long ... there's also supposed to be overlaid dstat output which seems to be not working atm | |
| 13:40:17 | mordred | Shrews: also - it's sort of an exploration about using that stackviz stuff for non-tempest runs - and it seems like it's going great | |
| 13:40:41 | Shrews | so the goal is to optimize our test suite? | |
| 13:41:32 | mordred | Shrews: yeah - or at least to be able to see if there are any problem children | |
| 13:42:04 | mordred | Shrews: also, from poking at this, in theory we could add dstat and stackviz to the unittests base job and wire it up such that we always produce the report for all stestr-based jobs | |
| 13:42:14 | mordred | but that, of course, is out of scope of this patch :) | |
| 13:43:38 | Shrews | k k | |
| 14:06:01 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Decouple OpenStackCloud from Connection https://review.openstack.org/610981 | |
| 14:06:06 | mordred | Shrews: ^^ there ya go | |
| 14:12:29 | samueldmq | what's the typical error code when quota is not enough? | |
| 14:13:26 | mordred | Shrews, dtantsur, samueldmq: was thinking, as you can likely see, that clarkb was right and that making shade.OpenStackCloud subclass from openstack.Connection may have been a mistake. Instead, just freezing shade at its current point in time so that shade users can happily not get messed with | |
| 14:13:35 | mordred | samueldmq: oh golly - no clue :) | |
| 14:14:13 | samueldmq | mordred: :( | |
| 14:14:20 | dtantsur | mordred: I think the baremetal shade parts need a lot of love, so dunno about freezing them.. | |
| 14:14:32 | samueldmq | nova servers says the precondition is to have enough quota, but doesn't specify the error code | |
| 14:14:42 | mordred | samueldmq: http://git.openstack.org/cgit/openstack-infra/nodepool/tree/nodepool/driver/openstack/handler.py#n256 | |
| 14:15:07 | samueldmq | mordred: :-) | |
| 14:15:24 | mordred | samueldmq: we should maybe figure out how to throw a better execption in sdk :) | |
| 14:15:36 | samueldmq | *maybe* | |