| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-10-10 | |||
| 12:34:39 | dtantsur | apparently make baremetal update right from the first attempt is too hard :( | |
| 12:58:52 | mordred | dtantsur: lgtm. Shrews ? | |
| 12:59:09 | Shrews | eh? | |
| 13:00:18 | Shrews | { self._alternate_id() or 'id': self.id } works? | |
| 13:00:40 | Shrews | i did not know you could do that with dict keys | |
| 13:01:14 | dtantsur | I should have used brackets I guess :) | |
| 13:01:29 | dtantsur | it's kind of: key = self._alternative_id() or 'id' | |
| 13:01:33 | dtantsur | { key: self.id } | |
| 13:02:45 | Shrews | yep, just threw me off. +3 | |
| 13:03:36 | mordred | Shrews: I learn python from dtantsur all the time | |
| 13:03:46 | dtantsur | :D | |
| 13:08:26 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: cloud: rename with deprecation validate_node -> validate_machine https://review.openstack.org/609399 | |
| 13:15:34 | mordred | dtantsur: that's going to conflict with my delete-all-the-deprecated-things patch :) | |
| 13:15:59 | dtantsur | mordred: it may :) should I switch off utils.deprecated? | |
| 13:17:08 | mordred | yeah - I think maybe, especially since it's in the shade layer where we never remove old things, let's just rename the method and then do a 'validate_node = validate_machine' after it | |
| 13:20:17 | dtantsur | mordred: can I still use the deprecation library itself? | |
| 13:20:22 | dtantsur | or I can provide a custom warning | |
| 13:23:48 | mordred | dtantsur: I think custom warning - like log.debug in this case - would be best | |
| 13:24:25 | dtantsur | hmm, log.debug? I think in a similar situation you used the warnings module (because it's programmer's, not operator's choice) | |
| 13:25:16 | mordred | dtantsur: oh - well ... that's because in that scenario doing the weird thing is actually a legit valid thing ... we might not support a service and the user might be using sdk to get a handle to the rest service | |
| 13:25:30 | mordred | in this case, the user can totally change the call | |
| 13:25:34 | mordred | although - you make a great point ... | |
| 13:25:46 | mordred | if the user was using ansible, they wouldn't have the ability | |
| 13:25:56 | mordred | becuase the ansible module might be using the old call | |
| 13:26:04 | dtantsur | and btw it probably is | |
| 13:26:09 | mordred | yah | |
| 13:26:48 | mordred | so yeah - maybe warnings.warn is better for this one. stupid backwards compat | |
| 13:43:03 | mordred | Shrews: if you have a sec - https://review.openstack.org/#/c/604521/ - you had some -1 on that earlier | |
| 13:44:44 | Shrews | mordred: doesn't appear you did anything with my comment :-P | |
| 13:45:22 | jroll | fungi: thanks for saying what I was trying to say, much better than I did (graphql thread) | |
| 13:46:32 | fungi | jroll: just trying to help get some clarity. i think you made some other good points | |
| 13:46:42 | jroll | :) | |
| 13:47:03 | mordred | Shrews: oh - I didn't? crap | |
| 13:57:48 | Shrews | mordred: nope. comment was on ps6 | |
| 13:59:50 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove all the deprecated stuff https://review.openstack.org/605508 | |
| 13:59:51 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Start shifting cloud object-store methods to proxy https://review.openstack.org/608317 | |
| 13:59:51 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Make it clear that OpenStackCloud is a mixin https://review.openstack.org/608318 | |
| 14:00:45 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: cloud: rename with deprecation validate_node -> validate_machine https://review.openstack.org/609399 | |
| 14:00:49 | dtantsur | mordred: ^^ | |
| 14:02:36 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add support for per-service rate limits https://review.openstack.org/604521 | |
| 14:02:45 | mordred | Shrews: sorry about that - thanks | |
| 14:03:17 | mordred | dtantsur: ++ | |
| 14:08:38 | Luzi | mordred, did you read the mail concerning Image encryption? http://lists.openstack.org/pipermail/openstack-dev/2018-September/135167.html | |
| 14:12:40 | mordred | Luzi: I did not - sounds like a thing I should read :) | |
| 14:13:05 | Luzi | yeah, basically we would like to use the encryption and decryption methods in nova, cinder and osc. And we still wondering where to put these. | |
| 14:16:43 | mordred | Luzi: awesome. I've got it open in my browser - am at openstack days nordic right now so it may take me a few minutes to fully digest | |
| 14:17:30 | Luzi | mordred: okay, we would appreciate input on the mailinglist too, so take your time :) | |
| 14:20:39 | openstackgerrit | Daniel Speichert proposed openstack/openstacksdk master: Added basic CRUD functionality around Host Aggregates https://review.openstack.org/609416 | |
| 14:28:01 | openstackgerrit | Daniel Speichert proposed openstack/openstacksdk master: Added basic CRUD functionality around Host Aggregates https://review.openstack.org/609416 | |
| 14:30:24 | ml | the delete methods implemented in the new data model call the delete() method of the resource, however ignore the return value | |
| 14:31:23 | ml | is this intended? the return value of Resource.delete() is quiet valuable since it informs whether the resource was deleted or never existed in the first place | |
| 14:31:29 | ml | example: https://github.com/openstack/openstacksdk/blob/master/openstack/network/v2/_proxy.py#L88 | |
| 14:33:10 | ml | this would save an additional request in the openstackcloud wrapper | |
| 14:35:04 | ml | nvm, the ignore_missing is obviously the way to go | |
| 14:45:31 | openstackgerrit | Johannes Kulik proposed openstack/osc-lib master: Add option to replace `shell.prompt_for_password` https://review.openstack.org/609433 | |
| 16:14:46 | openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Handle not having cinderclient.v1 available https://review.openstack.org/609473 | |
| 16:17:31 | dtantsur | heads up: bifrost is broken, presumably by the oslo.messaging release | |
| 16:17:58 | dtantsur | olivierb is working on a fix apparently | |
| 16:18:09 | dtantsur | mordred: sorry, we ate your CI ^^^ | |
| 16:20:39 | olivierb | dtantsur mordred yes should be coming shortly, sorry was afk for a bit | |
| 17:08:39 | olivierb | available as https://review.openstack.org/609499 | |
| 19:33:18 | openstackgerrit | Daniel Speichert proposed openstack/openstacksdk master: Added basic CRUD functionality around Host Aggregates https://review.openstack.org/609416 | |
| 19:55:58 | openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Handle not having cinderclient.v1 available https://review.openstack.org/609473 | |
| #openstack-sdks - 2018-10-11 | |||
| 02:00:31 | openstackgerrit | wangxiyuan proposed openstack/openstacksdk master: [WIP]Add registered limit CRUD support https://review.openstack.org/609572 | |
| 07:14:19 | openstackgerrit | wangxiyuan proposed openstack/openstacksdk master: Add registered limit CRUD support https://review.openstack.org/609572 | |
| 07:32:33 | openstackgerrit | wangxiyuan proposed openstack/openstacksdk master: Add registered limit CRUD support https://review.openstack.org/609572 | |
| 07:32:34 | openstackgerrit | wangxiyuan proposed openstack/openstacksdk master: Add limit CRUD support https://review.openstack.org/609604 | |
| 09:05:13 | dtantsur | API-SIG office hour here and now :) | |
| 09:22:46 | openstackgerrit | wangxiyuan proposed openstack/openstacksdk master: Add registered limit CRUD support https://review.openstack.org/609572 | |
| 09:22:47 | openstackgerrit | wangxiyuan proposed openstack/openstacksdk master: Add limit CRUD support https://review.openstack.org/609604 | |
| 12:15:17 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rearrange shade image code https://review.openstack.org/609683 | |
| 12:15:18 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: WIP Move image methods to sdk image proxy https://review.openstack.org/609684 | |
| 12:16:08 | mordred | samueldmq, dtantsur|brb: ^^ that last patch is definitely non-functional - but I wanted to push it up to see what you thought about the general idea | |
| 12:54:54 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rearrange shade image code https://review.openstack.org/609683 | |
| 12:55:43 | samueldmq | mordred: I like it | |
| 12:56:55 | samueldmq | mordred: the code in opesntackcloud will be much cleaner, and if you want to look at the specific craziness for each operation/version go to look at the proxies | |
| 12:57:41 | samueldmq | mordred: I was afraid we'd be creating a lot of files just for a little amount of code. multiple _proxy files... but the proxy files already exist today anyways | |
| 12:59:00 | mordred | samueldmq: sweet - and yeah, they're already there ... hopefully this can make people less afraid of the size of that openstackcloud file :) | |
| 13:00:00 | samueldmq | mordred: exactly, only the function contracts will be kept there | |
| 13:01:26 | samueldmq | 12.5k loc in a single file is not human-friendly | |
| 13:02:15 | mordred | samueldmq: it does make it easy to search for something from inside vim :) | |
| 13:02:20 | samueldmq | that overflows my brain several times when I scroll it down | |
| 13:02:27 | samueldmq | mordred: ++ | |
| 13:10:05 | mordred | Shrews: I know you love waking up to huge patches from me | |
| 13:10:28 | mordred | Shrews: but also ... ^^ 609684- totally unfunctional - but you might have an opinion on the general idea | |
| 13:13:29 | Shrews | oh, i've got opinions for ya.... | |
| 13:16:12 | dtantsur | mordred: ack, I'll try to get to it soon-ish | |
| 13:17:04 | dtantsur | mordred and all: the bifrost job was fixed, feel free to recheck things | |
| 13:18:42 | mordred | woot! | |
| 13:41:20 | ml | openstackcloud raises Exception from openstack.cloud.exc, it doesn't use anything from openstack.exception. | |
| 13:41:38 | ml | Why is that? | |
| 13:44:12 | mordred | ml: it's just historical - we haven't finished merging all the things yet | |
| 13:45:17 | mordred | ml: geting the openstackcloud code to raise exceptions from openstack.exception instead would be great | |
| 13:46:10 | ml | Can I start using them in my change already? or is it desired to be handled as one change? | |
| 13:48:23 | ml | probably a bad idea to keep both imports at the same time, because one can't import it as "exc" | |
| 13:50:31 | mordred | ml: we could just import it as exceptions ... I think either way you want to go is fine | |
| 13:50:44 | ml | ok, cool | |
| 14:06:59 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rearrange shade image code https://review.openstack.org/609683 | |
| 14:07:00 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: WIP Move image methods to sdk image proxy https://review.openstack.org/609684 | |
| 14:25:28 | dtantsur | mordred: is it okay that we ignore the error_message argument in https://github.com/openstack/openstacksdk/blob/master/openstack/_adapter.py#L129 ? | |