| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-08-07 | |||
| 17:20:28 | Shrews | mordred: +Ad | |
| 17:47:29 | PagliaccisCloud | anyone got a +2 to spare? https://review.openstack.org/#/c/584484/ | |
| 18:30:37 | mordred | PagliaccisCloud: I got AJaeger to leave a comment - but it's an update to a translated string which should go through the translations process. the base string seems to have already been fixed in the codebase. however, translation string updates are only proposed when there has been a change in the translations | |
| 18:44:40 | frickler | mordred: dtroyer: most of the rechecks I did seem to have passed, the others look like genuine issues to me. would be great if you could put https://review.openstack.org/516701 onto your review list | |
| 19:46:40 | openstackgerrit | Merged openstack/openstacksdk master: Fix to_dict recursion issues with circular aliases https://review.openstack.org/589250 | |
| 19:46:41 | openstackgerrit | Merged openstack/python-openstackclient master: Fix missing trailing spaces in network help messages https://review.openstack.org/588616 | |
| 20:13:56 | openstackgerrit | Monty Taylor proposed openstack/openstackclient master: Update openstackclient-check-plugins to honor constraints https://review.openstack.org/589465 | |
| 20:15:27 | mordred | dtroyer, frickler: ^^ that should fix theissues tosky was seeing with openstackclient-check-plugins on stable/queens (and the one in the stack before it, about stestr, is needed in that repo anyway) | |
| 20:16:16 | mordred | dhellmann: ^^ you might find that patch interesting as well - it is a patch thatuses the siblings logic outside of a tox context | |
| 20:55:44 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: DNM Testing pep8 line comments patch https://review.openstack.org/589635 | |
| 21:17:40 | mordred | Shrews: easy review if you have a sec: https://review.openstack.org/#/c/589212/ | |
| 22:10:42 | openstackgerrit | Merged openstack/python-openstackclient master: Add dns-domain support to Network object https://review.openstack.org/516701 | |
| 23:05:53 | openstackgerrit | Merged openstack/openstacksdk master: Stop calling get_all_types when service-type is None https://review.openstack.org/589212 | |
| 23:54:48 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Stop using the -consumer devstack jobs https://review.openstack.org/589675 | |
| 23:56:49 | mordred | Shrews: ^^ I think openstacksdk is sufficiently integrated with devstack that we shoudl do that | |
| #openstack-sdks - 2018-08-08 | |||
| 01:26:35 | adriant | mordred: will look! | |
| 01:27:21 | adriant | mordred: sorry I haven't had much time to look at anything SDK related. Been deep within billing related stuff for the last while. | |
| 09:14:50 | openstackgerrit | yanpuqing proposed openstack/python-openstackclient master: Add error message when network resources use "set" "unset" command https://review.openstack.org/579515 | |
| 11:09:20 | openstackgerrit | Yushiro FURUKAWA proposed openstack/osc-lib master: Revert "Fixes a bug with issubclass() being called on an instance" https://review.openstack.org/586617 | |
| 12:58:05 | Shrews | mordred: any idea what these failures are about? http://logs.openstack.org/75/589675/1/check/osc-functional-devstack-tips/cc9ccf7/testr_results.html.gz | |
| 13:00:11 | mordred | Shrews: I do not - osc's gate tests were broken until yesterday | |
| 13:21:31 | mordred | Shrews: got a sec for this one? https://review.openstack.org/#/c/589675/ should reduce some node churn | |
| 13:22:23 | Shrews | mordred: well, the tests I asked about are for that one | |
| 13:24:32 | mordred | ah - yeah | |
| 14:33:06 | amotoki | dtroyer: could you look at https://review.openstack.org/#/c/586617/ ? it is a revert in osc-lib which breaks neutronclient OSC plugin | |
| 14:38:37 | dmsimard | mordred: if it's any consolation, after doing even a bit of AWS I find the OpenStack APIs and Ansible modules for OpenStack MUCH better (and especially more consistent) | |
| 14:39:30 | dmsimard | The AWS APIs and modules are very inconsistent and unpredictable, it's almost like if they had been developed by entirely different companies | |
| 14:39:34 | dmsimard | so... good job ? :D | |
| 14:39:48 | dtroyer | amotoki: +2+W | |
| 14:40:10 | mordred | dmsimard: yay! thanks - that's great to hear | |
| 14:40:34 | amotoki | dtroyer: thanks. | |
| 14:43:13 | openstackgerrit | Merged openstack/osc-lib master: Remove PyPI downloads https://review.openstack.org/589369 | |
| 14:46:42 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rename Resource get and update to not clash with dict https://review.openstack.org/589193 | |
| 14:46:42 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add computed attribute type and location to base resource https://review.openstack.org/589194 | |
| 14:46:43 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove special handling of stacks https://review.openstack.org/589195 | |
| 14:46:43 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Make resource a dict subclass usable by shade layer https://review.openstack.org/530835 | |
| 17:43:42 | openstackgerrit | Merged openstack/osc-lib master: Revert "Fixes a bug with issubclass() being called on an instance" https://review.openstack.org/586617 | |
| 18:31:25 | frickler | Shrews: mordred: I'd guess those two failures are just racy tests that have unstable results, the job did pass before the recheck | |
| 18:32:39 | mordred | frickler: you mean https://review.openstack.org/#/c/589675/ ? - oh,you're right | |
| 18:32:54 | frickler | mordred: yes | |
| 18:33:00 | mordred | ++ | |
| 18:33:16 | mordred | I am pretty sure they are unrelated, since that patch doesn't touch that job at all | |
| 18:33:38 | frickler | ack | |
| 18:34:20 | frickler | dtroyer: with the dependency merged, I hope https://review.openstack.org/558824 at last is now ready for some final reviews | |
| 18:34:27 | Shrews | are we comfortable approving it then? | |
| 18:35:29 | mordred | Shrews: yeah - I think it should be fine | |
| 20:03:59 | openstackgerrit | Merged openstack/openstacksdk master: Stop using the -consumer devstack jobs https://review.openstack.org/589675 | |
| 20:15:08 | openstackgerrit | Merged openstack/python-openstackclient master: Add DNS support to floating IP commands https://review.openstack.org/558824 | |
| #openstack-sdks - 2018-08-09 | |||
| 00:09:42 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Make resource a dict subclass usable by shade layer https://review.openstack.org/530835 | |
| 00:09:53 | mordred | Shrews: I found new terrible things I can't wait to tell you about | |
| 00:10:21 | mordred | adriant: no worries re: time - you've been busy! I mostly want to make sure that once this stack goes green, we make sure it doesn't break you before we land it | |
| 00:11:12 | adriant | mordred: it mostly looks like stuff that shouldn't affect me, but I won't get a chance to play with it until next week at the earliest | |
| 00:11:25 | mordred | adriant: kk. no rush | |
| 00:11:30 | adriant | it's just the changing of the Resource internals to make it dict based right? | |
| 00:11:56 | mordred | adriant: yah- and renaming two of the methods - but most things shoudl be touching those Resource bits via proxy methods | |
| 00:12:18 | adriant | Yeah, none of my code goes that deep into the Resource class | |
| 00:12:27 | mordred | woot. then you should be fine | |
| 00:12:44 | adriant | Most of the stuff that I always ran into was the session stuff you fixed :) | |
| 00:14:13 | adriant | mordred: oh and https://review.openstack.org/#/c/544544/ totally forgot about that patch, but the person who proposed it never responded | |
| 00:45:56 | samueldmq | mordred: Shrews: I liked having openstack cloud and operator cloud as separate things. having that boundary made sense from user's perspective | |
| 00:48:43 | samueldmq | for instance, say I want to validate the abstraction layer against all public clouds. that means I would only consider calls for users, excluding operator's calls (which were in a separate thing) | |
| 03:02:29 | openstackgerrit | Rui Chen proposed openstack/openstacksdk master: Add more options to enable ansible testing feature https://review.openstack.org/590078 | |
| 08:56:10 | openstackgerrit | Yang JianFeng proposed openstack/openstacksdk master: Add support for octavia's resuorces quota https://review.openstack.org/590193 | |
| 09:17:35 | openstackgerrit | Lajos Katona proposed openstack/python-openstackclient master: Detailed help message for QoS max-burst-kbps value https://review.openstack.org/588168 | |
| 10:02:59 | openstackgerrit | Lajos Katona proposed openstack/python-openstackclient master: Detailed help message for QoS max-burst-kbps value https://review.openstack.org/588168 | |
| 10:28:41 | gtema | does anyone experience broken osc interactive mode? I do always get "unrecognized arguments" for each command. Unfortunately same happend even with 3.14.2, so likely problem is elsewhere | |
| 10:36:01 | openstackgerrit | Yang JianFeng proposed openstack/openstacksdk master: Add support for octavia's resuorces quota https://review.openstack.org/590193 | |
| 10:40:49 | openstackgerrit | Yang JianFeng proposed openstack/openstacksdk master: Add support for octavia's resuorces quota https://review.openstack.org/590193 | |
| 12:13:17 | openstackgerrit | Lajos Katona proposed openstack/python-openstackclient master: Detailed help message for QoS max-burst-kbps value https://review.openstack.org/588168 | |
| 12:25:56 | dtroyer | gtema: check your version of cmd2 (0.8.8) and cliff (2.13.0). Those are the versions I have in my development venv | |
| 12:27:17 | gtema | dtroyer: If I do a fresh 'pip install python-openstackclient' I get cmd2-0.9.3 and cliff-2.13.0 | |
| 12:29:43 | gtema | dtroyer, if I manually downgrade cmd2 to 0.8.8 it works, so probably freeze the version if the fix is not fast? | |
| 12:36:32 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rename Resource get and update to not clash with dict https://review.openstack.org/589193 | |
| 12:36:32 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add computed attribute type and location to base resource https://review.openstack.org/589194 | |
| 12:36:33 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Remove special handling of stacks https://review.openstack.org/589195 | |
| 12:36:33 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Make resource a dict subclass usable by shade layer https://review.openstack.org/530835 | |
| 12:42:22 | Shrews | mordred: i'm giddy with anticipation | |
| 12:43:20 | dtroyer | gtema: cmd2 has been a barrel of fun lately… we do have it capped at <0.9.0 for python 2, python3 is fine above that | |
| 12:43:50 | gtema | dtroyer: I'm having this issue with python 3.6 | |
| 12:44:22 | mordred | Shrews: in https://review.openstack.org/530835 - please to enjoy the bits in image.py and test_image.py | |
| 12:45:12 | mordred | Shrews: where the test was testing setting a property on the remote image called "properties" with the value '{"description": "This is not an image"}' | |
| 12:51:54 | Shrews | mordred: i don't yet know what the fundamental issue is, but i find it humorous that someone thought making the dict a string was the proper way to send the value | |
| 12:53:46 | mordred | Shrews: I thought you'd enjoy that | |
| 12:54:18 | Shrews | or maybe it's sad that that is what the api actually expects?? | |
| 12:54:37 | Shrews | i put nothing past openstack apis anymore | |
| 12:54:52 | mordred | nope. the api expects extra key-value pairs to be sent in the main image dict (this is one of the differences with v1 of the glance api which has a properties field) | |
| 12:55:13 | mordred | Shrews: so the sdk in this case is actually not doing that - and is not actually supporting dealing with the extra key-value pairs | |
| 12:56:15 | Shrews | so glance broke their own api by removing properties? | |
| 12:57:12 | Shrews | i mean, i guess you can do that moving from v1 to v2... but that seems silly | |
| 12:57:24 | Shrews | meh | |
| 12:57:57 | gtema | dtroyer: even cmd2==0.9.0.1 has a problem already | |
| 12:58:35 | mordred | Shrews: no - glance didn't break their own api - the sdk code implementing it never implemented it - and the test which theoretically showed it worked wasn't actually testing it | |
| 12:58:39 | mordred | Shrews: but yeah | |
| 12:59:33 | Shrews | ah | |
| 13:02:22 | mordred | Shrews: I think the whole stack should be green now - I had to add a property back to the https://review.openstack.org/589193 to make osc happy | |
| 13:51:18 | dtroyer | gtema: hmmm, ok, maybe py3 should be capped too… | |
| 14:25:18 | mordred | Shrews: if you get a sec, https://review.openstack.org/#/c/586727 could use eyes - it's needed for https://review.openstack.org/#/c/586728/ to work | |
| 14:40:10 | mordred | (we'll also need to cut a release with that in it) | |
| 14:40:51 | Shrews | +Ad | |
| 14:42:26 | mordred | yay | |