| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-07-30 | |||
| 19:26:13 | dtroyer | mordred: so the brokkeness in volume is due to the compat bits being removed from the python API, not something we currently test for. | |
| 19:26:28 | dtroyer | what pisses me off is they removed it the day before cutting the stable release | |
| 19:26:32 | dtroyer | no warning | |
| 19:34:43 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Fix broken functional tests https://review.openstack.org/587203 | |
| 19:35:00 | dtroyer | mordred: lets see if ^^^ does it | |
| 19:35:28 | mordred | dtroyer: sigh (re volume) | |
| 19:36:09 | mordred | dtroyer: maybe in stein we can make progress in removing that vector of failure | |
| 19:36:37 | dtroyer | cinder just jumped uo to my #2 for getting off the python lib, after glance | |
| 19:36:55 | mordred | dtroyer: nod. I will order my efforts accordingly | |
| 19:43:16 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Adds toggle port security on network create https://review.openstack.org/587166 | |
| 19:43:16 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: python-shade expose MTU setting. https://review.openstack.org/587167 | |
| 19:43:36 | mordred | slaweq: ^^ sorry - had to fix exception names for pep8/py35 | |
| 19:49:51 | slaweq | mordred: thx, sorry that I missed them :) | |
| 21:21:27 | openstackgerrit | Merged openstack/openstacksdk master: Support passing profile to get_one https://review.openstack.org/585780 | |
| 21:35:37 | mordred | dtantsur|afk: zomg. the ironic test passed! | |
| 23:02:13 | openstackgerrit | Merged openstack/openstacksdk master: Add support for static routes https://review.openstack.org/587163 | |
| 23:27:58 | openstackgerrit | Merged openstack/openstacksdk master: Add method for returning a raw response for an object https://review.openstack.org/586262 | |
| 23:33:27 | openstackgerrit | Merged openstack/openstacksdk master: Add support for streaming object responses https://review.openstack.org/586250 | |
| 23:33:28 | openstackgerrit | Merged openstack/openstacksdk master: Remove the auto-creation of containers in create_object https://review.openstack.org/586616 | |
| #openstack-sdks - 2018-07-31 | |||
| 01:15:57 | openstackgerrit | Fan Zhang proposed openstack/python-openstackclient master: Remove volume replication v1 support. https://review.openstack.org/587008 | |
| 01:38:20 | dtroyer | this ^^^ and https://review.openstack.org/#/c/587005/ will likely need to be merged to pass tests | |
| 02:05:13 | openstackgerrit | yanpuqing proposed openstack/openstacksdk master: Add an error message when router add subnet https://review.openstack.org/586996 | |
| 02:24:39 | openstackgerrit | Fan Zhang proposed openstack/python-openstackclient master: Fix broken gate jobs. https://review.openstack.org/587005 | |
| 02:56:02 | openstackgerrit | Merged openstack/openstacksdk master: Add some backoff to find_best_address https://review.openstack.org/575580 | |
| 06:03:31 | openstackgerrit | Fan Zhang proposed openstack/python-openstackclient master: Fix broken gate jobs. https://review.openstack.org/587005 | |
| 06:08:33 | openstackgerrit | Fan Zhang proposed openstack/python-openstackclient master: Fix broken gate jobs. https://review.openstack.org/587005 | |
| 07:48:17 | openstackgerrit | Fan Zhang proposed openstack/python-openstackclient master: [WIP] Fix broken gate jobs. https://review.openstack.org/587005 | |
| 11:02:30 | openstackgerrit | Merged openstack/openstacksdk master: Adds toggle port security on network create https://review.openstack.org/587166 | |
| 11:06:10 | openstackgerrit | Merged openstack/openstacksdk master: python-shade expose MTU setting. https://review.openstack.org/587167 | |
| 13:12:01 | mordred | dtroyer: so we should squash 587008 and 587005 ? | |
| 13:15:24 | mordred | fanzhang: looks like you're on top of it - let me know if you'd like me to help in any way | |
| 13:32:19 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: [WIP] Fix broken gate jobs. https://review.openstack.org/587005 | |
| 13:32:31 | mordred | fanzhang: ^^ pushed up an update | |
| 13:37:45 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Pass microversion info through from Profile https://review.openstack.org/587435 | |
| 14:11:39 | mordred | cdent: youknow all the things, right? | |
| 14:11:53 | cdent | mordred: I know everything except what you want to know. | |
| 14:11:59 | mordred | sweet. perfect | |
| 14:12:25 | mordred | cdent: do you happen to know what response bodies from nova errors look like? they don't seem to be documented in the api docs | |
| 14:12:48 | mordred | cdent: I have just learned that neutron sends a json dict {'NeutronError': 'some string'} | |
| 14:12:51 | mordred | because of course | |
| 14:13:11 | cdent | the nova api is murky to me, but I should be able to find something clearly relatively quickly | |
| 14:14:02 | mordred | cool - thanks! I *think* it might be a list of dicts with a message key - since we've got sdk code to handle that case | |
| 14:16:40 | cdent | mordred: looks like a dict keys on the fault name: https://github.com/openstack/nova/blob/03ccb1f9333bcfbdb2caf8a8c6e98622a63088cc/nova/api/openstack/wsgi.py#L1080-L1083 | |
| 14:17:25 | mordred | cdent: ah - cool. that would explain the code in sdk currently | |
| 14:17:30 | mordred | I will add a comment | |
| 14:22:53 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add support for neutron error messages https://review.openstack.org/587483 | |
| 14:34:44 | mordred | cdent: ^^ just in case you are curious. | |
| 14:42:14 | cdent | I'm sure we made this http://specs.openstack.org/openstack/api-wg/guidelines/errors.html for some reason but I can't remember why | |
| 15:01:37 | openstackgerrit | Merged openstack/openstacksdk master: Support for microversions in baremetal resources https://review.openstack.org/583532 | |
| 15:01:39 | openstackgerrit | Merged openstack/openstacksdk master: Add a simple baremetal functional job https://review.openstack.org/586574 | |
| 20:13:11 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: [WIP] Fix broken gate jobs. https://review.openstack.org/587005 | |
| 20:19:13 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: [WIP] Fix broken gate jobs. https://review.openstack.org/587005 | |
| 20:23:32 | dtroyer | mordred: ^^^ should get us really close… it needs a way to detect Image API v1 yet | |
| 20:24:05 | mordred | dtroyer: like - needs to be able to detect whether the cloud has v1? | |
| 20:24:41 | dtroyer | yes | |
| 20:24:55 | mordred | https://review.openstack.org/#/c/585029/ <-- | |
| 20:25:13 | mordred | dtroyer: that is what you need - unfortunately I did not manage to get it in to keystoneauth before the feature freeze | |
| 20:25:29 | dtroyer | I've hard-coded it 'not there' in that rev just to get this through… ah, nice | |
| 20:25:52 | mordred | dtroyer: yah - if you're ok with the test suite being a little wonk until we can get another ksa release cut - there's a path to it | |
| 20:26:09 | dtroyer | I'll think about this harder after the 30,000 foot fatigue is less | |
| 20:26:28 | dtroyer | I'm fine, this is better than ripping it all out | |
| 20:26:33 | mordred | dtroyer: alternately, the code in the versions show command that does it client-side would also work - it'll just be more expensive than would normally be pleasant | |
| 20:26:44 | mordred | cool | |
| 20:27:07 | dtroyer | hmmm… yeah, I was thinking something like that, it's a one-time deal so we can live with it | |
| 20:27:49 | mordred | ++ | |
| 20:28:07 | mordred | and it should all be really cheap local calls in functional tests - not quite like doing the same thing on an actual public cloud :) | |
| 20:58:37 | samueldmq | hi. I am not getting why we need ansible tests for the upper abstraction level/shade | |
| 20:58:49 | samueldmq | as opposed to having just the unit and functional tests... | |
| 20:59:24 | samueldmq | seems like those ansible tests should belong somewhere in the shade plugin to ansible (or something like that)? | |
| 21:01:17 | mordred | samueldmq: yes - they should indeed be there | |
| 21:01:38 | mordred | samueldmq: they were in the shade repo for hysterical raisins | |
| 21:01:59 | mordred | samueldmq: mostly that we didn't have a way to run them if we put them into the ansible repo | |
| 21:02:18 | mordred | samueldmq: but now that we can (and do) trigger jobs in Infra on PRs to ansible ... | |
| 21:02:34 | mordred | samueldmq: we should TOTALLY move them to ansible/ansible and get them integrated with ansible-test | |
| 21:02:53 | samueldmq | kk should be up to them to run the tests? | |
| 21:03:04 | samueldmq | or to us on our infra (seems to be what you're suggesting) | |
| 21:03:25 | samueldmq | mordred: ^ | |
| 21:05:23 | samueldmq | ahh I got it ... we can add a check on sdks to run ansible tests against proposed shade changes | |
| 21:05:32 | samueldmq | just to make sure we're not breaking'em on our side | |
| 21:06:01 | mordred | that's right | |
| 21:06:35 | mordred | we actually already run the shade-ansible test job on ansible/ansible PRs that touch openstack bits | |
| 21:06:42 | mordred | as well as on both shade and openstacksdk | |
| 21:07:25 | samueldmq | ok it's just a matter of putting things in their right place | |
| 21:07:53 | samueldmq | for running against arbitrary cloud ... do you think I should work on shade/functional tests side only? | |
| 21:08:20 | samueldmq | shade should be able to run its tests against arbitrary clouds, regardless being useful to ansible | |
| 21:08:28 | mordred | yes - I agree | |
| 21:08:38 | mordred | (although do it in openstacksdk and not shade- but yes) | |
| 21:08:56 | mordred | we also have WAY more coverage in the openstacksdk functional tests than we do in the ansible tests | |
| 21:09:00 | mordred | so we get a much nicer win | |
| 21:09:12 | samueldmq | ++ | |
| 21:09:39 | samueldmq | yes I meant openstacksdk ... just not got used to the change yet (since I had disapeared by the time of the merge) :-) | |
| 21:10:02 | samueldmq | didnt get* | |
| 21:10:23 | samueldmq | kk I'll take a look there .. but I'm a bit worried about the policy bits... | |
| 21:10:39 | samueldmq | since different users will have different permissions on different clouds | |
| 21:11:35 | samueldmq | that's a bit different than running just on devstack (opinionated). may require some work but should not be terrible' | |
| 21:16:55 | openstackgerrit | Doug Hellmann proposed openstack/openstacksdk master: fix 2 typos in documentation https://review.openstack.org/587624 | |
| 21:28:19 | mordred | samueldmq: yes - I totally agree (and same here - I still say shade a lot) | |
| #openstack-sdks - 2018-08-01 | |||
| 01:07:32 | openstackgerrit | Fan Zhang proposed openstack/python-openstackclient master: [WIP] Fix broken gate jobs. https://review.openstack.org/587005 | |
| 01:12:13 | fanzhang | mordred dtroyer ^ there is still 3 failed tests, and I may not have time to work on it today. BTW, added co-authored-by to commit messages. Thanks for helping on it :-) | |
| 01:14:30 | dtroyer | fanzhang: sorry about my bad typing (Falsex! ha!)… the remaining failures do appear to be the cinderclient issue being addressed in https://review.openstack.org/#/c/587601/ | |