Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-07-27
13:00:26 openstackgerrit Fan Zhang proposed openstack/python-openstackclient master: Add --key-name and --key-unset option for server rebuild API. https://review.openstack.org/576422
13:47:20 openstackgerrit Dmitry Tantsur proposed openstack/openstacksdk master: Support for microversions in baremetal resources https://review.openstack.org/583532
13:48:20 dtantsur mordred: how hard is it to add functional tests for ironic to the sdk?
13:50:26 mordred dtantsur: it shouldn't be too hard to add the tests - but I don't think we currently run against any devstacks configured for ironic (or any other deployments - doesn't have to be devstack)
13:50:38 mordred so we probably need to add a job
13:50:58 mordred right now our ironic coverages is basically through the shade layer and then through bifrost
13:51:04 mordred and the bifrost job
13:51:44 dtantsur mordred: but we don't have a bifrost job on openstacksdk itself, do we?
13:54:18 mordred oh - no we don't - we should add one
13:54:29 mordred seeing as how the ansible modules use openstacksdk now
13:57:52 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Run bifrost integration test jobs https://review.openstack.org/586564
13:57:56 mordred dtantsur: ^^
13:58:14 dtantsur mordred: looking already, thanks!
13:58:31 mordred dtantsur: we should probably update bifrost itself to just use openstacksdk directly and not via shade ... but maybe that's a step
13:59:15 dtantsur oh, right, I did not realize it also uses shade from python
14:00:17 mordred dtantsur: we added openstacksdk as a shade depend last cycle, so it should be a fairly easy switch
14:00:31 dtantsur right
14:01:09 dtantsur mordred: okay, I'll ponder creating a simple functional job for baremetal bits this afternoon. testing it locally does not scale well :)
14:06:03 dtantsur mordred: will I have to do something to use admin credentials?
14:09:54 mordred dtantsur: the functional test suite looks for clouds.yaml files already - and with a particular name
14:09:58 mordred dtantsur: TEST_CLOUD_NAME = os.getenv('OS_CLOUD', 'devstack-admin')
14:10:55 mordred dtantsur: oh - well - bother - the sdk-layer and shade-layer functional tests are still a little different
14:11:00 mordred that above is for the sdk layer ones
14:11:12 mordred for the shade layer (openstack/tests/functional/cloud) - it's
14:11:17 mordred self._demo_name = os.environ.get('OPENSTACKSDK_DEMO_CLOUD', 'devstack')
14:11:19 mordred self._op_name = os.environ.get(
14:11:21 mordred 'OPENSTACKSDK_OPERATOR_CLOUD', 'devstack-admin')
14:11:24 mordred but basically the same idea
14:11:53 mordred it's also worth looking at openstack/tests/functional/cloud/test_devstack.py ...
14:12:21 mordred we have a little system where you can set an env var in the job definition, like OPENSTACKSDK_HAS_MAGNUM: 1
14:12:24 dtantsur mordred: yeah, I'm looking at the SDK layer for now, since it's not covered at all
14:12:44 mordred and that test will check to make sure that the given service exists in the cloud
14:13:20 mordred then it's safe to put in lines like:
14:13:22 mordred if not self.user_cloud.has_service('volume'):
14:13:24 mordred self.skipTest('volume service not supported by cloud')
14:13:35 mordred into setUp
14:21:57 openstackgerrit Dmitry Tantsur proposed openstack/openstacksdk master: Add a simple baremetal functional job https://review.openstack.org/586574
14:22:06 dtantsur mordred: let's try this ^^^
14:26:31 mordred dtantsur: lgtm
14:26:39 mordred let's see what our friend zuul thinks
14:27:15 dtantsur yep :) I'm pretty sure I missed something on the first attempt
15:07:25 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add support for streaming object responses https://review.openstack.org/586250
15:35:09 corvus mordred: what's the news on a release with fb8eed6f298e81a80fab614a20f4e61ad6f834bd in it?
15:35:22 corvus Update create_object to handled chunked data
15:37:46 mordred corvus: we just need to land it and then I can get a bugfix release landed
15:37:57 mordred if you wanna +A it (once zuul is happy again)
15:51:59 corvus mordred: +2
15:53:58 mordred corvus: hrm. should probably add a release note to that change since it'll be the only change in a bugfix release
15:54:12 mordred answering "why does this bugfix release exist" is usually a good thing to do
15:54:34 mordred k
15:54:36 mordred gah
15:54:38 corvus mordred: i would have thought the answer to that would be obvious! (because there was a bug!) ;)
15:54:43 mordred hehehe
15:57:42 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Update create_object to handled chunked data https://review.openstack.org/585532
15:57:44 mordred corvus: ^^
15:58:26 corvus +2
16:01:32 mordred corvus: actualy - crappit - we need to land it on stable/rocky - https://review.openstack.org/586605 Update create_object to handled chunked data
16:01:36 mordred Shrews: ^^ got a sec?
16:01:52 Shrews aye
16:02:14 mordred Shrews: the master version of the patch has run through tests a few times already
16:02:35 corvus i don't think i will ever understand why openstacksdk has a stable branch.
16:02:47 corvus i've had it explained to me before
16:02:51 corvus in one ear and out the other
16:02:56 mordred yah. I hear you
16:03:20 mordred corvus: openstacksdk makes more sense than shade did - mainly because it actually is used inside of some of the openstack services
16:03:50 corvus mordred: where's the release going to come from?
16:04:02 Shrews mordred: +2/+A and +1 (can't +2 stable)
16:04:09 mordred oh - I should fix that
16:04:41 mordred corvus, Shrews: you've both been added to openstacksdk-stable-maint
16:04:57 mordred corvus: the 0.17.1 release will get cut from the stable/rocky branch
16:05:21 corvus mordred: when do you start cutting releases from master again?
16:05:44 corvus (also, if this is documented somewhere, feel free to tell me to rtfm)
16:05:54 mordred once all of the server projects have their stable/rocky branches cut and the freeze is lifted
16:06:10 corvus ok. kinda sorta makes sense.
16:06:24 corvus i'll stop asking questions to reduce the risk of that changing. :)
16:06:33 mordred corvus: smcginnis sent out an email with the subject "Release countdown for week R-4" if you want to read more
16:07:12 mordred corvus: it's definitely taken some getting used to - I still don't have my head fully wrapped around it - but I'm doing better this cycle than last cycle
16:11:56 mordred corvus, Shrews: also - I think I want to remove the auto-creation of container from the sdk create_object call - corvus' work here shows it's actually not a great idea
16:12:08 mordred but for backwards compat, we'll keep it in the shade version
16:12:17 mordred sound ok to y'all?
16:12:48 Shrews mordred: yeah, though i'm curious why it was there in there in the 1st place. didn't i comment that bit?
16:13:19 Shrews # On some clouds this is not necessary. On others it is. I'm confused.
16:13:33 Shrews i guess i'm still confused
16:13:35 Shrews :)
16:13:37 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add method for returning a raw response for an object https://review.openstack.org/586262
16:13:43 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add support for streaming object responses https://review.openstack.org/586250
16:14:06 mordred Shrews: so say we all
16:34:03 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove the auto-creation of containers in create_object https://review.openstack.org/586616
16:51:57 openstackgerrit Akihiro Motoki proposed openstack/osc-lib master: Revert "Fixes a bug with issubclass() being called on an instance" https://review.openstack.org/586617
16:53:28 amotoki dtroyer: mordred: osc-lib 1.11.0 release breaks OSC plugins (at least neutronclient OSC plugin). the above revert will fix it. could you check it as you two reviewed the reverted patch?
17:22:14 openstackgerrit Dmitry Tantsur proposed openstack/openstacksdk master: Add a simple baremetal functional job https://review.openstack.org/586574
19:37:07 openstackgerrit Merged openstack/openstacksdk master: Update create_object to handled chunked data https://review.openstack.org/585532
20:44:42 openstackgerrit Hongbin Lu proposed openstack/python-openstackclient master: [WIP] Support enable/disable uplink status propagation https://review.openstack.org/586684
21:04:55 openstackgerrit Hongbin Lu proposed openstack/openstacksdk master: [WIP] Add propagate_uplink_status to port https://review.openstack.org/586687
23:12:02 mordred amotoki: whoops! the issubclass/isinstance swap was drivenby python 3.7 being more strict about using isinstance. but I agree - this case looks like we read the code wrong and that does look like it's a class
23:12:43 mordred now - need to look at why that functional test failed
23:15:52 openstackgerrit Merged openstack/openstacksdk master: Support for microversions in base Resource https://review.openstack.org/583491
23:39:13 mordred amotoki: it looks like osc functional tests got broken by glance v1 not being available
23:39:26 mordred http://logs.openstack.org/17/586617/1/check/osc-functional-devstack/7218285/testr_results.html.gz
23:50:59 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add method for returning a raw response for an object https://review.openstack.org/586262

Earlier   Later