Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-02-15
22:45:27 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Honor service type aliases from the catalog https://review.openstack.org/544356
22:45:27 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Handle liberty-era neutron https://review.openstack.org/545117
#openstack-sdks - 2018-02-16
00:22:27 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Work around discovery being a bit messy for cinder https://review.openstack.org/545174
00:26:12 openstackgerrit Daniel Speichert proposed openstack/python-openstacksdk master: Strip API version from subsequent paginated links https://review.openstack.org/543035
00:39:23 openstackgerrit Daniel Speichert proposed openstack/python-openstacksdk master: It seems to be working as expected for glance pagination. https://review.openstack.org/545175
02:36:55 openstackgerrit OpenStack Proposal Bot proposed openstack/openstackclient master: Updated from global requirements https://review.openstack.org/521902
02:49:38 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/544222
14:38:47 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Honor service type aliases from the catalog https://review.openstack.org/544356
17:16:22 dasp mordred: I updated https://review.openstack.org/#/c/543035/ and the fix works for Glance. Should I worry about failing tests? Do you think there's a way I can test pagination here? I'm not entirely sure what integration testing is in place but if there was a test with paginated image listing, we probably could have caught the issue.
18:45:07 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Update base test case to use base from oslotest https://review.openstack.org/540372
18:45:08 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Update all test base classes to use base.TestCase https://review.openstack.org/540373
18:45:08 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Honor service type aliases from the catalog https://review.openstack.org/544356
18:46:26 mordred dasp: yeah - we should fix the tests, that's a real error. we've got functional tests in place ... but we'd need to get enough images loaded to cause pagination to be returned which I think would be hard on an 8G devstack
18:47:18 mordred dasp: I think for now we should just add a couple of requests-mock tests that return pagination links in all of the combinations
18:47:34 mordred dasp: I'll see if I can't knock up an example of that ...
18:49:44 dasp mordred: makes sense. We can just create 200 fake image with random dd'ed payload of 1 MB each.
18:51:33 dasp mordred: not sure if you've seen my two other changes proposed but they're about properties. I'm not sure if the current approach of adding every possible property added in source as a "known" property is to be continued. There are countless options and metadata definition is really for that. So in one change I proposed adding a few and in another, I fixed loading properties property with "everything else", since Glance image object is
18:51:34 dasp flattened. Is there any established direction for what's the better approach?
18:57:30 openstackgerrit Vladyslav Drok proposed openstack/osc-lib master: Allow to use the none auth plugin https://review.openstack.org/512699
19:03:00 mordred dasp: I like the 200 fake images with 1M dd payload idea
19:07:11 mordred dasp: will look at the properties patches next - in the shade layer we put everything we don't know about into a 'properties' dict (the flat image object in glance v2 is ... so much fun)
19:07:57 mordred dasp: incidentally, http://paste.openstack.org/show/674819/ fixes the unit tests - but I think I may have been wrong about urljoin being good enough - and we may have to get more clever - so I think definitely getting some testing in place to make sure the right thing happens is going to be essential for this one
19:11:52 mordred dasp: like- something more akin to your first version - but that just does: if uri.startswith('/v') and uri[2].isdigit(): uri = uri.split('/', 2)[2]
19:15:28 mordred dasp: yeah, I like the idea in 544544 - haven't dug in to the impl details yet. also like 544049
19:16:10 mordred dasp: in general I think we shold support reasonable/defined image properties like you did in 544049 - and have everything else go to properties
19:17:54 dasp mordred: awesome. Those were drafts to get the job done, so I expect some improvements may need to be applied but it worked for what I needed while writing a tool that uses it.
19:18:05 mordred dasp: I'm tempted to say we should just adopt the shade approach globally and put unknown fields into a generic properties bucket for everything - bu tI haven't actually thought through the ramifications for that, so I think it's safer to do it on image first
19:19:50 dasp mordred: there's another bug that I haven't brought up yet - openstacksdk is sending properties as JSON booleans whenever they are booleans. Glance API is kindly throwing 400. It wants 'true' to be a string instead (I found that out tracing what openstackclient is doing). So whenever I declared the property to be a bool, it's not working as expected due to Glance.
19:20:32 dasp mordred: Then, however, if I assign a string to a property declared as dict, it is actually sent to API as string, so I started to doubt if that type setting does anything at all.
19:21:07 dasp mordred: What I noticed openstackclient is doing is that it always asks for metadata catalog before updating images, then it probably validates client-side and figured out the type for every property.
19:22:55 mordred dasp: I believe the type setting is only used when we're injesting values from remotely - so yeah, it's not going to coerce it if you just set it
19:23:22 mordred dasp: hrm. we should maybe do the same thing as osc for glance and grab the metadata catalog for valdation/coercion
19:24:37 mordred dasp: although now I'm also wanting to have the properties coerce things when you set them - and figure out a 'good' way to be able to specify split typing - like "treat this as a bool for sdk interactoins, but send it as a string please"
19:26:16 dasp mordred: it sounds like it may be needed, although I wish that Glance API could accept booleans/floats even if the property needs to be stored as string later on internally.
19:41:43 mordred dasp: ++
19:42:12 mordred dasp: of course, the joy here in sdk land is that even if we got glance fixed, we'd still need to support older unfixed clouds. yay us!
21:21:21 openstackgerrit Brianna Poulos proposed openstack/python-openstackclient master: Update help text for encryption provider https://review.openstack.org/545459
23:23:33 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Update base test case to use base from oslotest https://review.openstack.org/540372
23:23:33 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Update all test base classes to use base.TestCase https://review.openstack.org/540373
23:23:34 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Honor service type aliases from the catalog https://review.openstack.org/544356
#openstack-sdks - 2018-02-17
00:17:50 mordred Qiming: I said this in the review - but perhaps we should set up a zaqar devstack config so we can get functional tests running (and catch things like the message/messaging issue)
05:20:41 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Update base test case to use base from oslotest https://review.openstack.org/540372
05:20:41 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Update all test base classes to use base.TestCase https://review.openstack.org/540373
05:20:42 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Honor service type aliases from the catalog https://review.openstack.org/544356
05:20:59 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Run examples tests with functional tests https://review.openstack.org/540374
05:21:04 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Re-enable orchestration functional tests https://review.openstack.org/540412
05:30:07 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Fetch tox dir and html reports https://review.openstack.org/545507
05:30:28 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Updated from global requirements https://review.openstack.org/541943
10:03:45 openstackgerrit OpenStack Proposal Bot proposed openstack/os-client-config master: Updated from global requirements https://review.openstack.org/545550
10:04:18 openstackgerrit OpenStack Proposal Bot proposed openstack/os-service-types master: Updated from global requirements https://review.openstack.org/545551
10:05:42 openstackgerrit OpenStack Proposal Bot proposed openstack/osc-lib master: Updated from global requirements https://review.openstack.org/538478
10:17:19 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/544222
10:17:41 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/545568
15:29:44 openstackgerrit Praveen N proposed openstack/python-openstackclient master: displays flavor specific for project https://review.openstack.org/540633
15:47:36 openstackgerrit Merged openstack-infra/shade master: Fetch tox dir and html reports https://review.openstack.org/545507
15:48:36 openstackgerrit Merged openstack-infra/shade master: Updated from global requirements https://review.openstack.org/541943
16:28:21 openstackgerrit Merged openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/545568
16:32:53 openstackgerrit Merged openstack/os-client-config master: Updated from global requirements https://review.openstack.org/545550
17:27:30 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Mark openstacksdk-functional-devstack-base as abstract https://review.openstack.org/545606
#openstack-sdks - 2018-02-19
16:13:12 mordred Shrews: welcome back - if you get a moment, I have some nice patches ready and waiting for you
16:13:41 Shrews ok
16:15:44 mordred Shrews: https://review.openstack.org/#/c/544356/ through https://review.openstack.org/#/c/544356 are ready to go, as are https://review.openstack.org/#/c/539936/ and https://review.openstack.org/#/c/539678
16:15:49 mordred Shrews: no specific rush obvs
16:41:41 Shrews mordred: what do the changes in https://review.openstack.org/#/c/540372/6/openstack/cloud/openstackcloud.py have to do with that logging change?
16:48:22 mordred Shrews: the base test update exposed an assumption in connect_as (because there is a code-path which uses connect_as on a connection that was not created from a full clouds.yaml config)
16:49:16 mordred Shrews: we could split it out into its own change to land before the base test change - I just figured I was assaulting you with too many patches as it was :)
16:50:28 Shrews mordred: it's fine, it just wasn't mentioned in the commit message so i was confused
16:56:22 mordred Shrews: fair :)
18:25:34 openstackgerrit Matt Riedemann proposed openstack/python-openstackclient master: Default --nic to 'auto' if creating a server with >= 2.37 https://review.openstack.org/545946
18:39:52 Shrews mordred: i +2'd or +3'd up to https://review.openstack.org/540374, which is failing
18:41:22 SamYaple do we have a weekly meeting ive been missing? last i looked there wasnt really an active meeting schedule
18:45:37 Shrews SamYaple: if there is one, i've been missing it too
18:45:51 Shrews so i think the answer is "no"
18:46:49 SamYaple cool. well let me know if that changes (and maybe it should?)
18:47:07 SamYaple i wouldnt mind a (bi)?monthly meeting
18:47:18 SamYaple get some better picture of long term plans
19:24:28 openstackgerrit Merged openstack/python-openstacksdk master: Calculate name in CloudRegion https://review.openstack.org/541059
20:06:37 openstackgerrit Merged openstack/python-openstacksdk master: Add get_client_config method to CloudRegion https://review.openstack.org/539678
20:10:48 openstackgerrit Merged openstack/python-openstacksdk master: Use keystone NoAuth plugin for auth_type none https://review.openstack.org/539936
20:24:41 mordred Shrews: thanks!
20:24:55 mordred SamYaple: andyah - I've been thinking it's about time to spin one of those up
#openstack-sdks - 2018-02-20
00:18:26 openstackgerrit Merged openstack/python-openstacksdk master: Use get_session_client in Connection https://review.openstack.org/541060
01:44:43 openstackgerrit Merged openstack/python-openstacksdk master: Update base test case to use base from oslotest https://review.openstack.org/540372
01:49:54 openstackgerrit Merged openstack/python-openstacksdk master: Update all test base classes to use base.TestCase https://review.openstack.org/540373
13:50:45 elmiko cdent: not sure if you saw the notes from last meeting (or if anyone mentioned it), we had all agreed to give +1s and -1s to the items on the agenda etherpad
13:51:00 elmiko sorry, should have said something last week
13:51:06 cdent elmiko: I did see that and then totally forgot
13:51:12 elmiko =)
13:51:26 cdent since you're here: I'll be somewhere in Ireland on thursday this week, so not around for meeting
13:54:21 elmiko cdent: ack, might be a light meeting again
13:54:28 elmiko enjoy the emerald isle ;)
14:01:12 cdent elmiko: I can't find last week's newletter in the archive. am I being blind?
14:03:28 elmiko cdent: must be, sent folder shows that i did indeed send it
14:03:43 cdent did you use the usual subject?
14:03:48 elmiko yes
14:05:05 elmiko cdent: http://lists.openstack.org/pipermail/openstack-dev/2018-February/127427.html
14:06:15 cdent elmiko: ah, I got it, it's pipermail choosing to thread underneath the previous one, I was looking for a top-level entry
14:11:46 elmiko that's weird
14:11:55 elmiko i certainly didn't post it as a "reply to" type thing
14:15:01 cdent I think pipermail is lame

Earlier   Later