Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2018-01-31
21:11:18 mordred can we blame you anyway thought? :)
21:11:20 adriant mordred: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/network/v2/network.py#L500-L501
21:11:33 adriant the client supplies both
21:11:38 adriant but only the second does anything
21:12:11 mordred adriant: AH
21:12:12 adriant my code simply ensures that you're supplying it as: "is_router_external" since it is dropped otherwise
21:12:40 adriant lemme double check
21:12:53 mordred so - yah- introducing the strictness broke a thing that was just passing multiple options and counting on unsupported things falling on the floor
21:13:45 adriant we can potentially introduce a "strict_list_params" boolean if we want, and default it to false, with a deprecation warning?
21:14:38 mordred yah. I'd love it if we could introduce that on the Connection and not on each call ...
21:14:59 adriant oh yeah, no on each call...
21:15:19 adriant not*
21:15:53 mordred also - I may be overthinking this ... but at least in the openstackclient case, the extra argument is the 'real' name for something we have a mapping for
21:16:12 adriant patch for openstackclient?
21:16:15 mordred adriant: we *could* have it do something similar to what your swift patch did a while back (look at the keys and then also the values)
21:16:26 adriant yeah, I can add that in
21:16:50 adriant but I bet you someone somewhere is passing in bogus values... but my worry is they are doing so expecting it to work
21:16:53 mordred thatwould let people use the REST-side parameters or the sdk parameters
21:17:18 adriant oh, so we do the remapping if they supply the values?
21:17:30 adriant yeah, could work
21:18:07 mordred yah. we've already got is_router_external='router:external' in sdk
21:18:31 adriant ok, lemme play with that
21:18:43 mordred so if we're just add a friendly mapping for folks before the set - then router:external would turn in to is_router_external twice- and then set would collapse it and OSC would work again
21:18:45 mordred cool
21:19:20 adriant and anyone beyond that is actually supplying bogus values does get an error, but... that's probably a good thing
21:19:46 mordred agree
21:22:31 adriant mordred: ok, now I'm confused... what branch are we working against? because it looks like you've merged stuff to stable queens but not master
21:22:52 mordred both - go ahead and write it for master and we can then cherry-pick it back to stable queens
21:23:10 adriant but why is stable queens further ahead of master? :P
21:24:04 openstackgerrit Merged openstack/os-client-config master: Split docs requirements and update tox.ini https://review.openstack.org/539594
21:24:26 mordred adriant: I may have fast-tracked two patches earlier to squeeze them in to the release ;)
21:25:15 openstackgerrit Merged openstack/os-client-config master: Updated from global requirements https://review.openstack.org/533991
21:30:42 adriant mordred: I think master is broken.
21:30:57 mordred adriant: awesome
21:31:35 adriant https://github.com/openstack/python-openstacksdk/blob/master/openstack/proxy.py#L43
21:31:36 adriant https://github.com/openstack/python-openstacksdk/blob/master/openstack/proxy2.py#L18
21:32:33 mordred adriant: hah. yes. that is, indeed, broken
21:32:49 mordred although amusingly the patch to rename BaseProxy to Proxy would fix that
21:32:50 adriant and after fixing that i get: AttributeError: 'module' object has no attribute 'Body'
21:33:26 mordred adriant: what's trying to call in through Proxy2?
21:33:47 adriant lemme see
21:34:39 mordred adriant: on master for me, openstack network list --external gets through to where it's supposed to fail
21:35:20 adriant oh ffs
21:35:23 adriant I think i see my issue
21:35:57 adriant ugh, the random fucking pyc files for 'meter' didn't get cleaned up
21:36:13 adriant i'm very confused by that...
21:36:20 adriant I nuked my venv
21:36:48 mordred I hate leftover .pyc files
21:38:59 adriant *sigh* and other random cruft leftover from using "python setup.py install" ages ago with an old version that included meter code :/
21:39:04 adriant works now...
21:44:40 adriant mordred: for that query mapping fix
21:45:17 adriant right now, if I just add the values to my checking, and nothing else, the 'values' data takes precedence over the real expected key if both are supplied
21:45:42 adriant are you ok with my making it so that if you supply both, we take the one we prefer them to sue?
21:45:43 adriant use*
21:45:59 adriant e.g.is_router_external > router:external
21:46:44 mordred adriant: yah - I think that seems right - if you supply both, we should have the 'official' thing wins
21:47:01 adriant mordred: currently would do it the other way https://github.com/openstack/python-openstacksdk/blob/master/openstack/resource.py#L234
21:47:19 adriant so I'll update transpose to check if the key is already present
21:47:26 mordred ++
21:49:55 adriant oh wait no I'm being silly. transpose just drops them. I need to make it actually try and use both.
21:50:38 mordred adriant: I must afk for a couple of hours - will check back in when I'm back - thanks for diving in on this!
22:39:04 openstackgerrit Merged openstack/python-openstackclient master: Make functional-tips job voting https://review.openstack.org/525283
22:41:17 openstackgerrit OpenStack Proposal Bot proposed openstack/os-client-config master: Updated from global requirements https://review.openstack.org/539718
22:44:38 openstackgerrit Merged openstack/python-openstacksdk master: Let enforcer.py work under both py2 and py3 https://review.openstack.org/539685
22:53:27 openstackgerrit Adrian Turjak proposed openstack/python-openstacksdk master: Add server-side names to query param checking https://review.openstack.org/539722
22:56:32 adriant mordred: fixed ^
22:57:13 adriant and the fix actually adds some nicer logic overall
#openstack-sdks - 2018-02-02
00:51:26 mordred rods_: I thought you'd like that!
01:21:22 openstackgerrit Nguyen Hung Phuong proposed openstack/service-types-authority master: Remove pbr warnerrors in favor of sphinx check https://review.openstack.org/539810
11:07:40 openstackgerrit Andreas Jaeger proposed openstack/os-client-config master: Add osc tips jobs back https://review.openstack.org/526706
11:10:13 openstackgerrit Andreas Jaeger proposed openstack/keystoneauth master: Remove PYTHONHASHSEED setting https://review.openstack.org/533798
11:26:10 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/540345
12:27:17 openstackgerrit Merged openstack-infra/shade master: Plumb use-direct-get through factory functions https://review.openstack.org/539586
12:27:19 openstackgerrit Merged openstack-infra/shade master: Fix get_server to work with use_direct_get https://review.openstack.org/539663
13:14:49 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Update base test case to use base from oslotest https://review.openstack.org/540372
13:14:49 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Update all test base classes to use base.TestCase https://review.openstack.org/540373
13:14:50 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Run examples tests with functional tests https://review.openstack.org/540374
13:16:16 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Use sdk for list_servers https://review.openstack.org/530770
13:28:39 openstackgerrit Merged openstack/os-client-config master: Zuul: Remove project name https://review.openstack.org/538901
14:04:26 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Use sdk for list_servers https://review.openstack.org/530770
14:04:26 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Fix get_server to work with use_direct_get https://review.openstack.org/540389
14:04:27 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Add all_projects as a preferred alias for all_tenants https://review.openstack.org/540390
14:09:14 rabel_ any opinions on https://bugs.launchpad.net/python-openstackclient/+bug/1744349 ? i'd like to implement this, shouldn't be a big deal. just want to hear some opinions before
14:09:14 openstack Launchpad bug 1744349 in python-openstackclient "Interface of "quota set" and "quota show" is missleading" [Undecided,New]
14:52:33 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Remove support for arbitrary attributes from CloudRegion https://review.openstack.org/540406
14:59:18 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Update all test base classes to use base.TestCase https://review.openstack.org/540373
14:59:18 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Run examples tests with functional tests https://review.openstack.org/540374
14:59:19 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Re-enable orchestration functional tests https://review.openstack.org/540412
15:32:01 rods_ mordred amazing work on https://review.openstack.org/#/c/540169/1, left two very minor comments
15:32:15 mordred rods_: awesome - thanks for reading through that!
15:38:07 mordred rods_: those are great feedback- thanks
16:10:44 openstackgerrit James E. Blair proposed openstack/openstackclient master: Zuul: Remove project name https://review.openstack.org/540433
17:37:34 Shrews mordred: your proxy change is next on my todo list after lunch
18:02:27 mordred Shrews: awesome! rods liked it. oh- I fixed it from his reviews ...
18:06:10 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Generate proxy methods from resource objects https://review.openstack.org/540169
18:10:18 mordred rods_: ^^ updated per your comments
18:10:32 rods_ mordred looking
18:31:06 openstackgerrit Merged openstack/openstackclient master: Zuul: Remove project name https://review.openstack.org/540433
18:33:22 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Use instance.get_interface instead of instance.interface https://review.openstack.org/540481
18:33:56 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Remove support for arbitrary attributes from CloudRegion https://review.openstack.org/540406

Earlier   Later