| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-01-18 | |||
| 14:44:56 | openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Rename resource2 and proxy2 to resource and proxy https://review.openstack.org/533826 | |
| 14:44:56 | openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Fix typo in the external service loader code https://review.openstack.org/534452 | |
| 14:44:57 | openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Fixed a few nits in the README https://review.openstack.org/534453 | |
| 14:44:57 | openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Remove deprecated wait_for methods from Proxy https://review.openstack.org/534832 | |
| 14:50:09 | dtroyer | dhellmann: The commit message has it backwards but that is why we are changing it in this instance… mind if I update it so we don't record the wrong intention? | |
| 14:50:26 | dhellmann | dtroyer : oh, no, go for it | |
| 14:50:34 | dhellmann | sorry I missed that | |
| 14:50:51 | dhellmann | too many irons in the fire yesterday :-/ | |
| 14:51:01 | dtroyer | me too… | |
| 14:53:58 | openstackgerrit | Dean Troyer proposed openstack/cliff master: remove -s alias for --sort-columns https://review.openstack.org/534771 | |
| 14:54:15 | dtroyer | dhellmann: wanna make sure I didn't get it wrong? ^^^^ | |
| 14:54:54 | dhellmann | yeah, that looks good | |
| 14:55:05 | dtroyer | +W | |
| 14:55:09 | dhellmann | I wasn't clear if we wanted a policy that cliff *not* use globals or if commands shouldn't | |
| 14:55:31 | dhellmann | if we want the latter, we could probably enforce that, although doing it in a backwards-compatible way would be a nightmare | |
| 14:56:09 | dtroyer | OSC has had the policy for commands to not use short options, because -s means too many different things, it seemed simpler to me to make those only used for global options, like those from cliff | |
| 14:56:23 | dhellmann | ok, that makes sense to me | |
| 14:56:37 | dtroyer | There are no short options in commands in the osc repo, the ones that do exist will all be in plugins | |
| 14:56:43 | dhellmann | we should probably publicize that somewhere | |
| 14:57:10 | dhellmann | oh, how about this | |
| 14:57:21 | dhellmann | we could change cliff to register plugin options after command options | |
| 14:57:28 | dhellmann | then we could turn on that "resolve" flag | |
| 14:57:28 | dtroyer | it is in our plugin guide, maybe needs to be bigger… then again the only people who tend to read that are the initial plugin devs, | |
| 14:57:42 | dtroyer | that's an idea | |
| 14:57:50 | dhellmann | that would have the effect of letting cliff and global plugins like formatters own the option namespace | |
| 14:58:03 | dtroyer | in fact, I like that idea | |
| 14:58:11 | dhellmann | ok, I'll make a note about that and post to the ML to get some other feedback | |
| 14:58:27 | dtroyer | cool, thanks | |
| 15:04:47 | dhellmann | implementing that is going to be tricky, because we're relying on the inheritance right now | |
| 15:04:53 | dhellmann | I'll have to think about the API changes needed | |
| 15:15:44 | dhellmann | dtroyer : http://lists.openstack.org/pipermail/openstack-dev/2018-January/126348.html | |
| 15:27:23 | openstackgerrit | Spencer Yu proposed openstack/python-openstackclient master: floatingip related should be removed from compute client https://review.openstack.org/535364 | |
| 15:49:37 | openstackgerrit | Spencer Yu proposed openstack/python-openstackclient master: floatingip related should be removed from compute client https://review.openstack.org/535364 | |
| 16:28:09 | openstackgerrit | Merged openstack/api-wg master: Expand note about rfc5988 link header https://review.openstack.org/531914 | |
| 16:29:08 | edleafe | dtantsur: ready for your eyes: https://etherpad.openstack.org/p/api-sig-newsletter | |
| 16:29:59 | dtantsur | edleafe: LGTM | |
| 16:30:13 | edleafe | dtantsur: ok, thanks! | |
| 17:28:38 | openstackgerrit | Dmitry Tantsur proposed openstack/api-wg master: Add guideline on exposing microversions in SDKs https://review.openstack.org/532814 | |
| 17:28:40 | dtantsur | edleafe: slightly updated ^^^ | |
| 17:33:22 | edleafe | dtantsur: ack | |
| 18:33:45 | mordred | dtantsur|afk: left a note - I think we have a bikeshed we need to have about naming | |
| 18:39:18 | openstackgerrit | Merged openstack/cliff master: remove -s alias for --sort-columns https://review.openstack.org/534771 | |
| 18:53:48 | openstackgerrit | Merged openstack/python-openstackclient master: Fix indentation in authentication.rst https://review.openstack.org/534848 | |
| 19:06:24 | mordred | dtroyer: if you have a sec, would you mind weighing in on https://review.openstack.org/#/c/533264 and https://review.openstack.org/#/c/533265 ? | |
| 19:20:22 | dtantsur|afk | mordred: oh, yeah, it's going to be fun ;) will respond tomorrow | |
| 19:34:34 | johnsom | Is anyone looking at the neutron breakage in openstacksdk 0.10.0 that is blocking the GR update? https://review.openstack.org/#/c/534345/ | |
| 19:34:52 | johnsom | We, octavia, really need that release in queens... | |
| 19:50:10 | mordred | johnsom: I am now :) | |
| 19:50:45 | johnsom | mordred Ok, thanks. I just heard a report of this being broken in the field too. Let me know if I can help in some way. | |
| 19:50:50 | mordred | wait a second ... there's a new openstacksdk release? | |
| 19:51:01 | openstackgerrit | Merged openstack-infra/shade master: Updated from global requirements https://review.openstack.org/525368 | |
| 19:51:04 | johnsom | Evidently | |
| 19:51:18 | mordred | oh joy. that's ... unfortunate | |
| 19:52:06 | johnsom | Well, I was hoping for one to get that sdk fix in for octavia. We really need that fix for the queens release. | |
| 19:53:01 | mordred | well, yes - I think a 0.10 release is a great idea - but there's a few more patches I'd wanted to get landed before we cut one this week | |
| 19:53:05 | johnsom | I figured you knew, but I guess not: https://review.openstack.org/#/c/533624/ | |
| 19:53:40 | johnsom | I just saw it as I've been watching for it due to the octavia fix | |
| 19:54:30 | mordred | well - such is life - I'll look in to the neutron failure for you | |
| 19:54:39 | johnsom | Ok, thanks | |
| 19:55:25 | johnsom | The person I heard also saw it was just trying to create a floating IP via OSC and got a failure. | |
| 19:58:45 | mordred | http://logs.openstack.org/45/534345/2/check/neutron-grenade/9831f38/logs/grenade.sh.txt.gz#_2018-01-17_18_04_33_423 | |
| 19:58:48 | mordred | seems to be the error | |
| 20:01:32 | mordred | I can reproduce locally | |
| 20:09:23 | dtroyer | mordred: +2 on both, ready to +W them? | |
| 20:09:33 | mordred | dtroyer: yup! | |
| 20:09:43 | dtroyer | done | |
| 20:10:20 | mordred | dtroyer: didn't we land a patch in osc to try importing new things from sdk if they're there? | |
| 20:11:36 | dtroyer | Hmmm… I actually don't remember for sure, but it wouldn't have been global, just getting Connection set up with OSC's sessiion or something | |
| 20:12:03 | mordred | yah | |
| 20:12:13 | mordred | well - I'll look in to that *next* | |
| 20:12:14 | dtroyer | the semantics are different enough in most of the client libs that it'll be a bit more than s// to change over | |
| 20:12:29 | mordred | oh - I mean in the network plugin where we make one for Neutron | |
| 20:12:55 | dtroyer | ah, yes, that is where we would have done that. If it hasn't moved to clientManager it should though | |
| 20:13:23 | dtroyer | I have unfortunately let most of OSC leave L1 cache in my brain the last few weeks | |
| 20:18:49 | mordred | dtroyer: I hear you | |
| 20:18:52 | mordred | there's only so much cache space | |
| 20:18:57 | mordred | johnsom: found bug - patch coming | |
| 20:20:16 | mordred | dtroyer: I think we may want to add the neutron-grenade job to the openstacksdk gate - neutron-grenade caught an issue that the other sdk/osc shared jobs didn't | |
| 20:26:07 | dtroyer | mordred: is that something that we'll need to think about for the other APIs, and if it'll take N jobs to do N APIs? | |
| 20:26:23 | mordred | dtroyer: no - this was just a bug in the backwards-compat code around Profile | |
| 20:27:02 | mordred | dtroyer: it's also possible that adding neutron-grenade doesn't really gain us anything systemically and we just got lucky/unlucky this time | |
| 20:27:38 | johnsom | Awesome you found the bug | |
| 20:28:13 | mordred | johnsom: yah - it's a silly likttle thing - but it's also easy enough to trigger, so making sure it's all gone | |
| 20:35:23 | openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Make sure we use config defaults in profile compat code https://review.openstack.org/535476 | |
| 20:35:47 | mordred | johnsom, dtroyer: ^^ that should fix the break in https://review.openstack.org/#/c/534345/ | |
| 20:42:30 | mordred | Shrews: ^^ you too, if you get a chance | |
| 20:43:50 | johnsom | Shouldn't there be a unit test update here? | |
| 20:52:17 | mordred | johnsom: yup. almost certainly | |
| 20:52:19 | mordred | :) | |
| 20:53:22 | openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Invert the attribute mapping https://review.openstack.org/533822 | |
| 21:06:03 | openstackgerrit | Merged openstack/python-openstacksdk master: Rationalize logging helpers and docs https://review.openstack.org/532634 | |
| 21:08:36 | openstackgerrit | Merged openstack/python-openstacksdk master: Add ability to register non-official services https://review.openstack.org/533263 | |
| 21:10:45 | openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Make sure we use config defaults in profile compat code https://review.openstack.org/535476 | |
| 21:11:01 | mordred | johnsom, Shrews: ^^ k. now with a test. I verified that the test breaks without the patch | |
| 21:11:07 | mordred | (and breaks in the way that osc was breaking) | |
| 21:42:21 | johnsom | Nice | |
| 21:58:18 | openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Make sure we use config defaults in profile compat code https://review.openstack.org/535476 | |
| 22:55:00 | openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Use version definition from openstack.version https://review.openstack.org/535336 | |
| 22:55:01 | openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Move openstack_cloud helper functions https://review.openstack.org/535515 | |
| 23:14:55 | openstackgerrit | Monty Taylor proposed openstack/python-openstacksdk master: Invert the attribute mapping https://review.openstack.org/533822 | |