Earlier  
Posted Nick Remark
#openstack-sdks - 2017-12-01
15:22:26 slaweq dtroyer: hello, will You have time to check my answers to Your comments in https://review.openstack.org/#/c/515401/ ?
15:22:35 slaweq dtroyer: thx in advance
15:22:41 thingee os-service-types doesn't have branches, but reno wants branches https://review.openstack.org/#/c/520475/1
15:24:38 dtroyer slaweq: it's on my list for today
15:24:44 slaweq dtroyer: thx a lot
15:27:24 openstackgerrit Monty Taylor proposed openstack/cliff master: Replace legacy tips jobs with shiny new versions https://review.openstack.org/524643
15:31:11 openstackgerrit Monty Taylor proposed openstack/cliff master: Replace legacy tips jobs with shiny new versions https://review.openstack.org/524643
15:36:51 openstackgerrit Monty Taylor proposed openstack/os-service-types master: Remove reference to stable/pike from releasenotes https://review.openstack.org/524647
15:36:58 mordred thingee, cmurphy: ^^
15:38:20 cmurphy mordred: /home/colleen/dev/os-service-types/releasenotes/source/index.rst:5:toctree contains reference to nonexisting document u'master'
15:38:28 cmurphy rename pike.rst to master.rst i think
15:38:58 mordred gah
15:39:00 mordred tahnks
15:39:17 openstackgerrit Monty Taylor proposed openstack/os-service-types master: Remove reference to stable/pike from releasenotes https://review.openstack.org/524647
15:39:45 dtroyer dhellmann: left a copule of comments in that etherpad, overall looks like a good approach
15:40:02 openstackgerrit Monty Taylor proposed openstack/os-service-types master: Updated from global requirements https://review.openstack.org/520475
15:40:32 Shrews would anyone else like to review mordred's merge-shade stack, or shall i just +W them? they're pretty much just cherry-picks from shade
15:40:59 mordred Shrews: I think you can just +W them - they've gone through the process once already
15:42:18 Shrews mordred: gah, is this the root? https://review.openstack.org/522974 it's the only one with a pypy fail
15:42:51 mordred hrm. why does that havea pypy fail - the pypy issue should have been fixed ...
15:43:31 mordred Shrews: oh - my - that's an actual weird fail, rather than just a job issue ...
15:43:44 Shrews yay
15:44:48 mordred or, rather, it's just weird- but looking in to it
15:45:18 Shrews k. gotta step out for a coffee run real quick anyway
15:46:01 dtroyer Shrews: FWIW I'm OK with you just +W on shade backports. I'm trying to pay more attention to the o-c-c stuff.
15:46:19 Shrews dtroyer: *nod*
15:48:47 mordred dtroyer, Shrews: ok. that error is something weird and deep in subunit ... I think I'm ready to give up on it - this is way too much effort for a thing that's pretty much unused
15:49:57 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Cleanup objects that we create on behalf of images https://review.openstack.org/522974
15:49:58 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Add method to cleanup autocreated image objects https://review.openstack.org/522975
15:49:58 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Complete move of baremetal machine tests https://review.openstack.org/522976
15:49:59 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Treat clouds.yaml with one cloud like envvars https://review.openstack.org/522977
15:49:59 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Protect against p_opt not having prompt attribute https://review.openstack.org/522978
15:50:00 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Update make_rest_client to work with version discovery https://review.openstack.org/522979
15:50:00 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Added nat_source flag for networks. https://review.openstack.org/522980
15:50:01 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Shift image tests from test_operator https://review.openstack.org/523258
15:50:01 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Start using Connection in openstack.cloud https://review.openstack.org/523259
15:50:02 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Remove get_legacy_client https://review.openstack.org/523483
15:50:02 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Remove openstack-tox-pypy jobs https://review.openstack.org/524651
15:55:55 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add osc-tox-unit-tips jobs https://review.openstack.org/524656
15:57:17 openstackgerrit Merged openstack/os-service-types master: Remove reference to stable/pike from releasenotes https://review.openstack.org/524647
16:00:46 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add shade and python-openstacksdk tips jobs https://review.openstack.org/524659
16:06:50 openstackgerrit Merged openstack/os-service-types master: Updated from global requirements https://review.openstack.org/520475
16:14:02 amotoki mordred: one question on https://review.openstack.org/#/c/522369/3/tox.ini : do you drop '{toxinidir}/demoapp' from docs requirements temporarily?
16:14:04 amotoki mordred: This is required to build cliff doc expectedly but I am okay if it is provisional.
16:27:37 mordred amotoki: there's a previous patch which changes how it works to use code from in the tree
16:27:57 mordred amotoki: oh - wait- that was from you :)
16:28:29 mordred amotoki: I think that's a bug in my patch then - let me fix
16:28:41 amotoki mordred: thanks :)
16:28:47 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Add cliff and keystoneauth to tips jobs https://review.openstack.org/524639
16:28:48 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Make py27 and py35 versions and template of unit-tips jobs https://review.openstack.org/524670
16:28:48 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Avoid tox_install.sh for constraints support https://review.openstack.org/524671
16:34:52 openstackgerrit Monty Taylor proposed openstack/cliff master: Move doc requirements to doc/requirements.txt https://review.openstack.org/522369
16:34:53 openstackgerrit Monty Taylor proposed openstack/cliff master: Replace legacy tips jobs with shiny new versions https://review.openstack.org/524643
16:34:53 openstackgerrit Monty Taylor proposed openstack/cliff master: Remove tox_install.sh and just pass -c in tox https://review.openstack.org/523984
16:34:54 openstackgerrit Monty Taylor proposed openstack/cliff master: DNM testing docs and releasenotes jobs https://review.openstack.org/522370
16:35:04 mordred amotoki: ^^ that should be happier I think
16:38:34 amotoki mordred: i think we need {toxinidir}/demoapp in [testenv:docs] deps too
16:39:32 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add osc, shade and sdk tips jobs https://review.openstack.org/524656
16:43:44 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Add osc-tox-unit-tips jobs https://review.openstack.org/524676
16:43:58 mordred amotoki: duh. of course. silly me :)
16:45:16 mordred amotoki: oh. wait. this is ... darn it
16:45:44 mordred this won't work at all ... let me mark that WIP for now
16:46:11 openstackgerrit Merged openstack/python-openstacksdk master: Avoid tox_install.sh for constraints support https://review.openstack.org/524498
16:47:46 amotoki mordred: it is a bit tricky. we installs cliffdemo from local mainly for docs and testing the sphinx directive. it might need more work for docs build with venv you are working on
16:49:32 mordred amotoki: yah - that's the issue - tox isn't involved in the new docs build jobs, so specifying the requirement there is an issue- I kinda thing we should revert the local cliffdemo patch and go back to installing it from pypi like before - and just add cliffdemo to global-requirements since it *is* a requirement that cliff has for both docs and testing
16:49:55 mordred amotoki: otherwise I think we're going to wind up getting too clever all just to avoid adding one line to global-requirements
16:50:32 amotoki mordred: honestly i am not sure cliffdemo is worth published to pypi
16:50:55 amotoki mordred: the current cliffdemo in PyPI is really old
16:51:04 mordred amotoki: it's already published there- that's how it was being installed before your patch
16:53:18 amotoki mordred: yes. it works with cliffdemo in PyPI, but cliffdemo itself is mainly for demo purpose (+ test for the sphinx directive)
16:53:38 mordred amotoki: totally. however, there is already precedent - openstack-release-test is in global-requirements for a similar reason
16:53:48 amotoki mordred: i am not sure what is the right solution. I would like to hear opinion of dhellmann
16:54:16 mordred amotoki: agree. definitely want his opinion :)
16:57:00 mordred amotoki, dhellmann: for sake of argument, here's a g-r patch adding it: https://review.openstack.org/524678 Add cliffdemo
17:22:24 openstackgerrit Merged openstack/cliff master: Use in-tree cliffdemo app for docs build https://review.openstack.org/515016
17:32:22 mordred dtroyer: https://review.openstack.org/#/c/522977 https://review.openstack.org/#/c/522978 https://review.openstack.org/#/c/522979 and https://review.openstack.org/#/c/522980 are cherry-picks of occ patches
17:32:44 mordred dtroyer: and https://review.openstack.org/#/c/523483/6 is a non-cherry-pick that touches that section of the code
18:10:16 openstackgerrit Merged openstack/python-openstacksdk master: Add pools attribute to load balancer heath monitor https://review.openstack.org/522962
18:22:46 openstackgerrit Doug Hellmann proposed openstack/cliff master: do not require installing demo app to build docs https://review.openstack.org/524695
18:32:32 thingee dtroyer, mordred with https://review.openstack.org/#/c/523834/3 and https://review.openstack.org/#/c/516701/7/openstackclient/network/common.py extensions being proposed in osc and python-openstacksdk, perhaps we can have some common extension checking code for the existing cases, but stop accept new cases?
18:38:12 openstackgerrit Monty Taylor proposed openstack/cliff master: Move doc requirements to doc/requirements.txt https://review.openstack.org/522369
18:38:13 openstackgerrit Monty Taylor proposed openstack/cliff master: Replace legacy tips jobs with shiny new versions https://review.openstack.org/524643
18:38:13 openstackgerrit Monty Taylor proposed openstack/cliff master: Remove tox_install.sh and just pass -c in tox https://review.openstack.org/523984
18:38:14 openstackgerrit Monty Taylor proposed openstack/cliff master: DNM testing docs and releasenotes jobs https://review.openstack.org/522370
18:38:22 mordred dhellmann: ^^ reparented on your patch
18:38:40 dhellmann mordred : looking
19:06:25 mordred stevemar: responded to https://review.openstack.org/#/c/524670 - I can update it to move the branch exclusion down into the project tepmlate if you prefer
19:37:54 openstackgerrit Monty Taylor proposed openstack/cliff master: DNM testing docs and releasenotes jobs https://review.openstack.org/522370
19:47:19 mordred dhellmann: zomg. ^^ passes!!!
19:56:42 dhellmann mordred : woot!
19:56:58 mordred dhellmann, dtroyer: cliff runs legacy-tempest-dsvm-neutron-src ... I think (once it's solid) that osc-functional-devstack-tips would be a good replacement for that - since hte point would be to make sure that patches to cliff don't break devstack by breaking osc, right?
19:57:22 dhellmann I think that's the point of running that job, yes
19:58:32 openstackgerrit Merged openstack/python-openstackclient master: Add cliff and keystoneauth to tips jobs https://review.openstack.org/524639
19:58:49 dhellmann it looks like we're still waiting for jobs to pass on my patch at the bottom of that stack
19:58:57 mordred cool. once dtroyer has the -tips job fixed I can put up a patch to switch that over, and we'll be done with legacy jobs across osc, sdk and cliff
19:59:06 mordred yah - the legacy devstack job is taking its sweet time
20:01:10 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Fix SDK Connection creation alternative to Profile https://review.openstack.org/523938
20:01:11 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Rework Network client config for new SDK Connection https://review.openstack.org/524715
20:01:27 mordred dhellmann, dtroyer: also, fwiw, I put up a patch to keystoneauth to run osc, sdk and shade functional tests on keystoneauth changes - so I think we're actually getting into a really good place in terms of cross-testing these base-level pieces \o/ https://review.openstack.org/#/c/524656/
20:01:35 mordred ooh. that looks like a fix from dtroyer

Earlier   Later