Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2017-11-29
16:20:54 sdague yeh
16:23:07 sdague also, I think graphql seems to work best when the front end has intimate knowledge of the costs of asking for things on the backend. So as a layer between the github ui and services, it's awesome
16:27:39 mordred sdague: yah - or, as soon as they finish adding all of the things to the graphql layer, it'll help zuul's github driver make fewer API calls and thus avoid rate-limit issues
16:28:15 sdague mordred: sure
16:28:46 mordred sdague: but I agree, in general, with the assessment about intimate knowledge - in this example, the zuul thing is a cost optimization - it's certainly not an easier/better way to write the first version of the thing
16:29:07 sdague mordred: and, you are hitting the API raw, because you need that level of granularity
16:29:17 mordred yup
16:29:26 sdague but, if you went through someone's random SDK
16:29:35 sdague you are unlikely to get those optimizations
16:29:40 mordred yup. exactly
16:30:11 mordred that said - I'd kind of LOVE a graphql api option for openstack service ... for similar reasons
16:30:49 mordred finding the port that's ona subnet on a network is basically doing three full list calls and doing a client-side in-memory join
16:31:02 sdague mordred: honestly, building a graphql porcelin for all of openstack would be a totally legit thing to do
16:31:38 sdague it would be different enough that I don't think it would be confusing between the rest resources at the point sevices and what it returned
16:32:56 mordred sdague: yah. although having a per-service graphql as well that the porcelin could use for push-downs for efficiency would also be nice ... but yes, a graphql openstack porcelain that could do "I want to create a floating IP on a port from the server that is on this subnet of this network"...
16:33:29 mordred would be awesome to do as one call
16:41:58 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Fix basepython setting in tox.ini https://review.openstack.org/523915
16:56:42 openstackgerrit Merged openstack/python-openstackclient master: Set correct designate endpoint in docs https://review.openstack.org/523567
17:17:33 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: DNM: Test -tips variations https://review.openstack.org/523938
18:07:32 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Fix basepython setting in tox.ini https://review.openstack.org/523915
18:07:33 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Avoid tox_install.sh for constraints support https://review.openstack.org/508061
18:08:26 Kvisle Hi! I can see that https://review.openstack.org/#/c/522004/ looks good with review, but it doesn't seem to be merged yet. Do I need to do anything?
18:10:13 Shrews Kvisle: No. Just waiting for mordred to have a chance to look it over first.
18:10:22 Kvisle Ah =)
18:14:18 mordred Kvisle: +A - thanks!
18:15:31 Kvisle \o/
18:20:29 Shrews mordred: that's an interesting error you got there on that image sorting fix. rsync seems to think there's a MITM attack
18:21:30 mordred Shrews: yay!
18:21:34 Shrews http://logs.openstack.org/93/523893/1/gate/openstack-tox-py27/8ddfac1/ara/result/38e984ce-db99-4dac-8399-5e4002a0025b/
18:25:03 mordred Shrews: that sounds like a thing we should bring up over in infra land
18:25:12 Shrews k
18:35:09 thingee mordred: I'm still interested on working on oaktree. I read through the brain dump email and appreciate you writing that up, finally ;)
18:37:28 thingee mordred: I would like to keep my core seat please.
18:40:07 cdent I’d like to work on oaktree too, but I’m struggling to think I’ll have the time :(
18:51:47 openstackgerrit Merged openstack-infra/shade master: Implement availability_zone_hints for networks and routers. https://review.openstack.org/522004
19:06:37 Shrews just for the record, if oaktree attempts to handle more than just openstack clouds (which is already insanely complex), it will be doomed to failure. <EOM>
19:35:30 cdent Shrews++
19:43:18 SamYaple Shrews: all we gotta do is abstract a little bit more. easy peasy
19:44:52 openstackgerrit Harald Jensås proposed openstack/python-openstackclient master: Allow setting network-segment on subnet update https://review.openstack.org/523974
19:48:02 thingee Shrews: +1
20:18:38 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: DNM: Test -tips variations https://review.openstack.org/523938
20:32:38 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: DNM: Test -tips variations https://review.openstack.org/523938
20:55:44 openstackgerrit Harald Jensås proposed openstack/python-openstackclient master: Allow setting network-segment on subnet update https://review.openstack.org/523974
21:04:56 mordred thingee: woot. sorry it took me so long to get that down on paper in any useful way
21:05:06 mordred SamYaple: agree
21:05:39 mordred cdent: I'm going to give you core for now, just because - if it doesn't work out, no biggie
21:06:20 cdent mordred: I think I can handle that responsibly. Thanks.
21:09:35 openstackgerrit Merged openstack/python-openstacksdk master: Sort image update results before comparing https://review.openstack.org/523893
21:09:35 openstackgerrit Merged openstack/python-openstacksdk master: Add ability to work in other auth contexts https://review.openstack.org/522970
21:09:37 openstackgerrit Merged openstack/python-openstacksdk master: Add helper property to get the current user id https://review.openstack.org/522971
21:09:38 openstackgerrit Merged openstack/python-openstacksdk master: Remove reference to context-managers from release note https://review.openstack.org/522972
21:09:38 openstackgerrit Merged openstack/python-openstacksdk master: Document current_user_id in a release note https://review.openstack.org/522973
21:10:53 SamYaple mordred: ill try to get on the rest of the reviews after i land in denver
21:11:07 SamYaple keep them small and ill keep reviewing :P
21:18:18 mordred SamYaple, Shrews: I think we need a tag or a topic or something to mark "this already landed in shade or os-client-config and is just a cherry-pick to get them up to date" vs. "this is actual code that needs actual review other than 'do the tests pass'"
21:19:35 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: DNM: Test -tips variations https://review.openstack.org/523938
21:20:32 dtroyer mordred: at what point would you want to reverse that? ie, SDK is source of truth and shade/occ are 'backports'? when they become shims?
21:22:01 openstackgerrit Monty Taylor proposed openstack/cliff master: Use in-tree cliffdemo app for docs build https://review.openstack.org/515016
21:22:02 openstackgerrit Monty Taylor proposed openstack/cliff master: Move doc requirements to doc/requirements.txt https://review.openstack.org/522369
21:22:02 openstackgerrit Monty Taylor proposed openstack/cliff master: Remove tox_install.sh and just pass -c in tox https://review.openstack.org/523984
21:22:25 openstackgerrit Monty Taylor proposed openstack/cliff master: DNM testing docs and releasenotes jobs https://review.openstack.org/522370
21:25:11 mordred dtroyer: yah- when they become shims
21:25:35 mordred dtroyer: and hopefully at that point we don't have to do any cherry-picking/backports *fingers crossed*
21:35:17 openstackgerrit Julia Kreger proposed openstack-infra/shade master: De-client-ify many baremetal calls https://review.openstack.org/523986
21:35:18 openstackgerrit Julia Kreger proposed openstack-infra/shade master: Fix operator cloud get_nic_by_mac https://review.openstack.org/523987
21:35:20 openstackgerrit Julia Kreger proposed openstack-infra/shade master: De-client-ify fixed method get_nic_by_mac https://review.openstack.org/523988
21:35:21 openstackgerrit Julia Kreger proposed openstack-infra/shade master: Remove python-ironicclient https://review.openstack.org/523989
21:37:32 openstackgerrit Monty Taylor proposed openstack-infra/shade master: Avoid tox_install.sh for constraints support https://review.openstack.org/508061
21:37:33 Shrews mordred: maybe. i just compared git logs to discover that, but if it would help others, fine with me
21:39:25 Shrews mordred: there is a git option to leave a "cherry picked" comment, iirc
21:39:37 openstackgerrit Monty Taylor proposed openstack/python-openstacksdk master: Remove use of tox-siblings role https://review.openstack.org/523993
21:39:46 Shrews git cherry-pick -x ... or similar
21:39:59 Shrews i thought git-review carried it over, too
21:40:15 TheJulia -X
21:40:26 TheJulia -x doesn't create the comment
21:41:14 Shrews well boo
21:41:37 Shrews oh, but -X does?
21:41:38 TheJulia c'est la vie
21:41:44 TheJulia yes, it does
21:42:21 Shrews whoomp, there it is
21:44:05 mordred Shrews: neat!
21:44:17 mordred oh- also - wow ... TheJulia do I see a Remove python-ironicclient patch up there???
21:44:52 TheJulia mordred: is it too early to consider it a birthday gift?
21:45:39 TheJulia mmm whisky
21:46:42 TheJulia Seriously though, Yes, I hope it is right. Unit tests pass locally, which is a good sign. I fired up a dnm test on bifrost to pull it in and see if it breaks. I also moved my wip tag accordingly.
21:48:59 Shrews we should, ya know, merge that and stuff
21:50:03 TheJulia Shrews: yeah, for some reason my removal of my wip tag earlier today from the patch chain didn't take... :\
21:50:35 mordred TheJulia, Shrews: +2 with comment on https://review.openstack.org/#/c/499774/3 - comment applies to the previous patch too (which is already +A'd) - I think it's totally fine for us to deal with in a followup
21:52:06 mordred TheJulia: also, I think there is a rebase oops in https://review.openstack.org/#/c/500119/3
21:52:24 openstackgerrit Merged openstack-infra/shade master: Fix basepython setting in tox.ini https://review.openstack.org/523915
21:53:16 TheJulia mordred: replied, and agreed, I'll rip that out in the morning.
21:53:25 Shrews what's funny is, that it still passed tests
21:53:44 Shrews s/funny/sad/ ??
21:54:18 TheJulia wow... fun rebase failure :(
21:57:07 openstackgerrit Julia Kreger proposed openstack-infra/shade master: De-clientify baremetal create/delete https://review.openstack.org/500119
21:57:14 openstackgerrit Julia Kreger proposed openstack-infra/shade master: De-client-ify baremetal machine port list https://review.openstack.org/500120
21:57:30 mordred TheJulia: AHA - normalize_machines only removes novaclient noise - I was wondering how the old method worked with normalize_machines(MachienPortList()) :)
21:58:06 TheJulia mordred: my guess, cp -a python-novaclient python-ironicclient
22:01:17 mordred TheJulia: also, left a note for later in https://review.openstack.org/#/c/500119 - I don't think we should do anything about it today or tomorrow
22:01:30 mordred TheJulia: thank you for leaving the comment there though - it was very helpful :)

Earlier   Later