Posted	Nick	Remark
#openstack-sdks - 2017-11-15
17:47:21	openstackgerrit	Monty Taylor proposed openstack/python-openstacksdk master: Add jobs for Zuul v3 https://review.openstack.org/518130
17:47:22	openstackgerrit	Monty Taylor proposed openstack/python-openstacksdk master: Fix magnum functional test https://review.openstack.org/518946
17:47:22	openstackgerrit	Monty Taylor proposed openstack/python-openstacksdk master: Handle glance image pagination links better https://review.openstack.org/518131
17:47:22	openstackgerrit	Monty Taylor proposed openstack/python-openstacksdk master: Fix regression for list_router_interfaces https://review.openstack.org/518132
17:47:23	openstackgerrit	Monty Taylor proposed openstack/python-openstacksdk master: Support filtering servers in list_servers using arbitrary parameters https://review.openstack.org/518133
17:47:23	openstackgerrit	Monty Taylor proposed openstack/python-openstacksdk master: Migrate to testtools for functional tests https://review.openstack.org/518799
17:47:24	openstackgerrit	Monty Taylor proposed openstack/python-openstacksdk master: Rework config and rest layers https://review.openstack.org/519029
17:48:55	mordred	SamYaple, dtroyer: I had to fix a requirements sync issue in the first patch: https://review.openstack.org/#/c/518128 - but also fixed comments from briancurtin - could use a re-kick on that and https://review.openstack.org/#/c/518129
17:50:42	mordred	SamYaple, Shrews: also - if you get a sec, https://review.openstack.org/#/c/518799 could use a second +2 / +A
17:52:59	SamYaple	we should build a site where we can trade reviews. you scratch my back ill scratch yours kinda deal
17:53:08	Shrews	mordred: oh you don't want me reviewing the sdk code. i've never even looked at it, so not comfortable approving things (which i'm surprised i can do)
17:53:50	SamYaple	Shrews: these patches are lots of syncing sdk with shade
17:54:02	SamYaple	or at least the onesim reviewing
17:55:03	mordred	Shrews: yah - this is the 'sync shade' series - most of that patch is "make the sdk tests use the shade base test class"
17:55:42	Shrews	even still
17:55:57	mordred	Shrews: that said - obvs don't review/vote on anything you're not comfortable reviewing/voting on - but I'll definitely be poking you as we do more things to the shade code
17:56:39	openstackgerrit	Monty Taylor proposed openstack/python-openstacksdk master: Add notes about moving forward https://review.openstack.org/501438
17:56:39	openstackgerrit	Monty Taylor proposed openstack/python-openstacksdk master: Move task_manager and adapter up a level from cloud https://review.openstack.org/519772
17:57:15	mordred	Shrews: case in point - ^^ that touches the task_manager stuff in a way that affects both the sdk and the shade code, so if you have time, I'd love your eyes at least on the 'shade' half
17:59:24	Shrews	mordred: as a compromise, i will be glad to +1, maybe +2, things. i'll let someone else +A
17:59:44	mordred	++
18:00:06	mordred	Shrews: mostly if you see evil/bad things tell me I'm stupid :)
18:04:58	SamYaple	no more operator/openstackcloud seperation going forward, correct?
18:08:00	Shrews	SamYaple: no need for it at this point
18:08:35	SamYaple	+1
18:09:14	SamYaple	it seemed like a clever idea initially. but its just been annoying to me when writing ansible/salt modules to use shade
18:15:21	Shrews	mordred: left a not-a-minus-1 comment on https://review.openstack.org/518130 given our discovery in shade
18:41:31	openstackgerrit	Monty Taylor proposed openstack/python-openstacksdk master: Remove bogus and unneeded role from job definition https://review.openstack.org/520173
18:41:40	mordred	Shrews: ^^ thanks. fixed
19:16:04	openstackgerrit	Merged openstack-infra/shade master: Remove unnecessary roles reference https://review.openstack.org/520140
19:26:06	SamYaple	huh. are openstacksdk merged messages not dumping out here?
19:34:19	frickler	SamYaple: only for master branch
19:34:28	openstackgerrit	Merged openstack/python-openstacksdk master: Add jobs for Zuul v3 https://review.openstack.org/518130
19:37:39	openstackgerrit	Merged openstack/python-openstacksdk master: Fix magnum functional test https://review.openstack.org/518946
19:38:13	SamYaple	ah
19:38:19	openstackgerrit	Merged openstack/python-openstacksdk master: Handle glance image pagination links better https://review.openstack.org/518131
19:38:29	openstackgerrit	Merged openstack/python-openstacksdk master: Fix regression for list_router_interfaces https://review.openstack.org/518132
19:39:26	SamYaple	mordred: youre worse than me with self-approving!
20:12:01	mordred	SamYaple: well - those were just mechanical cherry-picks - let's use people's review bandwidth for the harder stuff where feedback matters :)
20:17:09	SamYaple	mordred: i always come up with reasons too
20:17:17	mordred	SamYaple: :)
20:17:20	SamYaple	:)
20:56:02	openstackgerrit	Merged openstack-infra/shade master: Fix creating a server with specifying scheduler_hints https://review.openstack.org/519705
21:45:40	openstackgerrit	OpenStack Proposal Bot proposed openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/520169
22:28:51	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient master: Network: Add interfaces info in router show https://review.openstack.org/477728
23:35:01	openstackgerrit	Merged openstack/python-openstackclient master: Add RemoveNetwork command to server https://review.openstack.org/515453
23:48:15	openstackgerrit	Merged openstack/python-openstacksdk master: Support filtering servers in list_servers using arbitrary parameters https://review.openstack.org/518133
23:48:17	openstackgerrit	Merged openstack/python-openstacksdk master: Migrate to testtools for functional tests https://review.openstack.org/518799
23:48:19	openstackgerrit	Merged openstack/python-openstacksdk master: Rework config and rest layers https://review.openstack.org/519029
#openstack-sdks - 2017-11-16
00:03:33	openstackgerrit	Merged openstack/osc-lib master: Add CLI/ENV options and documentation for keystone-to-keystone https://review.openstack.org/513828
00:03:34	openstackgerrit	Merged openstack/python-openstackclient master: Show detailed message of neutron exception https://review.openstack.org/519831
00:43:00	openstackgerrit	Merged openstack/python-openstacksdk master: Add notes about moving forward https://review.openstack.org/501438
01:45:56	openstackgerrit	Merged openstack/python-openstackclient master: Network: Add interfaces info in router show https://review.openstack.org/477728
06:32:49	openstackgerrit	chenyb4 proposed openstack/python-openstacksdk master: Add block_store support single volume display image message https://review.openstack.org/519244
06:35:08	openstackgerrit	chenyb4 proposed openstack/python-openstacksdk master: Add cluster support force delete parameter when cluster/node delete https://review.openstack.org/518874
07:59:11	openstackgerrit	OpenStack Proposal Bot proposed openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/520169
08:36:39	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/python-openstacksdk master: Avoid default mutable values in arguments https://review.openstack.org/510870
10:58:20	openstackgerrit	OpenStack Proposal Bot proposed openstack-infra/shade master: Updated from global requirements https://review.openstack.org/520379
11:00:40	openstackgerrit	OpenStack Proposal Bot proposed openstack/cliff master: Updated from global requirements https://review.openstack.org/520389
11:07:07	openstackgerrit	OpenStack Proposal Bot proposed openstack/keystoneauth master: Updated from global requirements https://review.openstack.org/520418
11:19:46	openstackgerrit	OpenStack Proposal Bot proposed openstack/os-api-ref master: Updated from global requirements https://review.openstack.org/520469
11:20:01	openstackgerrit	OpenStack Proposal Bot proposed openstack/os-client-config master: Updated from global requirements https://review.openstack.org/520472
11:20:16	openstackgerrit	OpenStack Proposal Bot proposed openstack/os-service-types master: Updated from global requirements https://review.openstack.org/520475
11:20:48	openstackgerrit	OpenStack Proposal Bot proposed openstack/osc-lib master: Updated from global requirements https://review.openstack.org/520481
11:25:43	openstackgerrit	OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/520518
11:26:07	openstackgerrit	OpenStack Proposal Bot proposed openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/520169
14:29:59	openstackgerrit	Monty Taylor proposed openstack/python-openstacksdk master: Remove ansible functional tests for now https://review.openstack.org/520602
14:57:44	openstackgerrit	Merged openstack-infra/shade master: Updated from global requirements https://review.openstack.org/520379
15:04:08	openstackgerrit	Merged openstack/python-openstacksdk master: Move task_manager and adapter up a level from cloud https://review.openstack.org/519772
15:04:09	openstackgerrit	Merged openstack/python-openstacksdk master: Remove bogus and unneeded role from job definition https://review.openstack.org/520173
15:05:57	openstackgerrit	Merged openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/520169
15:14:30	openstackgerrit	Merged openstack/python-openstacksdk master: Avoid default mutable values in arguments https://review.openstack.org/510870
15:17:04	openstackgerrit	Jose Castro Leon proposed openstack/python-openstackclient master: Add support for endpoing filter commands https://review.openstack.org/520614
15:44:53	openstackgerrit	Jose Castro Leon proposed openstack/python-openstackclient master: Add support for endpoing group commands https://review.openstack.org/520627
15:50:17	openstackgerrit	Jose Castro Leon proposed openstack/python-openstackclient master: Add support for endpoing filter commands https://review.openstack.org/520614
17:01:50	openstackgerrit	Monty Taylor proposed openstack-infra/shade master: Cleanup objects that we create on behalf of images https://review.openstack.org/520652
17:01:52	openstackgerrit	Monty Taylor proposed openstack-infra/shade master: Add method to cleanup autocreated image objects https://review.openstack.org/520653
17:07:47	openstackgerrit	Merged openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/520518
17:48:48	openstackgerrit	Andreas Jaeger proposed openstack-infra/shade master: Remove setting of version/release from releasenotes https://review.openstack.org/520667
18:39:15	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient master: Prepare for os-clinet-config to go away https://review.openstack.org/520675
19:07:27	openstackgerrit	Monty Taylor proposed openstack/python-openstackclient master: Add logic to handle old and new sdk constructor https://review.openstack.org/520688
19:07:55	mordred	dtroyer: ^^ we seem to have both been thinking about the same general area this morning :)
19:11:04	dtroyer	Nice, thanks. That'll work for now, eventually the SDK instantiation should move to Clientmanager directly…
19:13:23	openstackgerrit	Merged openstack-infra/shade master: Remove setting of version/release from releasenotes https://review.openstack.org/520667
19:59:05	mordred	dtroyer: ++
21:05:46	openstackgerrit	Andreas Jaeger proposed openstack/os-client-config master: Remove setting of version/release from releasenotes https://review.openstack.org/520790
21:06:26	openstackgerrit	Andreas Jaeger proposed openstack/osc-lib master: Remove setting of version/release from releasenotes https://review.openstack.org/520791
21:13:42	dklyle	dtroyer, openstackclient question if you have a minute
21:13:56	dtroyer	dklyle: sure
21:14:08	dklyle	OS_DOMAIN_ID is from the project scoped token?
21:14:25	dklyle	not the user's domain, but the project domain?
21:15:22	dklyle	Horizon doesn't provide that value, but gophercloud requires it, want to provide the proper value
21:15:31	dklyle	in the openrc file
21:16:49	dklyle	I'm missing something in the openstackclient code as I couldn't tell where the env is read
21:17:00	dklyle	only some documentation
21:17:24	dtroyer	it's a ksa thing actually, and the exact context depends on which plugin is in use
21:17:44	dtroyer	but this question should be answerable…I'm looking through KSA now
21:18:05	dklyle	ksa is the piece I was missing
21:19:03	dtroyer	but for gophercloud anting it, I have no idea if that uses things in the same way
21:19:17	dtroyer	it should, for all of our sanity

Earlier   Later