Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2017-08-09
21:25:02 efried As I'm deprecating old opts with new adapter ones...
21:25:07 mordred ooh. that sounds like fun
21:25:15 efried The option comes through to the real code correctly, but in UT when we do CONF.set_override, it doesn't.
21:25:39 mordred I love it when there's a bug in unittests that is just a bug in unittests
21:25:59 efried That's not very clear. Here: (dhellmann this might interest you)
21:26:50 efried I've got an option 'old'. I deprecate it in favor of 'new' by registering a DeprecatedOpt. I set up my conf to contain old = 'foo'. In my actual code, I can see CONF.old == 'foo' and CONF.new == 'foo', which is how deprecation aliases are s'posed to work.
21:26:52 efried BUT
21:27:17 efried When I say CONF.set_override(old='bar')
21:27:31 efried ...now CONF.old == 'bar' but CONF.new still == 'foo'.
21:47:45 dhellmann efried : that sounds like a bug. The original version of the deprecation stuff didn't support using the old name in code, because you were supposed to update all of those references at the same time. When mtreinish added that feature for tempest, we missed some access paths.
21:48:45 dhellmann efried : my own position is that I would expect all references to the old option name to be updated when the deprecated option is registered, so that the only place one should see that old name is in an old configuration file
21:59:04 efried dhellmann That makes sense to me. Ergo I wouldn't expect someone to use CONF.set_override('old', ...) at all... except in unit tests to prove that stuff still works if the deprecated conf option is used ;-)
21:59:19 efried (in the conf)
22:41:59 efried dhellmann (mordred) https://bugs.launchpad.net/oslo.config/+bug/1709728
22:42:00 openstack Launchpad bug 1709728 in oslo.config "CONF.set_override doesn't alias deprecated opts" [Undecided,New]
23:03:30 efried mordred Does endpoint_filter={'interface': ['internal', 'public']} work as an arg to Session.request??
23:03:48 efried Cause doesn't that endpoint_filter wind up in requests.Session?
23:11:52 mordred efried: no - requests doesn't know anything about endpoint_filter
23:12:11 efried mordred I must not have traced it through right, then.
23:12:16 mordred efried: session.request(endpoint_filter={'interface': ['internal', 'public']}) SHOULD work and if it doesn't somethig is broke
23:12:43 efried mordred We'll find out in https://review.openstack.org/492247
23:14:46 mordred efried: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L599
23:16:04 efried mordred Beaut. But https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L703 will still send the endpoint filter through, right? It'll just get ignored?
#openstack-sdks - 2017-08-10
00:52:10 mordred efried: yah
11:45:37 openstackgerrit Colleen Murphy proposed openstack/keystoneauth master: Allow discovery URLs to have trailing slashes https://review.openstack.org/492484
13:19:43 openstackgerrit Colleen Murphy proposed openstack/keystoneauth master: Allow discovery URLs to have trailing slashes https://review.openstack.org/492484
14:28:44 openstackgerrit XueFeng Liu proposed openstack/service-types-authority master: It's better to use 'cluster' as senlin's service_type https://review.openstack.org/484011
15:27:54 openstackgerrit Reedip proposed openstack/python-openstackclient master: Allow PD as Subnetpool during Subnet creations https://review.openstack.org/491664
17:19:16 cdent elmiko, edleafe https://etherpad.openstack.org/p/api-wg-newsletter
17:19:59 elmiko ack
17:20:58 edleafe nice touch on the 308
17:21:23 elmiko yeah, love the 308
17:21:26 edleafe wait - do we lose the hyphen?
17:21:42 elmiko uh oh, THIS WASN'T MENTIONED IN THE VOTE!
17:21:42 edleafe IOW, API-WG -> API SIG or API-SIG?
17:23:16 elmiko fwiw, i'm good with that copy cdent
17:23:57 cdent hmmm, yes, to hyphen or not to hyphen
17:24:13 cdent let’s hyphen?
17:24:20 elmiko i had assumed hyphen, but i'm not sure what the idea from the tc was
17:24:27 edleafe I like hyphens
17:24:53 edleafe "You can take my hyphen when you pry it from my cold dead hands!"
17:26:01 edleafe Like all things, the particulars aren't important, as long as we're consistent
17:26:58 cdent hobgoblins
17:28:02 edleafe Seeing as you have "Location: /api-sig/news", let's keep the hyphen
17:28:27 elmiko +1
17:28:27 cdent yeah, I already changed it and sent it
17:29:07 elmiko \o/
17:30:40 edleafe kewl
18:20:20 openstackgerrit Brian Curtin proposed openstack/python-openstacksdk master: Introduce Member for Octavia (load balancing) https://review.openstack.org/451488
19:31:09 openstackgerrit OpenStack Release Bot proposed openstack/python-openstackclient master: Update reno for stable/pike https://review.openstack.org/492660
21:15:09 openstackgerrit Merged openstack/python-openstacksdk master: Update load_balancer for v2 API https://review.openstack.org/454410
21:30:01 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Allow PD as Subnetpool during Subnet creations https://review.openstack.org/491664
21:37:29 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Update release/stable branch table in docs https://review.openstack.org/492699
#openstack-sdks - 2017-08-11
02:50:29 openstackgerrit Rui Chen proposed openstack/python-openstackclient master: [Compute]Make column content readable for both human and machine https://review.openstack.org/445794
07:24:40 openstackgerrit Rui Chen proposed openstack/python-openstackclient master: [Compute]Make column content readable for both human and machine https://review.openstack.org/445794
07:59:08 openstackgerrit Zhaokun Fu proposed openstack/python-openstackclient master: add --password option for openstack server create Closes-Bug:1708570 https://review.openstack.org/490718
09:30:30 openstackgerrit yfzhao proposed openstack/os-client-config master: Fix wrong links https://review.openstack.org/492924
09:42:57 openstackgerrit sudhir agarwal proposed openstack/python-openstackclient master: Replace six.iteritems() with .items() https://review.openstack.org/492929
10:26:37 openstackgerrit Merged openstack/keystoneauth master: Enable some off-by-default checks https://review.openstack.org/477775
12:05:01 _heena_py__ Hi
12:05:25 _heena_py__ I dont know if this is the right IRC but I needed to know a way to fetch cinder volume attachments in python
13:12:55 openstackgerrit Sean Handley proposed openstack/os-client-config master: DataCentred supports Keystone V3 and Glance V2. https://review.openstack.org/493002
14:13:40 openstackgerrit Merged openstack/python-openstackclient master: Update reno for stable/pike https://review.openstack.org/492660
14:36:24 openstackgerrit Merged openstack/python-openstackclient master: Update release/stable branch table in docs https://review.openstack.org/492699
15:43:56 openstackgerrit Merged openstack/python-openstackclient master: Add .htaccess for docs migration https://review.openstack.org/491631
17:26:56 openstackgerrit Merged openstack/osc-lib feature/osc4: Refactor initialize_app() to allow overriding https://review.openstack.org/491846
18:18:14 openstackgerrit Merged openstack/cliff master: Make openstackdocstheme an optional doc dependency https://review.openstack.org/491378
18:31:15 openstackgerrit Merged openstack/os-client-config master: Update the documentation link for doc migration https://review.openstack.org/491374
22:22:17 fried_rice mordred How do you feel about returning a list from ServiceTypes.get_service_data_for_project?
22:50:55 openstackgerrit Eric Fried proposed openstack/os-service-types master: Non-unique project names: by_project as list https://review.openstack.org/493254
22:50:59 fried_rice mordred ^
22:54:49 openstackgerrit Eric Fried proposed openstack/service-types-authority master: Add placement service https://review.openstack.org/462140
22:56:08 fried_rice Made ^ depend on -^
#openstack-sdks - 2017-08-12
11:41:12 openstackgerrit OpenStack Proposal Bot proposed openstack/cliff master: Updated from global requirements https://review.openstack.org/493298
11:50:14 openstackgerrit OpenStack Proposal Bot proposed openstack/os-client-config master: Updated from global requirements https://review.openstack.org/491294
13:14:53 mordred fried_rice: what if instead we don't do project: nova for placement? I think by_project's value is that it can answer the question "what is the service-type that people mean when they say {name}?" - placement is NEVER the answer to that question for name==nova - it just happens to live in the nova repo right now
18:31:47 openstackgerrit Monty Taylor proposed openstack/os-service-types master: Support secondary services https://review.openstack.org/493325
18:34:26 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Add placement service https://review.openstack.org/462140
18:34:26 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Add flag to indicate a service is a secondary service https://review.openstack.org/493326
18:34:48 mordred fried_rice: ok. there's a different stab at the issue
18:36:06 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Add placement service https://review.openstack.org/462140
18:36:06 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Add flag to indicate a service is a secondary service https://review.openstack.org/493326
#openstack-sdks - 2017-08-13
12:55:32 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Convert network segment functional tests to JSON https://review.openstack.org/491612
16:11:35 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Add placement service https://review.openstack.org/462140
16:11:36 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Add flag to indicate a service is a secondary service https://review.openstack.org/493326
16:11:36 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Ensure git rev-parse output works in python3 https://review.openstack.org/493361
16:11:37 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Use consistent url schemes https://review.openstack.org/493362
16:11:37 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Only run json.dump once https://review.openstack.org/493363
16:11:38 openstackgerrit Monty Taylor proposed openstack/service-types-authority master: Add three more transformations https://review.openstack.org/493364
16:11:39 openstackgerrit Monty Taylor proposed openstack/os-service-types master: Support secondary services https://review.openstack.org/493325
16:11:40 openstackgerrit Monty Taylor proposed openstack/os-service-types master: Update unittests to be able to sync latest data https://review.openstack.org/493365
16:11:41 openstackgerrit Monty Taylor proposed openstack/os-service-types master: Consume new mapping fields from service-type-authority https://review.openstack.org/493366
#openstack-sdks - 2017-08-14
06:38:33 openstackgerrit Qearl proposed openstack/python-openstacksdk master: fix the bug that cannot create a listener by openstacksdk https://review.openstack.org/493449
07:55:06 openstackgerrit Qearl proposed openstack/python-openstacksdk master: The patch is fix the bug that cannot create a listener by openstacksdk https://review.openstack.org/493449
08:28:54 openstackgerrit Colleen Murphy proposed openstack/keystoneauth master: Allow discovery URLs to have trailing slashes https://review.openstack.org/492484
10:33:11 openstackgerrit Qearl proposed openstack/python-openstacksdk master: fix the bug that cannot create a listener by openstacksdk https://review.openstack.org/493449
13:01:57 efried mordred Okay. It ain't pretty, but it's better than breaking compatibility I suppose.
13:02:13 efried Though then you went and did that with https://review.openstack.org/#/c/493366
13:11:03 openstackgerrit Merged openstack/keystoneauth master: Allow discovery URLs to have trailing slashes https://review.openstack.org/492484
13:19:24 efried mordred Why is jenkins ignoring https://review.openstack.org/#/c/493365/ ?

Earlier   Later