| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2017-07-19 | |||
| 13:04:01 | efried | mordred I was about to start tackling cmurphy's comments on https://review.openstack.org/#/c/483604 - any disagreement or guidance before I do that? | |
| 13:07:52 | openstackgerrit | Harry Rybacki proposed openstack/python-openstackclient master: Implied Roles https://review.openstack.org/290253 | |
| 13:36:02 | efried | mordred I can patch up one of those issues, but can you help with the other? I put in some test cases to demonstrate. | |
| 13:36:41 | openstackgerrit | Eric Fried proposed openstack/keystoneauth master: Discourage 'version' and accept 'M.latest' https://review.openstack.org/483604 | |
| 13:39:19 | efried | mordred See my test comments ^^ | |
| 13:40:40 | dtroyer | amotoki: good find! that is totally not where I have been looking... | |
| 13:41:57 | amotoki | dtroyer: i noticed this when I rechecked it just after your project-config change on cinder v1 was merged. | |
| 13:42:36 | amotoki | dtroyer: but it is a case we would like to detect in osc plugin reviews. | |
| 13:43:06 | dtroyer | so it looks like we had multiple problems than… | |
| 13:43:37 | amotoki | good news is karborclient patch has been merged. | |
| 14:22:46 | openstackgerrit | Merged openstack/python-openstacksdk master: Add config param for cluster object https://review.openstack.org/485100 | |
| 15:48:42 | mordred | efried: morning! | |
| 15:48:53 | efried | mordred It has been that. | |
| 15:49:24 | efried | mordred TL;DR the new test cases I put in demonstrate a bug. I'm trying to fix it, would welcome your expertise & help there. | |
| 15:58:05 | mordred | efried: kk. will jump on it in just a sec | |
| 15:58:14 | efried | thx | |
| 16:23:22 | openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Fixed minor review comments and updated docs https://review.openstack.org/485267 | |
| 16:39:13 | openstackgerrit | Merged openstack/keystoneauth master: Add ability to specify a microversion in a request https://review.openstack.org/482746 | |
| 16:46:39 | openstackgerrit | Akihiro Motoki proposed openstack/python-openstackclient master: Disable karborclient until a fixed version is released https://review.openstack.org/485274 | |
| 16:46:51 | openstackgerrit | Michael Johnson proposed openstack/python-openstacksdk master: Introduce Pool for Octavia (load balancing) https://review.openstack.org/449264 | |
| 16:58:05 | openstackgerrit | Michael Johnson proposed openstack/python-openstacksdk master: Introduce Pool for Octavia (load balancing) https://review.openstack.org/449264 | |
| 17:17:43 | efried | mordred Yeah, I can make both `latest` and `M.latest` work there. | |
| 17:23:59 | mordred | efried: the error I'm getting is TypeError: 'NoneType' object has no attribute '__getitem__' | |
| 17:24:33 | efried | mordred Yeah, because [versioned_]data_for is returning None when it should be returning the v3 object. | |
| 17:24:40 | mordred | gotcha - I see it now | |
| 17:24:40 | efried | mordred I'm almost there - hold tight a sec. | |
| 17:24:44 | mordred | kk | |
| 17:38:23 | openstackgerrit | Eric Fried proposed openstack/keystoneauth master: Discourage 'version' and accept 'M.latest' https://review.openstack.org/483604 | |
| 17:38:36 | efried | mordred ^^ checka-checka-check-it-out. | |
| 17:38:47 | efried | cmurphy that was a great find! | |
| 17:42:05 | mordred | efried: ooh, I'm excited | |
| 17:42:39 | efried | mordred And looks like the rest of the chain is now merged, so this is the last thing I'm really antsy about getting into the release. | |
| 17:42:49 | efried | (Others may have antsiness of their own) | |
| 17:43:33 | mordred | efried: beautiful! | |
| 17:44:18 | efried | mordred Okay, do we pester lbragstad edleafe cdent at this point? | |
| 17:46:35 | mordred | efried: and cmurphy :) | |
| 17:46:49 | efried | cmurphy said she was going to be afk today, and we should proceed without her. | |
| 17:47:05 | efried | mordred I believe I have addressed her concern. | |
| 17:47:56 | efried | mordred http://eavesdrop.openstack.org/irclogs/%23openstack-sdks/%23openstack-sdks.2017-07-19.log.html#t2017-07-19T08:54:16 just so you don't think I'm making that up :) | |
| 17:49:34 | mordred | efried: I don't think that at all :) | |
| 17:50:00 | cdent | mordred: efried is a gambling addict, you cannot believe what he says | |
| 17:50:05 | efried | hahahahaha | |
| 17:50:22 | cdent | that coin was for food! | |
| 17:50:44 | efried | cdent Sokay, when I hit the jackpot I'll buy ALL of us food. | |
| 17:50:51 | efried | Gotta play to win. | |
| 17:50:53 | cdent | \o/ | |
| 17:51:08 | cdent | so, where am I supposed to be looking? | |
| 17:51:26 | efried | cdent https://review.openstack.org/#/c/483604/ -- actually, wasn't sure whether you were involved or not (or are a ksa core) | |
| 17:51:26 | lbragstad | ksa version discovery bits? | |
| 17:51:27 | openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Fixed minor review comments and updated docs https://review.openstack.org/485267 | |
| 17:51:49 | efried | lbragstad Yes, specifically M.latest business https://review.openstack.org/#/c/483604 | |
| 17:52:02 | lbragstad | efried: neat | |
| 17:52:05 | mordred | lbragstad: yup. and then that cleanup patch there whih addresses review conerns from cmurphy and samueldmq | |
| 17:52:15 | efried | Oh, right, morgan too... | |
| 17:52:15 | lbragstad | is that the last bit required to land before we can release ksa? | |
| 17:52:45 | mordred | lbragstad: yes - although I'm still holding out hope for the alias patches - but these two are the last required required | |
| 17:52:45 | cdent | efried: i’m not core, but I’ve been following along with that stuff so happy to review | |
| 17:52:47 | lbragstad | our final release for ksa in Pike will be next week | |
| 17:53:04 | cdent | I’m less and less core each day. | |
| 17:53:35 | mordred | cdent, efried: while I have you here: https://review.openstack.org/#/c/484018/ - I pushed up a fifth patch to the series to address the review comments, but then just squashed it all into that one | |
| 17:53:57 | efried | lbragstad Will there be a ksa release this week too? | |
| 17:54:10 | mordred | cdent: tl;dr - after digging further I have come to agree with your original review - and also realized that for our initial uses it's ok to not have it | |
| 17:54:16 | lbragstad | well - next week is the last week for client libraries | |
| 17:54:22 | lbragstad | so for sure next week if not earlier | |
| 17:54:38 | mordred | lbragstad: I thought this week was the freeze week | |
| 17:55:14 | lbragstad | mordred: this week is non-client library freeze | |
| 17:55:40 | efried | lbragstad And ksa counts as a non-client library, yah? | |
| 17:55:41 | lbragstad | https://releases.openstack.org/pike/schedule.html#p-final-lib | |
| 17:55:50 | lbragstad | efried: i guess it does? | |
| 17:57:13 | efried | mordred So to be clear, https://review.openstack.org/#/c/484018/ is now sans cache, with test mixin refactor, etc. all in one? | |
| 17:57:15 | openstackgerrit | Gage Hugo proposed openstack/python-openstackclient master: Add project tags functionality https://review.openstack.org/481284 | |
| 17:57:18 | mordred | lbragstad: yah - I tihnk ksa falls into that bucket so that client libshave a week to incorporate changes from ksa before they freeze | |
| 17:57:34 | lbragstad | mordred: ok - good point | |
| 17:57:42 | cdent | starting off without cache seems sound | |
| 17:57:43 | lbragstad | i was just digging in to the definitions in releases | |
| 17:57:44 | mordred | efried: yup. and the other patches will be anbandoned - left them there for now so that folks can look at the progression if it's helpful | |
| 17:57:59 | lbragstad | yeah - so ksa should release this week | |
| 17:58:02 | mordred | cdent: turns out the two pathches we have to use the lib woudldn't use the cache anyway | |
| 17:58:05 | mordred | cdent: :) | |
| 17:58:15 | cdent | :) | |
| 18:00:08 | openstackgerrit | XueFeng Liu proposed openstack/python-openstacksdk master: Fix `openstack cluster service list` https://review.openstack.org/485299 | |
| 18:29:31 | cdent | mordred: gotta dine but will poke at that stuff by tomorrow morning at the latest | |
| 18:34:03 | jangutter | Is the gate still broken with: Failed to load karborclient.osc.v1.protectables.ShowProtectable: No module named ShowProtectable? | |
| 18:51:51 | openstackgerrit | XueFeng Liu proposed openstack/python-openstacksdk master: Fix comment in services function https://review.openstack.org/485299 | |
| 19:24:52 | openstackgerrit | Merged openstack/python-openstackclient master: Disable karborclient until a fixed version is released https://review.openstack.org/485274 | |
| 21:13:28 | openstackgerrit | Monty Taylor proposed openstack/os-service-types master: Throw an exception on conflicting arguments https://review.openstack.org/485360 | |
| 21:14:12 | mordred | efried: ^^ that should take care of your review feedback. you holding off on a +A of the first patch for a specific thing I should go track down? | |
| 21:45:04 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Fix dynamic names in network functional tests https://review.openstack.org/485363 | |
| 22:27:02 | efried | mordred I'll +A https://review.openstack.org/#/c/484018/ if you're ready for it. | |
| 22:27:16 | mordred | efried: j15 | |
| 22:27:18 | mordred | gah | |
| 22:27:26 | mordred | efried: yes - I think it's good to go | |
| 22:27:34 | efried | mordred Done. | |
| 22:28:40 | mordred | woot | |
| 22:33:28 | efried | mordred https://review.openstack.org/#/c/485360/ reviewed | |
| 22:41:09 | openstackgerrit | Michael Johnson proposed openstack/python-openstacksdk master: Introduce Member for Octavia (load balancing) https://review.openstack.org/451488 | |
| 22:46:45 | openstackgerrit | Michael Johnson proposed openstack/python-openstacksdk master: Introduce Member for Octavia (load balancing) https://review.openstack.org/451488 | |
| 22:53:19 | openstackgerrit | Michael Johnson proposed openstack/python-openstacksdk master: Introduce Member for Octavia (load balancing) https://review.openstack.org/451488 | |
| 23:29:29 | openstackgerrit | Merged openstack/os-service-types master: Implement fetching and accessor methods https://review.openstack.org/484018 | |
| 23:31:10 | openstackgerrit | Merged openstack/service-types-authority master: Remove leading openstack/ from project name https://review.openstack.org/484422 | |