Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2017-05-25
20:52:17 dhellmann makes sense
20:52:28 dhellmann just --null then?
20:52:44 dhellmann not --null-delimited-output?
20:53:27 dtroyer hmmm, it may need to be more specific, to be honest I have been thinking about cribbing the xargs -0 option, not sure if we need to be able to specify the delimiter char
20:53:38 dhellmann oh, -0 works
20:53:56 dhellmann ok, the other thing we talked about was "command extensions"
20:54:00 dhellmann I'm looking at that right now
20:54:04 dtroyer the semantics are not identical to xargs though so maybe that connection is not quite as useful
20:54:17 dhellmann I can either load them from a separate namespace for each use (args, pre, & post hooks)
20:54:34 dhellmann or I can load them from one namespace and expect a class with a specific API for each of those cases
20:54:39 dhellmann any preference?
20:55:01 dhellmann I'll make --null-delimited-output and -0 aliases
20:55:26 dtroyer I've imagined it as a single class with essentially hook methods to override, but I don't have a huge preference yet
20:55:33 dtroyer the alias sounds good
20:55:55 dhellmann ok, I was leaning toward a class, too
20:56:04 dtroyer having a single namespace does feel cleaner
20:56:27 dhellmann I was going to make the namespace the application namespace + cmd_name.replace(' ', '_')
20:56:39 dhellmann then plugins can have their own names
20:56:56 dtroyer sounds good
20:56:58 dhellmann k
21:42:20 dtroyer dhellmann: if you're still around… with the major rev of cliff on the near horizon, do you want to wait for that release for this stuff to land ^^^^
22:55:10 openstackgerrit Merged openstack/os-client-config master: Add helper method to fetch service catalog https://review.openstack.org/464238
22:55:20 openstackgerrit Merged openstack/os-client-config master: Add ironicclient to constructors list https://review.openstack.org/464239
22:55:25 openstackgerrit Merged openstack/os-client-config master: Keep a singleton to support multiple get_config calls https://review.openstack.org/465195
22:55:30 openstackgerrit Merged openstack/os-client-config master: Don't pop from os.environ https://review.openstack.org/468020
23:05:18 openstackgerrit Doug Hellmann proposed openstack/cliff master: add cmd_name argument to CompleteCommand https://review.openstack.org/468195
23:05:19 openstackgerrit Doug Hellmann proposed openstack/cliff master: pass the command name from HelpCommand https://review.openstack.org/468196
23:05:19 openstackgerrit Doug Hellmann proposed openstack/cliff master: add hook for manipulating the argument parser https://review.openstack.org/468197
23:05:20 openstackgerrit Doug Hellmann proposed openstack/cliff master: add hook for get_epilog https://review.openstack.org/468198
23:05:20 openstackgerrit Doug Hellmann proposed openstack/cliff master: add before and after hooks https://review.openstack.org/468199
23:05:35 dhellmann dtroyer : let's see how closely this matches up with what you were thinking ^^
23:10:13 openstackgerrit Doug Hellmann proposed openstack/cliff master: add hook for get_epilog https://review.openstack.org/468198
23:10:14 openstackgerrit Doug Hellmann proposed openstack/cliff master: add before and after hooks https://review.openstack.org/468199
23:10:41 openstackgerrit Merged openstack/os-client-config master: Revert "Revert "Use interface not endpoint_type for keystoneclient"" https://review.openstack.org/464299
#openstack-sdks - 2017-05-26
00:27:59 openstackgerrit Takashi NATSUME proposed openstack/python-openstackclient master: List/show all server migration types https://review.openstack.org/450119
02:47:28 openstackgerrit ZhangHongtao proposed openstack/python-openstackclient master: Add optional parameter "user_id" and "type" to list credentials https://review.openstack.org/468256
03:39:38 openstackgerrit Rui Chen proposed openstack/python-openstackclient master: Replace "Display Name" by "Name" in volume list https://review.openstack.org/423081
10:59:25 RuiChen osc folks, gate-osc-dsvm-functional-tips-ubuntu-xenial-nv no voting jobs failed, seems it's a devstack bug, but not sure, when USE_PYTHON3=True, keystonemiddleware is not installed in py27 lib, that cause uploading image failed because swift (run in py27) can't import keystonemiddleware, I had pushed a bug to trace it
10:59:27 RuiChen https://bugs.launchpad.net/devstack/+bug/1693665
10:59:27 openstack Launchpad bug 1693665 in python-openstackclient "[Gate] gate-osc-dsvm-functional-tips-ubuntu-xenial-nv failed because of uploading image error" [Undecided,New]
10:59:56 RuiChen don't worry, that don't impact patches are merged
11:50:46 Dinesh_Bhor Qiming: ping, have 2 min? I have addressed other review comments but want to discuss one: https://review.openstack.org/#/c/319054/3/openstack/image/v2/image.py@117
11:54:24 Dinesh_Bhor Qiming: you there?
17:29:11 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/468495
#openstack-sdks - 2017-05-27
14:58:24 openstackgerrit caoyuan proposed openstack/python-openstackclient master: Correct the command to list dhcp agent https://review.openstack.org/468652
16:47:09 openstackgerrit Yuval Shalev proposed openstack/python-openstacksdk master: Added server console output method https://review.openstack.org/468078
17:36:18 openstackgerrit Yuval Shalev proposed openstack/python-openstacksdk master: Added server console output method https://review.openstack.org/468078
18:10:12 openstackgerrit Yuval Shalev proposed openstack/python-openstacksdk master: Added server console output method https://review.openstack.org/468078
#openstack-sdks - 2017-05-28
14:16:55 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add guidelines on Version Discovery https://review.openstack.org/459710
14:16:56 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add document describing consuming version discovery https://review.openstack.org/459405
#openstack-sdks - 2017-05-29
09:05:58 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add direction field to QoS bandwidth limit. https://review.openstack.org/458056
11:12:49 Dinesh_Bhor Qiming_: ping, you there?
11:55:30 Qiming_ hi, Dinesh_Bhor
11:56:00 Dinesh_Bhor Qiming_: do you have 5 min? want to discuss your review comment
11:56:08 Qiming_ sure
11:56:19 Dinesh_Bhor Qiming_: I have addressed your other comments but want to discuss this: https://review.openstack.org/#/c/319054/3/openstack/image/v2/image.py@117 comment
11:56:27 Dinesh_Bhor Qiming_: With my understanding you are saying that If there are 10 attributes to the image and if user wants to update name and visibility then user will have to give all 10 attributes in input dict with updated values of name and visibility.
11:57:34 Qiming_ yes, that was my understanding
11:57:52 Qiming_ the server is supposed to parse the difference between the updated resource and the existing one
12:00:22 Dinesh_Bhor Qiming_: ok, do you have any existing example in SDK as you said it is consistent with other apis?
12:00:38 Dinesh_Bhor Qiming_: It will help me to understand it...
12:00:59 Qiming_ the expected user code is something like this:
12:01:19 Qiming_ image = sdk.image.get_image(name_or_id)
12:01:35 Qiming_ image.name = 'new_name'
12:02:20 Qiming_ sdk.image.update_image(image, **image.to_dict())
12:03:39 Dinesh_Bhor Qiming_: aah, ohk, got it. thanks
12:03:46 Qiming_ np
12:40:52 openstackgerrit Akihiro Motoki proposed openstack/python-openstackclient master: Network L3 Router Commands for OSC https://review.openstack.org/385729
14:04:15 openstackgerrit caoyuan proposed openstack/python-openstackclient master: Correct the command to list dhcp agent https://review.openstack.org/468652
17:10:12 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/python-openstacksdk master: Add new parameter "is_default" to Network QoS policy. https://review.openstack.org/430363
22:00:11 openstackgerrit Merged openstack/keystoneauth master: Add global_request_id param to Adapter constructor https://review.openstack.org/467991
22:33:40 Charlie816 Hi
22:34:22 Charlie816 I am here to perform a requested task.
23:07:20 openstackgerrit Akihiro Motoki proposed openstack/cliff master: sphinxext: Show metavar of positional args https://review.openstack.org/468971
23:07:50 openstackgerrit Akihiro Motoki proposed openstack/cliff master: sphinxext: Show metavar of positional args https://review.openstack.org/468971
#openstack-sdks - 2017-05-30
00:24:13 stevemar dhellmann: are the patches for https://review.openstack.org/#/q/topic:command-extensions related to OSC plugins? to extend quota and the such?
00:45:44 openstackgerrit Akihiro Motoki proposed openstack/python-openstackclient master: volume functest: ensure snapshots deleted when volume delete https://review.openstack.org/466507
01:10:34 openstackgerrit Merged openstack/cliff master: Ensure python standard argparse module is loaded https://review.openstack.org/466271
06:58:54 openstackgerrit Merged openstack/python-openstacksdk master: Add new parameter "is_default" to Network QoS policy. https://review.openstack.org/430363
07:13:29 openstackgerrit Akihiro Motoki proposed openstack/python-openstackclient master: volume functest: ensure snapshots deleted when volume delete https://review.openstack.org/466507
08:37:27 openstackgerrit Yuval Shalev proposed openstack/python-openstacksdk master: Added server console output method https://review.openstack.org/468078
09:14:38 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add new parameter "is_default" to Network QoS policy. https://review.openstack.org/432260
09:39:04 openstackgerrit Vu Cong Tuan proposed openstack/python-openstackclient master: Trivial fix typos https://review.openstack.org/469027
11:14:41 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add new parameter "is_default" to Network QoS policy. https://review.openstack.org/432260
11:29:43 openstackgerrit Yuval Shalev proposed openstack/python-openstacksdk master: Added server console output method https://review.openstack.org/468078
11:31:53 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: Start using 'cliff.sphinxext' https://review.openstack.org/452861
11:31:54 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: Convert 'server' commands to use autoprogram https://review.openstack.org/458452
11:45:15 openstackgerrit Stephen Finucane proposed openstack/cliff master: sphinxext: Generate better usage examples https://review.openstack.org/469063
11:45:15 openstackgerrit Stephen Finucane proposed openstack/cliff master: sphinxext: Allow configuration of ignorable options https://review.openstack.org/469064
12:57:48 openstackgerrit Stephen Finucane proposed openstack/cliff master: sphinxext: Allow configuration of ignorable options https://review.openstack.org/469064
13:08:45 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: Start using 'cliff.sphinxext' https://review.openstack.org/452861
13:08:45 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: Convert 'server' commands to use autoprogram https://review.openstack.org/458452
13:11:55 sfinucan dtroyer: When you're back, fancy taking a look at those two patches to integrate cliff.sphinxext into OSC again? ^
13:16:52 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add returning EndpointData objects from discovery https://review.openstack.org/469084
13:16:54 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Rework EndpointData construction to normalize catalog first https://review.openstack.org/469085
13:16:55 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Move version discovery logic to keystoneauth1.discover https://review.openstack.org/469086
13:16:56 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add url manipulation and microversion collection https://review.openstack.org/469087
13:16:57 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add flags to turn discovery on and off https://review.openstack.org/469088
13:16:58 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Support explicitly requesting the 'latest' version https://review.openstack.org/469089
13:16:59 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Add support for version ranges https://review.openstack.org/469090

Earlier   Later