Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2017-05-18
02:11:47 openstackgerrit Qiming Teng proposed openstack/osc-lib master: Remove support to deprecated '--profile' option https://review.openstack.org/465782
03:33:09 openstackgerrit Qiming Teng proposed openstack/osc-lib master: Remove support to deprecated '--profile' option https://review.openstack.org/465782
03:35:33 openstackgerrit Rui Chen proposed openstack/python-openstackclient master: Refactor Extension show and list command https://review.openstack.org/449757
04:04:14 openstackgerrit Rui Chen proposed openstack/python-openstackclient master: [Compute]Make column content readable for both human and machine https://review.openstack.org/445794
07:03:12 openstackgerrit Rui Chen proposed openstack/python-openstackclient master: [Compute]Make column content readable for both human and machine https://review.openstack.org/445794
08:50:16 openstackgerrit Carlos Goncalves proposed openstack/python-openstackclient master: Add 'data_plane_status' option to Port classes https://review.openstack.org/458626
09:38:04 openstackgerrit Rui Chen proposed openstack/python-openstackclient master: Create server with security group ID and name https://review.openstack.org/462076
11:28:47 cdent mordred: are all of your current gerrit submission for api-wg still legit and currently appropriately based etc?
11:28:49 openstackgerrit Merged openstack/api-wg master: Print name of violating file in unittest https://review.openstack.org/462813
11:54:42 mordred cdent: they're pretty good - lemme take a quick pass ...
11:55:11 cdent mordred: I was seeing some colored dots when browsing around, but that may have been my fault
11:55:24 mordred I blame gerrit
11:55:30 cdent i'm in the process of reviewing some of them
11:56:05 mordred ah - neat. I'll take a pass through them and incorporate your reviews!
12:00:06 cdent i have a tendency to blame gerrit for most things
12:00:11 cdent bad weather today? gerrit
12:12:59 mordred yup
12:13:07 mordred the weather is gerrit's fault
12:14:03 cdent today's hayfever headache is _definitely_ gerrit's fault
12:17:05 mordred so the fun part is that I implemented the version discovery algorithm for one service in shade the other day - and found a place where it's too pedantic and inefficient (yay for matching docs and implementation!) ...
12:17:12 mordred adding an update based on that now :)
12:18:20 cdent yay!
12:21:06 mordred cdent: oh - also - at the forum someone pointed out that microversions use "latest" not "LATEST" - right?
12:22:03 cdent mordred: we had comments about that in one of the reviews, i'm not sure about at forum. The deal with microversions is that 'latest' is a magic token when provided in a request header. it's not used elsewhere (such as discovery doc)
12:22:26 cdent and at least in placement and nova it is _only_ lowercase
12:23:05 mordred cdent: yah - similar here, it would be a magic token that the user could provide as input as part of their request - I figure just making it lowercase to match should allow us to re-use the version matching lib for the version math parts
12:23:42 cdent makes sense
12:25:23 mordred oh - I think sean and I were talking about that and you weren't standing there ... I think the microversion-parse can be used for both major and micro versions
12:26:43 mordred with one exception (will need to add a flag) - which is that "2" for microversions should match the earliest 2.x microversion, and for major versions it should match the latest 2.x major version (only a couple of services publish more than one major version in discovery - but it does happen)
12:26:58 mordred other than that- the hard work is already done
12:27:53 cdent senator I do not recall that conversation
12:28:00 cdent but makes sense
12:28:14 mordred oh - or maybe it's not microversion-parse - that looks like it's just doing the parsing but doesn't have comparison operators
12:28:24 cdent microversion-parse is intentional _super_ simple
12:28:35 cdent return what's in the header, that's it
12:28:44 cdent but with room for future expansion
12:29:24 cdent i've considered moving most of the magic from placement's middleware and Version class into it
12:29:26 cdent but time etc
12:29:28 mordred gotcha. so - I think we were then discussing perhaps a new feature - which is the ability to compare versions with range/wildcard support
12:29:38 mordred yah. I think that's what sdague was likely talking about
12:30:53 mordred and oh-piddle. I thought that I had an optimization to the version discoveyr - but it's only an optimization in a pre-microversions world
12:31:13 mordred since you still need to fetch the discovery document at least once to find the supported microversions
12:31:38 mordred so .... whoops
12:37:19 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add support for historical service type aliases https://review.openstack.org/460654
12:37:19 openstackgerrit Monty Taylor proposed openstack/api-wg master: Change the version format to be ISO format https://review.openstack.org/462988
12:37:20 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add document describing consuming version discovery https://review.openstack.org/459405
12:37:20 openstackgerrit Monty Taylor proposed openstack/api-wg master: Describe the publication of service-types-authority data https://review.openstack.org/462815
12:37:21 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add guideline about consuming endpoints from catalog https://review.openstack.org/462814
12:52:20 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add guidelines on Version Discovery https://review.openstack.org/459710
12:52:21 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add document describing consuming version discovery https://review.openstack.org/459405
12:52:32 mordred aw. I scared cdent away
12:56:20 mordred sdague, elmiko, edleafe: ^^ that stack should be solid now - I believe it needs to be re-organized a little bit to be clearer about "this is advice for deployers" nad "this is advice for developers" and "this is advice for consumers" ... but I'd like to wait until we're happy with the content and maybe even have landed it before doing that
12:56:35 mordred otherwise I think it's extra churn that will hurt folks ability to do followup reviews
13:15:11 Dinesh_Bhor Qiming: ping
13:15:37 Qiming yes
13:16:48 Dinesh_Bhor Qiming: There is a patch submitted for fixing a long pending issue: https://review.openstack.org/#/c/319054/3
13:16:57 openstackgerrit Merged openstack/keystoneauth master: Updated from global requirements https://review.openstack.org/465255
13:17:24 Qiming Dinesh_Bhor, looking
13:18:13 Dinesh_Bhor Qiming: It will really help if you suggest the approach is correct or not then I will rebase it and open for review
13:18:42 Qiming Dinesh_Bhor, I was hoping that you are gonna do a rebase first, but anyway
13:19:04 Dinesh_Bhor Qiming: yes, I am going to rebase it
13:32:02 Qiming Dinesh_Bhor, left some comments
13:32:55 Qiming Dinesh_Bhor, I'd suggest you try a rebase first because quite some logic will be different after switching from resource to resource2 as the base class
13:34:59 Dinesh_Bhor Qiming: great, thanks, yes I will rebase it and also address the review comments given by you
13:35:14 Qiming Dinesh_Bhor, thanks
14:24:16 openstackgerrit chenyb4 proposed openstack/python-openstacksdk master: Add compute support server migrate operation https://review.openstack.org/465986
14:26:17 openstackgerrit chenyb4 proposed openstack/python-openstacksdk master: Add compute support server migrate operation https://review.openstack.org/465986
14:40:35 openstackgerrit Hong Hui Xiao proposed openstack/python-openstackclient master: Add vlan_transparent to network show command https://review.openstack.org/465996
15:08:31 openstackgerrit Hong Hui Xiao proposed openstack/python-openstackclient master: Don't show hint about vlan transparent in network set https://review.openstack.org/466002
15:08:35 openstackgerrit chenyb4 proposed openstack/python-openstacksdk master: Add compute support server migrate operation https://review.openstack.org/465986
15:22:16 elmiko mordred: ack, thanks!
16:41:14 cdent elmiko: proof please: https://etherpad.openstack.org/p/api-wg-newsletter
16:42:14 elmiko cdent: reading
16:43:17 elmiko cdent: lgtm, ship it!
16:43:22 cdent rad
16:43:28 elmiko =)
21:33:14 openstackgerrit Monty Taylor proposed openstack/os-api-ref master: WIP Add support for making sub-elements clearer https://review.openstack.org/464255
#openstack-sdks - 2017-05-19
00:48:00 chenyb4 briancurtin, please help me review https://review.openstack.org/#/c/462818/ https://review.openstack.org/#/c/465986/
00:48:11 chenyb4 thanks
02:14:01 openstackgerrit Rui Chen proposed openstack/python-openstackclient master: Create server with security group ID and name https://review.openstack.org/462076
11:40:14 openstackgerrit Monty Taylor proposed openstack/os-api-ref master: WIP Add support for making sub-elements clearer https://review.openstack.org/464255
12:40:09 openstackgerrit Akihiro Motoki proposed openstack/cliff master: Ensure python standard argparse module is loaded https://review.openstack.org/466271
17:19:09 openstackgerrit Akihiro Motoki proposed openstack/cliff master: Ensure python standard argparse module is loaded https://review.openstack.org/466271
20:29:59 openstackgerrit Merged openstack/openstackclient master: Updated from global requirements https://review.openstack.org/440080
#openstack-sdks - 2017-05-20
16:45:40 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add support for historical service type aliases https://review.openstack.org/460654
16:45:40 openstackgerrit Monty Taylor proposed openstack/api-wg master: Change the version format to be ISO format https://review.openstack.org/462988
16:45:41 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add guidelines on Version Discovery https://review.openstack.org/459710
16:45:41 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add document describing consuming version discovery https://review.openstack.org/459405
16:45:42 openstackgerrit Monty Taylor proposed openstack/api-wg master: Describe the publication of service-types-authority data https://review.openstack.org/462815
16:45:42 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add guideline about consuming endpoints from catalog https://review.openstack.org/462814
#openstack-sdks - 2017-05-21
03:21:45 openstackgerrit Reedip proposed openstack/python-openstackclient master: Add default-quota to subnet pool commands https://review.openstack.org/437367
03:39:26 openstackgerrit Akihiro Motoki proposed openstack/python-openstackclient master: volume functest: ensure snapshots deleted when volume delete https://review.openstack.org/466507
04:22:51 openstackgerrit Akihiro Motoki proposed openstack/python-openstackclient master: volume functest: ensure snapshots deleted when volume delete https://review.openstack.org/466507
04:39:00 openstackgerrit Reedip proposed openstack/python-openstackclient master: Add default-quota to subnet pool commands https://review.openstack.org/437367
06:04:37 openstackgerrit Akihiro Motoki proposed openstack/python-openstacksdk master: Network tag support https://review.openstack.org/461194
06:07:48 openstackgerrit Reedip proposed openstack/python-openstackclient master: Add default-quota to subnet pool commands https://review.openstack.org/437367
18:39:47 openstackgerrit Akihiro Motoki proposed openstack/python-openstackclient master: volume functest: ensure snapshots deleted when volume delete https://review.openstack.org/466507
#openstack-sdks - 2017-05-22
09:21:56 openstackgerrit Pavlo Shchelokovskyy proposed openstack/openstackclient master: Explicitly depend on python-openstackclient https://review.openstack.org/439641
11:13:46 openstackgerrit Carlos Goncalves proposed openstack/python-openstackclient master: Add 'data_plane_status' option to Port classes https://review.openstack.org/458626
13:54:55 Qiming dtroyer, mind review this patch when you get a minute? https://review.openstack.org/#/c/465782/ the deprecated option has been there for more than one year now

Earlier   Later