Posted	Nick	Remark
#openstack-sdks - 2017-04-11
14:56:11	amotoki	reedip_: which my comments did you see?
14:56:22	reedip_	I think only the last one :)
14:56:27	reedip_	tag red and tag blue
14:56:42	amotoki	resending some
14:57:25	amotoki	reedip_: I think you now see all :)
14:58:29	reedip_	amotoki : yeah, got all the messages
14:58:44	openstackgerrit	Sean McCully proposed openstack/keystoneauth master: KeystoneAuth should default to system CAFile. https://review.openstack.org/452585
14:58:52	amotoki	so I think we need to implement tag support in SDK and OSC repo
14:59:49	reedip_	amotoki: yeah, I was checking ankur's patch
14:59:54	reedip_	https://review.openstack.org/#/c/443944/
15:00:44	amotoki	reedip_: can you check how we support tag for images?
15:00:54	reedip_	amotoki : yeah , doing that
15:01:06	reedip_	from the link you sent above
15:01:33	amotoki	reedip_: we don't want to have a separate resource 'tag'. 'tag' is just an attribute for networking resources. this is the point.
15:02:07	reedip_	amotoki : okay, thats pretty clearpoiny
15:02:55	reedip_	poiny -> point
15:03:08	amotoki	reedip_: that's the point we agreed on PTG after discussing Steve and Dean
15:03:16	reedip_	ok
15:03:39	amotoki	reedip_: do you want to work on it?
15:04:26	reedip_	amotoki : yes, I will. I will look into how images have implemented it , and ensure that we have --tag as an attribute in OSC
15:05:19	amotoki	reedip_: thanks. I can support the work. 'tag' support is the last remaining part of OSC transition of neutron CLI :)
15:05:38	reedip_	amotoki: yeah , that I saw from the excel sheet :)
15:07:40	amotoki	reedip_: btw, regarding --external/--internal option of osc network list, my patch https://review.openstack.org/#/c/450152/ will address it (though i think you are aware of it)
15:08:50	reedip_	amotoki: yeah, I think someone else also had a similar patch... lemme check
15:09:04	reedip_	no, tht was in OSC, not SDK
15:09:13	reedip_	amotoki: yeah, the patch looked good :)
15:30:14	openstackgerrit	Merged openstack/python-openstacksdk master: Filtering support by is_router_external to network resource https://review.openstack.org/450152
15:45:49	openstackgerrit	Brian Curtin proposed openstack/python-openstacksdk master: Add support for volume attachments in compute v2 https://review.openstack.org/455335
15:50:27	openstackgerrit	Sean McCully proposed openstack/keystoneauth master: KeystoneAuth should default to system CAFile. https://review.openstack.org/452585
16:30:17	openstackgerrit	Monty Taylor proposed openstack/os-client-config master: WIP: Straw man for new format for vendor data https://review.openstack.org/455774
16:34:11	mordred	cdent: ^^ nascent stab at defining a new vendor profile document for occ, with an eye towards having it be something folks running clouds could publish to a well known public location
20:54:03	openstackgerrit	Ed Leafe proposed openstack/api-wg master: Create a set of api interoperability guidelines https://review.openstack.org/421846
#openstack-sdks - 2017-04-12
01:24:18	openstackgerrit	Huanxuan Ao proposed openstack/python-openstackclient master: "--type" should be required option in "network qos rule create" https://review.openstack.org/454575
01:37:49	openstackgerrit	Huanxuan Ao proposed openstack/python-openstackclient master: "--type" should be required option in "network qos rule create" https://review.openstack.org/454575
02:19:17	openstackgerrit	Merged openstack/python-openstackclient master: Add document about renaming OS_ENDPOINT_TYPE to OS_INTERFACE https://review.openstack.org/455252
04:10:30	openstackgerrit	OpenStack Proposal Bot proposed openstack/cliff master: Updated from global requirements https://review.openstack.org/455906
04:13:03	openstackgerrit	OpenStack Proposal Bot proposed openstack/keystoneauth master: Updated from global requirements https://review.openstack.org/455926
04:19:24	openstackgerrit	OpenStack Proposal Bot proposed openstack/openstackclient master: Updated from global requirements https://review.openstack.org/440080
04:19:51	openstackgerrit	OpenStack Proposal Bot proposed openstack/osc-lib master: Updated from global requirements https://review.openstack.org/455972
04:21:53	openstackgerrit	OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/456003
04:21:56	openstackgerrit	OpenStack Proposal Bot proposed openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/456004
06:51:07	RuiChen	hi reedip: I add some comments in https://review.openstack.org/#/c/425515/
06:58:43	reedip	hi RuiChen
06:58:45	reedip	checking
06:59:09	reedip	ok , seem like relevant comments
07:16:09	openstackgerrit	Reedip proposed openstack/osc-lib master: Add MultiKeyValueCommaAction to osc-lib https://review.openstack.org/425515
07:21:44	reedip	RuiChen: updated
07:22:04	reedip	I understood where I was going wrong with the KeyError, handled it separately
07:40:09	RuiChen	reedip: key1=val1,val2 key2=val 3 => {"key1": "val1", "val2"},{"key2": "val3"} the example is still wrong, should be key1=val1,val2,key2=val3 => {"key1": "val1,val2", "key2": "val3"}
07:40:50	RuiChen	reedip: and please fix the release notes
07:47:34	openstackgerrit	Reedip proposed openstack/osc-lib master: Add MultiKeyValueCommaAction to osc-lib https://review.openstack.org/425515
07:47:39	reedip	RuiChen : ^^
09:16:38	openstackgerrit	Merged openstack/api-wg master: Remove reference to nova on version discovery https://review.openstack.org/453744
11:36:36	openstackgerrit	Merged openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/456003
12:25:42	mordred	jamielennox: if you have a sec, could you look at https://review.openstack.org/#/c/452550/ ?
12:26:55	jamielennox	mordred: i had something for this...
12:27:34	mordred	jamielennox: neat! if there is a better way that's awesome :)
12:30:12	jamielennox	mordred: so the plan was that session supports app_name and app_version, and adapter supports client_name and client_version
12:30:33	jamielennox	when nova_client creates the adapter it should pass client_name and client_version
12:31:01	jamielennox	when heat (or whoever) creates the session it passes to novaclient it passes app_name and app_version
12:31:21	jamielennox	so when it talked to multiple clients you would get the correct heat/X novaclient/Y keystoneauth/Z ...
12:31:55	mordred	cool - did we do those?
12:32:04	jamielennox	in a couple of places...
12:32:07	jamielennox	but largely no
12:32:24	mordred	oh - but session and adapter have them - so I can use them it seems perhaps
12:32:49	jamielennox	there was then a session.additional_user_agent list that was for things like os-c-c that fit somewhere in the middle
12:33:13	mordred	jamielennox: awesome. I will rework this patch to make use of that system
12:33:45	mordred	so for example, occ willbe additional_user_agent - shade will be client and nodepool will be app
12:34:11	mordred	(at least, once all the python-*clients are removed)
12:34:12	jamielennox	mordred: yea, that was the intent but it was one of those things that the person who was pushing a lot to have it in lost interest once it was
12:34:18	jamielennox	yep
12:35:03	jamielennox	i feel like additional on session is going to be weird so let me know if you want that tweaked
12:35:43	mordred	kk.
12:35:51	openstackgerrit	Merged openstack/python-openstacksdk master: Updated from global requirements https://review.openstack.org/456004
12:50:23	openstackgerrit	Merged openstack/python-openstacksdk master: Add 'project_id' to Server query parameters https://review.openstack.org/454241
13:45:53	openstackgerrit	yuval shalev proposed openstack/python-openstacksdk master: Add support for volume attachments in compute v2 https://review.openstack.org/455335
13:56:03	openstackgerrit	yuval shalev proposed openstack/python-openstacksdk master: Add support for volume attachments in compute v2 https://review.openstack.org/455335
13:57:46	openstackgerrit	yuval shalev proposed openstack/python-openstacksdk master: Add support for volume attachments in compute v2 https://review.openstack.org/455335
14:19:57	openstackgerrit	yuval shalev proposed openstack/python-openstacksdk master: Add support for volume attachments in compute v2 https://review.openstack.org/455335
14:46:49	openstackgerrit	Monty Taylor proposed openstack/os-client-config master: Add ability to pass in user_agent https://review.openstack.org/452550
14:47:04	mordred	jamielennox: ^^ ok. I think that does things right using the app_name/client_name bits
14:57:59	mordred	jamielennox: also - client_name,client_version are not getting added to the user-agent in keystoneauth
14:58:25	mordred	so setting them on the adapter is possible, but it doesn't change anyting (setting additional_user_agent in the Session _does_ work)
15:01:57	mordred	jamielennox: oh - I see - it happens at request time - so I'm breaking that in shade - I can fix that
15:33:18	openstackgerrit	Monty Taylor proposed openstack/keystoneauth master: Shift additional_user_agent in the stack https://review.openstack.org/456259
15:33:19	openstackgerrit	Monty Taylor proposed openstack/keystoneauth master: Allow setting client name on the Session https://review.openstack.org/456260
16:00:39	reedip_	o/
21:21:22	mordred	edleafe, cdent: https://review.openstack.org/456394 I just made a neutron API spec that I'd love API-WG thoughts on
21:22:25	cdent	mordred: ah, cool, I look forward to reading that tomorrow. i have zero brains left for today
21:23:07	mordred	cdent: braaaaaaains
21:23:17	mordred	cdent: I'm fairly certain it's all wrong
21:23:25	cdent	best way to get started
21:23:27	mordred	cdent: I mean, except for the part where it's an essential feature
21:23:37	mordred	that I am certain I am correct about
21:23:40	mordred	but everythign else is wrong
21:39:33	edleafe	mordred: from an API perspective it seems fine. Maybe split the key type from the "key" key
21:39:45	edleafe	heh - a key named 'key'
21:40:17	edleafe	so the 'keys' list would contain dicts of "comment", "type", and "key"
21:40:36	edleafe	just to make it easier to filter client-side
21:41:10	mordred	edleafe: that'sa great idea

Earlier   Later