| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2017-03-29 | |||
| 07:59:34 | reedip | https://review.openstack.org/#/c/425515/ | |
| 08:00:08 | openstackgerrit | Reedip proposed openstack/osc-lib master: [WIP]Add MultiKeyValueCommaAction to osc-lib https://review.openstack.org/425515 | |
| 08:00:34 | reedip | rabel : can you check this patch , it would avoid you repeating the same code ( probably ) | |
| 08:03:58 | rabel | reedip: i will have a look at it. it would make sense to use your class for my patch once it is merged. | |
| 08:04:29 | reedip | rabel yes . though I wont like to bliock you , so you can add a ToDo for yourself | |
| 08:04:51 | reedip | that ways, everything is perfect, I guess | |
| 08:05:54 | rabel | reedip: it's true that my patch could already be merged without yours. i use the same logic as the --nic implementation. so we could change both to use the new class in a separate patch. | |
| 08:06:13 | reedip | rabel : sounds good ... lets race :D | |
| 08:07:31 | reedip | just kidding, I will push mine a bit slower , but otherwise the code looks good , I will look at it once more though in the evening | |
| 08:09:09 | rabel | :D i added me as a reviewer for your patch. i will have a look at it now and once you finished it, i will review it in detail | |
| 08:13:55 | reedip | :D | |
| 08:32:45 | rabel | reedip: let's see if i understand it right: the difference between MultiKeyValueAction and MultiKeyValueCommaAction is the latter supports something like "--my_param key1=val,ue1,key2=val,ue3", is that right? | |
| 08:33:06 | reedip | something like that | |
| 08:33:15 | reedip | actually exatly liek that | |
| 08:35:56 | rabel | than i think --nic, --network and --port should use MultiKeyValueAction, since we don't have values containing commas or multiple values for a key, i think. | |
| 08:36:14 | rabel | by the way: your patch looks good to me | |
| 08:43:38 | reedip | --network can have IPV4 address, IPv6 address and Network ID | |
| 08:44:18 | reedip | as the addresses are one-to-one, so I guess yes, the multikeyvaluecomma action may not be required | |
| 09:19:39 | RuiChen | hi dtroyer: I add comments in your patch https://review.openstack.org/#/c/450452/ | |
| 12:08:03 | dtroyer | RuiChen: thanks. FWIW, if we have not already set neutron to be the default for help we should do that so we can still do most help wihtout auth. | |
| 12:09:40 | dtroyer | it looks like that is the case… with no auth info, openstack help lists neutron commands now | |
| 14:23:46 | openstackgerrit | Jens Rosenboom proposed openstack/python-openstackclient master: Fix block-device-mapping when volume_size is empty https://review.openstack.org/451432 | |
| 14:32:50 | reedip | o/ | |
| 14:43:11 | frickler | why does e.g. "openstack server show" use compute API v2.1 by default and not something newer? | |
| 14:43:48 | frickler | that way it is not showing some information, like delete_on_termination attribute for volume attachments | |
| 14:45:29 | frickler | seems that was already discussed yesterday, so I'd just say that I'm +1 on "use the latest" | |
| 14:47:49 | openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: [WIP] Introduce Pool resource in Octavia Load Balancer Base https://review.openstack.org/449264 | |
| 16:19:26 | ankur-gupta-f4 | reedip: can you verify or not this bug: https://bugs.launchpad.net/python-openstackclient/+bug/1677252 | |
| 16:19:26 | openstack | Launchpad bug 1677252 in python-openstackclient ""network auto allocated topology create --check-resources" Fails with: "Request requires an ID but none was found"" [Undecided,New] | |
| 16:20:12 | reedip | ankur-gupta-f4 : u r lucky .. I was just drowsing :D | |
| 16:20:24 | ankur-gupta-f4 | ah well then good night :P | |
| 16:20:52 | reedip | ankur-gupta-f4 : this seems to be a bug | |
| 16:21:21 | reedip | jsut checking on master | |
| 16:23:54 | reedip | ankur-gupta-f4 : assigning it to myself with a bit of homework done, rest in another 6 hours I guess | |
| 16:24:31 | reedip | if u have any opinion, please do lemme know | |
| 16:24:52 | ankur-gupta-f4 | K. I have a patch that is blocked till its resolved | |
| 16:25:03 | reedip | ohh then wait | |
| 16:25:22 | ankur-gupta-f4 | do you know where the bug resides? | |
| 16:25:27 | reedip | SDK | |
| 16:25:33 | reedip | request preparation | |
| 16:25:41 | ankur-gupta-f4 | too lazy today to dig in | |
| 16:25:43 | ankur-gupta-f4 | okay | |
| 16:26:25 | reedip | wait | |
| 16:26:57 | reedip | http://paste.openstack.org/show/604690/ | |
| 16:27:50 | reedip | The --check resources is | |
| 16:27:52 | reedip | --check-resources Validate the requirements for auto allocated topology. | |
| 16:27:52 | reedip | Does not return a topology. | |
| 16:28:19 | reedip | ankur-gupta-f4 : I guess the current tenant ID needs to be used up | |
| 16:28:33 | reedip | for aut-allocated-topology with --check-resource | |
| 16:29:11 | ankur-gupta-f4 | so its just not passing, getting from context, the tenant/project id | |
| 16:29:23 | reedip | guess so | |
| 16:29:40 | ankur-gupta-f4 | bah. annoying. | |
| 16:29:57 | reedip | welcome to my world :D | |
| 16:30:20 | reedip | that was the last patch on _proxy | |
| 16:30:25 | reedip | https://github.com/openstack/python-openstacksdk/commit/e5068ec46aa7bb6b1738b8a64c29e44307f4ba98 | |
| 16:30:59 | reedip | seems like it fixed some. broke some | |
| 16:31:03 | reedip | maybe | |
| 16:35:49 | ankur-gupta-f4 | hmmm | |
| 16:36:04 | ankur-gupta-f4 | its weird because the fix from terry was in the last release of the SDK | |
| 16:36:13 | ankur-gupta-f4 | :( | |
| 16:36:21 | reedip | did it have the check for --check-resources? | |
| 16:36:49 | ankur-gupta-f4 | yea --check-resources his the Validate... function in auto_allocated_topology and the changes are there | |
| 16:37:30 | reedip | hmm lem edebug | |
| 16:37:53 | reedip | wait I think my code is not up to date ! | |
| 16:39:00 | reedip | I have 0.9.13 | |
| 16:39:59 | reedip | Upgraded to 0.9.14 and now checking | |
| 16:40:05 | reedip | it works ! | |
| 16:40:10 | reedip | thats weird ! | |
| 16:40:38 | ankur-gupta-f4 | yea | |
| 16:40:53 | ankur-gupta-f4 | its a matter of bumping global reqs | |
| 16:42:04 | reedip | done! | |
| 16:42:34 | reedip | He may have pulled up the master for OSC but not SDK | |
| 16:42:50 | reedip | if he is on Neutron, then lemme drop him a ping | |
| 16:47:40 | ankur-gupta-f4 | briancurtin: here? | |
| 16:48:05 | reedip | ankur-gupta-f4; that bug is now closed ( or would be soon ) | |
| 16:50:45 | ankur-gupta-f4 | k thanks | |
| 16:51:21 | reedip | :) | |
| 17:01:59 | openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: [WIP] Introduce Member for Octavia (loadbalancing) https://review.openstack.org/451488 | |
| 17:28:15 | openstackgerrit | Ankur proposed openstack/python-openstackclient master: Network L3 Router Commands for OSC https://review.openstack.org/385729 | |
| 18:33:47 | openstackgerrit | Sindhu Devale proposed openstack/python-openstackclient master: "floating ip set/unset port" for OSC https://review.openstack.org/383025 | |
| 18:34:14 | openstackgerrit | Sindhu Devale proposed openstack/python-openstackclient master: "floating ip set/unset port" for OSC https://review.openstack.org/383025 | |
| 19:13:25 | openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce Member for Octavia (loadbalancing) https://review.openstack.org/451488 | |
| 19:26:22 | openstackgerrit | Ed Leafe proposed openstack/api-wg master: Recommend the correct HTTP method for tags https://review.openstack.org/451536 | |
| 19:35:30 | dtroyer | frickler: /me catches up a bit | |
| 19:36:26 | dtroyer | The default compute API version is a bit of a mess because it may be set by OSC or by os-client-config. In either case it is '2' or '2.1'. This is equivalent to the Compute API itself that uses '2.1' if no microversion header is included in a request | |
| 19:36:54 | dtroyer | we accepted that behaviour because it meant OSC was backward-compatible | |
| 19:37:31 | dtroyer | as you've seen, specifying a microversion in —os-compute-api-version (or clouds.yaml) does work | |
| 19:37:44 | dtroyer | here's what I would like to do, need to get some feedback: | |
| 19:38:19 | dtroyer | change the meaning of version '2' to be '2.latest' without actually using the 'latest' text that the apiref warns is meant for testing. | |
| 19:38:52 | dtroyer | so while novaclient is available, we'd use novaclient.API_MAX_VERSION as the default for '2' | |
| 19:43:56 | frickler | dtroyer: sounds reasonable to me, seems like that would kind of ensure feature parity between osc and novaclient like for the volume status output | |
| 19:45:32 | frickler | dtroyer: also, using cloud.cfg with an explicit compute API version selected might in fact be a good enough workaround for me. I've been wanting to dump our openrc stuff in favor of that for some time now anyway | |
| 20:55:17 | openstackgerrit | Jim Rollenhagen proposed openstack/os-client-config master: Docs: add a note about rackspace API keys https://review.openstack.org/451563 | |
| 21:00:56 | openstackgerrit | Ken'ichi Ohmichi proposed openstack/api-wg master: Clarify the meaning of BODY https://review.openstack.org/451568 | |
| 21:32:07 | openstackgerrit | Nakul Dahiwade proposed openstack/python-openstacksdk master: Introduce Listener for Octavia (load balancing) https://review.openstack.org/451574 | |
| 22:18:31 | jamielennox | dtroyer: so the part i've always been stuck with is how to do negotiation | |
| 22:18:44 | jamielennox | it's pretty easy to add a header, and even do the discovery bit | |
| 22:19:03 | jamielennox | dtroyer: quieter here :) | |
| 22:19:23 | dtroyer | I'm just at discovery/negotiation | |
| 22:19:38 | jamielennox | dtroyer: the part i don't know how to do is the fallback for do X if something is available else do Y | |