| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2017-02-21 | |||
| 23:01:27 | dtroyer | I haven't asked anyone here yet... | |
| 23:08:28 | ankur-gupta-f4 | I will find out and get back to you. But I think it should replace. | |
| 23:18:24 | ankur-gupta-f4 | https://github.com/openstack/neutron/blob/ba519cc37f4b5c48fad3157fbfb1127623289b78/neutron/tests/unit/db/test_db_base_plugin_v2.py#L4639 | |
| 23:19:25 | ankur-gupta-f4 | but with if updated cidr overlaps with another then returns 409 | |
| 23:19:26 | ankur-gupta-f4 | https://github.com/openstack/neutron/blob/ba519cc37f4b5c48fad3157fbfb1127623289b78/neutron/tests/unit/db/test_db_base_plugin_v2.py#L4737 | |
| 23:21:13 | ankur-gupta-f4 | dtroyer: ^^^ | |
| #openstack-sdks - 2017-02-22 | |||
| 00:31:52 | dtroyer | ankur-gupta-f1: thanks, that is exactly what I am trying to find out, when there is an overlap. Right now, without an overlap a new pool is created, so making it act like neutronclient is a behaviour change. | |
| 00:42:32 | ankur-gupta-f4 | dtroyer: does that answer/solve the problem or is more digging needed. | |
| 00:45:05 | dtroyer | I think what we may need to do is write out the expectations of things like this, ie append or replace for existing option arguments. What we do now is more consistent with what we do in a lot of other places, but incomplete since it was not quite meant to be that way. | |
| 00:45:46 | dtroyer | what I wanted to confirm first is what Neutron intended and see if we could sort out user expectations to know which way to fix this. | |
| 00:46:07 | dtroyer | what I want to avoid is doing the collision detection in the client | |
| 00:46:23 | dtroyer | so there may not be much more to do here right now | |
| 00:46:34 | dtroyer | thanks | |
| 00:47:19 | ankur-gupta-f4 | :) | |
| 00:59:57 | openstackgerrit | Sindhu Devale proposed openstack/python-openstackclient master: OSC Quota List https://review.openstack.org/379813 | |
| 01:03:04 | ankur-gupta-f4 | sindhu: U here? | |
| 01:03:25 | sindhu | ankur-gupta-f4: yup, wass up | |
| 01:03:40 | ankur-gupta-f4 | hahaha. nm u know. | |
| 01:03:50 | ankur-gupta-f4 | do u get a return for that quota list for networks? | |
| 01:04:09 | sindhu | I fixed it now | |
| 01:04:20 | sindhu | ur not getting? | |
| 01:04:23 | ankur-gupta-f4 | i just pulled it down and it doesn't return the quotas for me | |
| 01:04:53 | sindhu | did u change the default value of any one of the attributes? | |
| 01:05:07 | ankur-gupta-f4 | oh yea i forgot that stupid quirk. | |
| 01:05:08 | ankur-gupta-f4 | k | |
| 01:05:50 | ankur-gupta-f4 | sindhu: thx | |
| 01:06:00 | sindhu | working now? | |
| 01:06:10 | ankur-gupta-f4 | yea | |
| 01:06:13 | sindhu | cool | |
| 01:34:00 | openstackgerrit | Sindhu Devale proposed openstack/python-openstackclient master: OSC Quota List https://review.openstack.org/379813 | |
| 02:32:12 | openstackgerrit | jiahui.qiang proposed openstack/python-openstackclient master: Fix can not set is_default in network https://review.openstack.org/434602 | |
| 02:45:51 | openstackgerrit | Anindita Das proposed openstack/python-openstackclient master: OSC Network Flavor https://review.openstack.org/382530 | |
| 02:58:08 | openstackgerrit | Merged openstack/python-openstacksdk master: Remove unnecessary get_id call in _prepare_request https://review.openstack.org/436209 | |
| 03:51:20 | ankur-gupta-f4 | dtroyer: stevemar updated the networking piece of Google Doc as far as my knowledge. imho remove all the LBaaS for now since it will be implemented after Octavia v2 API which is in progress (make it easier to read) | |
| 06:45:16 | openstackgerrit | Wang Hui proposed openstack/golang-client master: Update crud operation of volume API v3 https://review.openstack.org/421641 | |
| 06:47:13 | openstackgerrit | Wang Hui proposed openstack/golang-client master: add file support for openstack goclient https://review.openstack.org/429204 | |
| 07:01:34 | openstackgerrit | Wang Hui proposed openstack/golang-client master: Update crud operation of volume API https://review.openstack.org/421641 | |
| 07:04:31 | openstackgerrit | Wang Hui proposed openstack/golang-client master: add file support for openstack goclient https://review.openstack.org/429204 | |
| 07:19:49 | openstackgerrit | Hongbin Li proposed openstack/python-openstacksdk master: Support profile-only to cluster update https://review.openstack.org/436797 | |
| 07:53:14 | openstackgerrit | Rui Chen proposed openstack/python-openstackclient master: Support list commands by group name keyword https://review.openstack.org/436806 | |
| 08:27:28 | openstackgerrit | Rui Chen proposed openstack/python-openstackclient master: Show openstacksdk version info in "module list" https://review.openstack.org/436820 | |
| 08:40:59 | openstackgerrit | Rui Chen proposed openstack/python-openstackclient master: Show openstacksdk version info in "module list" https://review.openstack.org/436820 | |
| 09:58:19 | openstackgerrit | Rui Chen proposed openstack/python-openstackclient master: Fix "endpoint list" help message https://review.openstack.org/436851 | |
| 10:29:34 | openstackgerrit | Shan Guo proposed openstack/api-wg master: Fix typo in the doc https://review.openstack.org/436865 | |
| 14:23:51 | openstackgerrit | Merged openstack/python-openstacksdk master: Support profile-only to cluster update https://review.openstack.org/436797 | |
| 15:00:20 | reedip_1 | ankur-gupta-f1, ankur-gupta-f4 Hi | |
| 15:00:31 | reedip_1 | I updated https://review.openstack.org/#/c/398767/ for review | |
| 15:01:03 | reedip_1 | stevemar : Sorry I arrived late yesterday for the OSC meetup. If there is something to discuss, please let me know :) | |
| 15:01:26 | ankur-gupta-f4 | reedip_1: good evening. Okay will take a look in a bit. | |
| 15:02:03 | ankur-gupta-f4 | Morning* haha | |
| 15:02:14 | reedip_1 | ankur-gupta-f4 thanks ( yeah , its morning for me now :( ) | |
| 15:03:06 | ankur-gupta-f4 | 😞 | |
| 15:06:12 | ankur-gupta-f4 | reedip_1: how do you like Atlanta? | |
| 15:06:22 | reedip_1 | Wet ! | |
| 15:06:38 | reedip_1 | its raining since I arrived | |
| 15:07:08 | ankur-gupta-f4 | Thats too bad. Hopefully it isnt followed up by high humidity | |
| 15:07:25 | reedip_1 | Hope not | |
| 15:36:11 | openstackgerrit | Terry Howe proposed openstack/python-openstacksdk master: Fix problem with update including id https://review.openstack.org/436538 | |
| 15:55:07 | stevemar | ankur-gupta-f1: thanks for inputting all the data! | |
| 15:55:30 | ankur-gupta-f1 | stevemar: np hope it helps | |
| 16:00:36 | openstackgerrit | Sindhu Devale proposed openstack/python-openstackclient master: OSC Quota List https://review.openstack.org/379813 | |
| 16:03:12 | openstackgerrit | Sindhu Devale proposed openstack/python-openstackclient master: OSC Extension Show https://review.openstack.org/382023 | |
| 16:10:58 | swatson_ | Hi channel, I'm on the magnum team and I'm looking to add support for magnum functionality in the openstack client. | |
| 16:11:08 | openstackgerrit | Merged openstack/python-openstackclient master: Fix "endpoint list" help message https://review.openstack.org/436851 | |
| 16:11:54 | ankur-gupta-f1 | swatson_: hey, what you looking into. I can help out. | |
| 16:12:01 | swatson_ | Is adding support for that in openstackclient similar to plugging in our python-magnumclient in some way, or is all the work done inside python-openstackclient? | |
| 16:12:57 | swatson_ | ankur-gupta-f1: Hey :) I've already done some work with our python-magnumclient, and a lot of the openstackclient looks similar, but I'm trying to find a good starting point so I don't go down the wrong path to begin with | |
| 16:14:18 | ankur-gupta-f1 | yea I am looking at it. It depends on if you want to plug python-magnumclient into OSC (thus you have full control over the client) or you want to bring the commands into OSC native repo | |
| 16:14:51 | ankur-gupta-f1 | https://docs.openstack.org/developer/python-openstackclient/plugins.html | |
| 16:15:24 | swatson_ | I think we want to go down the path of a plugin | |
| 16:16:09 | ankur-gupta-f1 | well in that case look at that link it shows how to get started. | |
| 16:16:30 | swatson_ | ankur-gupta-f1 thanks! | |
| 16:16:39 | ankur-gupta-f1 | swatson_: feel free to add me to any reviews | |
| 16:16:50 | swatson_ | ankur-gupta-f1 will do | |
| 16:18:13 | ankur-gupta-f1 | swatson_: Neutron has some of its extensions implemented as plugins https://github.com/openstack/python-neutronclient/tree/master/neutronclient/osc as with Trove https://github.com/openstack/python-troveclient/tree/master/troveclient/osc | |
| 16:21:35 | swatson_ | ankur-gupta-f1: So OSC is crawling client directories specifically for one named 'osc'? | |
| 16:22:08 | ankur-gupta-f1 | ? | |
| 16:23:51 | swatson_ | I'm just trying to figure out the mechanism OSC is using to find the plugins | |
| 16:24:13 | swatson_ | I see entry_points.txt but no openstack.cli.extension entry in that file | |
| 16:24:27 | openstackgerrit | Merged openstack/python-openstacksdk master: Fix problem with update including id https://review.openstack.org/436538 | |
| 16:27:07 | ankur-gupta-f1 | swatson_: i see. searching | |
| 16:27:10 | swatson_ | ankur-gupta-f1: I guess that's in an egg-info | |
| 16:27:44 | ankur-gupta-f1 | dtroyer: stevemar: ^^^^^^^^^^^ | |
| 16:35:43 | dtroyer | swatson_: are you at PTG? | |
| 16:35:50 | swatson_ | dtroyer: No | |
| 16:36:18 | dtroyer | ok, it would be easier to do this f2f… but I can type too :) | |
| 16:36:32 | swatson_ | :) | |
| 16:36:41 | dtroyer | I've only quckly scanned the scrollback, but the process for an OSC plugin is outlined in that link above | |
| 16:37:06 | dtroyer | the plugin registers an entrypoint via setuptools, that is what OSC scans to pick up what is installed | |
| 16:37:38 | swatson_ | ah ok | |
| 16:38:11 | swatson_ | jvgrant just showed me something that we apparently got started in magnum several weeks ago | |
| 16:38:32 | swatson_ | and ankur-gupta-f1 showed me a couple examples via neutron/trove which should be a decent starting point | |
| 16:39:25 | dtroyer | ok. my original bare-bones plugin is at https://github.com/dtroyer/osc-plugin and should still work (I haven't tested it recetnyl, but the plugin interface has not changed | |
| 16:40:11 | ankur-gupta-f1 | dtroyer: https://github.com/openstack/python-troveclient/blob/master/troveclient/osc/plugin.py its the plugin file that creates the hook right? or no? | |
| 16:40:59 | swatson_ | dtroyer: I'll check it out. Thanks! | |
| 16:41:01 | dtroyer | those are the callbacks that OSC uses after scanning the entrypoint nmespace | |
| 16:41:40 | dtroyer | one to add the global option for API version, and make_client() is what actually returns a client object of some sort to call for the REST operations | |
| 16:42:13 | dtroyer | also, all of the projects in the OSC repo itself are written as plugins using this mechanism so are useful to look at as examples | |
| 16:42:30 | dtroyer | look for the modules like compute/client.py | |
| 16:43:20 | ankur-gupta-f1 | thanks dtroyer | |