| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2017-01-13 | |||
| 19:41:31 | stevemar | but apparently its there now | |
| 19:41:50 | stevemar | want me to pop it out from the display or fix the test? | |
| 19:42:19 | dtroyer | it should match nova-net if there is an equivalent | |
| 19:42:25 | stevemar | it is set to None atm | |
| 19:42:32 | dtroyer | I don't recall offhand which that is | |
| 19:45:21 | stevemar | i dont see any formatters for it in network.py | |
| 19:46:31 | stevemar | dtroyer: looks like it's not a nova-net option | |
| 19:46:46 | stevemar | since it's in get_attrs and not get_compute_attrs | |
| 19:49:30 | dtroyer | kk | |
| 19:53:32 | stevemar | dtroyer: well i tried passing in --default and --no-default | |
| 19:53:39 | stevemar | and well, it always come back as None | |
| 19:53:42 | stevemar | http://developer.openstack.org/api-ref/networking/v2/?expanded=create-network-provider-network-detail#create-network-provider-network | |
| 19:53:45 | stevemar | looking at that ^ | |
| 19:54:00 | stevemar | theres no "is_default" in the body expected (which is what the SDK passed) | |
| 19:55:49 | stevemar | theres no default anything in the create network APIs related stuff *shrug* | |
| 19:56:59 | stevemar | we could just keep it in there, the SDK returns it, so be it, maybe it's plumbing for something else | |
| 20:03:41 | openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: fix network functional tests for sdk 0.9.12 https://review.openstack.org/420154 | |
| 20:05:16 | stevemar | dtroyer: i'm good with https://review.openstack.org/#/c/420113/1 going in | |
| 20:07:34 | openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: fix functional tests for network agents https://review.openstack.org/420098 | |
| 20:08:26 | dtroyer | hmmm -tips isn't happy there | |
| 20:11:29 | stevemar | dtroyer: yep | |
| 20:11:39 | stevemar | mordred dtroyer know why this is failing? http://logs.openstack.org/98/420098/2/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/41e3ce3/console.html#_2017-01-13_18_35_30_737948 | |
| 20:11:45 | stevemar | ERROR: InvocationError: '/opt/stack/new/python-openstackclient/.tox/functional-tips/bin/pip install -q -U -e /opt/stack/new/osc-lib' | |
| 20:11:50 | stevemar | i'm doing it locally and it's fine | |
| 20:12:03 | mordred | stevemar: hrm. looking | |
| 20:12:19 | stevemar | mordred: it was your recent change to osc ;) | |
| 20:14:00 | mordred | yah. ... | |
| 20:15:16 | mordred | stevemar: ooh, interesting | |
| 20:15:19 | mordred | InstallationError: Command "python setup.py egg_info" failed with error code 1 in /opt/stack/new/osc-lib/ | |
| 20:15:49 | mordred | error: could not create 'osc_lib.egg-info': Permission denied | |
| 20:15:56 | mordred | crapballs | |
| 20:16:08 | stevemar | mordred: sudo ness? | |
| 20:16:43 | mordred | stevemar: k. patch coming | |
| 20:19:17 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient: Use git+file urls instead of directories https://review.openstack.org/420162 | |
| 20:19:25 | mordred | stevemar: let's see if that works a bit better | |
| 20:20:24 | stevemar | mordred: you're in all sorts of merge conflict, i fixed your patch before it merged (you were installing osc instead of the sdk) | |
| 20:20:41 | mordred | oh. bleh | |
| 20:21:02 | mordred | nice! | |
| 20:21:19 | stevemar | hmm | |
| 20:21:26 | stevemar | i think we may run into the same issue, not sure | |
| 20:21:49 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient: Use git+file urls instead of directories https://review.openstack.org/420162 | |
| 20:21:54 | mordred | stevemar: maybe that'll be better | |
| 20:22:47 | mordred | stevemar: if we get this working right, we should go poke the oslo folks about getting their stuff updated to point at /opt/stack/new instead of http | |
| 20:24:44 | stevemar | mordred: pardon my ignorance, but whats the big advantage? | |
| 20:32:57 | sindhu | stevemar: so where can I find the definitions of all the methods defined under a particular client? for example if I have compute_client = self.app.client_manager.compute and it contains list_extensions which in turn has all the methods like _create, _delete, _get | |
| 20:33:36 | mordred | stevemar: the big advantage is that /opt/stack/new will have the repo set up by zuul with depends-on changes taken in to account | |
| 20:33:42 | mordred | stevemar: so for most patches it'll be identical | |
| 20:34:34 | mordred | stevemar: but if you ever want to have a depends-on patch in occ, sdk or osc-lib and then show things working in the osc patch, you'll need to clone from /opt/stack/new and not from git.o.o | |
| 20:35:04 | stevemar | mmm ok | |
| 20:37:20 | mordred | the _easier_ thing would be to just add the libs to LIBS_FROM_GIT for devstack, but then we'd need to run the functional tests not via tox ... and also the lib installed for the cloud is different than the lib installed for consuming the cloud APIs - so I think continuing to run the functional tests out of the tox venv is the betterer choice | |
| 20:51:20 | openstackgerrit | Nakul Dahiwade proposed openstack/python-openstackclient: OSC Network Flavor Profile https://review.openstack.org/396783 | |
| 21:05:33 | openstackgerrit | Merged openstack/python-openstackclient: Fix security group rule list for NEtwork v2 https://review.openstack.org/420113 | |
| 21:29:54 | openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Use git+file urls instead of directories https://review.openstack.org/420162 | |
| 21:30:18 | stevemar | mordred: 'did not specify requirement, use #egg' error | |
| 21:30:24 | stevemar | mordred: i wrapped it with quotes | |
| 21:31:00 | openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Run functional tests with SDK 0.9.12 https://review.openstack.org/418650 | |
| 21:31:05 | openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: fix network functional tests for sdk 0.9.12 https://review.openstack.org/420154 | |
| 21:36:27 | openstackgerrit | Sindhu Devale proposed openstack/python-openstackclient: OSC Extension Show https://review.openstack.org/382023 | |
| 21:40:36 | mordred | stevemar: thanks. I suck | |
| 21:50:40 | openstackgerrit | Sindhu Devale proposed openstack/python-openstackclient: "floating ip add/remove port" for OSC https://review.openstack.org/383025 | |
| 22:13:42 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient: Fix floating IP delete and show by IP https://review.openstack.org/420194 | |
| 22:14:24 | dtroyer | stevemar: ^^^ busted my brain today, but dang it we can delete Neutron floaters by IP address now, just like nova-net | |
| 22:18:40 | openstackgerrit | Merged openstack/python-openstackclient: fix functional tests for network agents https://review.openstack.org/420098 | |
| 22:26:24 | openstackgerrit | Shashank Kumar Shankar proposed openstack/python-openstackclient: Introduce Neutron DHCP agent commands to OSC. https://review.openstack.org/387611 | |
| #openstack-sdks - 2017-01-14 | |||
| 04:03:31 | openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Use git+file urls instead of directories https://review.openstack.org/420162 | |
| 04:31:24 | openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Run functional tests with SDK 0.9.12 https://review.openstack.org/418650 | |
| 04:31:27 | openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: fix network functional tests for sdk 0.9.12 https://review.openstack.org/420154 | |
| 04:39:24 | openstackgerrit | Steve Martinelli proposed openstack/python-openstackclient: Fix floating IP delete and show by IP https://review.openstack.org/420194 | |
| 04:41:03 | stevemar | mordred: i wouldn't say you "suck", inhale quickly though for sure | |
| 04:41:14 | stevemar | <3 | |
| 04:41:37 | stevemar | dtroyer: looks like your floating ip patch depends on SDK >=0.9.11 | |
| 04:42:04 | stevemar | dtroyer: i staged it on top of my "run tests with SDK 0.9.12" patch to see if it's true | |
| 04:44:13 | reedip | stevemar : good morning :). Any help needed for OSC ? | |
| 04:49:18 | stevemar | reedip: i think we're still looking at one last bug | |
| 04:49:41 | stevemar | reedip: http://logs.openstack.org/50/418650/11/check/gate-osc-dsvm-functional-ubuntu-xenial/329d025/testr_results.html.gz | |
| 04:49:52 | stevemar | the test_quota_set and test_quota_show | |
| 04:50:01 | stevemar | they dont seem to work with SDK at 0.9.12 | |
| 04:50:24 | reedip | stevemar : see if this helps : https://review.openstack.org/#/c/419911/ | |
| 04:50:29 | stevemar | the rest of the failures should be fixed | |
| 04:56:07 | stevemar | reedip: probably fixes it ;) | |
| 04:56:15 | reedip | :D | |
| 04:56:33 | reedip | Ok, I am looking into the default quota bug then | |
| 04:56:49 | reedip | I mean test_quota_show_with_default_option | |
| 04:56:51 | stevemar | reedip: probably need a test for the sdk change? | |
| 04:57:06 | stevemar | reedip: looking like the quota show bug stems from the same error | |
| 04:57:15 | reedip | stevemar : there was no test written earlier, but ok, I will fix it | |
| 04:57:18 | reedip | is it ??? | |
| 04:57:25 | reedip | U mean does it fix both the issues ? | |
| 05:00:43 | reedip | stevemar : no I dont think it fixes it | |
| 05:01:16 | reedip | stevemar : but the solution is similar | |
| 06:04:11 | stevemar | ah similar is good | |
| 06:55:24 | reedip | stevemar : upcoming | |
| 06:55:33 | reedip | sorry, it took some time to find out :) | |
| 06:57:16 | openstackgerrit | Reedip proposed openstack/python-openstacksdk: Fix QuotaDefault show https://review.openstack.org/420301 | |
| 07:11:28 | stevemar | reedip: np! i'll review it tmrw | |
| 07:11:36 | reedip | ok :) | |
| 07:25:55 | RuiChen | hi reedip: I work on the bug test_quota_show_with_default_option, ready to push a patch to openstacksdk | |
| 07:26:28 | reedip | RuiChen : ohh , I didnt know that. I already pushed a patch just a few minutes back | |
| 07:26:51 | reedip | RuiChen : https://review.openstack.org/420301 | |
| 07:27:00 | RuiChen | ah, see your patch https://review.openstack.org/#/c/420301/ | |