Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2017-01-11
15:38:25 stevemar 1) copy the functional job here, but call a different post_test_hook.sh, maybe post_test_osc_lib_hook.sh ? https://github.com/openstack-infra/project-config/blob/e172a5e4107f1774a77e212d82218086ed39329e/jenkins/jobs/osc.yaml#L2
15:38:58 stevemar 2) copy https://github.com/openstack/python-openstackclient/blob/master/openstackclient/tests/functional/post_test_hook.sh to the new name and have it clone and install osc-lib master
15:39:09 stevemar 3) make money
15:40:14 stevemar i could get fancy and maybe set an ENV variable somewhere that says we're using osc-lib from master, but ... i know this will work
15:41:28 dtroyer I don't know the job stuff well enough to know the shortcuts, your plan sounds like it will work
15:41:38 dtroyer should we commit the shell script first?
15:41:43 dtroyer also, stable jobs?
15:43:42 stevemar the shell script will be in osc no?
15:43:53 dtroyer yes
15:44:05 stevemar oh i thought you were asking about getting that in before osc-lib is released
15:44:07 stevemar ignore me
15:44:15 dtroyer should we also do sdk? can we do both in the same job?
15:44:21 dtroyer so many questions!
15:45:16 dtroyer a) I was thinking we'd want the new *-hook.sh merged before defining the job that calls it
15:45:43 dtroyer b) I'm still thinking through how this affects (or if it should?) stable jobs
15:46:09 dtroyer c) we should also do the sdk this way, can we do both in the same job in a sane manner?
15:47:32 stevemar dtroyer: i think we can
15:49:58 dtroyer o-c-c too?
15:50:05 dtroyer how much can we add??? :)
15:50:15 dtroyer those are the three primary break-risk libs for OSC
16:27:41 dtroyer stevemar: I just got the same results in my local OSC functional tests (same devstack-related failures) for both current and master osc-lib. Are you OK with pushing the release now or do you still want to wait intil the new job is in?
16:31:39 stevemar dtroyer: i'm OK with pushing
16:32:11 stevemar dtroyer: i'm trying to figure out the pip command to install the sdk
16:32:24 briancurtin pip install openstacksdk
16:32:35 stevemar hehe
16:32:50 stevemar briancurtin: from master instead?
16:32:58 briancurtin what?
16:33:08 stevemar i was thinking ... pip install -q -U -e "git+https://git.openstack.org/python-openstacksdk/openstacksdk.git#egg=openstacksdk"
16:33:34 briancurtin that probably works. or maybe egg=openstack. i can’t remember exactly what goes in the egg part
16:33:58 stevemar briancurtin: thats where i'm stumbling :)
16:34:20 briancurtin the PyPI package name is openstacksdk but the package that python itself deals with is called openstack, so maybe egg=openstack
16:35:12 dtroyer looks like egg=python_openstackclient is used for that case, so pypi package name?
16:35:24 dtroyer with '-' -> '_' mapping
16:36:06 stevemar dtroyer: sorta, pip install -q -U -e "git+https://git.openstack.org/openstack/osc-lib.git#egg=osc_lib" works for osc-lib
16:36:37 dtroyer so I'd expect #egg=puthon_openstacksdk to be the magic
16:37:10 dtroyer s/pu/py/
16:38:53 dtroyer pip install -q -U -e "git+https://git.openstack.org/openstack/python-openstacksdk.git#egg=python_openstacksdk"
16:38:59 dtroyer appears to have worked for me
16:40:21 stevemar *smh* i had an extra openstack in there
16:41:14 reedip_outofmemo briancurtin : ping
16:41:22 briancurtin reedip_outofmemo: what’s up
16:42:12 reedip_outofmemo briancurtin : hi , busy ?
16:42:20 openstackgerrit Steve Martinelli proposed openstack/python-openstackclient: add support for running tests with master dependencies https://review.openstack.org/419032
16:42:23 briancurtin reedip_outofmemo: no, what’s up
16:42:26 stevemar dtroyer: ^
16:42:30 reedip_outofmemo briancurtin : it was related to https://review.openstack.org/#/c/418729/
16:42:42 briancurtin yeah, what is the question?
16:43:13 reedip_outofmemo briancurtin : earlier, quota show for openstackclient ( before 0.9.12 version ) was working smoothly
16:43:29 reedip_outofmemo with 0.9.12, there has been a change and quota show now fails
16:43:39 reedip_outofmemo briancurtin :https://bugs.launchpad.net/python-openstackclient/+bug/1655537
16:43:39 openstack Launchpad bug 1655537 in python-openstackclient "Cannot see Network quota using "openstack quota show"" [Undecided,New] - Assigned to Reedip (reedip-banerjee)
16:44:23 briancurtin reedip_outofmemo: there was no change in 0.9.12, i think it was in 0.9.11, but this is an OSC problem and not an SDK problem
16:44:23 reedip_outofmemo briancurtin: the reason is though the Compute and Volume quotas are returned as dict, network quota is returned as an object
16:44:48 reedip_outofmemo briancurtin : ok , one question
16:45:03 reedip_outofmemo briancurtin : is the compute client and volume client part of Openstack SDK ?
16:45:09 briancurtin reedip_outofmemo: openstacksdk hasn’t explicitly returned dictionaries ever, though some time ago it did return objects that can act like dictionaries. compute hasn’t done that for probably 8 months
16:45:11 reedip_outofmemo briancurtin : like Network client
16:45:32 briancurtin reedip_outofmemo: I’m not sure, i don’t work on OSC. i think OSC only uses openstacksdk for the network related commands though, not for compute and volume
16:46:04 reedip_outofmemo stevemar : any suggestions related to above query ?
16:46:17 dtroyer reedip: briancurtin is correct re compute and volume quotas
16:46:41 reedip_outofmemo dtroyer : ok, so sdk is used only for Networks??????
16:46:54 dtroyer the root problem is that OSC was not ready for the 0.9.11 changes in the SDK because our functioanl tests were producing false positives for a time
16:47:00 dtroyer reedip: yes
16:47:03 reedip_outofmemo briancurtin : one more query
16:47:09 briancurtin reedip_outofmemo: sure
16:47:17 reedip_outofmemo dtroyer :okay, then I will fix the bug in OSC and not SDK
16:47:27 reedip_outofmemo briancurtin : this is related to quota set
16:47:41 dtroyer OSc needs to work with sdk >= 0.9.10 for a while yet
16:47:59 reedip_outofmemo briancurtin : in openstack SDK , you updated the proxy2
16:49:00 reedip_outofmemo briancurtin : https://github.com/openstack/python-openstacksdk/blob/master/openstack/proxy2.py#L64
16:49:12 briancurtin correct, there is a proxy2
16:49:28 reedip_outofmemo briancurtin : Neutron Quota set does not need the ID which is being passed here in the PUT request
16:50:56 reedip_outofmemo Neutron Quota API do not need the tenant/project ID as they have an endpoint in the quota resource itself for the tenant ID. For example. if Tenant ID is ABCDE , then Neutron has the quota endpoint for tenant as http://10.0.0.1:23423/v2/quotas/ABCDE.json
16:50:58 briancurtin so when building the request don’t make it require an ID. you might need to override the create method of the Quota resource and pass requires_id=False to the _prepare_request method https://github.com/openstack/python-openstacksdk/blob/master/openstack/resource2.py#L502
16:51:16 reedip_outofmemo briancurtin : Yup , I am trying to do that
16:51:41 reedip_outofmemo briancurtin : Just wanted to update you. There might be one more change, I will put up the patch tomorrow
16:51:47 briancurtin reedip_outofmemo: ok cool
16:52:02 reedip_outofmemo briancurtin : thanks , hope this resolves soon :)
16:52:35 reedip_outofmemo dtroyer : sorry for bugging you , but if OSC needs to work with SDK >=0.9.10, then should I just put a type check ?
16:53:35 reedip_outofmemo dtroyer: that would be simpler and can be removed once everything comes in line? Currently network quota is returned as an object, but earlier it was returned as a dict ( or something similar to a dict)
16:55:58 dtroyer reedip: there is currently a bit of compatibility code in the networking commands for this reason, do the same thing in the quota command and leave a note to remove it later
16:56:42 reedip_outofmemo dtroyer: aye aye !
17:00:24 dtroyer dhellmann, stevemar: I'd like to do a cliff release this week yet, likely last before freeze. I'm OK with https://review.openstack.org/412742, chime in when you get a minute if we should include it or not...
17:09:18 stevemar dtroyer: we can probably release without that patch, it's more for making sure our gates aren't busted
17:09:50 stevemar dtroyer: i've also released ksa for us, but getting blocked for the u-c bump
17:10:02 stevemar https://review.openstack.org/#/c/418608/
17:36:24 openstackgerrit Reedip proposed openstack/python-openstackclient: Fix quota show output https://review.openstack.org/419067
17:38:17 reedip_outofmemo stevemar , briancurtin : ^^
17:38:26 openstackgerrit Shashank Kumar Shankar proposed openstack/python-openstackclient: Introduce Neutron DHCP agent commands to OSC. https://review.openstack.org/387611
17:44:42 openstackgerrit Shashank Kumar Shankar proposed openstack/python-openstackclient: Introduce Neutron DHCP agent commands to OSC. https://review.openstack.org/387611
18:30:03 ankur-gupta-f dtroyer: here?
18:30:55 dtroyer ankur-gupta-f: yo
18:31:06 ankur-gupta-f Client functional tests :D
18:31:14 ankur-gupta-f so we tried the regexes
18:31:16 ankur-gupta-f now JSON
18:31:28 ankur-gupta-f but for existing patches can we leave regexes and follow up with JSON
18:32:05 dtroyer yes. it may still evolve more, I don't want you guys to chase too much of a moving target, OSC does that all the time anyway
18:32:18 dtroyer ther are a couple of things I'd like to make sure get in theough,
18:32:25 dtroyer using addCleanup() is one of those
18:32:49 dtroyer that is more than a cosmentic/developer preference thing

Earlier   Later