| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2025-02-25 | |||
| 16:21:59 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.connection https://review.opendev.org/c/openstack/openstacksdk/+/942599 | |
| 16:21:59 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.proxy https://review.opendev.org/c/openstack/openstacksdk/+/942598 | |
| 16:22:00 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: WIP: typing: Annotate openstack.service_description https://review.opendev.org/c/openstack/openstacksdk/+/942600 | |
| 17:21:45 | M0weng[m] | stephenfin or gtema : I'm finding that the `limit` functional tests don't seem to be getting a limit ID back either, but somehow they're not failing. This is the output when I print `raw_output`, `items`, and `limit_id` in turn in the `test_limit.LimitTestCase.test_limit_create_with_options` test: | |
| 17:23:01 | M0weng[m] | (or pastebin if you prefer https://paste.openstack.org/show/bDxU7qOBl2WseY8CeyeX/) | |
| 17:23:17 | gtema | pls check directly whether the SDK gets the ID mapped properly | |
| 17:23:56 | M0weng[m] | SDK does not either; this is its output from printing the whole limit and the limit ID in turn: | |
| 17:24:17 | M0weng[m] | None | |
| 17:24:17 | M0weng[m] | 'domain_name': None})})) | |
| 17:24:17 | M0weng[m] | openstack.identity.v3.limit.Limit(description=test, project_id=235fb40de1474c06b2756eaf9d66bff8, service_id=6c34e452f0b64587b442a29ff6889b2b, region_id=tempest-TestRegion-260053066, resource_name=tempest-resource_name-1709327697, resource_limit=15, location=Munch({'cloud': 'devstack-system-admin', 'region_name': 'RegionOne', 'zone': None, 'project': Munch({'id': '235fb40de1474c06b2756eaf9d66bff8', 'name': None, 'domain_id': None, | |
| 17:24:28 | M0weng[m] | (this is the output in the test) | |
| 17:24:45 | M0weng[m] | * (this is the output as I'm getting it from the test) | |
| 17:25:41 | gtema | weird, but at least now you know SDK is to blame | |
| 17:26:06 | gtema | with the SDK test script you could verify that id is being present in the response, not that we have keystone to blame | |
| 17:29:44 | stephenfin | M0weng[m]: What happens if you run this? https://paste.opendev.org/show/b247JKxsPqlVh3sZMNBM/ | |
| 17:31:36 | M0weng[m] | stephenfin: I'm getting an error that I need an auth_url argument when creating the connection object; what should I be putting there? | |
| 17:31:52 | stephenfin | Set OS_CLOUD first | |
| 17:32:11 | stephenfin | s/Set/Export/ | |
| 17:32:34 | M0weng[m] | ahh ok | |
| 17:34:19 | M0weng[m] | Hmm I'm getting a 400 error; OS_CLOUD is things like devstack-admin, devstack-system-admin right? | |
| 17:34:49 | stephenfin | Yep. Something like `export OS_CLOUD=devstack-admin` should do the trick | |
| 17:35:29 | M0weng[m] | Oh wait changing it to devstack-admin worked | |
| 17:35:44 | M0weng[m] | I'm getting an empty array back though | |
| 17:35:56 | M0weng[m] | Let me create a new limit first | |
| 17:36:47 | M0weng[m] | Ah wait I remember, I can't use devstack-admin to list, I need to use devstack-reader | |
| 17:38:03 | M0weng[m] | Response here:... (full message at <https://matrix.org/oftc/media/v1/media/download/AaxUKZUTsOrXZ1SgnN3G6eSVytWi3sQWiRC-kGVVZNDR7OaK5Tdwk1NO4OJE7DruuOpBwWGwAWTNPPfvAZWwfHVCeVhkj2zgAG1hdHJpeC5vcmcvSUhlR1BaSVJlblZPWnVyZHlVZWxnV2ll>) | |
| 17:39:00 | M0weng[m] | I need to head to class soon but I will take another look later today | |
| 17:47:27 | opendevreview | Merged openstack/openstacksdk master: typing: Add missing proxy arguments https://review.opendev.org/c/openstack/openstacksdk/+/942595 | |
| 18:15:11 | stephenfin | M0weng[m]: So I see the 'id' field in the output there (the line starting with 'limit 0: ') | |
| 18:15:40 | stephenfin | Are you *certain* you are using the correct openstacksdk in your test environment? | |
| 18:16:32 | stephenfin | Assuming you are running tests like e.g. 'tox -e functional-py39', you will need to install openstacksdk manually into the test environment in order to pick up your fix | |
| 18:17:20 | stephenfin | So e.g. 'source .tox/functional-py39/bin/activate; pip install -e $path_to_openstacksdk_repo_with_patches; deactivate; tox -e functional-py39' | |
| 18:17:28 | stephenfin | obviously you can sub 'py39' for 'py310' etc. | |
| 18:17:31 | M0weng[m] | Yeah I am seeing the install line where it installs from my local instead of the upstream. I'm using tox -e functional-tips and it re-installs every time. | |
| 18:17:37 | stephenfin | ah | |
| 18:17:46 | M0weng[m] | I edited tox.ini to point to my local version | |
| 18:18:04 | stephenfin | and your local version: you're on the correct branch with the fixes applied? | |
| 18:19:34 | M0weng[m] | Yep, it all seems to be there | |
| 18:21:13 | stephenfin | Very strange. I can't reproduce locally using `master` https://paste.opendev.org/show/byefSAYfIXTuuYWRgy1G/ | |
| 18:22:12 | stephenfin | You might just need to tidy up the PR and push it as a draft so, so one of us can take a look. I can't blame sdk quite yet | |
| 18:27:07 | M0weng[m] | Ok, will do when my next shift starts 👍️ | |
| 18:30:24 | opendevreview | Tim Burke proposed openstack/python-openstackclient master: Fix credential creation https://review.opendev.org/c/openstack/python-openstackclient/+/942721 | |
| 18:40:22 | timburke | FYI, ^^^ is needed to fix Swift's gate | |
| 19:06:50 | opendevreview | Merged openstack/codegenerator master: Increase openapi job timeout https://review.opendev.org/c/openstack/codegenerator/+/942676 | |
| 19:57:49 | opendevreview | Douglas Viroel proposed openstack/openstacksdk master: Bump compute max microversion to 2.100 https://review.opendev.org/c/openstack/openstacksdk/+/938833 | |
| 19:58:11 | opendevreview | Douglas Viroel proposed openstack/python-openstackclient master: Add support for showing scheduler_hints in server details https://review.opendev.org/c/openstack/python-openstackclient/+/938834 | |
| 21:19:05 | opendevreview | Merged openstack/python-openstackclient master: Fix credential creation https://review.opendev.org/c/openstack/python-openstackclient/+/942721 | |
| 21:31:34 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'registered limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/942735 | |
| 21:31:59 | M0weng[m] | The limits patch has been around for a while already (waiting on deprecation for `--region 'None'` behavior in six months): https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | |
| 21:31:59 | M0weng[m] | stephenfin / gtema : New patch for registered limits: https://review.opendev.org/c/openstack/python-openstackclient/+/942735 | |
| 22:05:58 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | |
| 22:06:29 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | |
| 22:08:46 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | |
| 22:10:31 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | |
| 22:15:24 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | |
| 22:48:45 | opendevreview | Merged openstack/python-openstackclient master: handle 'router create --flavor' option https://review.opendev.org/c/openstack/python-openstackclient/+/940595 | |
| 23:11:24 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'registered limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/942735 | |
| #openstack-sdks - 2025-02-26 | |||
| 00:25:36 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'registered limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/942735 | |
| 00:28:50 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'registered limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/942735 | |
| 00:29:26 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'registered limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/942735 | |
| 02:00:44 | opendevreview | Manuel Osorio proposed openstack/openstacksdk master: Add share transfer to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/925653 | |
| 02:23:57 | Yanks | Hello team! I've got this streaming image download support PR: https://review.opendev.org/c/openstack/openstacksdk/+/927778 I've resolved all the comments as well, may I know if this could be merged? :) | |
| 07:54:13 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: Ensure BS responses have some properties marked as required https://review.opendev.org/c/openstack/codegenerator/+/942631 | |
| 10:05:19 | opendevreview | Rajesh Tailor proposed openstack/openstacksdk master: Add support for image properties in server show https://review.opendev.org/c/openstack/openstacksdk/+/940798 | |
| 10:36:44 | opendevreview | Rajesh Tailor proposed openstack/python-openstackclient master: Add support for image properties in server show https://review.opendev.org/c/openstack/python-openstackclient/+/940799 | |
| 11:26:26 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.proxy https://review.opendev.org/c/openstack/openstacksdk/+/942598 | |
| 11:26:26 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: proxy: Remove '_check_resource' decorator https://review.opendev.org/c/openstack/openstacksdk/+/942597 | |
| 11:26:27 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: WIP: typing: Annotate openstack.service_description https://review.opendev.org/c/openstack/openstacksdk/+/942600 | |
| 11:26:27 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.connection https://review.opendev.org/c/openstack/openstacksdk/+/942599 | |
| 11:26:28 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Add (more) missing proxy arguments https://review.opendev.org/c/openstack/openstacksdk/+/942782 | |
| 11:34:20 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: Ensure BS responses have some properties marked as required https://review.opendev.org/c/openstack/codegenerator/+/942631 | |
| 11:45:39 | opendevreview | Merged openstack/openstacksdk master: typing: Don't abuse Proxy._update https://review.opendev.org/c/openstack/openstacksdk/+/942685 | |
| 11:55:47 | opendevreview | Merged openstack/openstacksdk master: typing: Remove duplicate TypeVar https://review.opendev.org/c/openstack/openstacksdk/+/942596 | |
| 14:10:50 | opendevreview | Merged openstack/codegenerator master: Ensure BS responses have some properties marked as required https://review.opendev.org/c/openstack/codegenerator/+/942631 | |
| 15:33:57 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: identity: Fix limit, registered limit creation https://review.opendev.org/c/openstack/openstacksdk/+/942818 | |
| 15:33:58 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: WIP: tests: Add reference to system admin credentials https://review.opendev.org/c/openstack/openstacksdk/+/942820 | |
| 15:33:58 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: identity: Add functional tests for limits, registered limits https://review.opendev.org/c/openstack/openstacksdk/+/942819 | |
| 15:34:29 | stephenfin | M0weng[m]: mea culpa: looks like I broke you. 👆 should fix things | |
| 15:44:08 | opendevreview | Merged openstack/codegenerator master: Add barbican secret schemas https://review.opendev.org/c/openstack/codegenerator/+/941234 | |
| 15:56:18 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Add (more) missing proxy arguments https://review.opendev.org/c/openstack/openstacksdk/+/942782 | |
| 15:56:19 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.proxy https://review.opendev.org/c/openstack/openstacksdk/+/942598 | |
| 15:56:19 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: proxy: Remove '_check_resource' decorator https://review.opendev.org/c/openstack/openstacksdk/+/942597 | |
| 15:56:20 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: WIP: typing: Annotate openstack.service_description https://review.opendev.org/c/openstack/openstacksdk/+/942600 | |
| 15:56:20 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.connection https://review.opendev.org/c/openstack/openstacksdk/+/942599 | |
| 16:22:30 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.proxy https://review.opendev.org/c/openstack/openstacksdk/+/942598 | |
| 16:22:31 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: WIP: typing: Annotate openstack.service_description https://review.opendev.org/c/openstack/openstacksdk/+/942600 | |
| 16:22:31 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.connection https://review.opendev.org/c/openstack/openstacksdk/+/942599 | |
| 17:06:15 | stephenfin | gtema: If I run 'openstack --os-cloud devstack-system-admin registered limit list', I get the following error | |
| 17:06:25 | stephenfin | xpecting to find domain in user. The server could not comply with the request since it is either malformed or otherwise incorrect. The client is assumed to be in error. (HTTP 400) | |
| 17:06:48 | stephenfin | Is that expected? How does one do system-scoped operations otherwise? | |
| 17:07:32 | gtema | stephenfin - it works for me on devstack now | |
| 17:07:46 | gtema | at least with 7.2.1 as I see now | |
| 17:08:11 | gtema | potentially we broke it with some of the changes recently | |
| 17:08:28 | stephenfin | I'm seeing it fail on dtantsur's change here https://zuul.opendev.org/t/openstack/build/e745767e1b0d4e6d86a0dee43238478a | |
| 17:09:34 | stephenfin | is that OSC in a virtualenv? could you share your `pip freeze` output? | |
| 17:09:38 | gtema | hmm, even with 7.3.2 on devstack it works | |
| 17:10:07 | gtema | https://paste.openstack.org/show/bHixZI149prOY0IyMEW7/ | |
| 17:10:25 | stephenfin | it could be my devstack, but as I said I also see it on Dmitry's patch | |
| 17:10:29 | gtema | it's a pure osc venv | |
| 17:10:57 | gtema | I just reinstalled devstack today, so it should be fresh | |