| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2023-01-05 | |||
| 16:02:29 | lajoskatona | if we have to do everythin outside SDK, so if we can add these methods to openstacksdk that is a big help I think | |
| 16:02:51 | gtema | definitely move to sdk | |
| 16:02:58 | gtema | I see no reason not to do this | |
| 16:03:31 | gtema | cli part may be separate OSC plugin, but sdk from my pov should be having support for everything what exists in openstack | |
| 16:04:16 | lajoskatona | gteam: sounds cool | |
| 16:04:47 | lajoskatona | gtema: do we need to bring this to some formal meeting, or open some spec or bug or similar? | |
| 16:05:14 | gtema | nope, just feel free to start adding directly to sdk | |
| 16:06:18 | lajoskatona | gtema: ok, thanks, we have a neutron bug to track this effort, so I can use that for tag and in commit msg to have the context for everybody | |
| 16:06:39 | gtema | sounds great | |
| 16:25:04 | opendevreview | Merged openstack/openstacksdk master: Move normalize security group to sg class https://review.opendev.org/c/openstack/openstacksdk/+/865025 | |
| 16:33:05 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored coe_cluster{,_template} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/866796 | |
| 16:47:29 | opendevreview | Merged openstack/openstacksdk master: Move normalize_server to compute mixin https://review.opendev.org/c/openstack/openstacksdk/+/866567 | |
| #openstack-sdks - 2023-01-06 | |||
| 08:13:38 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add volume summary command https://review.opendev.org/c/openstack/python-openstackclient/+/869436 | |
| 08:20:20 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add volume summary command https://review.opendev.org/c/openstack/python-openstackclient/+/869436 | |
| 09:46:31 | frickler | stephenfin: since your fix doesn't seem to work yet, can we go with the revert for now? or do a partial revert only for the baremetal part? | |
| 10:07:42 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 10:19:50 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored coe_cluster{,_template} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/866796 | |
| 10:21:42 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored coe_cluster{,_template} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/866796 | |
| 10:23:53 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 10:47:05 | stephenfin | frickler: I'd be okay with a partial revert, sure | |
| 10:47:13 | stephenfin | If you want to propose it, I'll review | |
| 11:12:59 | opendevreview | Lajos Katona proposed openstack/python-openstackclient master: Move network trunk commands from python-neutronclient https://review.opendev.org/c/openstack/python-openstackclient/+/869447 | |
| 11:24:18 | opendevreview | Dr. Jens Harbott proposed openstack/openstacksdk master: Revert "Add 'details' parameter to various 'find' proxy methods" https://review.opendev.org/c/openstack/openstacksdk/+/869315 | |
| 11:38:48 | opendevreview | Dr. Jens Harbott proposed openstack/openstacksdk master: DNM: Testing legacy job https://review.opendev.org/c/openstack/openstacksdk/+/869472 | |
| 12:15:11 | opendevreview | Lajos Katona proposed openstack/python-openstackclient master: Move network trunk commands from python-neutronclient https://review.opendev.org/c/openstack/python-openstackclient/+/869447 | |
| 12:30:02 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 12:35:40 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 12:40:04 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 13:21:31 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated contributor docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 14:02:32 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated contributor docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 14:03:10 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 14:20:32 | frickler | stephenfin: tox is completely acting up now on 869315 and I cannot reproduce locally. I'm holding a node for investigation now, but if you have any idea, feel free to join in | |
| 14:21:41 | gtema | yeah, tox became a real mess, myself debugging issues with it | |
| 14:30:10 | frickler | oh, I missed the explicit "--skip-missing-interpreters=false" parameter that we call tox with | |
| 14:43:08 | opendevreview | Dr. Jens Harbott proposed openstack/openstacksdk master: DNM test tox workaround https://review.opendev.org/c/openstack/openstacksdk/+/869480 | |
| 14:56:36 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 14:58:57 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 15:02:52 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 15:29:34 | stephenfin | frickler: if you want to get that passing, you either (a) drop usedevelop=true from tox.ini or (b) wait for https://github.com/tox-dev/tox/pull/2828 to merge | |
| 16:29:07 | opendevreview | Lajos Katona proposed openstack/openstacksdk master: Add BGP Speakers and Peers to SDK https://review.opendev.org/c/openstack/openstacksdk/+/869485 | |
| 17:26:47 | frickler | stephenfin: tox 4.2.5 doesn't help either. dropping usedevelop gives yet another error then: SystemExit: error: Multiple top-level packages discovered in a flat-layout: ['vv', 'extras', 'devstack', 'openstack', 'playbooks', 'releasenotes']. | |
| 17:27:10 | stephenfin | frickler: That's https://review.opendev.org/c/openstack/pbr/+/869082 | |
| 17:28:44 | stephenfin | That should be merged today and released Monday so we'll be unblocked then | |
| 17:28:55 | stephenfin | clarkb and fungi are looking at it | |
| 17:31:29 | fungi | yeah, just discussing how to preserve test coverage for older platforms now, i think clarkb is pushing up a new revision or additional change for it | |
| 17:31:52 | fungi | as a followup, according to what he said in #opendev | |
| 17:37:20 | fungi | er, in #openstack-infra i mean | |
| 17:37:32 | fungi | well, both | |
| 17:39:14 | whoami-rajat | stephenfin, hey, regarding your comment here https://review.opendev.org/c/openstack/python-openstackclient/+/869436/2/openstackclient/tests/unit/volume/v3/test_volume.py#123 | |
| 17:39:22 | whoami-rajat | I tried that before but did that with assertEqual | |
| 17:39:31 | whoami-rajat | in the examples i see assertCountEqual being used | |
| 17:39:54 | whoami-rajat | but I'm unsure if it compares the DictColumn ? | |
| 17:42:00 | stephenfin | can you rephrase the question? | |
| 17:43:55 | whoami-rajat | does the assertCountEqual method actually compare DictColumn? | |
| 17:45:17 | whoami-rajat | IIUC it takes frequency of elements and compares that, like Counter(list1) == Counter(list2) | |
| 17:45:43 | whoami-rajat | and that's what is used in tests to compare values with DictColumn in it | |
| 17:47:04 | whoami-rajat | like here https://github.com/openstack/python-openstackclient/blob/7985d496892635b70b71be552c52946824d73e9b/openstackclient/tests/unit/volume/v2/test_volume.py#L1125 | |
| 17:47:23 | whoami-rajat | stephenfin, ^ | |
| 17:49:23 | stephenfin | well you can check. Remove dictcolumn from one of the tests that has it and see if the test continues to pass | |
| 17:49:32 | stephenfin | but the answer is yes, it does compare as expected | |
| 17:50:21 | stephenfin | they're comparable because of this https://github.com/openstack/cliff/commit/c1c991045cece85dd55494f9d4670429e370e131 | |
| 17:51:05 | stephenfin | sorry, this https://github.com/openstack/cliff/commit/997e05fce6cf2267099f3d5f91116ba491495d7e | |
| 17:51:31 | stephenfin | (The first commit should have said "sortable", not "comparable") | |
| 17:55:39 | whoami-rajat | ok, i see it failing with a fake value, DictColumn(meta) != DictColumn({'fake':'dict'}) | |
| 17:55:43 | whoami-rajat | will update it | |
| 17:55:44 | whoami-rajat | thanks | |
| 18:18:22 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add volume summary command https://review.opendev.org/c/openstack/python-openstackclient/+/869436 | |
| 19:11:02 | opendevreview | Corey Bryant proposed openstack/openstackclient master: Test to ensure tox is pinned for stable/zed https://review.opendev.org/c/openstack/openstackclient/+/869504 | |
| 19:11:50 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 19:38:25 | opendevreview | Corey Bryant proposed openstack/python-openstackclient stable/zed: [DNM] Test to ensure tox is pinned for stable/zed https://review.opendev.org/c/openstack/python-openstackclient/+/869505 | |
| #openstack-sdks - 2023-01-09 | |||
| 11:22:53 | opendevreview | Polina Gubina proposed openstack/ansible-collections-openstack master: Volume module: - Add 'is_multiattach' parameter. When it is true, volume will be shareble https://review.opendev.org/c/openstack/ansible-collections-openstack/+/865477 | |
| 14:07:18 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 14:10:34 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 14:11:15 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 14:12:01 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 15:32:57 | opendevreview | Gaël THEROND proposed openstack/ansible-collections-openstack master: Add module to filter available volume services. https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868480 | |
| 15:32:57 | opendevreview | Gaël THEROND proposed openstack/ansible-collections-openstack master: Add module to filter available volume services. https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868480 | |
| 15:49:48 | opendevreview | Arnaud Morin proposed openstack/ansible-collections-openstack master: Add reboot and reboot_hard actions on server https://review.opendev.org/c/openstack/ansible-collections-openstack/+/866550 | |
| #openstack-sdks - 2023-01-10 | |||
| 08:08:15 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Volume module: - Add 'is_multiattach' parameter. When it is true, volume will be shareble https://review.opendev.org/c/openstack/ansible-collections-openstack/+/865477 | |
| 08:08:24 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add volume revert snapshot command https://review.opendev.org/c/openstack/python-openstackclient/+/869654 | |
| 08:16:19 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Add reboot and reboot_hard actions on server https://review.opendev.org/c/openstack/ansible-collections-openstack/+/866550 | |
| 10:02:14 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 10:07:25 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 10:50:33 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Drop _normalize class https://review.opendev.org/c/openstack/openstacksdk/+/865044 | |
| 12:11:02 | opendevreview | Merged openstack/ansible-collections-openstack master: Add reboot and reboot_hard actions on server https://review.opendev.org/c/openstack/ansible-collections-openstack/+/866550 | |
| 12:16:07 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 12:34:06 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added is_multiattach parameter to volume module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/865477 | |
| 12:34:24 | eest | i dont know if people recall my problem where openstack-sdk did not allow me to create a server with some specific settings unless i configured compute_api_version: "2.79" in clouds.yaml. I have now discovered that while it fixes my call to create a server, it breaks my call to create a server_group: Additional properties are not allowed (u'policies' was unexpected). It seems that even if i have set | |
| 12:34:30 | eest | my expected API version the code will instead inspect its "session" to see what microversion is supported and since it is 2.1 it tries using the older "policies" field instead of "policy" that it should be using | |
| 12:35:38 | gtema | do you hardcode microversion now? It should not be required, since sdk tries to choose max supported by user and cloud | |
| 12:36:47 | eest | yeah, i set "compute_api_version" in clouds.yaml, it is a bit of a mystery why the automatic microversion stuff does not work for me... i have a hard time figuring out where in the code this is actually discovered, maybe i could find out why | |
| 12:38:15 | eest | not sure if it is the openstack server side stuff that is not reporting the actually supported microversion, or if it is somehow lost in openstacksdk for some reason (i am using application credential auth which incurs extra API lookups for instance) | |
| 12:38:18 | gtema | pls try to figure out which param exactly is causing you issues without specifying MV. Hardcoding it this way is something very tricky and not without consequences | |
| 12:38:39 | eest | btw, i am not setting the "default" microversion, i believe that is another setting | |
| 12:38:54 | eest | right | |
| 12:39:00 | gtema | you should normally not set any version at all | |
| 12:40:46 | opendevreview | Mridula Joshi proposed openstack/openstacksdk master: Add support for glance cache list https://review.opendev.org/c/openstack/openstacksdk/+/869710 | |
| 12:45:15 | opendevreview | Merged openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 12:47:27 | eest | i have went so far as to checking compute/v2/server_group.py where it does "if utils.supports_microversion(session, '2.64'):" to figure out what policy thing to set, and inside supprts_microversion() it calls endpoint_data = adapter.get_endpoint_data(). printing endpoint_data i see: | |
| 12:47:46 | eest | EndpointData{api_version=(2, 1), catalog_url=https://url:port/v2.1/project-id, endpoint_id=someid, interface=public, major_version=None, max_microversion=None, min_microversion=None, next_min_version=None, not_before=None, raw_endpoint={'region_id': 'regionname', 'url': 'https://url:port/v2.1/project-id', 'region': 'regionname', 'interface': 'public', 'id': 'someid'}, region_name=regionname, | |