| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2023-01-05 | |||
| 13:11:12 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored lb_{health_monitor,listener,member,pool} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/867560 | |
| 13:11:45 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored coe_cluster{,_template} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/866796 | |
| 13:45:11 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: Rework 'details' parameter for baremetal proxy https://review.opendev.org/c/openstack/openstacksdk/+/869370 | |
| 13:45:27 | stephenfin | frickler: ^ | |
| 14:23:25 | frickler | stephenfin: thx, I'll mostly have to defer to what the CI says though | |
| 15:10:10 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Move _normalize_coe_* into _coe class https://review.opendev.org/c/openstack/openstacksdk/+/865043 | |
| 15:50:08 | lajoskatona | stephenfin, frickler: Hi, a question to think about regarding networking stadium projects CLI and python binding code | |
| 15:50:33 | lajoskatona | stephenfin, frickler: back in December we discussed it on team meeting: https://meetings.opendev.org/meetings/networking/2022/networking.2022-12-20-14.01.log.html#l-108 | |
| 15:51:14 | lajoskatona | stephenfin, frickler: frickler already shared his opinion but I think it is better to have the discussion here also perhaps with more people | |
| 15:52:07 | gtema | can you please reiterate what is stadium and what you want to achieve? | |
| 15:53:22 | lajoskatona | gtema: stadium projects for Neutron are projects that implement some networking feature/functionality with extra API that is not in core Neutron (like neutron-fwaas for Firewalls, neutron-dynamic-routing for BGP etc...) | |
| 15:54:31 | gtema | vpnaas as well? | |
| 15:54:33 | lajoskatona | gtema: so these are not core networking features, but now we have the CLI code (both old neutron commands and OSC plugin) in most cases in python-neutronclient repo | |
| 15:54:49 | lajoskatona | gtema yes vpnaas is also a stadium project | |
| 15:54:59 | gtema | okay | |
| 15:56:21 | lajoskatona | gtema: and we already deprecated the CLI code in python-neutronclient but the python bining code is also there, and even some OSC plugins call into the python binding of neutronclient instead of SDK | |
| 15:58:22 | gtema | ok, and so we should add those into the sdk and cli | |
| 15:59:00 | lajoskatona | gtema: and the question is that can we put these SDK methods (like add_bgp_speaker_to_dragent) to openstacksdk or keep them in neutronclient, and the same for the CLI part, shall we add these to osc or keep them as plugins in neutronclient? | |
| 15:59:40 | gtema | I would really like to see us starting adding those to sdk so that later also ansible modules can make use of that | |
| 15:59:59 | gtema | and once sdk is done also osc | |
| 16:00:02 | lajoskatona | gtema: if you can check the meeting log from December which I linked, the argument was to move only openstack network * commands, but that was just a first glance idea at that time | |
| 16:00:23 | gtema | or alternatively keep those in neutronclient (cli part), but use sdk as base | |
| 16:00:35 | lajoskatona | gtema: ok | |
| 16:01:18 | gtema | from my pov it is really important to have sdk coverage | |
| 16:01:45 | gtema | sooner or later somebody would want to use those things with ansible (as is now the case for vpn) | |
| 16:01:52 | gtema | and having sdk support is crucial here | |
| 16:02:01 | lajoskatona | gtema: I pushed a first wip for tap-as-a-service (https://review.opendev.org/c/openstack/tap-as-a-service/+/867786 ) its CLI code is in tap-as-a-service repo so not in neutronclient but perhaps good to see what it means | |
| 16:02:29 | lajoskatona | if we have to do everythin outside SDK, so if we can add these methods to openstacksdk that is a big help I think | |
| 16:02:51 | gtema | definitely move to sdk | |
| 16:02:58 | gtema | I see no reason not to do this | |
| 16:03:31 | gtema | cli part may be separate OSC plugin, but sdk from my pov should be having support for everything what exists in openstack | |
| 16:04:16 | lajoskatona | gteam: sounds cool | |
| 16:04:47 | lajoskatona | gtema: do we need to bring this to some formal meeting, or open some spec or bug or similar? | |
| 16:05:14 | gtema | nope, just feel free to start adding directly to sdk | |
| 16:06:18 | lajoskatona | gtema: ok, thanks, we have a neutron bug to track this effort, so I can use that for tag and in commit msg to have the context for everybody | |
| 16:06:39 | gtema | sounds great | |
| 16:25:04 | opendevreview | Merged openstack/openstacksdk master: Move normalize security group to sg class https://review.opendev.org/c/openstack/openstacksdk/+/865025 | |
| 16:33:05 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored coe_cluster{,_template} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/866796 | |
| 16:47:29 | opendevreview | Merged openstack/openstacksdk master: Move normalize_server to compute mixin https://review.opendev.org/c/openstack/openstacksdk/+/866567 | |
| #openstack-sdks - 2023-01-06 | |||
| 08:13:38 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add volume summary command https://review.opendev.org/c/openstack/python-openstackclient/+/869436 | |
| 08:20:20 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add volume summary command https://review.opendev.org/c/openstack/python-openstackclient/+/869436 | |
| 09:46:31 | frickler | stephenfin: since your fix doesn't seem to work yet, can we go with the revert for now? or do a partial revert only for the baremetal part? | |
| 10:07:42 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 10:19:50 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored coe_cluster{,_template} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/866796 | |
| 10:21:42 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored coe_cluster{,_template} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/866796 | |
| 10:23:53 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 10:47:05 | stephenfin | frickler: I'd be okay with a partial revert, sure | |
| 10:47:13 | stephenfin | If you want to propose it, I'll review | |
| 11:12:59 | opendevreview | Lajos Katona proposed openstack/python-openstackclient master: Move network trunk commands from python-neutronclient https://review.opendev.org/c/openstack/python-openstackclient/+/869447 | |
| 11:24:18 | opendevreview | Dr. Jens Harbott proposed openstack/openstacksdk master: Revert "Add 'details' parameter to various 'find' proxy methods" https://review.opendev.org/c/openstack/openstacksdk/+/869315 | |
| 11:38:48 | opendevreview | Dr. Jens Harbott proposed openstack/openstacksdk master: DNM: Testing legacy job https://review.opendev.org/c/openstack/openstacksdk/+/869472 | |
| 12:15:11 | opendevreview | Lajos Katona proposed openstack/python-openstackclient master: Move network trunk commands from python-neutronclient https://review.opendev.org/c/openstack/python-openstackclient/+/869447 | |
| 12:30:02 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 12:35:40 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 12:40:04 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 13:21:31 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated contributor docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 14:02:32 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated contributor docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 14:03:10 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 14:20:32 | frickler | stephenfin: tox is completely acting up now on 869315 and I cannot reproduce locally. I'm holding a node for investigation now, but if you have any idea, feel free to join in | |
| 14:21:41 | gtema | yeah, tox became a real mess, myself debugging issues with it | |
| 14:30:10 | frickler | oh, I missed the explicit "--skip-missing-interpreters=false" parameter that we call tox with | |
| 14:43:08 | opendevreview | Dr. Jens Harbott proposed openstack/openstacksdk master: DNM test tox workaround https://review.opendev.org/c/openstack/openstacksdk/+/869480 | |
| 14:56:36 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 14:58:57 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 15:02:52 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 15:29:34 | stephenfin | frickler: if you want to get that passing, you either (a) drop usedevelop=true from tox.ini or (b) wait for https://github.com/tox-dev/tox/pull/2828 to merge | |
| 16:29:07 | opendevreview | Lajos Katona proposed openstack/openstacksdk master: Add BGP Speakers and Peers to SDK https://review.opendev.org/c/openstack/openstacksdk/+/869485 | |
| 17:26:47 | frickler | stephenfin: tox 4.2.5 doesn't help either. dropping usedevelop gives yet another error then: SystemExit: error: Multiple top-level packages discovered in a flat-layout: ['vv', 'extras', 'devstack', 'openstack', 'playbooks', 'releasenotes']. | |
| 17:27:10 | stephenfin | frickler: That's https://review.opendev.org/c/openstack/pbr/+/869082 | |
| 17:28:44 | stephenfin | That should be merged today and released Monday so we'll be unblocked then | |
| 17:28:55 | stephenfin | clarkb and fungi are looking at it | |
| 17:31:29 | fungi | yeah, just discussing how to preserve test coverage for older platforms now, i think clarkb is pushing up a new revision or additional change for it | |
| 17:31:52 | fungi | as a followup, according to what he said in #opendev | |
| 17:37:20 | fungi | er, in #openstack-infra i mean | |
| 17:37:32 | fungi | well, both | |
| 17:39:14 | whoami-rajat | stephenfin, hey, regarding your comment here https://review.opendev.org/c/openstack/python-openstackclient/+/869436/2/openstackclient/tests/unit/volume/v3/test_volume.py#123 | |
| 17:39:22 | whoami-rajat | I tried that before but did that with assertEqual | |
| 17:39:31 | whoami-rajat | in the examples i see assertCountEqual being used | |
| 17:39:54 | whoami-rajat | but I'm unsure if it compares the DictColumn ? | |
| 17:42:00 | stephenfin | can you rephrase the question? | |
| 17:43:55 | whoami-rajat | does the assertCountEqual method actually compare DictColumn? | |
| 17:45:17 | whoami-rajat | IIUC it takes frequency of elements and compares that, like Counter(list1) == Counter(list2) | |
| 17:45:43 | whoami-rajat | and that's what is used in tests to compare values with DictColumn in it | |
| 17:47:04 | whoami-rajat | like here https://github.com/openstack/python-openstackclient/blob/7985d496892635b70b71be552c52946824d73e9b/openstackclient/tests/unit/volume/v2/test_volume.py#L1125 | |
| 17:47:23 | whoami-rajat | stephenfin, ^ | |
| 17:49:23 | stephenfin | well you can check. Remove dictcolumn from one of the tests that has it and see if the test continues to pass | |
| 17:49:32 | stephenfin | but the answer is yes, it does compare as expected | |
| 17:50:21 | stephenfin | they're comparable because of this https://github.com/openstack/cliff/commit/c1c991045cece85dd55494f9d4670429e370e131 | |
| 17:51:05 | stephenfin | sorry, this https://github.com/openstack/cliff/commit/997e05fce6cf2267099f3d5f91116ba491495d7e | |
| 17:51:31 | stephenfin | (The first commit should have said "sortable", not "comparable") | |
| 17:55:39 | whoami-rajat | ok, i see it failing with a fake value, DictColumn(meta) != DictColumn({'fake':'dict'}) | |
| 17:55:43 | whoami-rajat | will update it | |
| 17:55:44 | whoami-rajat | thanks | |
| 18:18:22 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add volume summary command https://review.opendev.org/c/openstack/python-openstackclient/+/869436 | |
| 19:11:02 | opendevreview | Corey Bryant proposed openstack/openstackclient master: Test to ensure tox is pinned for stable/zed https://review.opendev.org/c/openstack/openstackclient/+/869504 | |
| 19:11:50 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 19:38:25 | opendevreview | Corey Bryant proposed openstack/python-openstackclient stable/zed: [DNM] Test to ensure tox is pinned for stable/zed https://review.opendev.org/c/openstack/python-openstackclient/+/869505 | |
| #openstack-sdks - 2023-01-09 | |||
| 11:22:53 | opendevreview | Polina Gubina proposed openstack/ansible-collections-openstack master: Volume module: - Add 'is_multiattach' parameter. When it is true, volume will be shareble https://review.opendev.org/c/openstack/ansible-collections-openstack/+/865477 | |
| 14:07:18 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 14:10:34 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |