| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2022-10-28 | |||
| 10:21:14 | gtema | which cloud you use? | |
| 10:21:14 | ard_ | gtema: you mean it is something with my sandbox | |
| 10:21:14 | jm1 | gtema: where does this 'stores' come from and why is it passed to glance api? | |
| 10:22:17 | gtema | ard_ or is it real upstream deployed as private cloud? | |
| 10:22:46 | ard_ | it is aio deployment for testing purposes | |
| 10:23:08 | gtema | ok, never tried that | |
| 10:28:00 | gtema | I can reproduce it now once I try to set another property | |
| 10:47:30 | gtema | one awesome finding here: glance responds `Invalid operation: `move`. It must be one of the following: add, remove, replace.` and patch is generated by jsonpatch lib | |
| 10:47:39 | gtema | this looks like fun | |
| 10:51:08 | jm1 | gtema: incompatibility between jsonpatch lib used in glance and ard_'s venv or bug in glance? | |
| 10:52:14 | gtema | no clue. It doesn't mean every user will face it, since you need to have situation where jsonpatch desides attribute is "renamed" keeping the content | |
| 12:04:47 | gtema | jm1 ard_ - I am able to reproduce it now in the unittest, still digging where is it coming from. It is definitely a victim of magic properties handling | |
| 12:25:33 | jm1 | ard_: look at that, you can actually update the ramdisk and kernel in devstack https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_e3c/862864/1/check/ansible-collections-openstack-functional-devstack/e3c2883/job-output.txt | |
| 12:29:55 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Existing images update name, visibility etc https://review.opendev.org/c/openstack/ansible-collections-openstack/+/862565 | |
| 14:03:28 | arddennis | jm1: yes you can probably update kernel and ramdisk, but at some point of time you could loose this ability. And the question was more to highlight my misunderstanding of the situation. Where the property which is supposed to be changeable is not and vise versa. | |
| 14:49:19 | gtema | ard_ jm1: instead of invoking update_image a call to update_image_properties can be used (https://paste.opendev.org/show/beYgrcpmaEw1pIM6cFtU/). This is what is currently used in the cloud layer and is working. I am still trying to find out why update_image itself is corrupting extra params | |
| 16:05:08 | arddennis | gtema jm1: Do you think it is reasonable to move update for the properties out of the image update and make two api requests instead of one if properties are defined? It isn't hard to implement. | |
| 16:06:15 | gtema | point is that for historical reasons all "custom" properties of images are stored in OSC and SDK under "properties" attribute | |
| 16:06:37 | gtema | as customs all attrs not currently defined under Image resource are meant | |
| 16:07:08 | gtema | so when you want to access such prop - you need to look under image.properties["foo"] | |
| 16:07:34 | gtema | and when you want to update such props you need to use coinn.image.update_image_properties(foo="bar") | |
| 16:08:16 | arddennis | yes, first when I saw it I was a little bit confused, then accepted it. | |
| 16:08:28 | gtema | if you try to pass conn.image.update_image(foo="bar") foo is identified as custom property and then SDK does not know - what do you want to do with other custom properties - only change single one or reset them all | |
| 16:08:47 | gtema | problem right now is merging or the nested dicts | |
| 16:10:31 | gtema | but I agree, this is now pretty confusing and not self-explaining from docs | |
| 16:28:20 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Revert openstack.cloud.server parameter user_data to userdata https://review.opendev.org/c/openstack/ansible-collections-openstack/+/862935 | |
| 16:38:03 | servagem | Hi, could someone review this patch? It is missing one approval. Thank you. https://review.opendev.org/c/openstack/python-openstackclient/+/862513 | |
| 17:20:42 | jm1 | arddennis: would you please review the latest patchset? https://review.opendev.org/c/openstack/ansible-collections-openstack/+/862565/ | |
| #openstack-sdks - 2022-10-29 | |||
| 00:58:51 | opendevreview | Daniel Wilson proposed openstack/openstacksdk master: Accept queries when listing migrations https://review.opendev.org/c/openstack/openstacksdk/+/862664 | |
| 01:16:34 | opendevreview | Daniel Wilson proposed openstack/python-openstackclient master: Use the compute SDK in server list https://review.opendev.org/c/openstack/python-openstackclient/+/861546 | |
| 08:57:48 | opendevreview | Merged openstack/ansible-collections-openstack master: Revert openstack.cloud.server parameter user_data to userdata https://review.opendev.org/c/openstack/ansible-collections-openstack/+/862935 | |
| #openstack-sdks - 2022-10-30 | |||
| 22:28:48 | opendevreview | Daniel Wilson proposed openstack/python-openstackclient master: Use the SDK in server migration list https://review.opendev.org/c/openstack/python-openstackclient/+/862985 | |
| #openstack-sdks - 2022-10-31 | |||
| 11:33:21 | opendevreview | Denys Mishchenko proposed openstack/ansible-collections-openstack master: Existing images update name, visibility etc https://review.opendev.org/c/openstack/ansible-collections-openstack/+/862565 | |
| #openstack-sdks - 2022-11-01 | |||
| 16:50:24 | opendevreview | Rafael Castillo proposed openstack/openstacksdk master: Add all_projects parameter to find_server https://review.opendev.org/c/openstack/openstacksdk/+/857936 | |
| 16:59:32 | opendevreview | Rafael Castillo proposed openstack/openstacksdk master: Add all_projects parameter to find_server https://review.opendev.org/c/openstack/openstacksdk/+/857936 | |
| 17:01:14 | opendevreview | Rafael Castillo proposed openstack/openstacksdk master: Adds shelf offload action to server proxy https://review.opendev.org/c/openstack/openstacksdk/+/857947 | |
| 17:25:41 | opendevreview | Rafael Castillo proposed openstack/openstacksdk master: Adds shelf offload action to server proxy https://review.opendev.org/c/openstack/openstacksdk/+/857947 | |
| 18:24:15 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Updates server action for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/857976 | |
| 18:24:31 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Updates server action for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/857976 | |
| 18:28:47 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Updates server action for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/857976 | |
| 20:20:02 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Updates server_metadata for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863178 | |
| 22:19:22 | opendevreview | Rafael Castillo proposed openstack/openstacksdk master: Add all_projects parameter to find_server https://review.opendev.org/c/openstack/openstacksdk/+/857936 | |
| 22:20:59 | opendevreview | Rafael Castillo proposed openstack/openstacksdk master: Add all_projects parameter to find_server https://review.opendev.org/c/openstack/openstacksdk/+/857936 | |
| 22:21:23 | opendevreview | Rafael Castillo proposed openstack/openstacksdk master: Adds shelf offload action to server proxy https://review.opendev.org/c/openstack/openstacksdk/+/857947 | |
| 22:51:15 | opendevreview | Rafael Castillo proposed openstack/openstacksdk master: Add all_projects parameter to find_server https://review.opendev.org/c/openstack/openstacksdk/+/857936 | |
| 22:51:39 | opendevreview | Rafael Castillo proposed openstack/openstacksdk master: Adds shelf offload action to server proxy https://review.opendev.org/c/openstack/openstacksdk/+/857947 | |
| #openstack-sdks - 2022-11-02 | |||
| 10:26:39 | opendevreview | PB proposed openstack/ansible-collections-openstack master: updated argument spec based on documentation example https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 10:58:45 | opendevreview | PB proposed openstack/ansible-collections-openstack master: updated argument spec based on documentation example https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 11:17:57 | opendevreview | PB proposed openstack/ansible-collections-openstack master: updated argument spec based on documentation example https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 11:39:47 | opendevreview | PB proposed openstack/ansible-collections-openstack master: updated argument spec based on documentation example https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 11:40:09 | opendevreview | PB proposed openstack/ansible-collections-openstack master: updated argument spec based on documentation example https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 12:10:39 | opendevreview | PB proposed openstack/ansible-collections-openstack master: updated argument spec based on documentation example https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 12:27:26 | opendevreview | PB proposed openstack/ansible-collections-openstack master: updated argument spec based on documentation example https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 13:08:27 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Existing images update name, visibility etc https://review.opendev.org/c/openstack/ansible-collections-openstack/+/862565 | |
| 13:20:43 | arddennis | jm1: regarding https://review.opendev.org/c/openstack/ansible-collections-openstack/+/862565 what is required from my side to do? Should I change script logic to use additional method to update properties instead of image.id usage? It seems that next steps are not clean for me. | |
| 13:21:15 | jm1 | arddennis: hey :) i just submitted an update for that patch :D | |
| 13:21:42 | jm1 | arddennis: you dont have to do anything. once ci has passed and you are happy with my changes, we just need another core to vote on that patch and then we can merge it | |
| 13:22:43 | arddennis | jm1: sounds good :) | |
| 13:23:08 | jm1 | arddennis: so please vote on the changes :D | |
| 13:30:58 | jm1 | arddennis: thanks and sshnaidm has voted too! so once ci has passed, we can merge :) | |
| 13:31:12 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: DNM test latest devel test https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863267 | |
| 14:18:08 | opendevreview | PB proposed openstack/ansible-collections-openstack master: updated argument spec based on documentation example https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 14:20:57 | opendevreview | PB proposed openstack/ansible-collections-openstack master: Bulk creation of OpenStack SG rules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 17:54:13 | opendevreview | Merged openstack/ansible-collections-openstack master: Existing images update name, visibility etc https://review.opendev.org/c/openstack/ansible-collections-openstack/+/862565 | |
| 18:48:10 | opendevreview | PB proposed openstack/ansible-collections-openstack master: Bulk creation of OpenStack SG rules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863431 | |
| 19:24:19 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Fix documentation defaults for modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863267 | |
| 19:24:41 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Fix documentation defaults for modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863267 | |
| 21:15:43 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Fix documentation defaults for modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863267 | |
| 21:19:04 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Fix documentation defaults for modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863267 | |
| #openstack-sdks - 2022-11-03 | |||
| 08:13:53 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863483 | |
| 08:35:58 | opendevreview | PB proposed openstack/ansible-collections-openstack master: Bulk creation of OpenStack SG rules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 09:18:21 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863483 | |
| 09:27:37 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | |
| 09:32:11 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863483 | |
| 09:32:36 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | |
| 10:29:31 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | |
| 10:30:23 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_snapshot{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863498 | |
| 11:47:41 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored config module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863512 | |
| 12:44:14 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored config module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863512 | |
| 13:05:52 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Updates server_metadata for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863178 | |
| 13:19:46 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Updates server action for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/857976 | |
| 13:19:55 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Updates server_metadata for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863178 | |
| 13:45:00 | rcastillo | gtema: hi, it'd be awesome if you could have a look at this patch when you get a chance https://review.opendev.org/c/openstack/openstacksdk/+/857947 | |
| 13:45:13 | gtema | ack | |
| 14:10:59 | opendevreview | TaeJun Jang proposed openstack/python-openstackclient master: title: Add image metadef namespace command https://review.opendev.org/c/openstack/python-openstackclient/+/863525 | |
| 14:35:43 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | |
| 14:42:29 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored integration test of openstacksdk logging feature https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863529 | |
| 15:07:53 | opendevreview | Merged openstack/ansible-collections-openstack master: Refactored volume_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863483 | |
| 16:14:03 | servagem | Hello! Could someone review patch https://review.opendev.org/c/openstack/python-openstackclient/+/862513 ? Thank you | |
| 20:19:23 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | |
| #openstack-sdks - 2022-11-04 | |||
| 08:54:53 | opendevreview | Merged openstack/ansible-collections-openstack master: Fix documentation defaults for modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863267 | |
| 10:25:02 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | |
| 10:26:09 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_snapshot{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863498 | |
| 10:28:19 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored config module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863512 | |
| 10:28:52 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored integration test of openstacksdk logging feature https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863529 | |
| 10:38:03 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Fix backup metadata management https://review.opendev.org/c/openstack/openstacksdk/+/863634 | |
| 10:38:26 | gtema | jm1 - this is for you | |
| 10:39:11 | jm1 | gtema: uuuh nice :D thx! | |
| 10:39:51 | gtema | as usual - one line of code is causing heavy misbehave | |
| 10:41:55 | jm1 | gtema: this has never worked before, has it? wondering how people tested their code when they contributed it .. | |