| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2021-09-03 | |||
| 06:25:03 | gtema | https://meetings.opendev.org/irclogs/%23openstack-sdks/%23openstack-sdks.2021-09-02.log.html | |
| 06:25:51 | gtema | But generally - install matrix client (i.e. Element) and enter this room through irc bridge | |
| 06:25:59 | thomasb06 | got it, thank you | |
| 06:26:52 | gtema | https://github.com/matrix-org/matrix-appservice-irc/wiki/Bridged-IRC-networks | |
| 06:27:35 | gtema | This is really the best way for staying connected (for those not grown up in IRC age;-) | |
| 06:30:13 | thomasb06 | great, I'll give it a try | |
| 06:30:46 | gtema | Cool | |
| 06:42:10 | thomasb06 | what about https://x0.at/OYEh.txt ? | |
| 06:43:55 | gtema | almost | |
| 06:44:23 | gtema | you still should have exception handling block to prevent that the key (alternate_id) is known, but attribute is still missing | |
| 06:45:51 | gtema | we can potentially try elif ... return self._body.get(key) - this is kinda exception handling | |
| 06:46:49 | gtema | and also, I would potentially try to get _alternate_id() first not to invoke it 2 times | |
| 06:58:31 | thomasb06 | do we have a Walrus operator: https://x0.at/-qjT.txt | |
| 06:58:37 | thomasb06 | ? | |
| 08:14:38 | gtema | you can always try if you not sure | |
| 08:15:09 | gtema | our jobs will run all required tests with multiple py versions and you will see whether something is not working in particular py version | |
| 08:25:56 | thomasb06 | ok, this afternoon I'll commit the modification. What I need to do is clone the sdk repo and activate gerrit in it: https://opendev.org/openstack/openstacksdk.git ? | |
| 08:28:56 | gtema | yes, but please remember - try to make change for feature/r1 branch | |
| 08:29:35 | gtema | if doesn't work - do in master | |
| 08:35:53 | thomasb06 | if I remember well, the command to switch branch is `git checkout feature/r1` ? Option -b is when the branch doesn't exists but it's not the case: https://opendev.org/openstack/openstacksdk/src/branch/feature/r1 | |
| 08:36:33 | gtema | right. You might try to do `git checkout origin/feature/r1` | |
| 08:36:48 | gtema | I remember there was a challenge, but do not remember how exactly I managed this | |
| 08:38:34 | thomasb06 | it said: «HEAD is now at ed63ed6e Merge "Vpn ike policy resource" into feature/r1» | |
| 08:38:44 | gtema | good | |
| 08:51:04 | thomasb06 | sent: https://review.opendev.org/c/openstack/openstacksdk/+/807274 | |
| 08:51:53 | gtema | Good. Now you can sit and relay waiting for the results (up to 2 hours, since we have really lots of jobs) | |
| 08:52:23 | thomasb06 | cool. Time to go for my meal then | |
| 08:52:32 | gtema | and prepare to rework you change by changing commit message renaming it and giving reasonable description of the change | |
| 08:52:37 | gtema | enjoy | |
| 08:53:45 | thomasb06 | ah, of course... Until now, I've only made commits to training repos | |
| 08:53:53 | gtema | yupp | |
| 08:54:08 | gtema | remember to use `git commit --amend` not to produce new change | |
| 09:00:48 | thomasb06 | ok, I didn't now this command. The manual says it's like a reset and commit -c combined | |
| 09:01:25 | gtema | no - this is "rewrite last commit" | |
| 09:49:26 | opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 21:05:41 | thomasb06 | gtema: the operator `:=` doesn't work but with a key it went well: https://review.opendev.org/c/openstack/openstacksdk/+/807334 | |
| #openstack-sdks - 2021-09-04 | |||
| 06:32:53 | opendevreview | JIHOJU proposed openstack/python-openstackclient master: Add more filter option of columns for server list -c COLUMN https://review.opendev.org/c/openstack/python-openstackclient/+/807420 | |
| 07:20:52 | thomasb06 | to go backward 3 commits, it's `git rebase -i HEAD~3`, then change pick by drop, then `git commit --amend` to change the commit message, and to end `git review`? | |
| 07:42:31 | gtema | Well, 2 options | |
| 07:42:56 | gtema | 1) in UI click rebase and select "to HEAD" | |
| 07:43:58 | gtema | 2) do "git review -d LAST_CHANGE" and "git rebase feature/R1" | |
| 07:45:01 | gtema | In any way important: last line of commit message is changeid, this is the identifier for Gerrit. Once this changes you produce new change | |
| 07:45:48 | gtema | And every time you do regular commit your local hooks tend to ensure there is changeid there | |
| 07:46:41 | gtema | Wrt 2) somehow I am not 100% sure it will work. It may decide to rebase whole change and not only the last change | |
| 07:46:53 | gtema | Thus option 1) is the easiest way | |
| 09:16:31 | thomasb06 | as I have no UI, I'll go for option 2). Monday I'm back on the computer that has the repo, I'll try to rebase there. If clone the repository again on another computer and commit other changes, it's going to be messy I guess? | |
| 09:37:41 | thomasb06 | from another computer: https://review.opendev.org/c/openstack/openstacksdk/+/807427 | |
| 09:38:08 | thomasb06 | branch is feature/r1 and it's one commit far from the Head | |
| 09:47:00 | gtema | Under UI I mean gerrit | |
| 10:42:33 | thomasb06 | Yes, I haven't installed the gerrit UI yet. What I did was to clone the repository on another computer and as the copy was clean redo the modifications straight from the Head. Monday, I'll need to clean the three failed commit but I'm not sure about how to do it. Maybe `git fetch --force`? | |
| 11:06:41 | gtema | You don't install it | |
| 11:06:57 | gtema | The link you posted - simply open it with browser | |
| #openstack-sdks - 2021-09-06 | |||
| 09:44:23 | thomasb06 | About the three commits I did wrong, would it be enough to click 'Abandon' in the UI? | |
| 09:44:47 | gtema | yes | |
| 09:54:36 | thomasb06 | Done, the new commit is: https://review.opendev.org/c/openstack/openstacksdk/+/807427 | |
| 09:56:57 | thomasb06 | Sorry about it. Next time, I'll be more carefull and use commit --amend. From 4pm to 6pm, I have another tiny timeframe if you would have another cleaning modification for me | |
| 10:12:53 | gtema | thomasb06: if you look at https://opendev.org/openstack/openstacksdk/src/branch/feature/r1/openstack/tests/unit/block_storage/v3/test_proxy.py#L36 (pretty much the file as whole) | |
| 10:13:04 | gtema | you see there are multiple test classes | |
| 10:13:17 | gtema | which split test functions base on the "resource" we test | |
| 10:13:44 | gtema | similar is present in https://opendev.org/openstack/openstacksdk/src/branch/feature/r1/openstack/tests/unit/compute/v2/test_proxy.py | |
| 10:14:18 | gtema | so if you can apply the same pattern (splitting single test class into multiple) for all the other services it would be great | |
| 10:14:34 | gtema | basically openstacl/tests/unit//v/test_proxy.py | |
| 10:14:40 | gtema | * basically openstack/tests/unit//v/test_proxy.py | |
| 10:29:24 | thomasb06 | If I understood well you would need all the files `openstack/tests/unit/*/v/test_proxy.py` to be split into test classes as in `block_storage/v3/test_proxy.py` and `compute/v2/test_proxy.py` ? | |
| 10:30:42 | gtema | Yes | |
| 10:31:25 | thomasb06 | Very well, I start today | |
| 10:31:36 | gtema | You can also consult with the corresponding proxy file at all | |
| 10:32:13 | gtema | If you want, we can perhaps have a call today so that I get you briefly through the structure of the project | |
| 10:32:41 | thomasb06 | Maybe it's safer indeed | |
| 10:33:45 | thomasb06 | We have the same timezone so between 4 and 6, you can call any time. And at other moments too, I can take a 5mn break | |
| 10:34:16 | thomasb06 | may I post my number here? Not too sure about it... | |
| 10:35:46 | gtema | Not necessary | |
| 10:36:00 | gtema | I will send link for web conference | |
| 10:36:07 | gtema | Around 17 | |
| 10:36:36 | thomasb06 | Alright, I'll by my mailbox | |
| 11:41:39 | opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: Add Neutron Local IP CRUD https://review.opendev.org/c/openstack/openstacksdk/+/804988 | |
| 14:36:21 | gtema | thomasb06, are you here? Having time now? | |
| 14:38:51 | thomasb06 | Yes, I'm ready | |
| 14:40:07 | gtema | https://meetpad.opendev.org/sdk | |
| #openstack-sdks - 2021-09-07 | |||
| 12:07:40 | opendevreview | Laurent Almeras proposed openstack/ansible-collections-openstack master: use idempotent behavior + diff https://review.opendev.org/c/openstack/ansible-collections-openstack/+/806745 | |
| 14:21:45 | thomasb06 | gtema: Hello. Maybe I can start with `feature/r1/openstack/tests/unit/image/v2`, there seem to be few test files in the tree? | |
| 14:36:37 | thomasb06 | first trial of spliting the `TestImageProxy` class: https://review.opendev.org/c/openstack/openstacksdk/+/807734 | |
| 14:41:24 | gtema | yeah thomasb06 - left comments. You need to split it further as this change (one file per change, and not one split per change | |
| 14:53:42 | thomasb06 | corrected | |
| 14:57:36 | gtema | thks | |
| 15:21:21 | thomasb06 | and I just added the `TestMisc` class | |
| #openstack-sdks - 2021-09-08 | |||
| 14:21:09 | opendevreview | Rodolfo Alonso proposed openstack/openstacksdk master: Add "check_limit" to network Quota class https://review.opendev.org/c/openstack/openstacksdk/+/806254 | |
| 14:33:57 | thomasb06 | gtema: the accelerator unit test can split too | |
| 14:34:11 | gtema | Ok | |
| 14:36:48 | thomasb06 | how can I make a `git pull` to get the latest files? This command asks for a distant and a branch | |
| 14:44:47 | thomasb06 | Here is the commit: https://review.opendev.org/c/openstack/openstacksdk/+/807886 | |
| #openstack-sdks - 2021-09-09 | |||
| 13:21:31 | gtema | thomasb06 - if your question is still valid - you should not really use git pull (unless willing to go to real clean master). Instead you do `git review -d CHANGE_ID`. This will ensure you get latest version of your change | |
| 13:21:51 | gtema | otherwise (for branch) `git checkout master && git pull` | |
| 13:50:56 | opendevreview | Alfredo Moralejo proposed openstack/python-openstackclient master: Replace assertItemsEqual with assertCountEqual https://review.opendev.org/c/openstack/python-openstackclient/+/808079 | |
| 14:52:24 | ebbex | I have a problem where "openstack image set --property hw_qemu_guest_agent=no <uuid> && openstack image show <uuid>" always shows up as hw_qemu_guest_agent='True' in the output, can anyone else see if they get the same result? | |
| 14:53:52 | gtema | you may try to use `openstack image unset --property hw_qemu_guest_agent <uuid>`. Maybe this can make it | |
| 14:53:59 | ebbex | "glance image-show <uuid>" shows it correctly as "no". | |
| 14:54:48 | ebbex | I can even set the property to "horse" and glance shows it correctly but the openstack-client always evaluates it to 'True' for some reason. | |
| 14:54:59 | gtema | hmm, can you post output of the API response from`openstack image show <uuid> --debug`? | |
| 14:55:39 | ebbex | and it's only this property for some reason, hw_machine_type, hw_disk_bus, hw_scsi_model, etc. all fine. | |