Posted	Nick	Remark
#openstack-sdks - 2021-03-24
13:01:49	frickler	stephenfin: seems you misread my comment about indentation in https://review.opendev.org/c/openstack/openstacksdk/+/782578/2..3/README.rst , there still is only one space from "clouds:" to "mordred:". I meant to only remove one space from L31, not from all the others, too
13:02:18	stephenfin	oh, so I did
13:02:24	stephenfin	I'll push a follow-up to fix that
13:02:29	stephenfin	rather than rebase it again
13:43:40	openstackgerrit	Stephen Finucane proposed openstack/openstacksdk master: Add minimal support for Placement https://review.opendev.org/c/openstack/openstacksdk/+/745375
13:47:44	openstackgerrit	Stephen Finucane proposed openstack/openstacksdk master: Improve README to provide example of Resource usage https://review.opendev.org/c/openstack/openstacksdk/+/782578
13:47:47	openstackgerrit	Stephen Finucane proposed openstack/openstacksdk master: docs: Add intro doc to user guide https://review.opendev.org/c/openstack/openstacksdk/+/782704
13:47:50	openstackgerrit	Stephen Finucane proposed openstack/openstacksdk master: tox: Enable parallel docs build https://review.opendev.org/c/openstack/openstacksdk/+/782705
13:48:03	stephenfin	frickler: Changed my mind ^
14:03:28	openstackgerrit	Merged openstack/openstacksdk master: Added support for the Capabilities resource https://review.opendev.org/c/openstack/openstacksdk/+/777895
14:23:28	openstackgerrit	Valery Tschopp proposed openstack/python-openstackclient master: Implements hide image https://review.opendev.org/c/openstack/python-openstackclient/+/773649
14:35:50	openstackgerrit	Valery Tschopp proposed openstack/python-openstackclient master: Implements hide image https://review.opendev.org/c/openstack/python-openstackclient/+/773649
15:11:52	openstackgerrit	Ashley Rodriguez proposed openstack/openstacksdk master: Add share resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/775707
16:00:36	openstackgerrit	Riccardo Pittau proposed openstack/openstacksdk master: Fixing more import orders https://review.opendev.org/c/openstack/openstacksdk/+/782809
17:02:24	openstackgerrit	Valery Tschopp proposed openstack/python-openstackclient master: Implements hide image https://review.opendev.org/c/openstack/python-openstackclient/+/773649
18:09:55	openstackgerrit	Stephen Finucane proposed openstack/openstacksdk master: Add minimal support for Placement https://review.opendev.org/c/openstack/openstacksdk/+/745375
18:10:17	stephenfin	That was much trickier than I thought
18:11:27	stephenfin	gtema: Not for today, but that one is a bit weird. Placement didn't provide a body for POST (create) requests until microversion 1.20
18:11:39	stephenfin	so I've set _max_microversion, but what I really want is a _min_microversion
18:12:01	gtema	:) life is going to be more interesting with that
18:12:39	stephenfin	otherwise I need to set 'create_returns_body' dynamically or something
18:12:54	stephenfin	perhaps, but I think we need something like that
18:13:22	stephenfin	unless we want to start encoding microversion specific behaviour into each Resource implementation
18:13:31	gtema	ok, will think also
18:13:50	stephenfin	I can take a look at how hard it'll be. It's popped up a few times
18:14:20	stephenfin	for some of the NDSU stuff too. I think maybe twilit_dragon's patch?
18:14:32	gtema	should not be that hard, but tricky to get those few lines working properly
18:17:21	gtema	maybe. Sorry, need to go
21:05:56	openstackgerrit	Merged openstack/openstacksdk master: Update master for stable/wallaby https://review.opendev.org/c/openstack/openstacksdk/+/781700
22:55:59	openstackgerrit	Slawek Kaplonski proposed openstack/openstacksdk master: Add support for the Neutron L3 conntrack helper API https://review.opendev.org/c/openstack/openstacksdk/+/782870
#openstack-sdks - 2021-03-25
03:30:10	openstackgerrit	Alexander Wilcox proposed openstack/openstacksdk master: This is the Host Extension Resource, for capstone. https://review.opendev.org/c/openstack/openstacksdk/+/776320
04:18:16	openstackgerrit	Alexander Wilcox proposed openstack/openstacksdk master: This is the Host Extension Resource, for capstone. https://review.opendev.org/c/openstack/openstacksdk/+/776320
06:21:15	openstackgerrit	Dylan Zapzalka proposed openstack/openstacksdk master: WIP Added support for the Quota class set extension resource https://review.opendev.org/c/openstack/openstacksdk/+/777934
06:44:10	openstackgerrit	Dylan Zapzalka proposed openstack/openstacksdk master: Added support for the Quota class set extension resource https://review.opendev.org/c/openstack/openstacksdk/+/777934
07:24:41	openstackgerrit	Slawek Kaplonski proposed openstack/openstacksdk master: Add support for the Neutron L3 conntrack helper API https://review.opendev.org/c/openstack/openstacksdk/+/782870
07:57:45	openstackgerrit	Valery Tschopp proposed openstack/python-openstackclient master: Implements hide image https://review.opendev.org/c/openstack/python-openstackclient/+/773649
08:37:42	openstackgerrit	Riccardo Pittau proposed openstack/openstacksdk master: Fix more import order in tests https://review.opendev.org/c/openstack/openstacksdk/+/780903
08:37:42	openstackgerrit	Riccardo Pittau proposed openstack/openstacksdk master: Apply import order in some tests https://review.opendev.org/c/openstack/openstacksdk/+/780872
08:37:43	openstackgerrit	Riccardo Pittau proposed openstack/openstacksdk master: Apply import order in more tests https://review.opendev.org/c/openstack/openstacksdk/+/781078
08:37:44	openstackgerrit	Riccardo Pittau proposed openstack/openstacksdk master: Fixing more import orders https://review.opendev.org/c/openstack/openstacksdk/+/782809
12:22:20	openstackgerrit	Stephen Finucane proposed openstack/openstacksdk master: Add minimal support for Placement https://review.opendev.org/c/openstack/openstacksdk/+/745375
12:51:56	openstackgerrit	Riccardo Pittau proposed openstack/openstacksdk master: Apply import order in some tests https://review.opendev.org/c/openstack/openstacksdk/+/780872
14:52:56	openstackgerrit	Riccardo Pittau proposed openstack/openstacksdk master: Fix more import order in tests https://review.opendev.org/c/openstack/openstacksdk/+/780903
14:53:08	openstackgerrit	Riccardo Pittau proposed openstack/openstacksdk master: Apply import order in more tests https://review.opendev.org/c/openstack/openstacksdk/+/781078
14:54:11	openstackgerrit	Riccardo Pittau proposed openstack/openstacksdk master: Fixing more import orders https://review.opendev.org/c/openstack/openstacksdk/+/782809
15:03:27	diablo_rojo	stephenfin joining?
15:03:35	stephenfin	gdi DST
15:03:37	stephenfin	yup
16:55:27	diablo_rojo	gouthamr, gtema did make an etherpad: https://etherpad.opendev.org/p/xena-ptg-sdk-cli
17:09:42	gouthamr	diablo_rojo: ah, thank you
17:30:15	diablo_rojo	gouthamr, no problem!
19:50:52	openstackgerrit	Nicole Chen proposed openstack/openstacksdk master: Add export location resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/780990
#openstack-sdks - 2021-03-26
00:37:31	openstackgerrit	Nicole Chen proposed openstack/openstacksdk master: Added share types to shared file systems. https://review.opendev.org/c/openstack/openstacksdk/+/783123
00:56:36	openstackgerrit	Nicole Chen proposed openstack/openstacksdk master: Added share types to shared file systems. https://review.opendev.org/c/openstack/openstacksdk/+/783123
06:28:21	openstackgerrit	Nicole Chen proposed openstack/openstacksdk master: Added User Message to Shared File Systems https://review.opendev.org/c/openstack/openstacksdk/+/783187
15:17:21	openstackgerrit	Nicole Chen proposed openstack/openstacksdk master: Added User Message to Shared File Systems https://review.opendev.org/c/openstack/openstacksdk/+/783187
15:40:46	openstackgerrit	Nicole Chen proposed openstack/openstacksdk master: Added share types to shared file systems. https://review.opendev.org/c/openstack/openstacksdk/+/783123
15:54:39	openstackgerrit	Stephen Finucane proposed openstack/openstacksdk master: placement: Add support for resource providers https://review.opendev.org/c/openstack/openstacksdk/+/745375
15:54:40	openstackgerrit	Stephen Finucane proposed openstack/openstacksdk master: placement: Add support for resource classes https://review.opendev.org/c/openstack/openstacksdk/+/783350
#openstack-sdks - 2021-03-28
19:49:53	openstackgerrit	Ashley Rodriguez proposed openstack/openstacksdk master: Add share network subnet resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/783582
19:56:26	openstackgerrit	Ashley Rodriguez proposed openstack/openstacksdk master: Add share resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/775707
21:38:53	openstackgerrit	Ashley Rodriguez proposed openstack/openstacksdk master: Add share network subnet resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/783582
#openstack-sdks - 2021-03-31
10:01:44	slaweq	gtema: stephenfin and other sdk cores, can You take a look at https://review.opendev.org/c/openstack/openstacksdk/+/782870? thx in advance
10:25:23	stephenfin	gtema: Can you look at https://review.opendev.org/c/openstack/openstacksdk/+/782870 again?
10:25:31	stephenfin	I spotted one thing
10:25:32	stephenfin	slaweq: ^
10:26:58	slaweq	stephenfin: thx, checking
10:27:31	slaweq	stephenfin: thx, I will address Your comments today
10:41:12	openstackgerrit	Slawek Kaplonski proposed openstack/openstacksdk master: Add support for the Neutron L3 conntrack helper API https://review.opendev.org/c/openstack/openstacksdk/+/782870
10:42:50	slaweq	stephenfin: gtema updated ^^
10:42:53	slaweq	thx for review
10:43:22	slaweq	according that "assert isinstance()" I changed that but there is a lot of other places where it is used in functional tests
10:43:31	slaweq	do You think we should change it everywhere?
10:43:54	gtema	generally yes, but not now. Part of R1.0 - would be cool
10:44:13	slaweq	gtema: ok
10:56:11	stephenfin	slaweq: Think you missed a test
11:03:48	openstackgerrit	Slawek Kaplonski proposed openstack/openstacksdk master: Add support for the Neutron L3 conntrack helper API https://review.opendev.org/c/openstack/openstacksdk/+/782870
13:19:42	openstackgerrit	David Hill proposed openstack/python-openstackclient master: Add rule parameter in openstackclient https://review.opendev.org/c/openstack/python-openstackclient/+/784100
13:28:06	noonedeadpunk	I'm not sure, it feels like I missed to add some test, but wasn't able to find current one... And don't feel strength in writing proper one from scratch for https://review.opendev.org/c/openstack/openstacksdk/+/783849
14:03:15	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: Add rule parameter in openstackclient https://review.opendev.org/c/openstack/python-openstackclient/+/784100
14:50:30	openstackgerrit	Stephen Finucane proposed openstack/osc-lib master: parseractions: Make key validation reusable https://review.opendev.org/c/openstack/osc-lib/+/784110
16:27:29	openstackgerrit	Ryan Zimmerman proposed openstack/openstacksdk master: Add compute microversion 2.57 https://review.opendev.org/c/openstack/openstacksdk/+/781131
16:44:07	stephenfin	gtema: Can you take a look at https://review.opendev.org/c/openstack/python-openstackclient/+/773649 and https://review.opendev.org/c/openstack/python-openstackclient/+/780030 please?
16:44:17	gtema	ok
16:47:00	gtema	how should the pre-commit-hook work? I checked out your change, tried to add broken commit and nothing happened
17:09:28	stephenfin	gtema: Did you install pre-commit?
17:09:57	gtema	and how to do that? maybe this hints a release note is missing
17:10:14	stephenfin	I didn't want to include a release note because it seemed too internal
17:10:19	stephenfin	I could add docs though
17:10:36	gtema	exactly, and that is therefore unclear how to use
17:11:18	gtema	it's just every git is using their own way to use hooks and I never seen .pre-commit-config.yaml usage
17:19:41	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: Add pre-commit https://review.opendev.org/c/openstack/python-openstackclient/+/780030
17:19:42	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: hacking: Remove references to encoding https://review.opendev.org/c/openstack/python-openstackclient/+/784138
18:40:42	openstackgerrit	Merged openstack/python-openstackclient master: network: Add support for vnic-type vdpa https://review.opendev.org/c/openstack/python-openstackclient/+/778571
20:12:00	openstackgerrit	Ashley Rodriguez proposed openstack/openstacksdk master: Add share access rules resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/784162
22:25:56	openstackgerrit	Mark Tony proposed openstack/openstacksdk master: Add a share network resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/784177
22:33:11	openstackgerrit	Dylan Zapzalka proposed openstack/openstacksdk master: Added support for the GroupType resource https://review.opendev.org/c/openstack/openstacksdk/+/784178
22:33:59	openstackgerrit	Dylan Zapzalka proposed openstack/openstacksdk master: WIP Added support for the GroupType resource https://review.opendev.org/c/openstack/openstacksdk/+/784178
#openstack-sdks - 2021-04-01
00:07:13	alpalka	@diablo_rojo I had a question about how to implement the list/get method on my resource I am attempting to implement
00:07:16	alpalka	?

Earlier   Later