Posted	Nick	Remark
#openstack-sdks - 2020-06-17
10:09:53	openstackgerrit	Jens Harbott (frickler) proposed openstack/python-openstackclient master: Revert "Format location columns in network commands" https://review.opendev.org/736150
10:15:32	frickler	dtroyer: mordred: ^^ added my reasoning to the revert, happy to discuss when you find some time
10:17:24	openstackgerrit	Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Move action_group to runtime https://review.opendev.org/735977
10:35:28	openstackgerrit	Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Fixes for modules generation script https://review.opendev.org/735968
12:05:14	openstackgerrit	Vishakha Agarwal proposed openstack/openstacksdk master: [WIP] Add domain config CRUD support https://review.opendev.org/736171
12:13:36	openstackgerrit	Merged openstack/ansible-collections-openstack master: Fix ansible-test errors https://review.opendev.org/736062
12:29:13	openstackgerrit	Merged openstack/ansible-collections-openstack master: Move action_group to runtime https://review.opendev.org/735977
12:36:08	openstackgerrit	Merged openstack/ansible-collections-openstack master: Fixes for modules generation script https://review.opendev.org/735968
12:58:45	openstackgerrit	Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add volume_info module https://review.opendev.org/735949
12:59:24	openstackgerrit	Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add OpenstackModule to os_server_action https://review.opendev.org/721746
14:03:18	openstackgerrit	Riccardo Pittau proposed openstack/ansible-collections-openstack master: Remove tox from test-requirements https://review.opendev.org/736224
14:08:34	frickler	mordred: this also needs some ensure-venv thing, if you have time https://658019d6165ae4c8eab6-597ff148d0ea9164d11e7cb764cf9b04.ssl.cf1.rackcdn.com/679445/2/check/openstackclient-check-plugins/c1f9a28/job-output.txt
16:14:03	openstackgerrit	Monty Taylor proposed openstack/openstackclient master: Make sure virtualenv is installed for check plugins https://review.opendev.org/736290
16:33:36	openstackgerrit	Mohammed Naser proposed openstack/python-openstackclient master: port: add --host to list command https://review.opendev.org/736005
17:17:10	openstackgerrit	Merged openstack/openstackclient master: Make sure virtualenv is installed for check plugins https://review.opendev.org/736290
17:22:41	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Drop python3.5 support https://review.opendev.org/736058
17:22:42	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Use unittest.mock instead of mock https://review.opendev.org/734455
17:36:14	openstackgerrit	Monty Taylor proposed openstack/ansible-collections-openstack master: Update author lines https://review.opendev.org/736307
17:50:21	openstackgerrit	Sean McGinnis proposed openstack/openstacksdk master: Use unittest.mock instead of mock https://review.opendev.org/734455
18:45:18	openstackgerrit	Merged openstack/ansible-collections-openstack master: Add OpenstackModule to os_server_action https://review.opendev.org/721746
22:08:56	openstackgerrit	Monty Taylor proposed openstack/ansible-collections-openstack master: Update author lines https://review.opendev.org/736307
22:08:57	openstackgerrit	Monty Taylor proposed openstack/ansible-collections-openstack master: Add ansible 2.10 testing https://review.opendev.org/736393
22:14:59	openstackgerrit	Monty Taylor proposed openstack/ansible-collections-openstack master: Add ansible 2.10 testing https://review.opendev.org/736393
22:15:00	openstackgerrit	Monty Taylor proposed openstack/ansible-collections-openstack master: Update author lines https://review.opendev.org/736307
22:15:01	openstackgerrit	Monty Taylor proposed openstack/ansible-collections-openstack master: Add ignore file for ansible-test sanity 2.11 https://review.opendev.org/736394
23:23:12	openstackgerrit	Merged openstack/python-openstackclient master: Revert "Format location columns in network commands" https://review.opendev.org/736150
23:23:13	openstackgerrit	Merged openstack/python-openstackclient master: Don't display Munch objects in the output https://review.opendev.org/679445
#openstack-sdks - 2020-06-18
06:45:30	openstackgerrit	Merged openstack/openstacksdk master: Add query parameter 'id' for security_groups https://review.opendev.org/735601
11:36:46	openstackgerrit	Pratik Raj proposed openstack/cliff master: optimize size and time using --no-cache-dir https://review.opendev.org/736641
12:07:20	openstackgerrit	jayaditya gupta proposed openstack/cliff master: Output correct json for security groups in 'openstack server show' https://review.opendev.org/735128
12:13:12	mordred	slaweq: see comment from frickler on https://review.opendev.org/#/c/736005/ - it's possible there is a neutron bug
12:13:30	slaweq	mordred: looking
12:14:27	mordred	slaweq: (it's possible it's not - but when I see "unintended information leak" ...)
12:34:09	openstack	Launchpad bug 1884067 in neutron "[API] Filtering by fields not allowed to see is possible for regular users" [High,Confirmed]
12:34:09	slaweq	mordred: I just opened https://bugs.launchpad.net/neutron/+bug/1884067
12:34:16	slaweq	mordred: frickler thx for finding this
12:35:19	slaweq	mordred: frickler I think we are not checking what fields are available for user during filtering, we are only removing such fields from the returned data
12:35:23	frickler	slaweq: sorry, I wanted to ping you earlier about this but then got distracted, it just looked odd to me when testing mnaser's patch
12:35:35	slaweq	I will ask amotoki to take a look into it
12:38:00	mordred	\o/. we're helpful! good catch frickler :)
12:38:23	mordred	mnaser: you made things betterer
12:39:28	mnaser	what did I do oops
12:39:55	mnaser	oh no
12:39:58	mnaser	that’s no good
12:40:19	mnaser	we should fix that soon :)
12:40:48	mnaser	(and if no one has the time to do that, I can, cause you know, that’s a little important)
12:41:14	mnaser	I’m not that worried though, we don’t expose the host id anywhere so I don’t think anyone can see it to use it later
13:51:31	shaohe_feng	hi, mordred and gtema
13:52:01	shaohe_feng	there is a issue when I connect glance from cyborg
13:52:11	shaohe_feng	Need you help
13:53:30	shaohe_feng	Traceback (most recent call last):
13:53:31	shaohe_feng	"/opt/stack/cyborg/cyborg/image/api.py", line 163, in download
13:56:10	mordred	I want to help shaohe_feng
13:56:26	shaohe_feng	Traceback (most recent call last):
13:56:27	shaohe_feng	"/opt/stack/cyborg/cyborg/image/api.py", line 163, in download
14:12:29	mordred	shaohe_feng: try pasting to paste.openstack.org and then copying the link here
14:14:02	shaohe_feng	mordred: this is the traceback http://paste.openstack.org/show/794946/
14:17:00	shaohe_feng	mordred: this is the conf http://paste.openstack.org/show/794948/
14:19:48	shaohe_feng	mordred: this is the cyborg repo https://github.com/openstack/cyborg and glance api code is here: https://github.com/openstack/cyborg/blob/6dab512af226677c9065f85f264a691f3aeb6eab/cyborg/image/glance.py
14:20:25	mordred	shaohe_feng: sadly I don't think we're going to be much help with that - it's using glanceclient not openstacksdk - I'm really not sure what's going on :(
14:21:05	shaohe_feng	mordred I'm using SDK:
14:21:48	shaohe_feng	+ ksa_adap = utils.get_sdk_adapter(
14:22:12	shaohe_feng	in my code I chage it to get_sdk_adapter
14:23:26	shaohe_feng	here I change get_ksa_adapter to get_sdk_adapter https://github.com/openstack/cyborg/blob/6dab512af226677c9065f85f264a691f3aeb6eab/cyborg/image/glance.py#L113
14:24:33	mordred	shaohe_feng: yes - but the traceback you pasted is flowing through glanceclient - so it seems that sdk adapter is just being used to find the list of glance servers
14:25:09	mordred	so - at some point that info is being passed to a Glanceclient constructor - and god only knows what it's doing
14:25:33	shaohe_feng	https://github.com/openstack/cyborg/blob/master/cyborg/common/utils.py#L135
14:25:44	shaohe_feng	^ mordred: what the get_sdk_adapter define
14:26:00	shaohe_feng	so why it still use glanceclient ?
14:26:14	shaohe_feng	I already change it to get_sdk_adapter
14:26:54	shaohe_feng	something wrong when I change it to get_sdk_adapter ？
14:27:27	shaohe_feng	mordred can you tell me what should I do?
14:28:02	mordred	shaohe_feng: that looks fine - but there is still this: https://github.com/openstack/cyborg/blob/6dab512af226677c9065f85f264a691f3aeb6eab/cyborg/image/glance.py#L129
14:28:11	mordred	shaohe_feng: let me look at the code a little more and see if I can make some suggestions
14:28:38	shaohe_feng	mordred: thank you.
14:30:07	gtema	shaone_feng - I guess you should be targeting dropping your cyborg/image/glance completely and modify cyborg/image/api to use SDK instead
14:31:19	mordred	gtema: looking at the master branch, it looks like they're laready doing that
14:31:43	gtema	oh, I was looking to the posted particular commit
14:31:45	mordred	oh - wait
14:31:47	mordred	eah
14:32:22	mordred	ZOMG - the method is returning a GlanceClient and calling it a session
14:32:25	gtema	even in master there is still from cyborg.image import glance
14:33:05	mordred	yup.
14:33:13	mordred	I was fooled by "session.delete()"
14:38:02	shaohe_feng	gtema: mordred: I'm still use GlanceClient ?
14:39:45	mordred	gtema: they're going to nerdsnipe me in to fixing cyborg aren't they?
14:42:46	gtema	shaone_feng - you stacktrace exactly points into that
14:42:56	gtema	mordred - right
14:42:59	shaohe_feng	gtema: mordred: sorry, I'm offline just now. something wrong with my network.
14:43:11	shaohe_feng	may I missing something?
14:43:40	gtema	shaohe_feng - guess not
14:43:52	mordred	shaohe_feng: cyborg.image.api.API._get_session_and_image_id is constructing a Glanceclient object
14:44:05	mordred	shaohe_feng: which in turn is used in API.download
14:44:06	shaohe_feng	good, so what should I change?
14:44:23	mordred	probably the entire cyborg/image/glance.py file
14:44:31	shaohe_feng	the FPGA need to download image
14:44:40	gtema	yes - drop it and modify the cyborg/image/api
14:44:42	shaohe_feng	we need to program the FPGA
14:44:53	shaohe_feng	any example for it?
14:44:55	mordred	shaohe_feng: I'm going to see if I can make a non-working example patch that can point you in the right direction

Earlier   Later