| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2020-06-11 | |||
| 14:55:27 | sshnaidm | if it's not ok, let's leave _wait function as it was: https://review.opendev.org/#/c/721746/14..15/plugins/modules/server_action.py | |
| 15:01:30 | mordred | sshnaidm: yeah - I think that's fine. I think we can simplify it in the future - but waiting on that is not valuable | |
| 15:44:43 | openstackgerrit | Merged openstack/python-openstackclient master: Remove os-client-config references https://review.opendev.org/734097 | |
| 17:14:22 | openstackgerrit | Merged openstack/python-openstackclient stable/train: Client should parse string to boolean for value 'is_domain' https://review.opendev.org/732398 | |
| 23:51:14 | openstackgerrit | Merged openstack/ansible-collections-openstack master: Add note about py3 in readme https://review.opendev.org/735081 | |
| #openstack-sdks - 2020-06-12 | |||
| 05:53:24 | frickler | is there a reason why "router create" doesn't allow additional settings like external-gateway? according to the api-ref that should be possible | |
| 08:34:55 | openstackgerrit | Merged openstack/openstacksdk master: NIT: Fix application credential https://review.opendev.org/734756 | |
| 13:11:51 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Add support for filters into the project cleanup https://review.opendev.org/735336 | |
| 13:27:32 | mordred | frickler: I doubt it's on purpose | |
| 13:28:47 | mordred | gtema: if you get a chance this morning, could you look at https://review.opendev.org/#/c/734000/ - it's green now that we released cliff | |
| 13:29:19 | gtema | btw, just few hours ago noticed, that when we do now "openstack command list" - everything is doubled | |
| 13:30:05 | mordred | neat | |
| 13:33:02 | mordred | gtema: that is not true for me | |
| 13:33:13 | gtema | okay, pretty interesting | |
| 13:33:44 | gtema | every plugin is doubled for me and for my colleague | |
| 13:34:13 | gtema | lemme check again | |
| 13:34:24 | mordred | I'm using the container image with sha a865640d8bef | |
| 13:35:43 | gtema | hmm, you are right. Then something is corrupted in our env setup | |
| 13:36:03 | gtema | but it started really very recently | |
| 13:36:05 | mordred | cool. to double-check I pulled the latest image and it also still works | |
| 13:36:09 | gtema | okay, will dig further | |
| 13:36:37 | mordred | gtema: maybe it's something with the latest cliff change? (don't know how that would do it though) | |
| 13:37:00 | gtema | but funny that you exactly work in this area | |
| 13:37:09 | mordred | gtema: yeah | |
| 13:37:16 | gtema | it happens though only for our project, which adds plugins | |
| 13:37:30 | mordred | oh - wait! | |
| 13:37:32 | mordred | no | |
| 13:37:36 | mordred | it totally happens for me | |
| 13:41:00 | mordred | gtema: definitely caused by latest cliff | |
| 13:41:11 | mordred | let me see if applying the osc-lib patch fixes it | |
| 13:41:18 | gtema | okay | |
| 13:41:50 | mordred | yes | |
| 13:41:58 | mordred | https://review.opendev.org/#/c/734000/ fixes it | |
| 13:42:18 | mordred | I don't understand WHY - but since that wants to land anyway maybe I'm not too worried about it | |
| 13:42:21 | gtema | okay, great | |
| 13:42:50 | mordred | gtema: I went ahead and +A'd it. I'll cut a release as soon as that lands | |
| 13:42:58 | gtema | perfect | |
| 13:56:45 | vkmc | o/ | |
| 13:56:47 | vkmc | hi folks, we have a quick doubt on format | |
| 13:57:11 | vkmc | we want to comply with the human interface guidelines as much as possible | |
| 13:57:19 | vkmc | we ran into this https://docs.openstack.org/python-openstackclient/latest/contributor/command-options.html#required-options | |
| 13:57:22 | vkmc | in the docs | |
| 13:57:40 | vkmc | and we are a bit confused on the "--" usage | |
| 13:57:49 | vkmc | shouldn't double dashed params be optional params? | |
| 13:58:04 | gtema | vkmc - mostly | |
| 13:58:29 | gtema | but there are situation, where you have so many mandatory params that you simply can't do everything positional | |
| 13:59:08 | vkmc | well, yes, that makes sense | |
| 13:59:22 | gtema | so rule of a thumb - everything "important to breathe" is positional, everything else is "--" | |
| 13:59:43 | vkmc | concern came up in this patch set https://review.opendev.org/#/c/732991/ | |
| 14:00:04 | vkmc | it's a command with very few params and both of them mandatory... openstack share resize <share> <size> | |
| 14:00:11 | vkmc | IMHO there shouldn't be dashes involved there | |
| 14:00:23 | gtema | agree | |
| 14:00:40 | gtema | share at least "must" be positional | |
| 14:00:53 | gtema | since this is a root element of the operation | |
| 14:01:18 | gtema | if there would be multiple props you can set on the share - they would be likely dashed-ones | |
| 14:01:32 | gtema | if it's a single one - it's ok to make it positional either | |
| 14:01:54 | gtema | but still - size is up to you how to name | |
| 14:02:31 | vkmc | ok, it's clearer now | |
| 14:03:07 | vkmc | thanks gtema :) | |
| 14:03:10 | gtema | welcome | |
| 14:05:33 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Update babel and webpack https://review.opendev.org/730639 | |
| 14:05:34 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Update karma, jasmine and istanbul https://review.opendev.org/730640 | |
| 14:05:35 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Update yaml-loader and json-loader https://review.opendev.org/730643 | |
| 14:05:36 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Update eslint and switch to standard https://review.opendev.org/730644 | |
| 14:05:37 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Remove jsdoc https://review.opendev.org/730678 | |
| 14:09:53 | yoctozepto | hi mordred | |
| 14:10:06 | yoctozepto | must have lost this channel on failed irc client upgrade | |
| 14:12:01 | mordred | yoctozepto: it happens :) | |
| 14:17:33 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: CI: New jobs https://review.opendev.org/702132 | |
| 14:17:34 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Update babel and webpack https://review.opendev.org/730639 | |
| 14:17:35 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Update karma, jasmine and istanbul https://review.opendev.org/730640 | |
| 14:17:36 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Update yaml-loader and json-loader https://review.opendev.org/730643 | |
| 14:17:37 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Update eslint and switch to standard https://review.opendev.org/730644 | |
| 14:17:38 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Remove jsdoc https://review.opendev.org/730678 | |
| 14:17:39 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: WIP Re-add functional tests https://review.opendev.org/735344 | |
| 14:28:32 | openstackgerrit | Monty Taylor proposed openstack/osc-lib master: Fix the misspelling of "argument" https://review.opendev.org/629790 | |
| 14:30:04 | openstackgerrit | Monty Taylor proposed openstack/osc-lib master: Implement auth caching https://review.opendev.org/359489 | |
| 14:51:46 | dtroyer | vkmc: I would encourage you to conider your command set as a whole and look for consistency. in some commands —size is optional as it can be inferred, like volume create with —image. User feedback has strongly valued the consistency of the OSc commands as a whole... | |
| 14:58:08 | openstackgerrit | Merged openstack/osc-lib master: Remove commandmanager subclass https://review.opendev.org/734000 | |
| 15:02:23 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Cache auth token in keyring https://review.opendev.org/735352 | |
| 15:02:58 | mordred | dtroyer: ^^ lookie - reviving the 2.5 year old jamielennox patch! | |
| 15:03:27 | mordred | (although gonna make a stab at doing it down in sdk so it's not just an osc thing) | |
| 15:41:56 | dtroyer | Woot!! | |
| 15:42:58 | dtroyer | I was hoping to look that up soon… the cloud I am blessed to use has Duo enabled so psuedo-mfa, we're leveraging interactive mode so we don't get auth pings on damn near every API call…that would be the real fix | |
| 15:43:11 | dtroyer | mordred: know anyone who can fix fog too? :) | |
| 15:44:13 | mordred | dtroyer: sure - just replace it with sdk and you should be fine ;) | |
| 15:44:53 | dtroyer | ah, right, the ole s/chef/anisble/ solution! | |
| 15:44:58 | mordred | :) | |
| 15:46:12 | mordred | dtroyer: I'm thinking - if we can get this token caching thing to work - we should/could use a similar mechanism to allow optional password storage - and add an 'openstack cloud login' command that would trigger the password prompt and then save it in your keyring for you - but in a way that if you do that with osc, then any sdk consumers for that cloud will be able to pull the password from your | |
| 15:46:14 | mordred | keyring | |
| 15:46:44 | mordred | I think gtema was asking about the ability to save passwords separately but not just in the secure.yaml file | |
| 15:47:07 | mordred | also - gtema - see 735352 :) | |
| 15:47:46 | dtroyer | mordred: that parallels the dreams I had about leveraging keychain/ssh-agent-type stuff | |
| 15:47:54 | mordred | yeah | |
| 15:49:02 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/cliff master: Remove cap on cmd2 https://review.opendev.org/735364 | |
| 15:51:22 | ralonsoh | mordred, ^^ | |
| 15:51:31 | ralonsoh | I think this will fix some problems in the CI | |
| 15:51:43 | ralonsoh | importing cliff in rally_openstack | |
| 15:51:44 | ralonsoh | https://4ca4d8620dc864739feb-f83d06667d580e000031601b82c71a43.ssl.cf5.rackcdn.com/735193/1/check/neutron-rally-task/acf1423/job-output.txt | |
| 15:53:06 | openstackgerrit | Merged openstack/osc-lib master: Revert "Add error message when occurrence Forbidden error" https://review.opendev.org/713595 | |