| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2020-06-11 | |||
| 13:05:19 | mordred | no, that's expected | |
| 13:05:24 | mordred | and we should fix it - but for now | |
| 13:05:34 | mordred | use self.conn.wait_for_server if you use self.conn.get_server | |
| 13:06:08 | mordred | (although that's not going to let you pass in a status) | |
| 13:06:37 | sshnaidm | yeah, server is <class 'munch.Munch'> | |
| 13:06:39 | mordred | sshnaidm: actually - for this case ... | |
| 13:06:57 | mordred | sshnaidm: try using self.conn.compute.get_server(self.params['server']) | |
| 13:06:58 | frickler | jawad_axd: with subnetpools creating a subnet is pretty simple, but still a dedicated action, I don't think there's a way around that | |
| 13:08:35 | mordred | sshnaidm: we need to finish https://review.opendev.org/#/c/630912 to fix the other thing, and that's important, but probably not a thing you want to wait on | |
| 13:08:40 | jawad_axd | @frickler Thanks. | |
| 13:09:26 | sshnaidm | mordred, hmm, it didn't find server with self.conn.compute.get_server(self.params['server']) | |
| 13:11:09 | sshnaidm | and w/o compute: TypeError: wait_for_server() got an unexpected keyword argument 'status' | |
| 13:11:31 | sshnaidm | I think I'll wait a little to introduce this function.. | |
| 13:11:49 | mordred | sshnaidm: yeah - there's no status parameter for self.conn.wait_for_server | |
| 13:12:37 | mordred | sshnaidm: one more thign to try (sorry, still on first coffee) | |
| 13:12:50 | mordred | sshnaidm: self.conn.compute.find_server(self.params['server']) | |
| 13:15:43 | sshnaidm | mordred, that seems working | |
| 13:21:34 | sshnaidm | mordred, <class 'openstack.compute.v2.server.Server'> - it seems to have all attributes as "None" | |
| 13:25:32 | sshnaidm | I've got only ID and name | |
| 13:35:09 | openstackgerrit | Merged openstack/ansible-collections-openstack master: Fix ansible-devel sanity tests for deprecations https://review.opendev.org/735095 | |
| 13:41:43 | mordred | sshnaidm: that resource doesn't seem to have been fetched | |
| 13:42:31 | sshnaidm | mordred, well, it got id and name | |
| 14:24:04 | openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add note about py3 in readme https://review.opendev.org/735081 | |
| 14:54:10 | openstackgerrit | Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add OpenstackModule to os_server_action https://review.opendev.org/721746 | |
| 14:54:40 | sshnaidm | mordred, ended up with two objects, "Server" for wait_for_server and "Munch" for all the rest ^ | |
| 14:55:27 | sshnaidm | if it's not ok, let's leave _wait function as it was: https://review.opendev.org/#/c/721746/14..15/plugins/modules/server_action.py | |
| 15:01:30 | mordred | sshnaidm: yeah - I think that's fine. I think we can simplify it in the future - but waiting on that is not valuable | |
| 15:44:43 | openstackgerrit | Merged openstack/python-openstackclient master: Remove os-client-config references https://review.opendev.org/734097 | |
| 17:14:22 | openstackgerrit | Merged openstack/python-openstackclient stable/train: Client should parse string to boolean for value 'is_domain' https://review.opendev.org/732398 | |
| 23:51:14 | openstackgerrit | Merged openstack/ansible-collections-openstack master: Add note about py3 in readme https://review.opendev.org/735081 | |
| #openstack-sdks - 2020-06-12 | |||
| 05:53:24 | frickler | is there a reason why "router create" doesn't allow additional settings like external-gateway? according to the api-ref that should be possible | |
| 08:34:55 | openstackgerrit | Merged openstack/openstacksdk master: NIT: Fix application credential https://review.opendev.org/734756 | |
| 13:11:51 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Add support for filters into the project cleanup https://review.opendev.org/735336 | |
| 13:27:32 | mordred | frickler: I doubt it's on purpose | |
| 13:28:47 | mordred | gtema: if you get a chance this morning, could you look at https://review.opendev.org/#/c/734000/ - it's green now that we released cliff | |
| 13:29:19 | gtema | btw, just few hours ago noticed, that when we do now "openstack command list" - everything is doubled | |
| 13:30:05 | mordred | neat | |
| 13:33:02 | mordred | gtema: that is not true for me | |
| 13:33:13 | gtema | okay, pretty interesting | |
| 13:33:44 | gtema | every plugin is doubled for me and for my colleague | |
| 13:34:13 | gtema | lemme check again | |
| 13:34:24 | mordred | I'm using the container image with sha a865640d8bef | |
| 13:35:43 | gtema | hmm, you are right. Then something is corrupted in our env setup | |
| 13:36:03 | gtema | but it started really very recently | |
| 13:36:05 | mordred | cool. to double-check I pulled the latest image and it also still works | |
| 13:36:09 | gtema | okay, will dig further | |
| 13:36:37 | mordred | gtema: maybe it's something with the latest cliff change? (don't know how that would do it though) | |
| 13:37:00 | gtema | but funny that you exactly work in this area | |
| 13:37:09 | mordred | gtema: yeah | |
| 13:37:16 | gtema | it happens though only for our project, which adds plugins | |
| 13:37:30 | mordred | oh - wait! | |
| 13:37:32 | mordred | no | |
| 13:37:36 | mordred | it totally happens for me | |
| 13:41:00 | mordred | gtema: definitely caused by latest cliff | |
| 13:41:11 | mordred | let me see if applying the osc-lib patch fixes it | |
| 13:41:18 | gtema | okay | |
| 13:41:50 | mordred | yes | |
| 13:41:58 | mordred | https://review.opendev.org/#/c/734000/ fixes it | |
| 13:42:18 | mordred | I don't understand WHY - but since that wants to land anyway maybe I'm not too worried about it | |
| 13:42:21 | gtema | okay, great | |
| 13:42:50 | mordred | gtema: I went ahead and +A'd it. I'll cut a release as soon as that lands | |
| 13:42:58 | gtema | perfect | |
| 13:56:45 | vkmc | o/ | |
| 13:56:47 | vkmc | hi folks, we have a quick doubt on format | |
| 13:57:11 | vkmc | we want to comply with the human interface guidelines as much as possible | |
| 13:57:19 | vkmc | we ran into this https://docs.openstack.org/python-openstackclient/latest/contributor/command-options.html#required-options | |
| 13:57:22 | vkmc | in the docs | |
| 13:57:40 | vkmc | and we are a bit confused on the "--" usage | |
| 13:57:49 | vkmc | shouldn't double dashed params be optional params? | |
| 13:58:04 | gtema | vkmc - mostly | |
| 13:58:29 | gtema | but there are situation, where you have so many mandatory params that you simply can't do everything positional | |
| 13:59:08 | vkmc | well, yes, that makes sense | |
| 13:59:22 | gtema | so rule of a thumb - everything "important to breathe" is positional, everything else is "--" | |
| 13:59:43 | vkmc | concern came up in this patch set https://review.opendev.org/#/c/732991/ | |
| 14:00:04 | vkmc | it's a command with very few params and both of them mandatory... openstack share resize <share> <size> | |
| 14:00:11 | vkmc | IMHO there shouldn't be dashes involved there | |
| 14:00:23 | gtema | agree | |
| 14:00:40 | gtema | share at least "must" be positional | |
| 14:00:53 | gtema | since this is a root element of the operation | |
| 14:01:18 | gtema | if there would be multiple props you can set on the share - they would be likely dashed-ones | |
| 14:01:32 | gtema | if it's a single one - it's ok to make it positional either | |
| 14:01:54 | gtema | but still - size is up to you how to name | |
| 14:02:31 | vkmc | ok, it's clearer now | |
| 14:03:07 | vkmc | thanks gtema :) | |
| 14:03:10 | gtema | welcome | |
| 14:05:33 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Update babel and webpack https://review.opendev.org/730639 | |
| 14:05:34 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Update karma, jasmine and istanbul https://review.opendev.org/730640 | |
| 14:05:35 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Update yaml-loader and json-loader https://review.opendev.org/730643 | |
| 14:05:36 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Update eslint and switch to standard https://review.opendev.org/730644 | |
| 14:05:37 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Remove jsdoc https://review.opendev.org/730678 | |
| 14:09:53 | yoctozepto | hi mordred | |
| 14:10:06 | yoctozepto | must have lost this channel on failed irc client upgrade | |
| 14:12:01 | mordred | yoctozepto: it happens :) | |
| 14:17:33 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: CI: New jobs https://review.opendev.org/702132 | |
| 14:17:34 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Update babel and webpack https://review.opendev.org/730639 | |
| 14:17:35 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Update karma, jasmine and istanbul https://review.opendev.org/730640 | |
| 14:17:36 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Update yaml-loader and json-loader https://review.opendev.org/730643 | |
| 14:17:37 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Update eslint and switch to standard https://review.opendev.org/730644 | |
| 14:17:38 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: Remove jsdoc https://review.opendev.org/730678 | |
| 14:17:39 | openstackgerrit | Monty Taylor proposed openstack/js-openstack-lib master: WIP Re-add functional tests https://review.opendev.org/735344 | |