Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-04-17
15:59:21 openstackgerrit Merged openstack/shade master: Break out py27 job templates https://review.opendev.org/718068
15:59:22 openstackgerrit Merged openstack/shade master: Update master for stable/ussuri https://review.opendev.org/719021
16:01:03 AJaeger dtantsur: yes, if you change one line, everything blows up as you noticed
16:01:42 smcginnis AJaeger: That may be the reason for inclusing our indirect dependencies in there - to make sure that scenario doesn't happen my locking down everything and make sure we always get the versions we expect to get.
16:01:49 smcginnis *including
16:02:10 AJaeger smcginnis: but we don't - I need an example, give me somem time, please
16:02:19 AJaeger And then let's discuss whether I'm right or not...
16:02:48 dtantsur smcginnis: the other way around. if you include all dependencies, any change will likely cascade.
16:03:09 smcginnis dtantsur: Yes, but that would be by design, right?
16:03:09 dtantsur if you only include direct dependencies, you'll get into trouble only if your minimum cap conflicts with some other.
16:03:19 dtantsur not sure
16:03:31 dtantsur I see the goal of lower-constraints differently
16:03:48 smcginnis If we want a definitive set of requirement minimums that can be used, we need to be explicit about everything that gets installed to be able to verify it actually works.
16:04:11 dtantsur I only care about direct dependencies because that's what we (in a project) control
16:05:16 dtantsur like, in this case I have to care that something else is using babel and pytz. I don't think I should.
16:05:20 smcginnis But like Andreas pointed out, if we say we want version 1.0, but then an indirect dependency raises that to 2.0, we aren't actually capturing (or at least validating) what our minimum version of that lib should be.
16:06:09 dtantsur smcginnis: in this case the job will fail and we'll know :)
16:06:26 dtantsur that's literally what happened with my patch
16:06:39 smcginnis I'm probably missing some context. Which patch is this?
16:06:57 dtantsur smcginnis: tl;dr I've uncapped babel and it got pulled again down the road with a conflicting pytz requirement
16:07:49 smcginnis Yeah, so that points to the reason for why lower-constraints should have packages that are not in requirements and test-requirements.
16:08:00 smcginnis It needs to control the full environment.
16:08:11 dtantsur for me it points to the opposite thing :)
16:08:23 dtantsur I don't need this control. As a developer I don't care about it.
16:08:31 dtantsur Maybe we see the goals of lower-constraints differently?
16:08:42 dtantsur For me it's only to verify that we don't violate our minimum caps
16:09:00 smcginnis But going the route you are advocating, you've just pointed out that causes problems. :)
16:09:22 dtantsur it caused a problem because we also capped pytz
16:09:43 dtantsur which wasn't a direct dependency either
16:10:01 dtantsur or maybe it's too late for me to think clearly :)
16:11:29 smcginnis The reason we have it in l-c is because it is an indirect dependency that of not constrained will install a different and potentially conflicting version like you are saying.
16:11:53 AJaeger smcginnis: is lower-constraitns documented somewhere?
16:12:07 smcginnis So even if we use neither babel nor pytz directly, having them in l-c will force the exact versions to be installed and avoid conflicts like that.
16:12:35 dtantsur smcginnis: okay, I remembered why we stopped doing it in ironic, I think. It's fine while it works, but every time you need to update something, it's a cascading nightmare.
16:12:48 smcginnis AJaeger: I'm not really sure. I remember when Doug was working on it, and he had to explain some of the reasoning for the approach to me a few times, but I don't recall reading a spec or anything like that.
16:13:00 dtantsur anyway, if people feel I should keep Babel in lower-constraints, I can do it
16:13:05 dtantsur just let me know
16:13:24 smcginnis dtantsur: Well, again, you can argue that's by design. If you change one thing, then you have to expect there may be other packages that will also need to be raised.
16:13:42 dtantsur it's not unreasonable, I just've never looked at it this way
16:14:03 smcginnis The exercise being to find what the new lowest set of requirements are that should be expected to work.
16:14:08 AJaeger I found https://docs.openstack.org/project-team-guide/dependency-management.html
16:15:28 dtantsur updated ^^
16:15:28 openstackgerrit Dmitry Tantsur proposed openstack/python-openstackclient master: Remove Babel from requirements https://review.opendev.org/720701
16:35:07 AJaeger smcginnis, dtantsur|afk https://etherpad.opendev.org/p/S_6OvGeqCniK5CLVxIan is what I found out so far.
16:35:22 AJaeger So, lower-constraints might be working correctly - but we're usingn it in a broken way ;(
16:35:58 AJaeger With removing install_command suddenly you open pandora's box since none of the requirements is correct anymore ;(
16:40:35 AJaeger I'll send this out as an email...
16:46:59 openstackgerrit Andreas Jaeger proposed openstack/keystoneauth master: Cleanup py27 support https://review.opendev.org/720742
16:52:30 openstackgerrit Merged openstack/shade master: Add Python3 victoria unit tests https://review.opendev.org/719022
16:53:57 smcginnis AJaeger: Thanks for sending that. I've seen a few projects fix that over the last several months, but I'm sure there are probably several more that are still doing that wrong.
17:12:15 openstackgerrit Merged openstack/osc-lib master: Remove Babel from requirements https://review.opendev.org/717737
17:34:40 AJaeger smcginnis: too many repos ;(
20:42:12 openstackgerrit Merged openstack/os-client-config master: Cleanup py27 support https://review.opendev.org/717609
21:05:02 AJaeger smcginnis: coming back to our discussion, the project-team-guide does not talk about adding all dependencies, it only talks about the direct requirements, doesn't it? Updating it becomes really tricky in my experience: You increase one version, that needs further updates, that need further...
21:05:38 AJaeger To me it looks like we're not mastering lower-constraints yet...
21:05:58 AJaeger sorry, enough on that - need to leave now...
21:10:25 smcginnis AJaeger: Have a good weekend!
21:11:15 smcginnis Maybe we can invoke Doug for more background. The concepts behind this were probably lost due to not having openstack-specs anymore. Or at least some other good place to write it all down.
21:37:39 openstackgerrit Merged openstack/python-openstackclient master: Use unittest.mock instead of third party mock https://review.opendev.org/717410
#openstack-sdks - 2020-04-18
21:17:09 openstackgerrit Sean McGinnis proposed openstack/keystoneauth master: Use unittest.mock instead of third party mock https://review.opendev.org/720925
#openstack-sdks - 2020-04-19
13:59:01 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Re-add python3.5 testing https://review.opendev.org/721084
14:05:09 openstackgerrit Merged openstack/keystoneauth master: Update master for stable/ussuri https://review.opendev.org/717030
15:23:37 mordred AJaeger: is there a reason for openstackdocstheme to be in test-requirements in addition to doc/requirements.txt?
15:26:45 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Re-add python3.5 testing https://review.opendev.org/721084
15:29:48 AJaeger mordred: yes - one I don't agree with ;) Let me give you apointer..
15:30:28 AJaeger more correct would be to only add reno, since when I removed it I got pointed to:
15:30:30 AJaeger https://docs.openstack.org/reno/latest/user/usage.html
15:30:36 AJaeger tox -e venv -- reno new slug-goes-here
15:30:48 AJaeger That's expected to work for many repos.
15:31:07 AJaeger So, I think we can remove docstheme and keep reno - but never checked that
15:31:19 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Re-add python3.5 testing https://review.opendev.org/721084
15:32:15 AJaeger so, try keeping reno in if you want
15:32:30 mordred AJaeger: ah - nod
15:32:44 mordred wow - people use tox -evenv to run the reno command?
15:32:56 AJaeger apparently
15:33:37 AJaeger mordred: but not every repo has in in test-requirements. Seems project specific
15:33:39 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Re-add python3.5 testing https://review.opendev.org/721084
15:34:20 mordred AJaeger: well - I don't feel strongly about removing reno :) -- I *do* need to remove openstackdocstheme because it doesn't support 3.5 - but we also don't need it there
15:35:16 AJaeger yeah, you can remove it or go to version 1.31.2 as well. Your change LGTM. Thanks for fixing!
15:36:04 mordred AJaeger: thanks!
#openstack-sdks - 2020-04-20
11:22:53 openstackgerrit Merged openstack/ansible-collections-openstack master: Moved openstack inventory script from community.general https://review.opendev.org/719429
15:50:28 nightmare_unreal quick question, If i want to add a new command to openstackclient where should I look into ? for e.g. openstack hypervisor list is an existing cmd. I want to add openstack migration list to it.
15:50:41 nightmare_unreal basically registering new command.
15:51:06 dtantsur nightmare_unreal: the commands are listed in setup.cfg
15:51:33 nightmare_unreal so during runtime openstackclient looks at setup.cfg ?
15:51:59 dtantsur nightmare_unreal: VERY roughly speaking, yes
15:52:16 dtantsur (it actually goes through the python's entry point mechanism)
15:52:28 nightmare_unreal hmm okay. Thanks :) .
15:52:56 dtantsur nightmare_unreal: check https://docs.openstack.org/stevedore/latest/user/index.html if you're curious
15:53:23 nightmare_unreal Thanks a lot :D
17:14:28 AJaeger cmurphy: could you review this keystoneauth change, please? https://review.opendev.org/720742
17:17:51 cmurphy AJaeger: done
17:18:34 AJaeger thanks, cmurphy
18:47:24 openstackgerrit Merged openstack/keystoneauth master: Cleanup py27 support https://review.opendev.org/720742
19:37:48 johnsom Is anyone else getting py36/py37 failures on the openstack.tests.unit.baremetal.v1.test_proxy.TestWaitForNodesProvisionState.test_timeout_and_failures_not_fail test for openstacksdk?
19:38:15 johnsom One of the students I am mentoring pointed out that master seems to have a problem with that test.
19:38:44 johnsom https://www.irccloud.com/pastebin/w06wGSwb/
19:42:07 smcginnis johnsom: Just ran py37 and it passes for me.
19:42:30 johnsom Hmm, how odd. I could reproduce the problem he was seeing.
19:42:50 johnsom (That paste above was from running local for me)

Earlier   Later