Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-03-24
18:36:00 openstackgerrit Merged openstack/python-openstackclient master: Honor endpoint override from config for volume https://review.opendev.org/714624
19:14:43 openstackgerrit Merged openstack/openstacksdk master: Add support for not including the ID in creation requests https://review.opendev.org/714120
20:36:48 openstackgerrit Sagi Shnaidman proposed openstack/openstacksdk stable/train: Run fetch-subunit-output role conditionally https://review.opendev.org/714770
20:36:59 openstackgerrit Sagi Shnaidman proposed openstack/openstacksdk stable/stein: Run fetch-subunit-output role conditionally https://review.opendev.org/714771
20:40:27 openstackgerrit Sagi Shnaidman proposed openstack/openstacksdk stable/rocky: Run fetch-subunit-output role conditionally https://review.opendev.org/714774
21:24:52 openstackgerrit Merged openstack/python-openstackclient master: Add unit tests and release note for dns_publish_fixed_ip https://review.opendev.org/702266
21:34:44 openstackgerrit Merged openstack/python-openstackclient master: Fix faulthy state argument choice https://review.opendev.org/699931
22:18:58 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Add ansible-collections-openstack to the required-projects https://review.opendev.org/714784
23:32:30 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Update the badge shown in galaxy https://review.opendev.org/714795
#openstack-sdks - 2020-03-25
00:26:13 openstackgerrit Merged openstack/openstacksdk master: Add bulk creation of rules for Security Group. https://review.opendev.org/714103
06:40:46 openstackgerrit Merged openstack/ansible-collections-openstack master: Add ansible-collections-openstack to the required-projects https://review.opendev.org/714784
06:42:35 openstackgerrit Merged openstack/ansible-collections-openstack master: Update the badge shown in galaxy https://review.opendev.org/714795
07:08:30 openstackgerrit Merged openstack/openstacksdk master: Add support for Identity Providers https://review.opendev.org/714122
09:13:00 openstackgerrit Sagi Shnaidman proposed openstack/openstacksdk stable/rocky: Fix pep8 issues in project https://review.opendev.org/714899
09:36:13 openstackgerrit Sagi Shnaidman proposed openstack/openstacksdk stable/rocky: Fix pep8 issues in project https://review.opendev.org/714899
10:02:40 openstackgerrit Mark Chappell proposed openstack/openstacksdk master: Add support for Federation Protocols https://review.opendev.org/714431
10:07:59 sshnaidm dtantsur, mordred, cores, can you please take a look at https://review.opendev.org/#/c/714899 ? I don't really understand what Jens Harbott means, maybe I don't have a right context. But something should be done there to restore the gates. I don't know why fixing pep8 is such a problem, tbh.
10:19:58 openstackgerrit Jens Harbott (frickler) proposed openstack/openstacksdk stable/rocky: Cap hacking to avoid pep8 failures https://review.opendev.org/714911
10:20:36 frickler sshnaidm: that's me, btw, and ^^ is my proposed alternative. not sure test-reqs.txt is the correct location, but I hope so
10:21:02 sshnaidm frickler, great, thanks!
10:21:07 sshnaidm let's see if it helps
10:21:39 sshnaidm but there are a lot of pep8 issues, including non-4 indentation, etc
10:27:54 dtantsur thanks frickler, I guess we should do it on all branches?
10:28:15 sshnaidm frickler, it fails, on pep8 and requirements-check now
10:33:48 rpittau frickler: I left a comment in the review
11:09:45 openstackgerrit Jens Harbott (frickler) proposed openstack/openstacksdk stable/rocky: Cap hacking to avoid pep8 failures https://review.opendev.org/714911
11:10:38 frickler rpittau: seems you were right, not sure why we do not pull in our local (test-)reqs.txt in the pep8 env, but this should fix the errors
11:11:46 rpittau frickler: yeah, that should work
11:12:06 frickler dtantsur: I didn't see pep8 failures for newer branches
11:21:59 dtantsur frickler: they're probably fixed, but I think at some point we (as a community) came to a resolution to cap hacking
11:37:37 frickler dtantsur: indeed, with https://review.opendev.org/640597 mordred fixed it the way I would have expected for train and beyond
11:37:50 frickler not sure about stein, though
11:38:07 dtantsur frickler: should we backport that instead of your patch maybe?
11:39:59 frickler dtantsur: maybe, let's wait what mordred thinks about it, did a -W on my patch in the meantime
11:41:51 dtantsur frickler: I personally find it quite non-controversial. but I'm fine with waiting as well.
11:44:18 tremble dtantsur, Can I interest you in https://review.opendev.org/#/c/714431/ and get the last of my SDK changes in?
11:44:46 dtantsur you can try :)
11:50:54 dtantsur +2, a couple of minor things for your optional consideration
11:52:46 tremble dtantsur, The brackets nit is an old habit from switching between programming languages I'm never 100% exactly what the evaluation order is and brackets make it obvious
11:53:12 gtema tremble - will you do a followup or change it here?
11:53:31 gtema since I will give it a go otherwise
11:53:45 dtantsur tremble: I don't insist, but they look a bit weird for a long-term Python coder like me
11:54:05 gtema agree
11:55:16 tremble gtema, I'll get them cleaned up, if you guys are happy python will do the right thing then there's no reason to add my coding oddities to a shared code base.
12:19:25 openstackgerrit Mark Chappell proposed openstack/openstacksdk master: Add support for Federation Protocols https://review.opendev.org/714431
12:33:40 gtema dtantsur, https://review.opendev.org/#/c/699416/ please
13:02:31 dtantsur gtema: you know that I'm not really on OSC core, right?
13:13:01 mordred frickler, dtantsur: I'm good backporting whichever pep8 patch makes sense ... the test-requirements seems fine since that's in master already
13:20:32 gtema dtantsur - sure, but your opinion as SDK dev
13:24:18 dtantsur okay, but I'm in a chain of meetings now
13:31:16 openstackgerrit jayaditya gupta proposed openstack/python-openstackclient master: Add '--force; parameter to 'openstack quota set' https://review.opendev.org/713881
13:52:35 openstackgerrit Jens Harbott (frickler) proposed openstack/openstacksdk stable/stein: Move pep8 requirements in to test-requirements https://review.opendev.org/714946
13:53:41 frickler mordred: dtantsur: sshnaidm: rpittau: ^^ that would be the backport, needed manual amending because the hacking factory seems to not be there, I don't think we would want to backport that, too, would we?
13:54:03 dtantsur I guess not..
13:55:24 mordred frickler: wfm
13:55:46 sshnaidm frickler, actually my patch is a backport, but with conflicts resolved
13:55:53 sshnaidm I couldn't backport it automatically
13:56:42 sshnaidm frickler, mordred https://review.opendev.org/#/c/714899/
14:35:25 openstackgerrit Vishakha Agarwal proposed openstack/python-openstackclient master: Adding options to user cli https://review.opendev.org/697444
15:19:21 openstackgerrit Merged openstack/python-openstackclient master: Switch image to use SDK https://review.opendev.org/650374
15:19:22 openstackgerrit Merged openstack/python-openstackclient master: Complete switch from glanceclient to SDK for image service https://review.opendev.org/699416
15:35:27 tremble dtantsur ( gtema ), https://review.opendev.org/714431 now has your requested changes
15:35:56 dtantsur will check after the current meeting
15:36:03 tremble Sure thing
15:37:33 tremble mordred, was there a nominal date for the next SDK 'release' ?
15:39:59 mordred tremble: my current thinking is "as soon as your patches land"
15:40:07 mordred tremble: but - absolutely by the end of this week
15:40:16 mordred (so we need to get your patches landed by the end of this week at the latest)
15:41:14 mordred s/patches/patch
15:44:29 tremble Fair enough :)
15:44:41 tremble mordred, Well https://review.opendev.org/714431 is ready for review :)
15:49:33 tremble mordred, Dumb question - Do you need anything from me on the release notes side of things? I have no idea how reno works
15:50:41 mordred tremble: it's probably not a bad idea. to make one, you just run "reno some-name" - so like "reno added-federation-support" - it'll make a file in releasenotes and show you the path to it
15:51:07 mordred then you edit that file, remove sections that aren't relevant and put in content - so announcing the new feature - doesn't have to be a lot
15:51:17 mordred then git add the file and add it to the commit
15:52:04 tremble mordred, Most of the commits are merged already, should I just spawn a separate review?
15:52:22 mordred yeah - or you could add it to your latest patch there
15:52:58 mordred when we cut the release we'll pick up all of the notes from it - so they can be in a separate patch or in the same - whichever is easier for you will work for me :)
15:53:29 tremble I'll drop it as its own patch, I've been having issues with test flakes
15:54:26 mordred cool
16:00:33 tremble In theory there's a 'service_provider' interface that I've not added support for because we're not using it (we offload the relevant pieces to Apache)
16:38:46 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_mapping https://review.opendev.org/713643
16:38:47 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New module: os_keystone_mapping_info https://review.opendev.org/713686
16:38:48 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_identity_provider https://review.opendev.org/714632
16:38:49 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_identity_provider_info https://review.opendev.org/714633
16:38:50 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_federation_protocol https://review.opendev.org/714991
16:38:51 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_federation_protocol_info https://review.opendev.org/714992
16:47:19 openstackgerrit Mark Chappell proposed openstack/openstacksdk master: Add Release notes entry for Identity v3 IDP, Mapping and Protocol https://review.opendev.org/714994
17:50:14 openstackgerrit Akihiro Motoki proposed openstack/python-openstackclient master: Adding options to user cli https://review.opendev.org/697444
19:27:34 openstackgerrit Merged openstack/openstacksdk master: Add support for Federation Protocols https://review.opendev.org/714431
19:27:35 openstackgerrit Merged openstack/openstacksdk master: Add Release notes entry for Identity v3 IDP, Mapping and Protocol https://review.opendev.org/714994
19:41:02 sshnaidm frickler, can we please revisit this patch again? https://review.opendev.org/#/c/714899/ it pass and fixes a lot of pep8 issues
19:41:39 sshnaidm seems like https://review.opendev.org/#/c/714911/ just ignores them.. also could be an option, of course
20:08:57 openstackgerrit Jesse Pretorius (odyssey4me) proposed openstack/openstacksdk master: [tests] Improve devstack/post playbook efficiency https://review.opendev.org/715052
20:25:28 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add unit test for rackspace block-storage workaround https://review.opendev.org/715058
20:25:58 mordred dtantsur|afk: ^^
20:28:07 mordred sshnaidm: just left a comment on your backports of the fetch-subunit-output - let's squash in odyssey4me's
20:28:28 mordred (since I think the two of them together will be a nice improvement for all the branches)
20:29:59 sshnaidm mordred, yeah, totally fine with that
20:30:02 mordred cool

Earlier   Later