Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-02-26
17:14:20 mordred to pass if_match to resource.commit() and get it all the way to _prepare_request
17:14:59 mordred (as well as to openstack.proxy.Proxy._update)
17:15:12 mordred gtema: ^^ does that sound sane to you?
17:15:32 mordred because I agree - you don't want an if-match property on the resource - it's not actually a part of the resource
17:15:33 gtema lemme read quickly
17:15:57 mordred gtema: https://review.opendev.org/710030 has the rest of the context
17:16:19 dulek That sounds sane, sure, but where in prepare_request() would I have the value of user's if-match?
17:16:28 dulek Seems like it doesn't get any user input at the moment.
17:16:33 dulek Though I guess it could?
17:16:56 dulek Okay, I see.
17:17:19 dulek So the good old plumbing is the correct way. :)
17:18:03 mordred yeah - I think we'd want them to call either my_network_resource.commit(conn.network, if_match='revision=3') - or conn.update_network(foo='bar', if_match='revision=3')
17:18:24 mordred we could get fancier and make our if_match take a dict instead of a strict and construct the string for them
17:18:39 gtema we don't expect if-match to ever be used outside of network, right?
17:18:47 dulek gtema: In such form - no.
17:19:21 dulek mordred: I'd probably prefer conn.update_network(foo='bar', if_match_rev=3). I don't think in Neutron you're allowed to use other property names anyway.
17:20:25 gtema we can then do the old way with _base resource in the network service, not to have changes in real openstack.Resource
17:20:29 mordred hrm. if it's only ever revision and we can confirm that, yeah - i'd prefer that - or even just "if_revision"
17:20:44 mordred gtema: yeah.
17:21:44 mordred ok. yeah - seems to just be revision: https://docs.openstack.org/api-ref/network/v2/#revisions
17:22:16 mordred we might want to check to see if the neutron supports the revision-if-match extension too - but we can probably skip that for v1
17:22:30 mordred so I'd argue for "if_revision" or something else clean like that
17:23:14 mordred gtema: it's more widely used
17:23:32 gtema okay then
17:23:39 gtema never noticed so far
17:23:46 openstackgerrit Merged openstack/openstacksdk master: Adding basic implementation for Accelerator(Cyborg) https://review.opendev.org/679914
17:24:08 mordred https://docs.openstack.org/swift/pike/overview_encryption.html
17:24:15 dulek mordred: Yeah, but now neutron-specific changes in base resource? Because that'd be really neutron-specific, it seems.
17:24:32 gtema a good old swift
17:25:29 mordred python-cinderclient has a test that sets if-match
17:26:05 mordred api-sig also suggests its use, and there is an ironic spec about using it
17:26:08 mordred but I don't see code anywhere
17:26:48 mordred so - I think we could still stick with gtema's suggestion of just doing it in network since it's not *actually* widely supported with any sort of semantics that we can predict
17:27:06 mordred and in network we can implement it as if_revision not as generic if-match exposure
17:27:17 mordred which, if we grow generic if-match in the future shouldn;'t conflict
17:27:34 gtema yupp, sounds good for me
17:27:44 dulek mordred: I agree here. So base resource for neutron resources subclassing prepare_request?
17:29:07 openstackgerrit Artem Goncharov proposed openstack/ansible-collections-openstack master: Add volume_backup module https://review.opendev.org/710093
17:30:18 mordred dulek: yeah - I think so. if you're game to take a stab at that - maybe throw up a WIP early even if it's not quite working yet and we can see how that goes
17:31:04 mordred it's also possible that putting it in base resource behind an "allow_if_revision" flag might hurt our brains less ... but it also might be more plumbing :)
17:31:32 dulek mordred: I'll see what I can do, sure. Thanks for help!
17:33:37 gtema ok, I "depart" for today. cu
18:16:01 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Add a tool to build collections with pbr https://review.opendev.org/710047
#openstack-sdks - 2020-02-27
13:32:54 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Fix network segment range "_get_ranges" function https://review.opendev.org/710031
14:20:47 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Add a tool to build collections with pbr https://review.opendev.org/710047
15:29:29 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Fix F841 and remove exclusion https://review.opendev.org/698063
15:29:30 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Fix E128 and remove exclusion https://review.opendev.org/698064
15:29:31 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Fix F401 and remove exclusion https://review.opendev.org/698065
15:29:32 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Remove old artifacts when building new ones https://review.opendev.org/710293
15:29:33 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Run flake8 in linters https://review.opendev.org/710294
15:29:34 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Remove F403 and F405 exclusions https://review.opendev.org/710295
15:29:35 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Fix W504 and remove exclusion https://review.opendev.org/710296
15:52:49 openstackgerrit Michał Dulko proposed openstack/openstacksdk master: Implement If-Match support for Neutron resources https://review.opendev.org/710030
15:56:04 openstackgerrit Michał Dulko proposed openstack/openstacksdk master: Implement If-Match support for Neutron resources https://review.opendev.org/710030
16:00:18 elmiko API SIG office hour now open
16:00:25 openstackgerrit Michał Dulko proposed openstack/openstacksdk master: Implement If-Match support for Neutron resources https://review.opendev.org/710030
16:02:45 gtema hi elmiko. So with PTG it's all clear, right?
16:03:23 dulek mordred, gtema: Alright, so here's my attempt to implement that thing with the simple plumbing: https://review.opendev.org/#/c/710030.
16:03:27 dulek Tell me what you think!
16:05:28 gtema dulek, will have a look, but unfort. not today - a total madness today
16:05:53 dulek gtema: Well, this thing isn't really urgent.
16:07:55 gtema that's good
16:09:16 elmiko gtema: is it?
16:09:55 gtema elmiko - it is, nobody cares. We do what we want
16:14:05 mordred dulek: that's looking good!
16:15:06 mordred elmiko, gtema: I requested a day from kendall for SDK/OSC/ansible-openstack - I think that could also easily include API ... basically a day we can divy up however
16:15:52 gtema yupp, thanks mordred. With additional 1/4 day dtantsur requested specifically for API we are absolutely ok
16:16:31 gtema and as Kendall confirmed per email - there is no procedure/deadline on how/whether we need to publish our planning
16:17:13 mordred cool
16:26:24 elmiko sorry got sig_meeting
16:35:47 elmiko mordred gtema , that sounds good to me. i won't be at the ptg, but i'm happy to help from afar however i can
16:35:59 gtema ack
18:56:20 tbarron 1
18:56:26 tbarron wrong window
18:56:28 tbarron sorry
18:56:52 tbarron mysecretbankpw42
18:57:34 tbarron https://bankofamerica.com/user=?/tbarron
19:16:35 mordred tbarron: I'm so rich now
19:38:32 tbarron mordred: nice
19:56:53 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Remove old artifacts when building new ones https://review.opendev.org/710293
19:56:54 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Run flake8 in linters https://review.opendev.org/710294
19:56:55 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Fix F841 and remove exclusion https://review.opendev.org/698063
19:56:56 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Remove F403 and F405 exclusions https://review.opendev.org/710295
19:56:57 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Fix E128 and remove exclusion https://review.opendev.org/698064
19:56:58 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Fix W504 and remove exclusion https://review.opendev.org/710296
19:56:59 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Fix F401 and remove exclusion https://review.opendev.org/698065
23:33:27 openstackgerrit Merged openstack/ansible-collections-openstack master: Add tests for os_user_role in multidomain context https://review.opendev.org/705719
23:38:06 openstackgerrit Merged openstack/ansible-collections-openstack master: fix constructed compose https://review.opendev.org/704582
#openstack-sdks - 2020-02-28
02:31:24 openstackgerrit Prashant Bhole proposed openstack/openstacksdk master: Fix: Set image name correctly if filename is not passed https://review.opendev.org/710368
10:52:16 openstackgerrit Michał Dulko proposed openstack/openstacksdk master: Implement If-Match support for Neutron resources https://review.opendev.org/710030
10:52:16 openstackgerrit Michał Dulko proposed openstack/openstacksdk master: Implement If-Match support for Neutron resources https://review.opendev.org/710030
14:20:17 openstackgerrit Adam Harwell proposed openstack/openstacksdk master: Add availability_zone param to load balancer https://review.opendev.org/710452
#openstack-sdks - 2020-02-29
14:50:45 openstackgerrit Merged openstack/ansible-collections-openstack master: Add a tool to build collections with pbr https://review.opendev.org/710047
#openstack-sdks - 2020-03-01
12:15:16 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Just use shutil.rmtree in build.py https://review.opendev.org/710640
12:31:38 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Just use shutil.rmtree in build.py https://review.opendev.org/710640
12:31:39 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Fix H236 and remove exclusion https://review.opendev.org/698066
12:31:40 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Remove from __future__ lines https://review.opendev.org/698067
12:31:41 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Test with and assert support for python3 https://review.opendev.org/710641
#openstack-sdks - 2020-03-02
12:53:59 larsks How does one pass all_tenants=true to the list_volumes method in python-openstacksdk?
13:27:50 openstackgerrit Merged openstack/ansible-collections-openstack master: Remove old artifacts when building new ones https://review.opendev.org/710293

Earlier   Later