Posted	Nick	Remark
#openstack-sdks - 2019-10-03
09:30:11	mordred	stephenfin: cool. I have someone interested in adding some type annotations - which obviously need 2 to go away
09:30:32	stephenfin	mordred: https://review.opendev.org/#/c/676209/
09:30:41	stephenfin	ignore all the failures - I rushed it :)
09:30:45	mordred	nice!
09:31:10	stephenfin	We might want to put this in openstack-zuul-jobs though https://review.opendev.org/#/c/676210/
09:31:19	mordred	stephenfin: zuul projects are already py3 - this one: https://review.opendev.org/#/c/686249/ added annotations but had to put in an ignore on the "import openstack" line
09:32:04	mordred	yeah - probably so. we've actually caught bugs with mypy in zuul
09:32:09	stephenfin	mordred: That's because we're using an old version of flake8 because hacking hasn't been updated. New versions support type hints
09:32:19	stephenfin	or rather, detect that an import is necessary due to type hints
09:32:50	stephenfin	alas, updating hacking to work with flake8 3.x is easier said that done because it was completely rewritten. I've tried and failed a few times :(
09:32:51	mordred	oh - no - I mean we had to mypy ignore it becuase there's no type information from openstack I think
09:32:55	stephenfin	ohhh
09:33:06	mordred	oh goodie
09:33:31	mordred	stephenfin: yeah - line 17: https://review.opendev.org/#/c/686249/3/zuul_registry/swift.py
09:33:46	stephenfin	mordred: This should do the same thing, I think https://review.opendev.org/#/c/676208/1/setup.cfg@91
09:34:16	stephenfin	but maybe not. I'm at about 3/10 on the "understanding how mypy works" scale rn
09:34:22	mordred	stephenfin: ignore_missing_imports? or follow_imports=skip?
09:34:32	stephenfin	ignore_missing_imports
09:34:50	stephenfin	hmm, maybe not actually
09:35:04	mordred	ah - no, follow_imports=skip
09:35:07	mordred	https://mypy.readthedocs.io/en/latest/running_mypy.html#follow-imports
09:36:23	stephenfin	Hmm, worth experimenting with those flags, I imagine
09:36:26	stephenfin	That's cool though
09:37:04	mordred	yeah
09:37:13	stephenfin	I'd like to see them in most of oslo too, though I think I'll need to request help from the mypy folks for o.v.o. That's a weird one
09:37:19	stephenfin	zuul doesn't use oslo though, does it?
09:37:24	mordred	that said - it would be nice to add the annotations so that you could annotate things with signatures of the imported objects
09:37:35	mordred	stephenfin: that's right - zuul does not use oslo
09:37:49	stephenfin	cool. probably won't affect you much so :)
09:55:26	mordred	stephenfin: oh - actually - fwiw, we just run mypy in our pep8 tox env
09:55:44	mordred	which is really "static code analysis tox env"
09:57:05	stephenfin	Hmm, I wanted to keep it separate because (a) pep8 is already _really_ slow in nova and I did not want to make it even slower, and (b) we're all luddites there and I didn't want to foist stuff onto people before they were ready :)
09:57:24	stephenfin	I could go with pep8 though. Don't some project use a 'linters' target?
09:57:27	stephenfin	*projects
09:57:45	stephenfin	or 'style' or something? /me tries to recall where he saw it
10:07:12	mordred	stephenfin: yeah - we tried switching to linters a while back, but didn't really get any traction
10:08:08	mordred	but - you know - mostly thinking about it from a gate pov and not a local dev pov - I imagine pep8+mypy is still quicker than py36 unittests
10:08:22	mordred	it's a good point re: local dev though, especially if pep8 is slow for y'all
10:14:47	mordred	poo. the connection metaclass makes sdk almost impossible to type hint
10:15:36	mordred	maybe we should replace it with a generated file and a zuul job that runs when os-service-types list updates
10:50:32	openstackgerrit	Merged openstack/os-client-config master: Update master for stable/train https://review.opendev.org/683481
11:02:14	openstackgerrit	Merged openstack/shade master: fix "How To Contribute",bugs,review url https://review.opendev.org/682801
11:02:14	openstackgerrit	Merged openstack/shade master: Update master for stable/train https://review.opendev.org/683658
11:19:48	openstackgerrit	Merged openstack/python-openstackclient master: Add 'openstack server migrate (confirm|revert)' commands https://review.opendev.org/664393
11:49:37	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Use has_service in functional test's require_service https://review.opendev.org/685995
11:49:38	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999
13:11:41	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: WIP Start supporting type info https://review.opendev.org/686397
13:32:48	openstackgerrit	Monty Taylor proposed openstack/keystoneauth master: WIP Add typing flag file https://review.opendev.org/686401
13:50:37	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Use has_service in functional test's require_service https://review.opendev.org/685995
13:56:25	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999
13:56:44	openstackgerrit	Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408
14:00:23	mordred	dtantsur|afk: when you get a sec, I left a note in 685999 - I'm wondering if you have any ideas on how a "good" way to handle that is since you've been doing more with microversions so far
14:00:56	mordred	I'm guessing I'd want to put something into the ServerGroup resource that controlled which mv it used when doing the creation call
14:08:11	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999
14:10:41	mordred	dtantsur|afk: neverind - mriedem tells me that in this case it's easy - old mv never actually supported a list
14:11:10	mriedem	child's play
14:19:33	openstackgerrit	Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408
14:23:19	openstackgerrit	Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408
15:33:45	openstackgerrit	Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408
15:37:32	openstackgerrit	Matt Riedemann proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408
15:46:11	openstackgerrit	Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408
15:56:33	openstackgerrit	Tristan Cacqueray proposed openstack/openstacksdk master: WIP: annotate some swift function used by the zuul_registry https://review.opendev.org/686433
15:59:43	openstackgerrit	Matt Riedemann proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408
16:00:49	elmiko	API SIG office hour is now open
23:59:14	openstackgerrit	Brin Zhang proposed openstack/python-openstackclient master: Add server migrate list CLI https://review.opendev.org/675304
#openstack-sdks - 2019-10-04
06:51:36	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999
06:52:29	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999
06:53:16	openstackgerrit	Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042
06:56:04	mordred	efried, cmurphy, kmalloc, Shrews: https://review.opendev.org/#/q/topic:fix-auth-discovery <-- assuming all three are green, I believe that is now the stack with the right depends-on to fix the issue and that the tests jobs properly validate the issue. the sdk patches should show that the needed sdk fixes work without the ksa fix, then the sdk test jobs on the ksa patch show that they continue to work
06:56:06	mordred	with the fix added
06:56:46	mordred	which should make it safe to land the openstacksdk patches, cut a release, then land the ksa patch and cut a release.
06:57:48	mordred	of course, I *think* what we need here (correct me if I'm wrong efried) is that we need to land the patches, then backport to stable/train, then cut a stable release on train - first for sdk then for ksa
08:09:08	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: WIP Start supporting type info https://review.opendev.org/686397
08:09:09	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Use generated list of services instead of metaclass https://review.opendev.org/686542
09:05:29	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Use generated list of services instead of metaclass https://review.opendev.org/686542
10:57:35	mordred	gtema: https://review.opendev.org/#/c/686542/ if you get a sec
11:09:34	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Start supporting type info https://review.opendev.org/686397
11:27:35	mordred	Shrews, cmurphy, efried, kmalloc: woot! all green!
11:58:40	bverschueren_	if anyone has a moment to look at https://review.opendev.org/#/c/682909/ ? thx
12:23:00	mordred	gtema, efried: incidentally - the ksa patch also fixes a thing that sdk was doing but we weren't noticing - which is making a failed call to discovery before *every* nova call -- because it failed, it didn't cache a discovery document
12:23:22	gtema	really? cool
12:23:26	mordred	I only noticed it was happing debugging a different issue
12:23:27	mordred	yeah
12:24:04	gtema	ok. I do not see this in my cloud, so perhaps some additional Nova change is there, but cool that it fixes things generally
12:28:38	gtema	nom, you are totally right - I simply haven't noticed that
12:39:21	openstackgerrit	Monty Taylor proposed openstack/os-client-config master: Stop testing python2.7 https://review.opendev.org/686589
12:43:56	openstackgerrit	Monty Taylor proposed openstack/python-openstackclient master: Stop testing python2 https://review.opendev.org/686590
12:48:24	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Stop testing python2 https://review.opendev.org/686592
12:56:27	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999
12:57:02	mordred	gtema: ^^ I added a release note (was going to backport to stable/train, but noticed there was no release note explaining why the patch was important)
13:06:20	openstackgerrit	OpenStack Release Bot proposed openstack/python-openstackclient master: Update master for stable/train https://review.opendev.org/686607
13:12:55	gtema	mordred: +2-ed
13:15:55	mordred	gtema: thanks!
13:30:05	efried	mordred: I concur with your assessment. Were you thinking we would get those stable/train releases into train's requirements before the release?
13:30:32	openstackgerrit	Merged openstack/python-openstackclient master: Update master for stable/train https://review.opendev.org/686607
13:41:39	mordred	efried: I don't know if it's possible to - but I figured cutting a small point release on top of train shortly after the release could also work, yeah/
13:41:41	mordred	?
13:42:51	efried	mordred: the difference being that we cannot update e.g. nova's lower-constraints after the release, so we can't rely on the new behavior in train in that case.
13:44:30	mordred	hrm. maybe it's worth going and talking to our release friends
13:51:33	openstackgerrit	Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042

Earlier   Later