| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2019-07-09 | |||
| 15:13:45 | mordred | dtantsur: I agree with all of your uneasiness | |
| 15:15:04 | dtantsur | the practical question for me is whether to update openstacksdk or hack endpoint_override inside ironic | |
| 15:23:13 | mordred | dtantsur: well - this logic is actually all in keystoneauth | |
| 15:36:04 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Return empty lists for resources if neutron doesn't exist https://review.opendev.org/669869 | |
| 17:54:58 | Shrews | mordred: gtema: fyi, looks like the openstacksdk-functional-devstack-magnum and openstacksdk-functional-devstack-masakari check jobs have been consistently failing since https://review.opendev.org/662743 | |
| 17:55:50 | Shrews | i was unable to find any earlier change with those failures (though it may exist) | |
| 17:59:36 | mordred | Shrews: oh - we should fix that then | |
| 18:00:14 | mordred | Shrews: looks like it's just failing the has_service Magnum check | |
| 18:00:21 | Shrews | i cant access the logs from this coffee shop. my vpn blocks logs.o.o for some reason | |
| 18:00:35 | mordred | maybe it's incidental and something changed in devstack | |
| 18:01:09 | Shrews | thats an odd check to fail in a magnum specific test :) | |
| 18:02:28 | mordred | Shrews: yah | |
| 18:02:42 | mordred | Shrews: also - I guess it's good that we have that check | |
| 18:02:55 | Shrews | ++ | |
| 18:08:28 | Shrews | heading back to the house. thought i could work from here just to get out of the house, but much too uncomfortable here. biab | |
| #openstack-sdks - 2019-07-10 | |||
| 10:23:31 | openstackgerrit | Bin Lu proposed openstack/python-openstackclient master: add optional argument metric to set metric for routes https://review.opendev.org/637658 | |
| 14:00:42 | mordred | slaweq: I fixed https://review.opendev.org/#/c/669869/ yesterday - have a moment to reapply your +2 ? | |
| 14:01:46 | slaweq | mordred: done | |
| 14:08:48 | mordred | slaweq: thanks! | |
| 14:30:02 | slaweq | mordred: yw | |
| 15:38:42 | openstackgerrit | Merged openstack/openstacksdk master: Return empty lists for resources if neutron doesn't exist https://review.opendev.org/669869 | |
| 17:24:43 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Rework statistics reporting https://review.opendev.org/659841 | |
| 17:35:10 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Prepare Server to be used in cloud layer https://review.opendev.org/665105 | |
| 17:41:44 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Use resource layer for compute flavors https://review.opendev.org/650903 | |
| 17:59:59 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Repair masakari FT https://review.opendev.org/670145 | |
| #openstack-sdks - 2019-07-11 | |||
| 02:16:16 | openstackgerrit | Bin Lu proposed openstack/python-openstackclient master: add optional argument metric to set metric for routes https://review.opendev.org/637658 | |
| 12:35:55 | openstackgerrit | Grégoire Unbekandt proposed openstack/openstacksdk master: Can't create a metadata named key, clear, delete https://review.opendev.org/670293 | |
| 13:58:47 | openstackgerrit | Grégoire Unbekandt proposed openstack/openstacksdk master: Specify store when importing an image https://review.opendev.org/670309 | |
| 15:56:38 | openstackgerrit | Eric Fried proposed openstack/keystoneauth master: Add a per-request global_request_id https://review.opendev.org/670341 | |
| 16:00:03 | edleafe | Let the API-SIG Office Hour begin! | |
| 16:00:07 | elmiko | \o/ | |
| 16:00:57 | edleafe | elmiko: Don't know if you got the letter from Kendall Nelson about groups planning to be in Shanghai | |
| 16:01:46 | elmiko | i did see that, is anyone from the sig going to be there? | |
| 16:01:56 | elmiko | i will not be ther | |
| 16:02:19 | edleafe | I was hoping to ask you and dtantsur|afk, but he's afk, apparently | |
| 16:02:27 | edleafe | I won't be there, either | |
| 16:05:39 | elmiko | i don't recall if dmitry had mentioned it | |
| 16:08:52 | edleafe | Well, she mentioned that unless someone says "Yes, our team will be at that PTG", the assumption is that they won't | |
| 16:09:33 | edleafe | So if dtantsur|afk wants to host a session there, he'll have to a) let Kendall know and b) plan on being lonely :) | |
| 16:11:12 | elmiko | heh, good point | |
| 16:11:42 | elmiko | i can send an email to dmitry just to confirm if he will be there | |
| 16:18:01 | cmurphy | hello, i have a question to bring to the api-sig | |
| 16:18:23 | cmurphy | We have a change to remove some deprecated config options related to PKI tokens https://review.opendev.org/659434 (cc vishakha) | |
| 16:18:29 | openstackgerrit | Merged openstack/openstacksdk master: Can't create a metadata named key, clear, delete https://review.opendev.org/670293 | |
| 16:18:29 | cmurphy | for keystone | |
| 16:18:32 | openstackgerrit | Merged openstack/openstacksdk master: Repair masakari FT https://review.opendev.org/670145 | |
| 16:18:34 | openstackgerrit | Merged openstack/openstacksdk master: Add Python 3 Train unit tests https://review.opendev.org/669449 | |
| 16:19:29 | cmurphy | When those options are unconfigured, one of the APIs can't work and to date we've been raising a 500 to indicate the server is misconfigured | |
| 16:19:40 | cmurphy | With this change, there will no longer be any chance for that API to work since the server is effectively always misconfigured | |
| 16:19:51 | cmurphy | So the question is, do we keep raising the 500 consistent with how it worked before, or do we change the response to a 410 Gone to be a little more honest about the fact that this API just doesn't work any more | |
| 16:19:59 | cmurphy | keeping in mind that keystone doesn't do microversions | |
| 16:20:48 | elmiko | so, off the top of my head if that api is no longer supported i would expect some 4xx error as opposed to 5xx since the client is in error here | |
| 16:21:28 | elmiko | i'm not sure if 410 is the proper status or not, i'd have to do a little more reading | |
| 16:22:21 | cmurphy | okay, yeah someone else made the point that a 4XX at least indicates that retrying isn't going to do any good | |
| 16:22:48 | elmiko | right, imo 4xx means the client needs to do something different. which in this case means don't call those apis anymore XD | |
| 16:23:48 | elmiko | are you leaving the routes in for backward compatibility? like, how come you don't just return 404 for those? | |
| 16:23:58 | edleafe | cmurphy: Since you don't provide access to the old API behavior, it would be my preference to have keystone handle this case more gracefully. IOW, if it can do what it needs to do without those config settings, just do that | |
| 16:24:34 | elmiko | ++ good question edleafe | |
| 16:25:28 | cmurphy | elmiko: yes we wanted to leave the route there to maintain some kind of backwards compatibility even though that's not really achievable in this case | |
| 16:25:58 | elmiko | ack | |
| 16:26:22 | cmurphy | edleafe: there's no way to have keystone do the same thing without those config settings, the config setting just set a location of a CA cert file that was read and returned by that GET API | |
| 16:26:44 | edleafe | cmurphy: you *do* realize that mordred will hunt you down and punish you, right? :) | |
| 16:26:52 | cmurphy | yes >.> | |
| 16:26:54 | elmiko | haha | |
| 16:27:35 | edleafe | cmurphy: So you're making what amounts to a major version change, without leaving the old version in place. Is that correct? | |
| 16:29:18 | cmurphy | I don't think it's that drastic, the API was already badly designed because it depended on the operator generating this file and configuring this parameter, we're just cementing in the behavior it had if the operator failed to do that | |
| 16:30:06 | cmurphy | and since PKI tokens are not in use 99% of clouds will already have this behavior | |
| 16:30:56 | edleafe | By a "major version change" I meant one where a request that worked before can no longer work the same way. | |
| 16:31:19 | edleafe | If it's a case of "no one uses it anyway", then that's a practical matter | |
| 16:32:13 | edleafe | In that case, I think that 410 Gone is the proper response | |
| 16:33:15 | cmurphy | okay | |
| 16:33:43 | cmurphy | I'll take this back to the team, maybe we can find a way to handle this more gracefully, otherwise we'll go with a 410 | |
| 16:34:57 | cmurphy | thanks for the advice edleafe elmiko | |
| 16:35:03 | elmiko | gladly cmurphy =) | |
| 16:36:04 | edleafe | That's what we're here for! :) | |
| 16:38:33 | elmiko | speaking of that, i have to leave a little early edleafe | |
| 16:38:46 | edleafe | Awww, I'll miss you! | |
| 16:38:49 | elmiko | <3 | |
| 16:38:58 | elmiko | catch you next week if not sonner o/ | |
| 16:39:05 | elmiko | er even sooner! | |
| 16:39:23 | edleafe | I'll be here (for a while, at least!) | |
| 17:33:54 | cmurphy | mordred: could you ack https://review.opendev.org/670136 | |
| 17:57:50 | mordred | cmurphy: ack | |
| 18:00:39 | cmurphy | ty | |
| 21:30:10 | openstackgerrit | Merged openstack/keystoneauth master: Add a per-request global_request_id https://review.opendev.org/670341 | |
| 21:48:41 | openstackgerrit | Eric Fried proposed openstack/keystoneauth master: reno: per-request global_request_id https://review.opendev.org/670399 | |
| 22:16:06 | openstackgerrit | Merged openstack/keystoneauth master: reno: per-request global_request_id https://review.opendev.org/670399 | |
| #openstack-sdks - 2019-07-12 | |||
| 06:26:07 | openstackgerrit | ZhaoBo proposed openstack/openstacksdk master: force specify project_id during create Sg_rule may cause issue https://review.opendev.org/667261 | |
| 08:08:32 | openstackgerrit | Grégoire Unbekandt proposed openstack/openstacksdk master: Specify store when importing an image https://review.opendev.org/670309 | |
| 13:45:05 | openstackgerrit | Matt Riedemann proposed openstack/python-openstackclient master: Add host and hypervisor_hostname to create servers https://review.opendev.org/669609 | |
| 14:30:32 | elmiko | edleafe: dtantsur|afk , i'm trying to get some info for the ptg response. did we do a meetup in denver, and if so how many folks showed up? | |
| 15:05:42 | edleafe | elmiko: Yes, we did 2 of them, and there were about 12 people at the Forum meeting, and only about 6 at the PTG meeting. | |
| 15:05:52 | elmiko | awesome, thanks! | |
| #openstack-sdks - 2019-07-15 | |||
| 14:35:38 | stingrayza | hey folks. I'm trying to help shepherd in a PR in ansible for a new os_ module (os_group_info) if any reviewers could take a look, that'd be great, thanks! (Apologies if you've seen me cross-post this too many times) | |
| 14:35:39 | stingrayza | https://github.com/ansible/ansible/pull/57120 | |
| 15:28:08 | mordred | stingrayza: lgtm | |
| 15:31:39 | stingrayza | thanks mordred :) | |
| 15:50:52 | stingrayza | and thanks gtema :) | |
| #openstack-sdks - 2019-07-16 | |||
| 00:13:27 | openstackgerrit | Merged openstack/python-openstackclient master: Add Python 3 Train unit tests https://review.opendev.org/669447 | |
| 00:19:37 | openstackgerrit | Merged openstack/osc-lib master: Add Python 3 Train unit tests https://review.opendev.org/669446 | |