Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2019-05-08
04:08:11 adriant johnsom: see error
04:08:55 adriant i'm not sure if octavia is screwed and should be returning links to version urls, or if it never did
04:11:33 johnsom Octavia had the links, what version of Octavia API are you using? Very old versions didn’t have links, but the newer version does. Sdk accounted for this.
04:17:43 adriant johnsom: we are running Queens, Octavia, which I thought had links?
04:17:53 adriant at least from looking at the code
04:18:12 adriant https://github.com/openstack/octavia/blame/master/octavia/api/root_controller.py#L56
04:18:42 johnsom adriant: 2.0.3 fixed the links issue. If you are running an older version of queens I highly recommend you update to the current queens version.
04:19:36 johnsom Current is 2.1.0 fyi
04:20:54 adriant I'm just curious why this 'used' to work
04:21:01 adriant and now doesn't
04:21:50 adriant we haven't upgraded octavia for a while, and I'm fairly sure the tools we had that used the SDK to talk to it, did used to work as recently as a month or two back :(
04:21:53 johnsom Yeah, I don’t have an answer for that. Octavia hasn’t touched the links code in a while so not likely the issue.
04:23:59 adriant weird :/
04:32:12 adriant johnsom: so looks like weird running a version that doesn't include links...
04:32:20 adriant but then why did the SDK used to work?
04:32:42 adriant was it updated to only expect links, or did it ever handle the non-link case?
04:32:59 johnsom Yeah, older versions compensated for that
04:33:08 adriant hmmm
04:34:17 johnsom I can’t speak for the sdk as I don’t track it closely. I can only talk to what we did in Octavia.
04:34:18 adriant any reason why it isn't capable of both cases?
04:34:32 adriant although I guess that's a mordred question
04:34:52 adriant because it's an annoying bit of backward incompatibility :(
04:35:11 johnsom Yeah, we fixed it in Octavia as soon as it was raised that we had an issue/bug.
04:35:12 adriant we plan to upgrade octavia to stein soon anyway, but still awkward
04:35:48 johnsom Yeah, even a queen update would probably fix you up.
04:36:44 adriant meanwhile I'm going to just find an old version of the SDK that still works I guess
04:36:59 johnsom Ok. Sorry for the trouble!
04:38:39 adriant I'm just curious why this code every worked...
04:38:43 adriant ever*
04:41:32 adriant and downgrading the SDK gets me a different error! :P
04:41:35 adriant "UnboundLocalError: local variable 'api_version' referenced before assignment"
04:43:36 adriant ty cdent
04:49:15 adriant well ok, I just can't make the SDK talk to Octavia :/
04:55:02 adriant actually, johnsom, when did you add version discovery at all to Octavia?
04:56:13 adriant nvm, looked at the repo
04:56:14 adriant ages ago
04:56:17 adriant hmmm
04:58:20 johnsom Yeah, a long time ago
05:20:31 adriant I give up, I'll rewrite this code to use the octavia client tomorrow...
05:20:55 adriant if anyone has alternative ideas for me when I look at IRC tomorrow, I'd be happy to try them.
06:21:22 adriant HAH! 0.17.2 works!
06:27:37 adriant so yeah, mordred, I'd call this a regression bug. SDK ought to work with older octavia despite the lack of links in the version listing.
08:18:08 openstackgerrit Witold Bedyk proposed openstack/python-openstackclient master: document the --timing option https://review.opendev.org/657640
13:06:41 mordred adriant: yeah - i agree - let's see if we can't figure out a fix
13:08:12 mordred adriant: oh - you know what ... (sorry I wasn't awake when you were encountering this ...)
13:08:44 mordred oh, no, nevermind. I thought there might be a one-line fix
13:16:54 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Workaround for older octavia https://review.opendev.org/657799
13:17:13 mordred adriant: when you wake up ... ^^ that should fix you from a workaround perspective
13:17:37 mordred adriant: looking at the code, I have a few ideas of how to solve this slighly less hacky - but they'll take a few more minutes to work on
13:18:12 gtema mordred: just a few minutes longer? that's like immediately ;-)
13:18:19 mordred gtema: hehe
13:19:26 mordred tl;dr - I think if we refactor openstack.service_description.ServiceDescription._make_proxy a little bit, we can make it easier to override parts of the story for individual services ... in their ServiceDescription subclass
13:20:13 gtema what do you mean?
13:21:07 mordred I'm not 100% sure yet :)
13:21:15 gtema :D
13:24:14 mordred johnsom: does octavia have microversions? (doesn't look like it) - also, I see a comment in the code that indicates exposing the v1 endpoint is a security risk - does that mean it's reasonable at this point to assume v2 is the only thing we'll be talking to (in the cases where version discovery doesn't work)
13:25:32 mordred gtema: I *think* what I'm thniking is that we have the ServiceDescription class do the initial stuff the same for everybody - then have a method we can override on a per-service basis (but most wouldn't) - that handles "what do I do if I found the service but service discovery didn't work"
13:26:23 mordred but what I shoudl really do is finish that patch from above and add some tests that show the correct behavior with a linkless octavia version document
13:27:13 gtema yes, right.
13:28:50 gtema mordred: as I see we do not currently have any tests for vendor profiles. I see those are really tricky, but probably need to introduce some
13:29:22 gtema especially since I am preparing this vendor_hook as part of the vendors/*.json and openstack.connect(vendor_hook='')
13:32:34 mordred gtema: yes. we should probably make some tests
13:32:58 gtema will try implement some for the vendor_hook patch
13:33:07 gtema and then extend separately
13:33:13 mordred :)
13:33:20 gtema hehe
13:48:16 johnsom mordred: v1 is only for neutron to talk to us, it was never user facing. No microcersions either.
13:49:15 mordred johnsom: ok, cool
13:54:42 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Workaround older octavia version discovery https://review.opendev.org/657799
13:55:03 mordred johnsom, adriant, gtema: ok - I was wrong - there is a one-line fix if you don't count the comment
13:55:40 gtema hehe, nice
13:57:17 gtema mordred: probably rename then network_adapter => adapter; network_endpoint => endpoint?
14:00:46 mordred gtema: I thought about that - but I was worried about shadowing other variables in that method. lemme pull it into a helper method real quick
14:00:58 gtema ok
14:05:36 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Workaround older octavia version discovery https://review.opendev.org/657799
16:23:44 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Add support for vendor hooks https://review.opendev.org/657848
21:18:17 openstackgerrit Jeremy Houser proposed openstack/python-openstackclient master: Alter test_volume.py to ensure volume deletion https://review.opendev.org/652682
21:22:46 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Fix bug in endpoint group deletion https://review.opendev.org/655889
21:59:23 adriant mordred: ty!
22:00:40 adriant I guess for that one script I'll downgrade to 0.17.2 for now, and then upgrade to the 0.28.0 release when it is out
22:00:45 adriant lemme grab that patch and test it
22:46:23 mordred adriant: yeah - let me know if it does, and we can get it in and get 0.28.0 out (which is overdue anyway)
22:52:16 adriant mordred: it works for me at least against an older Octavia
22:52:40 adriant I don't have a newer one to point to, but looking at the code changes I shouldn't change anything there either
22:52:51 adriant it* shouldn't
22:53:34 mordred adriant: cool. I'll try to get some tests written for it in the morning
23:25:16 openstackgerrit Merged openstack/python-openstackclient master: Fix --limit option in image list sub-command https://review.opendev.org/617139
23:28:01 openstackgerrit LIU Yulong proposed openstack/python-openstackclient master: Add floating IP Port Forwarding commands https://review.opendev.org/650062
#openstack-sdks - 2019-05-09
00:13:52 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Use cliff formattable columns in network commands https://review.opendev.org/657907
03:09:42 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Use cliff formattable columns in image commands https://review.opendev.org/657911
03:13:57 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Use cliff formattable columns in identity commands https://review.opendev.org/657912
11:09:34 openstackgerrit Stephen Finucane proposed openstack/cliff master: Stop wildcard importing argparse https://review.opendev.org/611889
11:09:35 openstackgerrit Stephen Finucane proposed openstack/cliff master: WIP: Add support for environment variables https://review.opendev.org/611890
11:26:29 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Use cliff formattable columns in identity commands https://review.opendev.org/657912
11:26:29 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Use cliff formattable columns in image commands https://review.opendev.org/657911
11:28:00 bjanssens Hello ppl, I'm trying to pass the OS_PROJECT_DOMAIN_NAME env to openstack.connect but it seems not to be passed through any pointers?
13:21:50 openstackgerrit Jeremy Houser proposed openstack/python-openstackclient master: Refactor test_snapshot.py and test_transfer_request.py https://review.opendev.org/655554
14:03:49 mordred bjanssens: hi! do you also have a clouds.yaml file with clouds defined?
14:04:10 mordred poo. bjanssens left before I finished typing
14:13:49 openstackgerrit Jeremy Houser proposed openstack/python-openstackclient master: Refactor test_snapshot.py and test_transfer_request.py https://review.opendev.org/655554

Earlier   Later