Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2019-03-01
13:43:32 gtema ahh, I haven't read it so far - still talking. But if you have suggestion how to bypass this crap of not being able to properly delete zone for new test - you are welcome
14:22:12 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Get rid of setUpClass and block it for forever https://review.openstack.org/640379
14:23:17 mordred Shrews, gtema, dtantsur: I decided review comments of "don't use setUpClass" were a thing that can totally be a local hacking check, rather than just a human review comment. possibly too much of a rabbithole for the morning, but there it is
14:23:49 dtantsur well, why not? :)
14:26:37 dtantsur mordred: :) a reference to crying pandas is convincing enough, but I wonder if we should add a bit more details to HACKING.rst
14:26:47 mordred dtantsur: fair
14:27:07 mordred dtantsur: I suppose some people want ACTUAL INFORMATION
14:27:34 dtantsur wait, WUT??
14:37:12 Shrews how is making baby pandas cry NOT enough info????
14:40:44 dtantsur I've heard about heartless people out there
14:46:46 gtema so, I'm now finally back.
14:58:10 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Add DNS support https://review.openstack.org/623009
15:01:57 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Add DNS support https://review.openstack.org/623009
15:03:48 gtema mordred, dtantsur: what do you think about https://review.openstack.org/#/c/638731/ in general? There is still some issue with broken ansible tests, which I can't figure out yet.
15:13:35 gtema Shrews: ^^
15:44:51 Shrews gtema: will take a look shortly
15:45:38 gtema oki, thanks
16:29:23 openstackgerrit Morgan Fainberg proposed openstack/openstacksdk master: Replace TaskManager with a keystoneauth concurrency https://review.openstack.org/604926
16:40:18 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Get rid of setUpClass and block it for forever https://review.openstack.org/640379
16:44:16 openstackgerrit Doug Wiegley proposed openstack/python-openstackclient master: Add 'security_group' type support to network rbac commands https://review.openstack.org/636760
17:05:27 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Add DNS support https://review.openstack.org/623009
18:36:51 openstackgerrit Merged openstack/openstacksdk master: Add image tasks schema methods https://review.openstack.org/639332
18:46:38 mordred needscoffee: probably want to update the depends-on in the task manager patch to https://review.openstack.org/#/c/640389/ (the ksa constraints patch)
19:22:15 needscoffee mordred: ahh fair enough.
19:22:57 openstackgerrit Morgan Fainberg proposed openstack/openstacksdk master: Replace TaskManager with a keystoneauth concurrency https://review.openstack.org/604926
19:23:27 needscoffee mordred: but also YAY the rate limiting patch landed in KSA.
20:18:05 mordred needscoffee: IKR???
22:16:32 openstackgerrit Merged openstack/keystoneauth master: Drop py35 jobs https://review.openstack.org/639915
22:38:37 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Replace TaskManager with a keystoneauth concurrency https://review.openstack.org/604926
22:39:29 mordred needscoffee: ^^ updated ... we'd added in a couple of calls to task_manager.stop() since we wrote the patch that weren't covered in the rebase (cause new)
22:39:50 mordred those are just causing exceptions, because there is no object to call stop on
22:39:57 mordred so I removed them
22:40:03 mordred fingers crossed for this time
23:14:07 needscoffee mordred: ah yeah
23:14:10 needscoffee mordred: that makes sense
23:16:27 needscoffee mordred: thankfully that becomes a non-issue (no more of it) soon.
23:22:02 mordred ++
23:25:48 needscoffee i really hope it passes so we can get that in and stop playing the "this might need more love" game.
#openstack-sdks - 2019-03-02
00:04:22 openstackgerrit Merged openstack/keystoneauth master: add python 3.7 unit test job https://review.openstack.org/610685
02:06:47 openstackgerrit Morgan Fainberg proposed openstack/openstacksdk master: Replace TaskManager with a keystoneauth concurrency https://review.openstack.org/604926
02:07:07 needscoffee mordred: ^ needs lower-constraints update.
02:07:16 needscoffee mordred: but otherwise should pass this time, should be good to remove -2 on it
08:04:58 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Replace TaskManager with a keystoneauth concurrency https://review.openstack.org/604926
08:10:11 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Add DNS support https://review.openstack.org/623009
15:26:28 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Replace TaskManager with a keystoneauth concurrency https://review.openstack.org/604926
15:28:25 mordred needscoffee: ^^ nodepool imports openstack.task_manager, so that patch restores the file even though sdk doesn't use it so that we can unwind it out of nodepool
15:28:54 needscoffee Aha
15:29:09 needscoffee Good stuff
15:31:02 needscoffee So if zuul passes it, I think it is ready to land.
15:31:16 needscoffee Woo, nice to see this moving.
15:44:13 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Move pep8 requirements in to test-requirements https://review.openstack.org/640597
15:44:34 mordred needssleep: srrsly
15:52:31 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Collect request stats https://review.openstack.org/614834
15:52:50 mordred needssleep: there's the followup for the other thing we'll need to get in for feature parity
15:58:41 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Don't try to upload to images in saving or queued state https://review.openstack.org/624188
#openstack-sdks - 2019-03-03
13:27:49 mordred Shrews: ZOMG! https://review.openstack.org/#/c/604926/ is green!
13:27:50 mordred kmalloc: ^^
14:21:38 kmalloc Yeah
14:23:50 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Collect request stats https://review.openstack.org/614834
18:11:34 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Collect request stats https://review.openstack.org/614834
#openstack-sdks - 2019-03-04
06:35:31 openstackgerrit Niraj Singh proposed openstack/openstacksdk master: Add support to get progress details of notification https://review.openstack.org/640673
12:11:41 openstackgerrit Merged openstack/os-service-types master: Update home-page https://review.openstack.org/630075
14:54:54 Shrews mordred: wow. neat. +2
14:57:22 mordred Shrews: ikr?
14:58:43 Shrews mordred: does that mean we need to change nodepool to always pass the rate down?
14:59:03 mordred Shrews: yeah - I've got a nodepool patch up ...
14:59:04 Shrews and remove its own task manager, obviously
14:59:10 Shrews oh
14:59:15 mordred Shrews: https://review.openstack.org/#/c/640643/
15:07:56 Shrews mordred: imma fix up those errors real quick for ya...
15:08:16 mordred Shrews: oh - I've got em fixed locally
15:08:26 Shrews ok
15:08:33 mordred Shrews: want me to go ahead and push them up?
15:08:39 Shrews sure
15:09:01 Shrews if'ns you'ns wanna
15:10:49 Shrews mordred: you missed the 'import os' in provider.py
15:11:25 mordred poop
16:30:24 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Make tox tips job actually run sdk tests https://review.openstack.org/640804
17:09:36 mordred Shrews, dtantsur: ^^ if you get a sec - the openstacksdk jobs we run on keystoneauth changes have just been running keystoneauth tests
17:09:49 dtantsur heh
17:57:59 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: Add "name" filter in "list" call when retrieving a single register https://review.openstack.org/637238
18:31:26 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Move pep8 requirements in to test-requirements https://review.openstack.org/640597
18:53:38 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Clarify error if no version can be found https://review.openstack.org/640835
18:57:11 mordred dtantsur|afk: ^^ that's a followup based on your review
20:26:20 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Move pep8 requirements in to test-requirements https://review.openstack.org/640597
21:13:21 openstackgerrit Merged openstack/openstacksdk master: Make tox tips job actually run sdk tests https://review.openstack.org/640804
21:19:10 mordred \o/
21:19:24 mordred kmalloc: ^^ you migth find that patch that just landed amusing
21:19:52 mordred kmalloc: for some value of amusing
21:23:09 tosky mordred: talking about amusing things... do you remember our old discussion about openstacksdk and its lack of branches which makes the openstack-check-plugins jobs fail on older branches?
21:23:12 kmalloc hahaha
21:23:20 kmalloc oh man really?
21:23:35 kmalloc well then...
21:24:55 mordred tosky: uhm ... let's go with "yes" but also maybe it would be fun to rehash the problem as-if I didn't remember because I'm old and addled
21:25:08 mordred (although openstacksdk does have branches)
21:25:51 tosky uh
21:26:28 tosky let me find again which unbranches repository prevented those jobs from working
21:26:32 mordred http://git.openstack.org/cgit/openstack/openstacksdk/log/?h=stable/rocky
21:26:35 mordred probably shade?
21:26:49 mordred oh!

Earlier   Later