Posted	Nick	Remark
#openstack-sdks - 2019-01-31
18:07:46	openstackgerrit	Michael Johnson proposed openstack/openstacksdk master: Added Octavia load balancer and listener stats https://review.openstack.org/633856
19:47:30	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Fix resource deletion in clustering https://review.openstack.org/631362
22:03:26	openstackgerrit	Duc Truong proposed openstack/openstacksdk master: Fix resource deletion in clustering https://review.openstack.org/631362
22:08:05	openstackgerrit	Duc Truong proposed openstack/openstacksdk master: Fix resource deletion in clustering https://review.openstack.org/631362
#openstack-sdks - 2019-02-01
03:43:52	openstackgerrit	Merged openstack/openstacksdk master: fix typo https://review.openstack.org/633989
04:11:20	openstackgerrit	Merged openstack/openstacksdk master: use overriden base_path in remaining CRUD operations https://review.openstack.org/632757
15:05:01	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Fix resource deletion in clustering https://review.openstack.org/631362
15:54:42	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Fix resource deletion in clustering https://review.openstack.org/631362
15:54:57	mordred	Shrews: sorry - realized that change warranted a release note ^^
17:57:57	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Fix resource deletion in clustering https://review.openstack.org/631362
17:58:24	mordred	Shrews: and again - adding the exception handling means it's important to actually import the exceptions module
17:59:39	openstackgerrit	Michael Johnson proposed openstack/openstacksdk master: Add Octavia (load_balancer) load balancer failover https://review.openstack.org/634010
18:04:44	openstackgerrit	Michael Johnson proposed openstack/openstacksdk master: Add Octavia (load_balancer) load balancer failover https://review.openstack.org/634010
18:11:59	openstackgerrit	Michael Johnson proposed openstack/openstacksdk master: Add Octavia (load_balancer) load balancer failover https://review.openstack.org/634010
18:34:12	openstackgerrit	Michael Johnson proposed openstack/openstacksdk master: Add Octavia (load_balancer) load balancer failover https://review.openstack.org/634010
20:16:53	openstackgerrit	Michael Johnson proposed openstack/openstacksdk master: Add Octavia (load_balancer) load balancer failover https://review.openstack.org/634010
20:39:06	openstackgerrit	Michael Johnson proposed openstack/openstacksdk master: Add Octavia (load_balancer) provider API support https://review.openstack.org/634488
21:00:54	openstackgerrit	Merged openstack/openstacksdk master: Fix resource deletion in clustering https://review.openstack.org/631362
22:34:48	openstackgerrit	Michael Johnson proposed openstack/openstacksdk master: Add Octavia (load_balancer) provider API support https://review.openstack.org/634488
23:47:11	openstackgerrit	Michael Johnson proposed openstack/openstacksdk master: Add Octavia (load_balancer) flavor profile API https://review.openstack.org/634518
#openstack-sdks - 2019-02-02
00:42:10	openstackgerrit	Michael Johnson proposed openstack/openstacksdk master: Add Octavia (load_balancer) flavor API https://review.openstack.org/634532
03:12:51	openstackgerrit	Michael Johnson proposed openstack/openstacksdk master: Add Octavia (load_balancer) amphora API https://review.openstack.org/634538
13:38:07	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Add support for bodyless commits https://review.openstack.org/634558
13:38:29	mordred	johnsom: ^^ added a commit on to the end of your stack inspired by it - let me know what you think
13:38:40	mordred	johnsom: also, left a comment on one of them about attribute naming
15:32:22	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Make all resource locations process project_id https://review.openstack.org/634572
15:32:23	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Stop mocking method in fwaas test https://review.openstack.org/634574
15:32:23	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Rename compute.service.zone to availability_zone https://review.openstack.org/634573
18:18:51	johnsom	Cool, thanks!
18:42:35	openstackgerrit	Michael Johnson proposed openstack/openstacksdk master: Add Octavia (load_balancer) flavor API https://review.openstack.org/634532
18:43:52	openstackgerrit	Michael Johnson proposed openstack/openstacksdk master: Add Octavia (load_balancer) amphora API https://review.openstack.org/634538
18:44:02	openstackgerrit	Michael Johnson proposed openstack/openstacksdk master: Add Octavia (load_balancer) amphora API https://review.openstack.org/634538
18:51:08	openstackgerrit	Michael Johnson proposed openstack/openstacksdk master: Add support for bodyless commits https://review.openstack.org/634558
#openstack-sdks - 2019-02-03
16:08:35	openstackgerrit	Merged openstack/openstacksdk master: Adds tags support for Octavia (load_balancer) https://review.openstack.org/633849
16:21:29	openstackgerrit	Merged openstack/openstacksdk master: Added Octavia load balancer and listener stats https://review.openstack.org/633856
22:03:51	openstackgerrit	Yuval Shalev proposed openstack/openstacksdk master: Added server diagnostics https://review.openstack.org/634618
#openstack-sdks - 2019-02-04
13:42:13	openstackgerrit	Yuval Shalev proposed openstack/openstacksdk master: Added server diagnostics https://review.openstack.org/634618
14:29:27	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Don't try to upload to images in saving or queued state https://review.openstack.org/624188
16:31:46	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient master: Fix --limit option in image list sub-command https://review.openstack.org/617139
18:50:56	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient master: More state handling in volume transfer requests functional tests https://review.openstack.org/634776
18:52:18	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient master: Fix --limit option in image list sub-command https://review.openstack.org/617139
18:54:14	openstackgerrit	Dean Troyer proposed openstack/osc-lib master: Allow use of user-id as well as username for authentication https://review.openstack.org/633964
20:28:48	openstackgerrit	Yuval Shalev proposed openstack/openstacksdk master: Added server diagnostics https://review.openstack.org/634618
21:23:10	openstackgerrit	Vlad Gusev proposed openstack/python-openstackclient master: Add support for get details of Quota https://review.openstack.org/515401
22:10:16	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient master: More state handling in volume transfer requests functional tests https://review.openstack.org/634776
#openstack-sdks - 2019-02-05
02:03:15	openstackgerrit	Kailun Qin proposed openstack/python-openstackclient master: Add network segment range command object https://review.openstack.org/625544
02:20:32	openstackgerrit	Kailun Qin proposed openstack/python-openstackclient master: Add network segment range command object https://review.openstack.org/625544
07:04:31	openstackgerrit	Vlad Gusev proposed openstack/python-openstackclient master: Add support for get details of Quota https://review.openstack.org/515401
10:01:20	gtema	mordred, are you here?
11:50:57	openstackgerrit	Vlad Gusev proposed openstack/python-openstackclient master: Add support for get details of Quota https://review.openstack.org/515401
11:55:23	openstackgerrit	Vlad Gusev proposed openstack/python-openstackclient master: Add support for get details of Quota https://review.openstack.org/515401
14:27:28	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient master: More state handling in volume transfer requests functional tests https://review.openstack.org/634776
15:11:53	mordred	gtema: morning
15:18:37	openstackgerrit	Merged openstack/openstacksdk master: Added server diagnostics https://review.openstack.org/634618
15:29:41	gtema	oh, hi mordred. I was going through the load-balancer series of changes for review and found, that in each a QueryParameter are used not in the way how I understand it
15:30:04	gtema	mordred: but you approved them, so I wonder whether something has changed in the meanwhile
15:31:18	gtema	mordred: they somehow use QueryParameters as if a list of returned parameters was expected. But octavia do this only if you specify column=col_a,col_b,etc
15:38:34	mordred	gtema: oh - it's entirely possible I just totally missed that - let me go re-look
15:39:13	gtema	i just posted -1 on couple of them, but they all have same issue
15:42:10	mordred	gtema: "The Octavia API v2 supports filtering based on all top level attributes of a resource. Filters are applicable to all list requests." - doesn't that mean that, for instance, on https://review.openstack.org/#/c/634518/1/openstack/load_balancer/v2/flavor_profile.py provider_name and flavor_data are both possible url filter criteria?
15:42:25	mordred	(although I canot imagine how someone would choose to filter on flavor_data)
15:42:56	gtema	that is exactly the point
15:43:43	gtema	but ok, if this is really what is meant here - then ok
15:44:08	mordred	I mean - I could see leaving flavor_data off because how would that work - but provider_name seems totally reasonable, yeah?
15:44:42	gtema	agree
15:45:28	johnsom	flavor_data is technically a string, so *maybe*?
15:45:52	mordred	johnsom: yeah. I mean - it would *physically* work :)
15:47:52	mordred	johnsom: dare I ask why flavor_data is a json string and not just a dict?
15:47:58	gtema	anyway - removing my "-1". Sorry and thanks for clarification
15:48:24	mordred	gtema: thanks for reviewing deeply!
15:48:25	gtema	because it is stated in docs: flavor_databodystringThe JSON string containing the flavor metadata.
15:48:35	johnsom	It's a string we share with third party drivers, so wanted to make it as neutral as possible.
15:48:48	gtema	mordred: welcome
15:49:46	johnsom	Basically the whole path for that string is json, including the schema validation, so it seemed silly to keep flipping back and forth with it.
15:50:04	johnsom	Plus it makes the CLI super easy
15:53:28	gtema	mordred: seen some changes with hints to upcoming R1.0. Any concrete plans on that?
15:58:34	mordred	gtema: I think there's three things I'd like to see done first ...
15:58:40	mordred	gtema: https://review.openstack.org/#/c/604926/ - remove task manager
15:59:05	mordred	gtema: https://review.openstack.org/#/c/630912/ align shade/sdk server objects and use server in shade layer
15:59:45	mordred	gtema: https://review.openstack.org/#/c/609684/ - same thing with image
16:00:28	mordred	(mostly because at least for image, I'm 100% certain it's going to break the existing image api in the sdk layer - even though I'm also 100% sure that api isn't terribly usable right now)
16:00:46	mordred	I think most of the rest of the objects are actually in pretty good shape
16:00:47	gtema	ok. Bad question: any "estimation timeline"?
16:00:50	mordred	hehe
16:01:24	mordred	I don't think those are too far off - the hardest one is finishing landing the semaphore patch to ksa
16:01:38	mordred	so "soon"? :)
16:01:45	gtema	agree, looks "stalled"
16:02:38	mordred	yah - I keep meaning to poke kmalloc in the face to see if we can do the final push and get it in there
16:02:43	gtema	ok. I wanted to probably bring DNS in time and potentially add "create container from directory" for object
16:03:02	kmalloc	the fair semaphore?
16:03:04	mordred	++
16:03:21	kmalloc	because i think we just need to have a real functional test for it.
16:03:23	mordred	kmalloc: yah. you went and took vacation, which is totally my excuse for that patch
16:03:25	kmalloc	otherwise it's ready
16:03:39	kmalloc	the few -1 nits can be cleaned up after.
16:04:35	kmalloc	i can try an spin up a test for it, but i admit i'm a bit out of my element for that (mostly because my brain is still recovering from vacation, almost all caught up finally)
16:04:35	mordred	gtema: oh - we should do the same thing for object as those patches for server and image - we've got comprehensive object upload support in the shade layer, including handling SLO/DLO for large objects
16:04:53	kmalloc	it's amazing how much time a vacation takes to fully recover from :P
16:04:58	mordred	kmalloc: yeah - I think we each have almost half of the story going on
16:05:03	gtema	mordred: oh, yeah

Earlier   Later