| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-10-18 | |||
| 16:00:17 | edleafe | The API-SIG Office Hour has officially started | |
| 16:00:25 | edleafe | (please hold your applause) | |
| 16:34:37 | elmiko | XD | |
| 17:35:55 | eandersson | Awesome thanks mordred | |
| 18:06:24 | mordred | kmalloc, lbragstad: either of you have a sec to look at https://review.openstack.org/#/c/609604 ? | |
| 18:06:57 | lbragstad | mordred oh - yes... i need to look at that anyway | |
| 18:07:00 | mordred | mostly - thepatch looks reasonable, but I don't know much about that api | |
| 18:07:13 | mordred | same with https://review.openstack.org/#/c/609572/ | |
| 18:07:50 | mordred | also - what the heck is a region_id? | |
| 18:08:10 | mordred | I don't want to know do I? | |
| 18:12:11 | lbragstad | mordred what questions do you have about that API? | |
| 18:13:44 | mordred | lbragstad: just - do those patches look right? | |
| 18:13:48 | mordred | in terms of exposing it? | |
| 18:21:00 | openstackgerrit | Merged openstack-infra/shade master: Support v4-fixed-ip and v6-fixed-ip in create_server https://review.openstack.org/611651 | |
| 18:49:55 | lbragstad | mordred sorry about that - apparently my network connection dies when i disconnect from power | |
| 18:51:09 | mordred | lbragstad: silly you | |
| 18:51:21 | mordred | lbragstad: have you considered not ever disconnecting from power? | |
| 18:51:58 | lbragstad | i am no | |
| 18:51:59 | lbragstad | now* | |
| 18:53:05 | lbragstad | mordred i might have to verify those patches manually | |
| 18:53:11 | lbragstad | but they do look correct | |
| 18:53:48 | mordred | lbragstad: I'm probably good with them looking correct for now - the interface seems reasonable enough | |
| 18:54:00 | lbragstad | one thing to note | |
| 18:54:09 | lbragstad | those APIs in keystone are still marked as experimental | |
| 18:54:22 | lbragstad | (the limits and registered limits APIs) | |
| 18:55:30 | lbragstad | i'm not sure if that impacts merging things to sdk | |
| 18:55:51 | lbragstad | fwiw - we have implemented support in python-keystoneclient and python-openstackclient | |
| 19:01:00 | kmalloc | mordred: on my list post lunch. | |
| 19:02:11 | lbragstad | mordred is there a doc for using sdk against a devstack? | |
| 19:02:39 | mordred | lbragstad: if you have a devstack, the stack user will already have a clouds.yaml - I think it defines two clouds, 'devstack' and 'devstack-admin' | |
| 19:02:55 | mordred | lbragstad: so you can just do "import openstack ; conn = openstack.connect(cloud='devstack')" | |
| 19:03:02 | lbragstad | huh | |
| 19:03:07 | lbragstad | badass | |
| 19:03:39 | mordred | lbragstad: then that limits api should be at conn.identity - so like "conn.identity.create_registered_limit()" | |
| 19:03:48 | lbragstad | nice | |
| 19:03:51 | mordred | in theory | |
| 19:04:10 | mordred | I just use vexxhost as my devstack - because mnaser is awesome | |
| 19:04:19 | lbragstad | :) | |
| 19:04:43 | lbragstad | very few things are better than dogfood | |
| 19:05:29 | mnaser | mordred: lbragstad <3 | |
| 19:05:54 | lbragstad | maybe brisket | |
| 19:06:15 | mordred | I recommend steaks cut from the chuck flap | |
| 19:06:17 | mordred | mmm | |
| 20:19:37 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use sdk for list_servers https://review.openstack.org/530770 | |
| 20:19:37 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add all_projects as a preferred alias for all_tenants https://review.openstack.org/540390 | |
| 20:19:38 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix get_server to work with use_direct_get https://review.openstack.org/540389 | |
| 21:59:10 | openstackgerrit | Merged openstack/openstacksdk master: Support v4-fixed-ip and v6-fixed-ip in create_server https://review.openstack.org/611652 | |
| 23:20:53 | openstackgerrit | Robin Cernin proposed openstack/python-openstackclient master: Improve document 'openstack complete' https://review.openstack.org/611469 | |
| #openstack-sdks - 2018-10-19 | |||
| 00:44:30 | openstackgerrit | Merged openstack/keystoneauth master: Update sphinx extension logging https://review.openstack.org/611135 | |
| 06:59:42 | openstackgerrit | Vishakha Agarwal proposed openstack/python-openstackclient master: Add project param in LimitList parser https://review.openstack.org/611789 | |
| 09:49:14 | openstackgerrit | Vlad Gusev proposed openstack/python-openstackclient master: Add support for get details of Quota https://review.openstack.org/515401 | |
| 10:37:04 | openstackgerrit | Vishakha Agarwal proposed openstack/python-openstackclient master: Add project param in LimitList parser https://review.openstack.org/611789 | |
| 10:44:57 | dtantsur | mordred: hey, you need to re-add your +W to https://review.openstack.org/#/c/609984/ now that the dependency has merged | |
| 10:47:43 | openstackgerrit | Vlad Gusev proposed openstack/python-openstackclient master: Add support for get details of Quota https://review.openstack.org/515401 | |
| 11:38:15 | openstackgerrit | Vlad Gusev proposed openstack/python-openstackclient master: Add support for get details of Quota https://review.openstack.org/515401 | |
| 12:24:40 | mordred | dtantsur: done | |
| 12:25:15 | dtantsur | thnx | |
| 12:46:32 | mordred | dtantsur, Shrews, dtroyer, slaweq: I pushed up a release request for sdk for an 0.18.0 - I'm thinking it's *basically* an RC, but I was thinking that it would be a good idea to start making some python-openstackclient patches to start using it more there - so we can see what shakes out of that. I also think we should figure out the baremetal resource normalization question and finish those image api | |
| 12:46:34 | mordred | patches | |
| 12:46:58 | dtantsur | yep, cool | |
| 12:47:14 | dtantsur | I think we'll need more deprecation for baremetal stuff in the shade part.. but we can left removals for 2.0 | |
| 12:47:23 | mordred | but I'm figuring we can use writing osc patches to use sdk for images instead of python-glanceclient to spur finishing the image api stuff | |
| 12:47:39 | mordred | dtantsur: ++ | |
| 12:48:46 | mordred | frickler: if you're around, would you mind +Aing https://review.openstack.org/#/c/585030/ ? | |
| 12:49:12 | dtantsur | mordred: oh, and we need to finish the story around rate limiting | |
| 12:49:14 | mordred | oh - actually - hang on, let me bump mins in that | |
| 12:49:23 | mordred | dtantsur: yes. thanks - that's the other thing we should finish | |
| 12:50:20 | mordred | we should chat with cmurphy about whether the keystoneauth retries feature justifies putting the rate limiting down in keystoneauth | |
| 12:51:58 | cmurphy | ah hmm that is a somewhat compelling case | |
| 12:52:18 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Make use of keystoneauth service-type filtering for versions https://review.openstack.org/585030 | |
| 12:53:24 | mordred | cmurphy: yah - I wrote more words on that review - but dtantsur had a patch to sdk to make use of the retriable_status_codes feature - and that made me realize that if ksa is doing retries under the covers, it makes higher-level rate limiting have a hole where it doesn't know about some of the interactions | |
| 12:53:43 | cmurphy | yeah that makes sense | |
| 12:54:22 | frickler | mordred: that patch seems to have a merge conflict now that you updated it | |
| 12:54:26 | mordred | that said - there's still a potential slight weirdness, as retries are implemented in the session, while a rate limit is really an adapter-level concept (so that it can be per-service) | |
| 12:54:28 | mordred | frickler: *awesome* | |
| 12:54:30 | mordred | lemme fix | |
| 12:55:47 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Make use of keystoneauth service-type filtering for versions https://review.openstack.org/585030 | |
| 12:55:51 | mordred | frickler: that should do it :) | |
| 12:57:52 | mordred | cmurphy: so I guess the important next step for that patch would be "write tests"? | |
| 12:58:51 | cmurphy | mordred: I'm kind of hoping there is a non-DIY way of implementing the semaphore thing | |
| 12:59:12 | cmurphy | mordred: but assuming there's not then tests would be a good next step | |
| 12:59:22 | mordred | cmurphy: I didn't find one when I was looking - although I totally agree with you | |
| 12:59:29 | mordred | I'm a bit sad there isn't one of these in the standard lib | |
| 12:59:44 | frickler | mordred: oh, that's osc, I can only +1 there anyway, but lgtm | |
| 13:00:01 | mordred | frickler: awesome, thanks! | |
| 13:00:24 | mordred | cmurphy: maybe we should upstream this one to the python stdlib once we're happy with it. I'm sure that'll only take 8 years or something | |
| 13:00:44 | cmurphy | :D | |
| 13:00:53 | dtantsur | heh | |
| 13:00:58 | dtantsur | Python 4.2 | |
| 13:01:06 | cmurphy | lol | |
| 13:12:52 | samueldmq | morning sdk | |
| 13:15:50 | mordred | morning samueldmq ! | |
| 13:25:17 | openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/openstacksdk master: DNM: Logging image code path https://review.openstack.org/611868 | |
| 13:29:33 | openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/openstacksdk master: DNM: Logging public server code path https://review.openstack.org/611869 | |
| 14:15:41 | openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add support for client-side rate limiting https://review.openstack.org/605043 | |
| 14:18:19 | mordred | dtantsur: ^^ I reworked it a bit based on your review and put the rate limit wait into the semaphore itself | |
| 14:18:33 | mordred | dtantsur: I tried to add some comments - but it's still a pretty dense class | |
| 14:18:41 | dtantsur | cool, will check | |
| 14:19:34 | mordred | kmalloc, cmurphy: ^^ also y'all. of course, it can't land without tests - so I still have to figure that out - but if you feel like attacking it logically, awesome | |
| 14:25:43 | dtantsur | mordred: I have a feeling there is a deadlock lurking there | |