| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-10-11 | |||
| 09:22:46 | openstackgerrit | wangxiyuan proposed openstack/openstacksdk master: Add registered limit CRUD support https://review.openstack.org/609572 | |
| 09:22:47 | openstackgerrit | wangxiyuan proposed openstack/openstacksdk master: Add limit CRUD support https://review.openstack.org/609604 | |
| 12:15:17 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rearrange shade image code https://review.openstack.org/609683 | |
| 12:15:18 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: WIP Move image methods to sdk image proxy https://review.openstack.org/609684 | |
| 12:16:08 | mordred | samueldmq, dtantsur|brb: ^^ that last patch is definitely non-functional - but I wanted to push it up to see what you thought about the general idea | |
| 12:54:54 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rearrange shade image code https://review.openstack.org/609683 | |
| 12:55:43 | samueldmq | mordred: I like it | |
| 12:56:55 | samueldmq | mordred: the code in opesntackcloud will be much cleaner, and if you want to look at the specific craziness for each operation/version go to look at the proxies | |
| 12:57:41 | samueldmq | mordred: I was afraid we'd be creating a lot of files just for a little amount of code. multiple _proxy files... but the proxy files already exist today anyways | |
| 12:59:00 | mordred | samueldmq: sweet - and yeah, they're already there ... hopefully this can make people less afraid of the size of that openstackcloud file :) | |
| 13:00:00 | samueldmq | mordred: exactly, only the function contracts will be kept there | |
| 13:01:26 | samueldmq | 12.5k loc in a single file is not human-friendly | |
| 13:02:15 | mordred | samueldmq: it does make it easy to search for something from inside vim :) | |
| 13:02:20 | samueldmq | that overflows my brain several times when I scroll it down | |
| 13:02:27 | samueldmq | mordred: ++ | |
| 13:10:05 | mordred | Shrews: I know you love waking up to huge patches from me | |
| 13:10:28 | mordred | Shrews: but also ... ^^ 609684- totally unfunctional - but you might have an opinion on the general idea | |
| 13:13:29 | Shrews | oh, i've got opinions for ya.... | |
| 13:16:12 | dtantsur | mordred: ack, I'll try to get to it soon-ish | |
| 13:17:04 | dtantsur | mordred and all: the bifrost job was fixed, feel free to recheck things | |
| 13:18:42 | mordred | woot! | |
| 13:41:20 | ml | openstackcloud raises Exception from openstack.cloud.exc, it doesn't use anything from openstack.exception. | |
| 13:41:38 | ml | Why is that? | |
| 13:44:12 | mordred | ml: it's just historical - we haven't finished merging all the things yet | |
| 13:45:17 | mordred | ml: geting the openstackcloud code to raise exceptions from openstack.exception instead would be great | |
| 13:46:10 | ml | Can I start using them in my change already? or is it desired to be handled as one change? | |
| 13:48:23 | ml | probably a bad idea to keep both imports at the same time, because one can't import it as "exc" | |
| 13:50:31 | mordred | ml: we could just import it as exceptions ... I think either way you want to go is fine | |
| 13:50:44 | ml | ok, cool | |
| 14:06:59 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rearrange shade image code https://review.openstack.org/609683 | |
| 14:07:00 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: WIP Move image methods to sdk image proxy https://review.openstack.org/609684 | |
| 14:25:28 | dtantsur | mordred: is it okay that we ignore the error_message argument in https://github.com/openstack/openstacksdk/blob/master/openstack/_adapter.py#L129 ? | |
| 14:26:06 | dtantsur | it's my third (?) attempt to understand error handling in https://review.openstack.org/#/c/604645/ and I'm still confused... | |
| 14:37:46 | openstackgerrit | Matthias Lisin proposed openstack/openstacksdk master: openstackcloud.py: Implement FWaaS wrapper methods. https://review.openstack.org/604811 | |
| 14:38:36 | mordred | dtantsur: probably not - and you're probably confused because it's probably broken | |
| 14:39:06 | mordred | dtantsur: lemme see if I can wrap my head around it | |
| 14:39:25 | dtantsur | cool. your head has much higher chances of figuring it out than mine :) | |
| 14:39:44 | Shrews | mordred: overall direction on 609684 looks pretty good to me. Maybe make BaseImageProxy abstract for clarity and to enforce _upload_image() is declared in other classes | |
| 14:40:32 | mordred | Shrews: yah - I tried that and hit "TypeError: metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases" | |
| 14:40:42 | Shrews | O.o | |
| 14:40:46 | mordred | Shrews: and at that point I just gav up and decided to farm goats | |
| 14:41:29 | Shrews | oh, maybe because it derives from Proxy | |
| 14:41:31 | Shrews | poo | |
| 14:42:07 | mordred | Shrews: although - I keep thinking that maybe that proxy metaclass is a bad idea | |
| 14:44:45 | Shrews | mordred: you could make BaseImageProxy more of an interface (call it BaseImageInterface), and make v1._proxy.Proxy derive from that *and* proxy.Proxy | |
| 14:47:28 | Shrews | there are other ways around it, but I'm meh about it | |
| 14:51:33 | dtantsur | we need some metaclasses for metaclasses | |
| 15:12:31 | smcginnis | dtantsur: Wouldn't that be metametaclasses? | |
| 15:12:42 | dtantsur | awesome, yeah? | |
| 15:41:02 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: WIP Move image methods to sdk image proxy https://review.openstack.org/609684 | |
| 15:41:02 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rearrange shade image code https://review.openstack.org/609683 | |
| 15:41:03 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Revert the Proxy metaclass https://review.openstack.org/609747 | |
| 15:41:25 | mordred | Shrews, dtantsur: ^^ how bout them metaapples? | |
| 15:45:27 | dtantsur | heh | |
| 15:49:42 | mordred | dtantsur: maybe by then I will have figured out the error message scenario | |
| 16:00:41 | elmiko | api sig office hours, HOOOoooooo | |
| 16:00:57 | elmiko | lol, i need to screenshot that | |
| 16:00:58 | edleafe | Office hour for API-SIG starts now | |
| 16:01:13 | edleafe | Try not to flood the channel with all your inquiries | |
| 16:02:08 | elmiko | ++ | |
| 16:02:55 | edleafe | hey, pipe down, elmiko! | |
| 16:06:37 | mordred | edleafe: are we there yet? | |
| 16:07:09 | edleafe | mordred: I swear, if you don't settle down, I'm turning this car around and going back home!! | |
| 16:08:18 | mordred | edleafe: but but but | |
| 16:13:42 | elmiko | edleafe: lol | |
| 16:13:54 | elmiko | edleafe: are we there yet? | |
| 16:14:18 | edleafe | elmiko: I'm going to count to 3... | |
| 16:17:07 | mordred | edleafe: elmiko keeps hitting me! | |
| 16:18:02 | mordred | if people are bored in office hours and want to review some fairly insane python patches - I've got plenty I can point you at ... | |
| 16:18:55 | elmiko | best office hours ever! | |
| 17:02:58 | edleafe | Well, that was underwhelming. :) | |
| 17:29:18 | openstackgerrit | Merged openstack/openstacksdk master: Correct updating baremetal nodes by name or ID https://review.openstack.org/608674 | |
| 18:14:55 | elmiko | edleafe: lol | |
| 18:21:18 | openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Handle not having cinderclient.v1 available https://review.openstack.org/609473 | |
| 20:02:52 | openstackgerrit | Merged openstack/openstacksdk master: Use discovery instead of config to create proxies https://review.openstack.org/600292 | |
| 20:16:47 | openstackgerrit | Merged openstack/openstacksdk master: Remove api version default values https://review.openstack.org/600330 | |
| 21:02:50 | openstackgerrit | Sean McGinnis proposed openstack/python-openstackclient master: Handle not having cinderclient.v1 available https://review.openstack.org/609473 | |
| #openstack-sdks - 2018-10-12 | |||
| 03:09:39 | openstackgerrit | Yang JianFeng proposed openstack/openstacksdk master: Add support for octavia's resuorces quota https://review.openstack.org/590193 | |
| 07:53:00 | openstackgerrit | Merged openstack/openstacksdk master: Add functional tests for clustering https://review.openstack.org/607061 | |
| 09:50:26 | openstackgerrit | Vishakha Agarwal proposed openstack/python-openstackclient master: Modify the help message for 'registered limit set' https://review.openstack.org/609985 | |
| 11:32:24 | openstackgerrit | Matthias Lisin proposed openstack/openstacksdk master: openstackcloud.py: Implement FWaaS wrapper methods. https://review.openstack.org/604811 | |
| 12:51:20 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Switch bare metal NIC actions in OpenStackCloud to baremetal Proxy calls https://review.openstack.org/610024 | |
| 13:01:41 | dtantsur | Shrews: hi, if you have a minute: https://review.openstack.org/#/c/609399/ | |
| 13:16:12 | Shrews | dtantsur|afk: sure, will take a look in a little bit | |
| 13:43:02 | mordred | oh my god the discovery patch landed | |
| 13:46:14 | edleafe | mordred: ?? Which patch? | |
| 13:46:42 | mordred | edleafe: Merged openstack/openstacksdk master: Use discovery instead of config to create proxies https://review.openstack.org/600292 | |
| 13:46:53 | mordred | edleafe: sdk is now fully discovery driven | |
| 13:47:15 | mordred | with config values only used for override | |
| 13:47:47 | edleafe | mordred: ah. For a second there, I thought you were referring to https://review.openstack.org/459405 | |
| 13:48:02 | mordred | edleafe: bah. like we'll ever finish that. it's too hard :) | |
| 13:48:43 | edleafe | nah, we have dtantsur|afk on it. | |
| 13:49:21 | mordred | good point | |
| 13:49:31 | Shrews | mordred: good grief. i +A'd that DAYS ago | |
| 13:49:33 | mordred | mnaser: do you know who a good person is to ping about the broken magnum job for sdk? | |
| 13:49:39 | Shrews | i assumed it merged already | |
| 13:50:00 | mordred | Shrews: there was an oslo.messaging release which broke bifrost which broke the sdk bifrost gate | |
| 13:50:30 | Shrews | see... this is why we should test in a silo | |
| 13:50:33 | mnaser | mordred: I think spyros (PTL) is usually pretty good about that stuff. I can’t recall his IRC nick off the top of my head | |
| 13:51:01 | mnaser | mordred: strigazi | |