Posted	Nick	Remark
#openstack-sdks - 2018-06-22
12:20:41	openstackgerrit	Jens Harbott (frickler) proposed openstack/python-openstackclient master: DNM: Test tips with python-cinderclient from git https://review.openstack.org/577404
12:24:10	frickler	dtroyer: found another small glitch, in my local testing I'm down to two failures in v3.test_volume_types now. hoping the second patch will show these
14:47:17	dtroyer	frickler: in https://review.openstack.org/#/c/577404/ depends-on is a URL not a commit-id, does that work? I don't think I've ever done it that way...
14:47:47	Shrews	dtroyer: yes, that's a new feature of zuulv3
14:47:54	dtroyer	nice
14:48:08	dtroyer	and rats, I was hoping that was why it wasn't behaving as expected :)
14:48:58	dtroyer	Shrews: now that my mental cache is warming up I'm beginning to recall that was to allow github urls?
14:49:09	Shrews	yeah
14:49:29	Shrews	dtroyer: https://zuul-ci.org/docs/zuul/user/gating.html#cross-project-dependencies
14:49:56	Shrews	note the "note" about deprecation
14:50:08	dtroyer	not only is it supported but change-id is deprecated…
14:50:10	dtroyer	jinz
14:50:13	dtroyer	jinx
14:50:20	dtroyer	damn, it's not even monday
14:50:30	dtroyer	thanks for the pointer
14:50:53	Shrews	np
15:05:47	openstackgerrit	Dean Troyer proposed openstack/python-openstackclient master: Fix volume type functional tests https://review.openstack.org/575448
18:35:38	openstackgerrit	Merged openstack/openstacksdk master: fix misspelling of 'server' https://review.openstack.org/577375
#openstack-sdks - 2018-06-23
13:33:43	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Add task manager parameter to Connection https://review.openstack.org/577616
15:52:45	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Switch to providing created_at field for servers https://review.openstack.org/577619
15:53:06	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Switch to providing created_at field for servers https://review.openstack.org/577619
22:22:15	openstackgerrit	Merged openstack/python-openstackclient master: Fix volume type functional tests https://review.openstack.org/575448
#openstack-sdks - 2018-06-24
00:26:58	openstackgerrit	Sami Makki proposed openstack/python-openstackclient master: Fix the `role implies list` command. https://review.openstack.org/557359
03:38:57	openstackgerrit	Merged openstack/python-openstackclient master: Fix the `role implies list` command. https://review.openstack.org/557359
03:46:00	openstackgerrit	Steve Martinelli proposed openstack/python-openstackclient master: Add --key-name option for server rebuild API. https://review.openstack.org/576422
03:47:23	openstackgerrit	Steve Martinelli proposed openstack/python-openstackclient master: Adding api_version to FakeApp https://review.openstack.org/576833
05:03:05	openstackgerrit	Merged openstack/python-openstackclient master: Fix subnet host_routes error https://review.openstack.org/540568
12:38:51	openstackgerrit	Monty Taylor proposed openstack-infra/shade master: Make OpenStackCloud a subclass of Connection https://review.openstack.org/577647
13:28:44	openstackgerrit	Merged openstack/python-openstackclient master: compute: limit the service's force down command above 2.10 https://review.openstack.org/576514
14:10:18	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Move clustering additions from shade directories https://review.openstack.org/577654
14:41:34	openstackgerrit	Merged openstack/openstacksdk master: Add testing of availability_zones() "details" argument https://review.openstack.org/575868
14:47:29	openstackgerrit	Merged openstack/openstacksdk master: Add hypervisor details to hypervisors list if requested https://review.openstack.org/575869
16:45:11	wacuuu	Hi. when i implement something new, it is on my side to provide proper ut right?
16:45:33	mordred	wacuuu: yes, that's right
16:46:41	mordred	wacuuu: it's preferrable to use requests-mock based unittests (you can see examples of them in the tree by looking for self.register_uris) - but a bunch of the tests for existing sdk functionality haven't been migrated to requests-mock yet
16:48:58	wacuuu	propably i misshear something on my question; crappy internet. so. my question is because of this https://storyboard.openstack.org/#!/story/2002563
16:49:26	wacuuu	i guess i should add ut case tha covers extra domain right?
16:50:24	mordred	wacuuu: yes - it would be preferred
16:50:30	wacuuu	ok, thanks
17:31:21	openstackgerrit	Monty Taylor proposed openstack-infra/shade master: Make OpenStackCloud a subclass of Connection https://review.openstack.org/577647
17:31:22	openstackgerrit	Monty Taylor proposed openstack-infra/shade master: Convert domain params tests to requests_mock https://review.openstack.org/577659
17:31:22	openstackgerrit	Monty Taylor proposed openstack-infra/shade master: Use RequestsMockTestCase everywhere https://review.openstack.org/577658
17:31:23	openstackgerrit	Monty Taylor proposed openstack-infra/shade master: Convert image_client mocks in test_shade_operator https://review.openstack.org/577661
17:31:23	openstackgerrit	Monty Taylor proposed openstack-infra/shade master: Convert test_caching to requests-mock https://review.openstack.org/577660
17:31:24	openstackgerrit	Monty Taylor proposed openstack-infra/shade master: Finish migrating image tests to requests-mock https://review.openstack.org/577662
18:45:12	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Move clustering additions from shade directories https://review.openstack.org/577654
18:45:13	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Convert test_caching to requests-mock https://review.openstack.org/577664
18:45:13	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Convert domain params tests to requests_mock https://review.openstack.org/577663
18:45:14	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Finish migrating image tests to requests-mock https://review.openstack.org/577666
18:45:14	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Convert image_client mocks in test_shade_operator https://review.openstack.org/577665
18:46:08	mordred	Shrews: ^^ if you get bored, those two stacks get rid of the last places where we were mocking clients rather than using requests-mock
21:33:30	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Move clustering additions from shade directories https://review.openstack.org/577654
21:42:27	openstackgerrit	Monty Taylor proposed openstack-infra/shade master: Make OpenStackCloud a subclass of Connection https://review.openstack.org/577647
21:42:27	openstackgerrit	Monty Taylor proposed openstack-infra/shade master: Finish migrating image tests to requests-mock https://review.openstack.org/577662
21:49:48	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Switch to providing created_at field for servers https://review.openstack.org/577619
22:20:58	openstackgerrit	Feilong Wang proposed openstack-infra/shade master: Add Magnum cluster support https://review.openstack.org/577673
23:06:08	openstackgerrit	Feilong Wang proposed openstack-infra/shade master: Add Magnum cluster support https://review.openstack.org/577673
#openstack-sdks - 2018-06-25
04:03:23	openstackgerrit	Feilong Wang proposed openstack-infra/shade master: Support Magnum /certificates API https://review.openstack.org/577720
09:48:54	openstackgerrit	tianhui proposed openstack/python-openstackclient master: Compute:Support keypair set key-type https://review.openstack.org/577768
13:19:30	Shrews	mordred: all of those seem to be failing tests
13:36:52	mordred	Shrews: and you don't think we should land failing tests?
13:39:21	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Move clustering additions from shade directories https://review.openstack.org/577654
13:39:45	mordred	Shrews: https://review.openstack.org/#/c/577662 through https://review.openstack.org/#/c/577658 are all green - hopefully that ^^ will also be green and if so I'll rebase the rest of the sdk version of the stack
13:58:23	Shrews	mordred: obviously *I* think we should land failing tests. would make things so much easier
13:58:45	mordred	Shrews: ++
13:59:13	Shrews	apparently i was only looking at the sdk results. landing the shade things now
14:00:09	mordred	Shrews: thanks! the last patch in the shade stack is expected to fail until we cut an sdk release containing https://review.openstack.org/#/c/577619/
14:00:25	mordred	Shrews: the tips jobs should show it'll work once that's released
14:01:05	Shrews	mordred: line 501 in https://review.openstack.org/#/c/577660/1/shade/tests/unit/test_caching.py seems to be the same as the line above it
14:01:47	mordred	Shrews: yes - it's calling it twice to show that the caching works- the REST calls for that are only in the register_uris once
14:02:00	Shrews	oh
14:02:22	Shrews	should have read the line below it
14:02:40	mordred	Shrews: bah. reading is for wimps
14:37:06	openstackgerrit	Merged openstack/openstacksdk master: Switch to providing created_at field for servers https://review.openstack.org/577619
15:01:47	dtantsur	mordred, TheJulia DriverNotFoundInEntrypoint: Could not find the following items in the 'ironic.drivers' entrypoint: agent_ilo, pxe_ilo
15:01:55	dtantsur	these are gone for real, yeah
15:02:08	dtantsur	hence the conductor fails to start, hence the 503 error
15:03:32	mordred	dtantsur: well, that does seem like a real error
15:04:03	dtantsur	mordred: yep, and it seems like bifrost still enables a bunch of drivers we're removing this week
15:04:18	dtantsur	I'll try to do something about it with my limited ansible skills....
15:04:42	mordred	dtantsur: does ironic not gate on bifrost I suppose?
15:04:58	dtantsur	mordred: nope. was on my radar, but never happened
15:06:08	mordred	gotcha. so it might be safer for us to turn it to non-voting for shade/sdk - since patches to ironic can break it?
15:08:28	openstackgerrit	Monty Taylor proposed openstack-infra/shade master: Switch bifrost jobs to nonvoting https://review.openstack.org/577846
15:08:34	mordred	Shrews: ^^ re: scrollback
15:09:36	Shrews	hrm, if ironic doesn't gate on it, yeah...
15:15:47	dtantsur	TheJulia: we should maybe add a bifrost job and revert ^^^
15:16:05	openstackgerrit	Merged openstack/python-openstackclient master: Network: Add tag support for security group https://review.openstack.org/547733
15:41:00	dtantsur	mordred, TheJulia, https://review.openstack.org/#/c/577848/ seems to pass the same set of jobs that used to pass before pxe_ilo removal
15:45:47	mordred	dtantsur: \o/
15:54:24	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Re-enable clustering functional tests https://review.openstack.org/577852
15:54:24	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Move clustering additions from shade directories https://review.openstack.org/577654
15:58:24	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Move clustering additions from shade directories https://review.openstack.org/577654
15:58:42	openstackgerrit	Monty Taylor proposed openstack/openstacksdk master: Re-enable clustering functional tests https://review.openstack.org/577852
16:47:10	openstackgerrit	Merged openstack-infra/shade master: Switch bifrost jobs to nonvoting https://review.openstack.org/577846
17:43:35	TheJulia	just now able to context switch over, but I concur
18:51:53	openstackgerrit	Merged openstack-infra/shade master: Use RequestsMockTestCase everywhere https://review.openstack.org/577658
18:52:28	openstackgerrit	Merged openstack-infra/shade master: Convert domain params tests to requests_mock https://review.openstack.org/577659
18:59:27	TheJulia	mordred: not a cat? :(
19:03:16	openstackgerrit	Merged openstack-infra/shade master: Convert test_caching to requests-mock https://review.openstack.org/577660

Earlier   Later