| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2018-05-04 | |||
| 14:29:42 | mordred | Shrews: ugh. probably. we should get the followup patch fixed | |
| 14:29:57 | pooja_jadhav | mordred: Hi | |
| 14:31:02 | mordred | Shrews: maybe we should try the fix patch instead of the revert | |
| 14:32:45 | Shrews | mordred: your patch can't work i think. there is no self.get_cache_expiration_time() | |
| 14:33:09 | Shrews | mordred: that's only in CloudRegion, which is why i asked how to get to that | |
| 14:34:42 | Shrews | as are the _cache_* attrs | |
| 14:35:09 | Shrews | oh, no | |
| 14:35:13 | Shrews | wrong about the attrs | |
| 14:35:24 | mordred | the patch adds get_cache_expiration_time | |
| 14:35:48 | Shrews | oh duh | |
| 14:36:10 | Shrews | *sigh | |
| 14:36:36 | Shrews | mordred: ok, let's just try your patch first | |
| 14:37:06 | mordred | Shrews: yah - this *is* accessing private members of the osdk base class ... so we'll need to add some tests to occ (which we were obviously missing anyway) to make sure those methods continue to work | |
| 14:37:25 | mordred | we run occ tests on sdk patches, so that should prevent sdk patches from changing those private members | |
| 14:37:37 | mordred | and yes, that's terrible software engineering practice in general | |
| 14:40:57 | openstackgerrit | Monty Taylor proposed openstack/os-client-config master: Revert "Replace guts with openstack.config" https://review.openstack.org/566328 | |
| 14:41:12 | mordred | Shrews: well, there's that (without merge conflict this time) in case we decide we want to go that route | |
| 14:46:08 | Shrews | mordred: i think the nodepool followup to use osdk is failing because osdk defines a get_cache_expirations() but shade is calling get_cache_expiration() | |
| 14:46:23 | Shrews | mordred: accidental pluralization there? | |
| 14:47:45 | Shrews | http://logs.openstack.org/58/566158/1/check/nodepool-functional-py35/45d52ed/controller/logs/screen-nodepool-builder.txt.gz#_May_04_05_56_28_537111 | |
| 14:48:13 | mordred | Shrews: crap | |
| 14:48:22 | mordred | Shrews: the plural/singular is intentional | |
| 14:48:24 | mordred | but | |
| 14:48:44 | mordred | not particularly awesome for this transition | |
| 14:51:32 | Shrews | so i think pushing your occ patch, given that ^ which would require a new osdk release, is probably the thing to do now? | |
| 14:51:46 | mordred | yah | |
| 14:51:59 | mordred | and I'll also work on a shade patch to use osdk for config directly | |
| 15:11:21 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Use openstack.config directly for config https://review.openstack.org/566340 | |
| 15:11:24 | mordred | Shrews: ^^ | |
| 15:55:14 | dmsimard | mordred: I got my thing to work. It's kinda dirty but I'll figure a better way later. | |
| 15:56:06 | mordred | dmsimard: ossum | |
| 15:56:28 | mordred | dmsimard: maybe at some point we should add a method to shade to be able to do the search you wanted to do | |
| 15:56:42 | mordred | dmsimard: since we also do it inside of shade - and there isn't a *good* way to do it otherwise | |
| 15:56:51 | dmsimard | mordred: in case you're curious: https://gist.github.com/dmsimard/6b21c9818878f8aacaf3ddaf63c669b3 | |
| 15:56:57 | dmsimard | brb | |
| 16:05:02 | mordred | dmsimard: fwiw - in your setup logging function - you don't need to go through yaml - you can just build that dict directly in python and pass it to dictConfig (what you're doing obviously works - and I kind of like it from a readability perspective, but thought I'd mention just in case) | |
| 16:05:45 | mordred | dmsimard: other than that - neat! | |
| 16:06:07 | openstackgerrit | Matt Smith (_alastor_) proposed openstack/openstacksdk master: Adding block_storage v3 API support https://review.openstack.org/566355 | |
| 16:07:31 | dmsimard | mordred: it's copy pasta from a boilerplate thing | |
| 16:08:15 | openstackgerrit | Matt Smith (_alastor_) proposed openstack/openstacksdk master: Adding block_storage v3 API support https://review.openstack.org/566355 | |
| 16:09:23 | mordred | dmsimard: ++ | |
| 16:18:08 | dmsimard | mordred: oh god, you can specify CIDRs in allowed_address_pairs and the mac address is optional T_T | |
| 16:18:14 | dmsimard | I was complicating my life for nothing | |
| 16:19:48 | mordred | dmsimard: \o/ | |
| 16:20:00 | openstackgerrit | David Moreau Simard proposed openstack-infra/shade master: Add a description field for port_create, port_update https://review.openstack.org/566359 | |
| 16:20:01 | dmsimard | I did find ^ though | |
| 16:20:04 | mordred | dmsimard: well - just think aboutall th ethings you learned | |
| 16:20:16 | dmsimard | mordred: I learn new things every day and it's awesome :D | |
| 16:30:03 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Use openstack.config directly for config https://review.openstack.org/566340 | |
| 16:30:12 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Use openstack.config directly for config https://review.openstack.org/566340 | |
| 16:59:08 | openstackgerrit | Merged openstack/os-client-config master: Add cache methods back to OpenSackConfig https://review.openstack.org/566322 | |
| 16:59:58 | Shrews | dmsimard: regarding my comment about a test for 566359, modifying existing tests should be ok too | |
| 17:00:26 | dmsimard | Shrews: ack | |
| 17:02:37 | openstackgerrit | Nobuto Murata proposed openstack/python-openstackclient master: Support --community in openstack image list https://review.openstack.org/565152 | |
| 17:17:14 | mordred | Shrews: remote: https://review.openstack.org/566368 Release 0.13.1 of os-client-config | |
| 17:31:45 | Shrews | mordred: what about https://review.openstack.org/566139 ? | |
| 17:32:56 | Shrews | i guess not as many people affected by that one | |
| 17:45:15 | mordred | Shrews: yah - and it's causing the tests to flap for a reason I can't figure out yet | |
| 17:45:54 | mordred | Shrews: I think it's interactions with globals across test cases - but I can't find which one | |
| 18:13:51 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Clean up floating ip tests https://review.openstack.org/566320 | |
| 18:14:13 | mordred | slaweq: ^^ that contains a fix related to the question I just asked in #openstack-neutron (the one where I flooded the channel) | |
| 18:14:40 | mordred | Shrews: ^^ that patch should hopefully make the sdk tests not quite so flappy/racey - and also fixes a bug | |
| 18:39:04 | mordred | Shrews: also, https://review.openstack.org/#/c/566340/ is ready for your scorn and derision | |
| 18:53:06 | openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add nodepool functional tests https://review.openstack.org/566388 | |
| 19:03:36 | openstackgerrit | Merged openstack/cliff master: exclude cmd2 0.8.3 and update to 0.8.4 https://review.openstack.org/560121 | |
| 19:41:36 | slaweq | mordred: yep, I saw it now :) | |
| 19:41:57 | slaweq | mordred: I will take a look in few minutes | |
| 20:19:31 | _alastor_ | hey folks, how do you set the service version from the ones available under the service's 'valid_versions' in the OSDK? | |
| 20:20:52 | _alastor_ | https://github.com/openstack/openstacksdk/blob/master/openstack/identity/identity_service.py#L19 | |
| 20:21:08 | _alastor_ | How does the SDK decide to use v3 vs v2? | |
| 20:21:28 | _alastor_ | It seems like it picks the first one in the list to use, but how can I force it to use the other one? | |
| 20:30:42 | _alastor_ | Is there a better place for these questions? | |
| 21:41:46 | _alastor_ | Is there a mailing list? Maybe I could ask my questions there? | |
| 21:51:38 | openstackgerrit | Merged openstack-infra/shade master: Use openstack.config directly for config https://review.openstack.org/566340 | |
| #openstack-sdks - 2018-05-05 | |||
| 13:28:51 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: add missing attribute in LBaaS v2 Pool API https://review.openstack.org/566434 | |
| #openstack-sdks - 2018-05-07 | |||
| 02:40:01 | openstackgerrit | Tovin Seven proposed openstack/osc-lib master: Add OpenTracing based driver id https://review.openstack.org/566493 | |
| 06:32:32 | openstackgerrit | chenyb4 proposed openstack/openstacksdk master: Change clustering example create parameter https://review.openstack.org/566510 | |
| 06:56:31 | openstackgerrit | chenyb4 proposed openstack/openstacksdk master: Change clustering example test create parameter https://review.openstack.org/566510 | |
| 07:56:02 | openstackgerrit | chenyb4 proposed openstack/openstacksdk master: Change clustering example test create parameter https://review.openstack.org/566510 | |
| 12:23:59 | pooja_jadhav | mordred: Can you please guide me how I can add new config option for split_logger so that I am able to enable the split logging functionality in all core projects?? | |
| 12:24:58 | pooja_jadhav | mordred: I am trying with various ways but not getting success. :( | |
| 15:09:31 | openstackgerrit | Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Support locking user password https://review.openstack.org/564200 | |
| 15:22:48 | mordred | _alastor_: right now it's config drive- although in the next few weeks we'll get proper discovery in place. you can pass 'identity_api_version' to the constructor for now to force a version | |
| 15:24:27 | mordred | pooja_jadhav: yes - let me look for a little bit and then I can help you out | |
| 15:25:05 | _alastor_ | mordred: Thanks! | |
| 16:51:08 | _alastor_ | mordred: I'm adding volume API 3 support and I'm having trouble getting get_config to set up the correct proxy for 'volume_api_version'. It's always choosing v3 rather than the one passed in. My changes can be seen in this review: https://review.openstack.org/#/c/566355/ | |
| 16:51:55 | _alastor_ | I've verified that 'identity_api_version' switches the proxy based on that value, I'm apparently missing the required logic for that switch | |
| 16:54:15 | openstackgerrit | Clark Boylan proposed openstack/python-openstackclient master: Use entrypoints lib instead of pkg_resources https://review.openstack.org/473954 | |
| 17:03:57 | openstackgerrit | Matt Smith (_alastor_) proposed openstack/openstacksdk master: Fixing bug where original and new dicts would always be the same https://review.openstack.org/566683 | |
| 17:06:04 | openstackgerrit | Clark Boylan proposed openstack/python-openstackclient master: Hack out pbr versioninfo to test entrypoints cost https://review.openstack.org/566685 | |
| 17:17:19 | _alastor_ | mordred: It also seems to be ignoring the OS_VOLUME_API_VERSION environment variable and always using v3 | |
| 17:37:01 | _alastor_ | This SDK is kind of hard to unravel | |
| 17:56:34 | _alastor_ | It's somewhere in the Connection constructor, because volume_api_version is '2' when returned from 'get_one' | |
| 17:56:57 | _alastor_ | but then it it gets passed into OpenStackCloud and that module is kinda big | |
| 18:49:16 | openstackgerrit | Matt Smith (_alastor_) proposed openstack/openstacksdk master: Adding block_storage v3 API support https://review.openstack.org/566355 | |
| 20:43:22 | openstackgerrit | Merged openstack/openstacksdk master: pypy is not checked at gate https://review.openstack.org/564729 | |
| 21:14:51 | openstackgerrit | Matt Smith (_alastor_) proposed openstack/openstacksdk master: Bugfix for block_storage not selecting the correct proxy https://review.openstack.org/566740 | |
| #openstack-sdks - 2018-05-08 | |||
| 12:02:16 | openstackgerrit | Merged openstack/keystoneauth master: Implement service_type alias lookups https://review.openstack.org/462218 | |
| 12:03:53 | openstackgerrit | Merged openstack/keystoneauth master: Add methods to get all of the version data https://review.openstack.org/559154 | |
| 14:48:34 | mordred | _alastor_: thanks for 566355 ... that actually shows a flaw in config loading that I need to fix in https://review.openstack.org/#/c/564494/ ... and also in words I said to you | |