Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2017-05-25
13:42:54 mordred Shrews: the reason for writing it isn't - but it's still a good idea I think - the OpenStackConfig object is really intended to be a singleton
15:19:49 openstackgerrit Reedip proposed openstack/python-openstackclient master: Introduce quota unset command https://review.openstack.org/376311
15:34:29 openstackgerrit Reedip proposed openstack/python-openstackclient master: Add extra dhcp option to 'port create/set/unset' https://review.openstack.org/356263
15:36:57 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add guidelines on Version Discovery https://review.openstack.org/459710
15:36:58 openstackgerrit Monty Taylor proposed openstack/api-wg master: Describe the publication of service-types-authority data https://review.openstack.org/462815
15:36:58 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add document describing consuming version discovery https://review.openstack.org/459405
15:37:32 mordred cdent, edleafe, elmiko: I believe I've gotten all current reviews taken care of
15:37:43 cdent yay!
15:38:18 edleafe mordred: on my list
15:46:52 elmiko mordred: sweet, i'm rounding the corner on my last lap for the reviews you posted
15:47:59 mordred elmiko: woot!
15:48:10 elmiko also kudos on consuming-version-discovery.rst, this thing is a beast!
15:52:17 mordred elmiko: it really is, isn't it?
15:52:34 mordred elmiko: the scary part is that somehow I actually have all of that stored in my head
15:53:09 elmiko mordred: that is scary...
15:53:31 elmiko mordred: i really like your enumeration of the algorithms though, i think it will help readers understand this better
15:54:57 mordred elmiko: thanks! ... I certainly hope so
15:55:13 mordred the fun part is that next I need to write a spec for keystone about implementing this in keystoneauth :)
15:56:35 elmiko good luck sir
15:58:48 openstackgerrit Yuval Shalev proposed openstack/python-openstacksdk master: Added server console output method https://review.openstack.org/468078
17:32:48 elmiko edleafe: draft up, https://etherpad.openstack.org/p/api-wg-newsletter
17:32:57 elmiko i realize you may be out, i'll wait 15-20 then post it
18:08:38 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Add flavor value options https://review.openstack.org/302795
19:30:17 openstackgerrit Merged openstack/python-openstackclient master: Convert volume functional tests into JSON format https://review.openstack.org/465208
19:31:34 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add guidelines on Version Discovery https://review.openstack.org/459710
19:31:34 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add support for historical service type aliases https://review.openstack.org/460654
19:31:35 openstackgerrit Monty Taylor proposed openstack/api-wg master: Describe the publication of service-types-authority data https://review.openstack.org/462815
19:31:35 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add document describing consuming version discovery https://review.openstack.org/459405
19:31:36 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add guideline about consuming endpoints from catalog https://review.openstack.org/462814
19:53:51 openstackgerrit Merged openstack/python-openstackclient master: Add functional test for volume service https://review.openstack.org/432282
20:20:10 dhellmann dtroyer : in ATL we talked about a daemon mode for cliff/OSC. My notes say "add an option to emit a null value after the formatter output". Is that really all we need there?
20:50:05 dtroyer dhellmann: that is the minimum needed to delimit return data for each command. I didn't want to invent a protocol for this so hopefully that is all we would need
20:50:24 dhellmann dtroyer : ok
20:50:49 dhellmann do we want a --daemon-mode that implies --interactive and also adds the null? or just a --null-delimited-output option?
20:52:08 dtroyer I was only thinking about the —null option as interactive is already implied when no command is given
20:52:17 dhellmann makes sense
20:52:28 dhellmann just --null then?
20:52:44 dhellmann not --null-delimited-output?
20:53:27 dtroyer hmmm, it may need to be more specific, to be honest I have been thinking about cribbing the xargs -0 option, not sure if we need to be able to specify the delimiter char
20:53:38 dhellmann oh, -0 works
20:53:56 dhellmann ok, the other thing we talked about was "command extensions"
20:54:00 dhellmann I'm looking at that right now
20:54:04 dtroyer the semantics are not identical to xargs though so maybe that connection is not quite as useful
20:54:17 dhellmann I can either load them from a separate namespace for each use (args, pre, & post hooks)
20:54:34 dhellmann or I can load them from one namespace and expect a class with a specific API for each of those cases
20:54:39 dhellmann any preference?
20:55:01 dhellmann I'll make --null-delimited-output and -0 aliases
20:55:26 dtroyer I've imagined it as a single class with essentially hook methods to override, but I don't have a huge preference yet
20:55:33 dtroyer the alias sounds good
20:55:55 dhellmann ok, I was leaning toward a class, too
20:56:04 dtroyer having a single namespace does feel cleaner
20:56:27 dhellmann I was going to make the namespace the application namespace + cmd_name.replace(' ', '_')
20:56:39 dhellmann then plugins can have their own names
20:56:56 dtroyer sounds good
20:56:58 dhellmann k
21:42:20 dtroyer dhellmann: if you're still around… with the major rev of cliff on the near horizon, do you want to wait for that release for this stuff to land ^^^^
22:55:10 openstackgerrit Merged openstack/os-client-config master: Add helper method to fetch service catalog https://review.openstack.org/464238
22:55:20 openstackgerrit Merged openstack/os-client-config master: Add ironicclient to constructors list https://review.openstack.org/464239
22:55:25 openstackgerrit Merged openstack/os-client-config master: Keep a singleton to support multiple get_config calls https://review.openstack.org/465195
22:55:30 openstackgerrit Merged openstack/os-client-config master: Don't pop from os.environ https://review.openstack.org/468020
23:05:18 openstackgerrit Doug Hellmann proposed openstack/cliff master: add cmd_name argument to CompleteCommand https://review.openstack.org/468195
23:05:19 openstackgerrit Doug Hellmann proposed openstack/cliff master: add hook for manipulating the argument parser https://review.openstack.org/468197
23:05:19 openstackgerrit Doug Hellmann proposed openstack/cliff master: pass the command name from HelpCommand https://review.openstack.org/468196
23:05:20 openstackgerrit Doug Hellmann proposed openstack/cliff master: add before and after hooks https://review.openstack.org/468199
23:05:20 openstackgerrit Doug Hellmann proposed openstack/cliff master: add hook for get_epilog https://review.openstack.org/468198
23:05:35 dhellmann dtroyer : let's see how closely this matches up with what you were thinking ^^
23:10:13 openstackgerrit Doug Hellmann proposed openstack/cliff master: add hook for get_epilog https://review.openstack.org/468198
23:10:14 openstackgerrit Doug Hellmann proposed openstack/cliff master: add before and after hooks https://review.openstack.org/468199
23:10:41 openstackgerrit Merged openstack/os-client-config master: Revert "Revert "Use interface not endpoint_type for keystoneclient"" https://review.openstack.org/464299
#openstack-sdks - 2017-05-26
00:27:59 openstackgerrit Takashi NATSUME proposed openstack/python-openstackclient master: List/show all server migration types https://review.openstack.org/450119
02:47:28 openstackgerrit ZhangHongtao proposed openstack/python-openstackclient master: Add optional parameter "user_id" and "type" to list credentials https://review.openstack.org/468256
03:39:38 openstackgerrit Rui Chen proposed openstack/python-openstackclient master: Replace "Display Name" by "Name" in volume list https://review.openstack.org/423081
10:59:25 RuiChen osc folks, gate-osc-dsvm-functional-tips-ubuntu-xenial-nv no voting jobs failed, seems it's a devstack bug, but not sure, when USE_PYTHON3=True, keystonemiddleware is not installed in py27 lib, that cause uploading image failed because swift (run in py27) can't import keystonemiddleware, I had pushed a bug to trace it
10:59:27 openstack Launchpad bug 1693665 in python-openstackclient "[Gate] gate-osc-dsvm-functional-tips-ubuntu-xenial-nv failed because of uploading image error" [Undecided,New]
10:59:27 RuiChen https://bugs.launchpad.net/devstack/+bug/1693665
10:59:56 RuiChen don't worry, that don't impact patches are merged
11:50:46 Dinesh_Bhor Qiming: ping, have 2 min? I have addressed other review comments but want to discuss one: https://review.openstack.org/#/c/319054/3/openstack/image/v2/image.py@117
11:54:24 Dinesh_Bhor Qiming: you there?
17:29:11 openstackgerrit OpenStack Proposal Bot proposed openstack/python-openstackclient master: Updated from global requirements https://review.openstack.org/468495
#openstack-sdks - 2017-05-27
14:58:24 openstackgerrit caoyuan proposed openstack/python-openstackclient master: Correct the command to list dhcp agent https://review.openstack.org/468652
16:47:09 openstackgerrit Yuval Shalev proposed openstack/python-openstacksdk master: Added server console output method https://review.openstack.org/468078
17:36:18 openstackgerrit Yuval Shalev proposed openstack/python-openstacksdk master: Added server console output method https://review.openstack.org/468078
18:10:12 openstackgerrit Yuval Shalev proposed openstack/python-openstacksdk master: Added server console output method https://review.openstack.org/468078
#openstack-sdks - 2017-05-28
14:16:55 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add guidelines on Version Discovery https://review.openstack.org/459710
14:16:56 openstackgerrit Monty Taylor proposed openstack/api-wg master: Add document describing consuming version discovery https://review.openstack.org/459405
#openstack-sdks - 2017-05-29
09:05:58 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add direction field to QoS bandwidth limit. https://review.openstack.org/458056
11:12:49 Dinesh_Bhor Qiming_: ping, you there?
11:55:30 Qiming_ hi, Dinesh_Bhor
11:56:00 Dinesh_Bhor Qiming_: do you have 5 min? want to discuss your review comment
11:56:08 Qiming_ sure
11:56:19 Dinesh_Bhor Qiming_: I have addressed your other comments but want to discuss this: https://review.openstack.org/#/c/319054/3/openstack/image/v2/image.py@117 comment
11:56:27 Dinesh_Bhor Qiming_: With my understanding you are saying that If there are 10 attributes to the image and if user wants to update name and visibility then user will have to give all 10 attributes in input dict with updated values of name and visibility.
11:57:34 Qiming_ yes, that was my understanding
11:57:52 Qiming_ the server is supposed to parse the difference between the updated resource and the existing one
12:00:22 Dinesh_Bhor Qiming_: ok, do you have any existing example in SDK as you said it is consistent with other apis?
12:00:38 Dinesh_Bhor Qiming_: It will help me to understand it...
12:00:59 Qiming_ the expected user code is something like this:
12:01:19 Qiming_ image = sdk.image.get_image(name_or_id)
12:01:35 Qiming_ image.name = 'new_name'
12:02:20 Qiming_ sdk.image.update_image(image, **image.to_dict())

Earlier   Later