| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2017-01-18 | |||
| 20:21:23 | briancurtin | the warnings are generally outputted at call-time, and I’m sure they get swallowed up by the ostestr or something | |
| 20:26:38 | openstackgerrit | Monty Taylor proposed openstack/os-client-config: Revert "Fix interface_key for identity clients" https://review.openstack.org/422222 | |
| 20:27:45 | waj334 | Is there any sort of instructions for adding new commands to the OSC? I can't seem to get it to pick up on the ones that I added. https://review.openstack.org/#/c/421585/ | |
| 20:28:09 | waj334 | I added a new .rst for these commands | |
| 20:34:44 | ankur-gupta-f2 | waj334: after pulling that patch into the osc dir. run a python setup.py install , or pip install -e . | |
| 20:35:30 | waj334 | that's exactly what I'm doing, but nada | |
| 20:35:47 | mordred | dtroyer: we discovered a lovely thing that the occ release broke - specifically, connecting identity CRUD on v2 only keystone on openstack (it's a REALLY specific break) - but the patch I just submitted fixes the issue | |
| 20:37:44 | ankur-gupta-f2 | waj334: bah. not in office today. See if you can grab Shashank or Sindhu | |
| 20:39:50 | mordred | dtroyer, Shrews: I'm torn on whether or not I thikn it's worth having an occ gate job with that config or not - we're adding a shade job that should at least inform us when it happens | |
| 20:41:18 | openstackgerrit | Steve Martinelli proposed openstack/keystoneauth: Update reno for stable/ocata https://review.openstack.org/422208 | |
| 20:41:47 | dtroyer | mordred: I'm going to lean toward yes… as occ grown more stuff it needs to handle the edge cases for a wide variety of configurations. If I ever get down my list far enough I have a pile-o-tests to add to it so OSC doesn't break in more fun areas… | |
| 20:43:23 | mordred | dtroyer: cool. I'll get the test job added and then trigger it on occ changes too | |
| 20:51:25 | openstackgerrit | Merged openstack/python-openstacksdk: Corrections in DHCP Agent Resource listing. https://review.openstack.org/421568 | |
| 20:51:58 | Shrews | shade is the client "canary in a coal mine" :) | |
| 21:10:19 | openstackgerrit | Merged openstack/python-openstackclient: Fill the missing colon https://review.openstack.org/421705 | |
| 21:53:48 | openstackgerrit | Ken'ichi Ohmichi proposed openstack/api-wg: Accurate status code vs. Backwards compatibility https://review.openstack.org/422264 | |
| 23:13:12 | openstackgerrit | Merged openstack/keystoneauth: Update reno for stable/ocata https://review.openstack.org/422208 | |
| 23:19:48 | openstackgerrit | Merged openstack/os-client-config: Revert "Fix interface_key for identity clients" https://review.openstack.org/422222 | |
| 23:22:45 | dtroyer | mordred: https://review.openstack.org/422308 releases o-c-c 1.26.0 | |
| 23:23:03 | dtroyer | so murano is in too | |
| 23:23:11 | mordred | dtroyer: woot! thank you | |
| 23:23:15 | openstackgerrit | Ed Leafe proposed openstack/api-wg: Add guidelines for boolean names https://review.openstack.org/411529 | |
| 23:23:41 | openstackgerrit | Ankur proposed openstack/python-openstacksdk: Network L3 Router Commands https://review.openstack.org/385728 | |
| 23:24:15 | mordred | edleafe: soo ... not that it matters, because shade != openstack rest apis ... | |
| 23:24:42 | mordred | edleafe: but shade went the oppposite way on booleans - prefixing them all with is_ or has_ | |
| 23:27:12 | mordred | edleafe: although I definitely agree with the positive naming and see a place where we missed one of those | |
| 23:28:22 | openstackgerrit | Ed Leafe proposed openstack/api-wg: Clarify the status values in versions https://review.openstack.org/411849 | |
| 23:30:50 | edleafe | mordred: Please add those comments to the review. I simply did a cursory survey of several projects, and put that guideline up as a strawman for people to beat on. | |
| 23:31:34 | mordred | edleafe: woot! will do | |
| 23:31:53 | edleafe | kewl | |
| 23:53:32 | openstackgerrit | Merged openstack/python-openstackclient: Fix functional test for creating subnet https://review.openstack.org/421310 | |
| #openstack-sdks - 2017-01-19 | |||
| 01:20:35 | openstackgerrit | Merged openstack/python-openstackclient: Functional test for volume snapshot https://review.openstack.org/421194 | |
| 01:54:05 | openstackgerrit | jiahui.qiang proposed openstack/python-openstackclient: Functional test for volume qos https://review.openstack.org/421066 | |
| 04:37:23 | openstackgerrit | Andy Botting proposed openstack/os-client-config: Fix typo for baremetal_service_type https://review.openstack.org/422381 | |
| 04:51:51 | openstackgerrit | jiahui.qiang proposed openstack/python-openstackclient: Error in the return of command 'volume qos create' https://review.openstack.org/421065 | |
| 05:59:57 | openstackgerrit | jiahui.qiang proposed openstack/python-openstackclient: Error in the return of command 'volume qos create' https://review.openstack.org/421065 | |
| 06:59:05 | openstackgerrit | Wang Hui proposed openstack/golang-client: Update crud operation of volume API v3 https://review.openstack.org/421641 | |
| 07:05:49 | openstackgerrit | Wang Hui proposed openstack/golang-client: Update crud operation of volume API v3 https://review.openstack.org/421641 | |
| 08:21:44 | openstackgerrit | Wang Hui proposed openstack/golang-client: Update crud operation of volume API v3 https://review.openstack.org/421641 | |
| 08:30:16 | openstackgerrit | jiahui.qiang proposed openstack/python-openstackclient: Error in the return of command server show, create https://review.openstack.org/422463 | |
| 09:11:30 | openstackgerrit | shizhihui proposed openstack/cliff: Add newline if the output formatter is json https://review.openstack.org/422488 | |
| 09:35:32 | openstackgerrit | Rui Chen proposed openstack/python-openstackclient: Update devref about "--no-property" https://review.openstack.org/421160 | |
| 14:29:23 | reedip_ | briancurtin : ping ( I think the last one didnt go ) | |
| 14:39:26 | reedip_ | stevemar , dtroyer ; ping | |
| 14:59:39 | waj334 | Can anyone take a look at this and give me some idea why these commands are not being added to OSC. I think I'm missing something. https://review.openstack.org/#/c/421585 | |
| 14:59:47 | briancurtin | reedip_: what’s up | |
| 15:00:02 | reedip_ | briancurtin : I had a qeury | |
| 15:00:05 | reedip_ | query * | |
| 15:00:23 | reedip_ | Is OpenstackSDK only used by OpenstackClient | |
| 15:00:39 | reedip_ | or can we explicitly call it via Rest API ? | |
| 15:00:49 | reedip_ | or other sort of clients | |
| 15:01:03 | briancurtin | reedip_: it’s a Python library, you can (and many people do), use it however and wherever you want | |
| 15:01:31 | reedip_ | briancurtin : My point is related to Bulk Creation support in Openstack SDK | |
| 15:01:52 | reedip_ | currently it lacks that and I would like to implement the same if there is scope to do so | |
| 15:03:23 | briancurtin | reedip_: is bulk creation something a rest API provides? if it is, then we can support it. if you’d want to make something that calls create_blah() 5 times for you, we don’t do that yet, but we could at some point | |
| 15:04:00 | reedip_ | briancurtin : actually, like in Neutron, bulk_create can be done using "resources_key" | |
| 15:04:02 | briancurtin | it would depend entirely on the details and what operations are actually happening as to how and where we’d do that, though | |
| 15:04:57 | reedip_ | briancurtin : I had a BP for this drafted, but it hardly had any information. Thought of discussing it with u guys once | |
| 15:04:58 | reedip_ | https://blueprints.launchpad.net/python-openstacksdk/+spec/bulk-support | |
| 15:05:21 | briancurtin | so, for example, rather than creating one network with {network: {“name”: ‘foo’, …}} you could send {networks: {“name”: ‘foo’, …}, {“name”: ‘bar’, …}} ?? | |
| 15:05:35 | reedip_ | briancurtin : YES ! | |
| 15:05:45 | reedip_ | this is true for a lot of resources | |
| 15:07:22 | briancurtin | reedip_: yeah that would be nice to support, and we can and will do that, but before we double up our APIs to support bulk we should ideally focus on getting the current set of behaviors up all cleaned up and completed for 1.0. i think that’s a pretty good thing to look at once we’ve hit 1.0 | |
| 15:07:52 | briancurtin | reedip_: so, we’re not too far away from being able to do that, but just not today | |
| 15:07:59 | reedip_ | braincurtin : ok, I think I can start working on it in parallel , and draft it in my local repo | |
| 15:08:17 | reedip_ | once we hit 1.0, I just need to resolve the conflicts | |
| 15:08:55 | reedip_ | and in the meanwhile if you would like, then I can help you with the cleanup of SDK, but m not sure what is exactly required | |
| 15:09:44 | briancurtin | reedip_: yep. it will be interesting to see what kind of API you come up with, so it would be best to just try and solve one particular operation, like for one resource. that way if you make everything ever do bulk and we have to change the API, you’re not having to do a ton of work to adjust 20 methods | |
| 15:10:39 | reedip_ | braincurtin : okay , got it. | |
| 15:10:52 | briancurtin | reedip_: we’re mostly doing what was just done in network, updating any remaining services to use openstack.resource2/proxy2 instead of openstack.resource/proxy. once that’s all done and we can remove the old resource, that is basically 1.0 | |
| 15:11:21 | reedip_ | anywhere I can help you with ? | |
| 15:12:20 | briancurtin | reedip_: i’m going to go through and do an audit so i know where we’re at (which i need to do anyway), and i’ll create a bunch of issues on https://bugs.launchpad.net/python-openstacksdk for each service we need to port | |
| 15:12:39 | reedip_ | braincurtin : Okay , I will look out on it | |
| 15:12:43 | briancurtin | reedip_: i’ll send you a couple of them shortly and you can pick whatever you’d like | |
| 15:12:54 | reedip_ | briancurtin : okay great :) | |
| 15:13:15 | reedip_ | thanks a lot briancurtin :) | |
| 15:13:26 | briancurtin | reedip_: you’re welcome, and thanks for all of your work | |
| 15:13:40 | reedip_ | braincurtin : dont thank me yet if there is work to be done :) | |
| 15:26:07 | stevemar | briancurtin: just tag 1.0, problem solved (reading scroll up) | |
| 15:26:25 | stevemar | err scroll back | |
| 15:30:55 | briancurtin | reedip_: https://bugs.launchpad.net/python-openstacksdk/+bugs?field.tag=resource2-port is a list of them. i’ve already done work locally on database and object_store so i assigned those and will push them soon. the rest are open! | |
| 15:31:22 | reedip_ | briancurtin : okay | |
| 15:31:29 | reedip_ | briancurtin : looking | |
| 15:31:50 | reedip_ | stevemar : I knew you would have an innovative answer :D | |
| 15:32:03 | briancurtin | stevemar: i’ll do that and then go on vacation for a month | |
| 15:32:08 | stevemar | briancurtin: hehe | |
| 15:32:09 | reedip_ | hahahahaha | |
| 15:32:39 | stevemar | briancurtin: you've got to be getting close to a 1.0 by now? i think? | |
| 15:33:03 | stevemar | in terms of breadth anyway, lots of resources and APIs are covered | |
| 15:33:40 | reedip_ | briancurtin : you mentioned a document in the Bug report | |
| 15:33:57 | reedip_ | When porting, do a walkthrough of the documentation to see if anything has changed so that we can keep the service updated." | |
| 15:33:57 | reedip_ | " | |
| 15:34:05 | reedip_ | Link to the document ??? | |
| 15:34:09 | briancurtin | stevemar: yeah pretty close. just need to get 8 services moved over to the newer base classes so everything is on the same API, and most of those are pretty small services | |
| 15:34:36 | stevemar | briancurtin: then we can deprecate all the python-*clients, yesss | |
| 15:34:55 | briancurtin | reedip_: oh i meant the REST API docs, like on docs.openstack.org. meaning when you’re porting over a particular resource, just check that it still offers the same fields or if it has more, perhaps add them | |
| 15:35:10 | reedip_ | briancurtin : oohhhh ! | |
| 15:35:11 | reedip_ | ok | |
| 15:35:59 | briancurtin | stevemar: some of those smaller services are pretty light in terms of depth, but now that we’ll be locked down on the API, just expanding things to keep up with what a REST API provides borders on trivial | |
| 15:36:10 | briancurtin | and adding new ones is pretty easy | |